Bug#657867: Please enable hardened build flags

2012-01-29 Thread Moritz Muehlenhoff
Package: qemu-kvm
Version: 1.0+dfsg-5
Severity: important
Tags: patch

Please enable hardened build flags through dpkg-buildflags.

Patch attached. (dpkg-buildflags abides noopt from DEB_BUILD_OPTIONS)

Cheers,
Moritz
diff -aur qemu-kvm-1.0+dfsg.harden/debian/rules qemu-kvm-1.0+dfsg/debian/rules
--- qemu-kvm-1.0+dfsg.harden/debian/rules	2012-01-26 21:41:14.0 +0100
+++ qemu-kvm-1.0+dfsg/debian/rules	2012-01-29 14:37:20.0 +0100
@@ -47,13 +47,11 @@
 	QEMU_EXE = $(QEMU_TAEGET)/qemu-system-ppcemb
 endif
 
-CFLAGS = -Wall -g
+CFLAGS = `dpkg-buildflags --get CFLAGS`
+CFLAGS += `dpkg-buildflags --get CPPFLAGS`
+CFLAGS += -Wall
+LDFLAGS = `dpkg-buildflags --get LDFLAGS`
 
-ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
-	CFLAGS += -O0
-else
-	CFLAGS += -O2
-endif
 ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 NUMJOBS = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 MAKEFLAGS += -j$(NUMJOBS)
@@ -73,6 +71,8 @@
 		--audio-card-list=ac97 es1370 sb16 cs4231a adlib gus hda \
 		--disable-strip \
 		--disable-xen \
+		--extra-cflags=${CFLAGS} \
+		--extra-ldflags=${LDFLAGS} \
 		--disable-blobs \
 		--disable-guest-agent \
 		--disable-smartcard-nss --disable-smartcard \
Nur in qemu-kvm-1.0+dfsg/debian/: rules~.


Bug#657867: Please enable hardened build flags

2012-01-29 Thread Michael Tokarev
tags 657867 + confirmed pending
thanks

On 29.01.2012 17:51, Moritz Muehlenhoff wrote:
 Package: qemu-kvm
 Version: 1.0+dfsg-5
 Severity: important
 Tags: patch
 
 Please enable hardened build flags through dpkg-buildflags.
 
 Patch attached. (dpkg-buildflags abides noopt from DEB_BUILD_OPTIONS)

This is something I wanted to do myself for quite some
time already.

Thank you for the patch, applied and upload is now pending!

/mjt



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org