Bug#659685: [ovs-dev] [PATCH] debian: Use provided kernel source dir instead of host kernel version.
Thank you, Justin and Simon. Simon, I added your Tested-by: and
pushed this to master and branch-1.[345].
On Tue, Feb 14, 2012 at 12:18:01PM +0900, Simon Horman wrote:
> I have tested this patch and the path and resulting package
> appear to be correct.
>
> I see ./configure --with-linux=/usr/src/linux-headers-3.1.0-1-amd64
> in the resulting config.log
>
> On Mon, Feb 13, 2012 at 06:05:19PM -0800, Justin Pettit wrote:
> > Assuming it's the fully correct path, it looks reasonable to me.
> >
> > --Justin
> >
> >
> > On Feb 13, 2012, at 4:15 PM, Ben Pfaff wrote:
> >
> > > DKMS passes in an explicit variable for the kernel source directory, so we
> > > should use that instead of `uname -r`.
> > >
> > > CC: 659...@bugs.debian.org
> > > Reported-by: Thomas Goirand
> > > Signed-off-by: Ben Pfaff
> > > ---
> > > debian/dkms.conf.in |2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/debian/dkms.conf.in b/debian/dkms.conf.in
> > > index ae1fc7a..d5bc37e 100644
> > > --- a/debian/dkms.conf.in
> > > +++ b/debian/dkms.conf.in
> > > @@ -1,6 +1,6 @@
> > > PACKAGE_NAME="openvswitch"
> > > PACKAGE_VERSION="__VERSION__"
> > > -MAKE="./configure --with-linux=/lib/modules/`uname -r`/build && make -C
> > > datapath/linux"
> > > +MAKE="./configure --with-linux='${kernel_source_dir}' && make -C
> > > datapath/linux"
> > > BUILT_MODULE_NAME[0]=openvswitch_mod
> > > BUILT_MODULE_NAME[1]=brcompat_mod
> > > BUILT_MODULE_LOCATION[0]=datapath/linux/
> > > --
> > > 1.7.2.5
> > >
> > > ___
> > > dev mailing list
> > > d...@openvswitch.org
> > > http://openvswitch.org/mailman/listinfo/dev
> >
> > ___
> > dev mailing list
> > d...@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> >
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#659685: [ovs-dev] [PATCH] debian: Use provided kernel source dir instead of host kernel version.
I have tested this patch and the path and resulting package
appear to be correct.
I see ./configure --with-linux=/usr/src/linux-headers-3.1.0-1-amd64
in the resulting config.log
On Mon, Feb 13, 2012 at 06:05:19PM -0800, Justin Pettit wrote:
> Assuming it's the fully correct path, it looks reasonable to me.
>
> --Justin
>
>
> On Feb 13, 2012, at 4:15 PM, Ben Pfaff wrote:
>
> > DKMS passes in an explicit variable for the kernel source directory, so we
> > should use that instead of `uname -r`.
> >
> > CC: 659...@bugs.debian.org
> > Reported-by: Thomas Goirand
> > Signed-off-by: Ben Pfaff
> > ---
> > debian/dkms.conf.in |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/debian/dkms.conf.in b/debian/dkms.conf.in
> > index ae1fc7a..d5bc37e 100644
> > --- a/debian/dkms.conf.in
> > +++ b/debian/dkms.conf.in
> > @@ -1,6 +1,6 @@
> > PACKAGE_NAME="openvswitch"
> > PACKAGE_VERSION="__VERSION__"
> > -MAKE="./configure --with-linux=/lib/modules/`uname -r`/build && make -C
> > datapath/linux"
> > +MAKE="./configure --with-linux='${kernel_source_dir}' && make -C
> > datapath/linux"
> > BUILT_MODULE_NAME[0]=openvswitch_mod
> > BUILT_MODULE_NAME[1]=brcompat_mod
> > BUILT_MODULE_LOCATION[0]=datapath/linux/
> > --
> > 1.7.2.5
> >
> > ___
> > dev mailing list
> > d...@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>
> ___
> dev mailing list
> d...@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#659685: [ovs-dev] [PATCH] debian: Use provided kernel source dir instead of host kernel version.
Assuming it's the fully correct path, it looks reasonable to me.
--Justin
On Feb 13, 2012, at 4:15 PM, Ben Pfaff wrote:
> DKMS passes in an explicit variable for the kernel source directory, so we
> should use that instead of `uname -r`.
>
> CC: 659...@bugs.debian.org
> Reported-by: Thomas Goirand
> Signed-off-by: Ben Pfaff
> ---
> debian/dkms.conf.in |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/debian/dkms.conf.in b/debian/dkms.conf.in
> index ae1fc7a..d5bc37e 100644
> --- a/debian/dkms.conf.in
> +++ b/debian/dkms.conf.in
> @@ -1,6 +1,6 @@
> PACKAGE_NAME="openvswitch"
> PACKAGE_VERSION="__VERSION__"
> -MAKE="./configure --with-linux=/lib/modules/`uname -r`/build && make -C
> datapath/linux"
> +MAKE="./configure --with-linux='${kernel_source_dir}' && make -C
> datapath/linux"
> BUILT_MODULE_NAME[0]=openvswitch_mod
> BUILT_MODULE_NAME[1]=brcompat_mod
> BUILT_MODULE_LOCATION[0]=datapath/linux/
> --
> 1.7.2.5
>
> ___
> dev mailing list
> d...@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
