Bug#659685: [ovs-dev] Bug#659685: Bug#659685: fails to build the kernel module

2012-02-13 Thread Ben Pfaff
On Mon, Feb 13, 2012 at 05:49:54PM +0900, Simon Horman wrote:
 On Mon, Feb 13, 2012 at 04:10:06PM +0800, Thomas Goirand wrote:
  Package: openvswitch-datapath-dkms
  Version: 1.4.0-1
  Severity: grave
  
  Hi there!
  
  First, thanks for maintaining OVS, this is a very nice software, which
  I will use with XCP (for which I'm working on the packaging, together
  with people from Citrix).
  
  Now, the less nice stuff... :)
  
  openvswitch-datapath-dkms fails to build its kernel module when I tried
  to install it in SID. Here's the relevant log:
  
  Building module:
  cleaning build area(bad exit status: 2)
  ./configure --with-linux=/usr/src/linux-headers-3.1.0-1-686-pae ; make -C 
  datapath/linux..(bad exit status: 2)
  Error! Bad return status for module build on kernel: 3.1.0-1-686-pae (i686)
  Consult /var/lib/dkms/openvswitch/1.4.0/build/make.log for more information.
  
  and the make.log contains:
  
  make: Entering directory 
  `/var/lib/dkms/openvswitch/1.4.0/build/datapath/linux'
  make: *** No targets specified and no makefile found.  Stop.
  make: Leaving directory 
  `/var/lib/dkms/openvswitch/1.4.0/build/datapath/linux'
  
  I believe that the step building the Makefile was never run (but I didn't
  investigate more and used the module-assistant version). Indeed:
 
 Strange, I think that the Makefile should be created by ./configure,
 which features in the debian/dkms.conf.in.
 
 Would it be possible for you to provide your make.log?

The config.log would be useful too.

Thomas, it's possible that you're hitting the following bug.  I
committed a fix for it to all of our active branches a few minutes
ago (so obviously it isn't in Debian yet):
http://openvswitch.org/pipermail/dev/2012-February/014890.html
If that is the problem, then you can work around it simply by
installing the libc6-dev package.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#659685: [ovs-dev] Bug#659685: Bug#659685: fails to build the kernel module

2012-02-13 Thread Thomas Goirand
On 02/14/2012 01:22 AM, Ben Pfaff wrote:
 The config.log would be useful too.
 
 Thomas, it's possible that you're hitting the following bug.  I
 committed a fix for it to all of our active branches a few minutes
 ago (so obviously it isn't in Debian yet):
 http://openvswitch.org/pipermail/dev/2012-February/014890.html
 If that is the problem, then you can work around it simply by
 installing the libc6-dev package.

This is a development box on which I was trying to install openvswitch,
so of course, libc6-dev was already installed. So no, that's not the
issue, however, obviously libc6-dev is needed.

On 02/13/2012 04:49 PM, Simon Horman wrote:
 Would it be possible for you to provide your make.log?

I've attached it to this mail.

On 02/13/2012 04:49 PM, Simon Horman wrote:
 Curiously installing openvswitch-datapath-dkms 1.4.0-1 does seem
 to work for me, also 3.1 but on amd64, though that may be a legacy
 of my environment.

FYI: I run in 32 bits, because that's the most optimized environment for
a Xen dom0.

During the course of upgrading XCP from 1.3 to 1.3.2, I've hit 3 bugs
already. I really hope that's going to be it! :)

Thomas
DKMS make.log for openvswitch-1.4.0 for kernel 3.1.0-1-686-pae (i686)
Mon Feb 13 17:49:56 UTC 2012
checking build number... none
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking whether gcc and cc understand -c and -o together... yes
checking how to run the C preprocessor... gcc -E
checking for ranlib... ranlib
checking for grep that handles long lines and -e... /bin/grep
checking for fgrep... /bin/grep -F
checking for perl... /usr/bin/perl
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking whether byte ordering is bigendian... no
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... 64
checking for library containing pow... -lm
checking for library containing clock_gettime... -lrt
checking for library containing timer_create... none required
checking for linux/netlink.h... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for SSL... yes
checking for Python 2.x for x = 4... /usr/bin/python
checking for pyuic4... no
checking for PySide.QtCore Python module... no
checking for PyQt4.QtCore Python module... yes
checking for twisted.conch.ssh Python module... yes
checking for twisted.internet Python module... yes
checking for twisted.application Python module... yes
checking for json Python module... yes
checking for zope.interface Python module... yes
checking whether to build ovsdbmonitor... yes
checking for dot... no
checking net/if_packet.h usability... yes
checking net/if_packet.h presence... yes
checking for net/if_packet.h... yes
checking whether strtok_r macro segfaults on some inputs... no
checking for struct stat.st_mtim.tv_nsec... yes
checking for struct stat.st_mtimensec... no
checking for mlockall... yes
checking for strnlen... yes
checking for strsignal... yes
checking for getloadavg... yes
checking for statvfs... yes
checking for setmntent... yes
checking mntent.h usability... yes
checking mntent.h presence... yes
checking for mntent.h... yes
checking sys/statvfs.h usability... yes
checking sys/statvfs.h presence... yes
checking for sys/statvfs.h... yes
checking linux/types.h usability... yes
checking linux/types.h presence... yes
checking for linux/types.h... yes
checking execinfo.h usability... yes
checking execinfo.h presence... yes
checking for execinfo.h... yes
checking for backtrace... yes
checking whether libc supports hooks for malloc and related functions... yes
checking valgrind/valgrind.h usability... no
checking valgrind/valgrind.h presence... no
checking for valgrind/valgrind.h... no
checking for connect in -lsocket... no
checking for library containing 

Bug#659685: [ovs-dev] Bug#659685: Bug#659685: fails to build the kernel module

2012-02-13 Thread Ben Pfaff
On Tue, Feb 14, 2012 at 01:54:28AM +0800, Thomas Goirand wrote:
 On 02/14/2012 01:22 AM, Ben Pfaff wrote:
  Would it be possible for you to provide your make.log?
 
 I've attached it to this mail.

Here's the root of the problem:
   checking for Linux build directory... /usr/src/linux-headers-3.1.0-1-686-pae
   checking for Linux source directory... configure: error: cannot find source 
directory (please use --with-linux-source)

I see that this was already fixed on master with the following commit:

--
From 715a77b74caf22e38d1f232d1cc45036b9b83e62 Mon Sep 17 00:00:00 2001
From: Ben Pfaff b...@nicira.com
Date: Tue, 10 Jan 2012 14:22:22 -0800
Subject: [PATCH] debian: Look in /lib/modules instead of /usr/src for DKMS 
kernel sources.

DKMS packages usually look in /lib/modules for kernel sources, since that
is the standard location, but our packages was looking directly in
/usr/src.  This fixes the problem.

Reported-by: Alban Browaeys pra...@yahoo.com
Tested-by: Alban Browaeys pra...@yahoo.com
Signed-off-by: Ben Pfaff b...@nicira.com
---
 AUTHORS |1 +
 debian/dkms.conf.in |2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/AUTHORS b/AUTHORS
index d413523..87b3ccd 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -60,6 +60,7 @@ provided helpful bug reports or suggestions.
 Aaron M. Ucko   u...@debian.org
 Aaron Rosen aro...@clemson.edu
 Ahmed Bilal numan...@gmail.com
+Alban Browaeys  pra...@yahoo.com
 Alex Yipa...@nicira.com
 Alexey I. Froloff   ra...@altlinux.org
 Bob Ballbob.b...@citrix.com
diff --git a/debian/dkms.conf.in b/debian/dkms.conf.in
index 56c6398..a6dc316 100644
--- a/debian/dkms.conf.in
+++ b/debian/dkms.conf.in
@@ -1,6 +1,6 @@
 PACKAGE_NAME=openvswitch
 PACKAGE_VERSION=__VERSION__
-MAKE=./configure --with-linux=/usr/src/linux-headers-`uname -r` ; make -C 
datapath/linux
+MAKE=./configure --with-linux=/lib/modules/`uname -r`/build ; make -C 
datapath/linux
 BUILT_MODULE_NAME[0]=openvswitch_mod
 BUILT_MODULE_NAME[1]=brcompat_mod
 BUILT_MODULE_LOCATION[0]=datapath/linux/
--

Somehow this bug fix did not make it to branches for 1.3 or 1.4.  I've
now cherry-picked it to both branches, so the next Debian upload
should incorporate the fix.

I see that we should really be using ' instead of ; in the make
rule.  I sent out a patch.

 During the course of upgrading XCP from 1.3 to 1.3.2, I've hit 3 bugs
 already. I really hope that's going to be it! :)

I hope so too.  I hope that the others have been adequately addressed;
let me know if not.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#659685: [ovs-dev] Bug#659685: Bug#659685: fails to build the kernel module

2012-02-13 Thread Simon Horman
On Mon, Feb 13, 2012 at 10:10:18AM -0800, Ben Pfaff wrote:
 On Tue, Feb 14, 2012 at 01:54:28AM +0800, Thomas Goirand wrote:
  On 02/14/2012 01:22 AM, Ben Pfaff wrote:
   Would it be possible for you to provide your make.log?
  
  I've attached it to this mail.
 
 Here's the root of the problem:
checking for Linux build directory... 
 /usr/src/linux-headers-3.1.0-1-686-pae
checking for Linux source directory... configure: error: cannot find 
 source directory (please use --with-linux-source)
 
 I see that this was already fixed on master with the following commit:
 
 --
 From 715a77b74caf22e38d1f232d1cc45036b9b83e62 Mon Sep 17 00:00:00 2001
 From: Ben Pfaff b...@nicira.com
 Date: Tue, 10 Jan 2012 14:22:22 -0800
 Subject: [PATCH] debian: Look in /lib/modules instead of /usr/src for DKMS 
 kernel sources.
 
 DKMS packages usually look in /lib/modules for kernel sources, since that
 is the standard location, but our packages was looking directly in
 /usr/src.  This fixes the problem.
 
 Reported-by: Alban Browaeys pra...@yahoo.com
 Tested-by: Alban Browaeys pra...@yahoo.com
 Signed-off-by: Ben Pfaff b...@nicira.com
 ---
  AUTHORS |1 +
  debian/dkms.conf.in |2 +-
  2 files changed, 2 insertions(+), 1 deletions(-)
 
 diff --git a/AUTHORS b/AUTHORS
 index d413523..87b3ccd 100644
 --- a/AUTHORS
 +++ b/AUTHORS
 @@ -60,6 +60,7 @@ provided helpful bug reports or suggestions.
  Aaron M. Ucko   u...@debian.org
  Aaron Rosen aro...@clemson.edu
  Ahmed Bilal numan...@gmail.com
 +Alban Browaeys  pra...@yahoo.com
  Alex Yipa...@nicira.com
  Alexey I. Froloff   ra...@altlinux.org
  Bob Ballbob.b...@citrix.com
 diff --git a/debian/dkms.conf.in b/debian/dkms.conf.in
 index 56c6398..a6dc316 100644
 --- a/debian/dkms.conf.in
 +++ b/debian/dkms.conf.in
 @@ -1,6 +1,6 @@
  PACKAGE_NAME=openvswitch
  PACKAGE_VERSION=__VERSION__
 -MAKE=./configure --with-linux=/usr/src/linux-headers-`uname -r` ; make -C 
 datapath/linux
 +MAKE=./configure --with-linux=/lib/modules/`uname -r`/build ; make -C 
 datapath/linux
  BUILT_MODULE_NAME[0]=openvswitch_mod
  BUILT_MODULE_NAME[1]=brcompat_mod
  BUILT_MODULE_LOCATION[0]=datapath/linux/
 --
 
 Somehow this bug fix did not make it to branches for 1.3 or 1.4.  I've
 now cherry-picked it to both branches, so the next Debian upload
 should incorporate the fix.
 
 I see that we should really be using ' instead of ; in the make
 rule.  I sent out a patch.

Thanks Ben, I plan to make make a fresh upload for this.

  During the course of upgrading XCP from 1.3 to 1.3.2, I've hit 3 bugs
  already. I really hope that's going to be it! :)
 
 I hope so too.  I hope that the others have been adequately addressed;
 let me know if not.
 



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#659685: [ovs-dev] Bug#659685: Bug#659685: fails to build the kernel module

2012-02-13 Thread Ben Pfaff
On Tue, Feb 14, 2012 at 09:31:18AM +0900, Simon Horman wrote:
 On Mon, Feb 13, 2012 at 10:10:18AM -0800, Ben Pfaff wrote:
  On Tue, Feb 14, 2012 at 01:54:28AM +0800, Thomas Goirand wrote:
   On 02/14/2012 01:22 AM, Ben Pfaff wrote:
Would it be possible for you to provide your make.log?
   
   I've attached it to this mail.
  
  Here's the root of the problem:
 checking for Linux build directory... 
  /usr/src/linux-headers-3.1.0-1-686-pae
 checking for Linux source directory... configure: error: cannot find 
  source directory (please use --with-linux-source)
  
  I see that this was already fixed on master with the following commit:
  
  Subject: [PATCH] debian: Look in /lib/modules instead of /usr/src for DKMS 
  kernel sources.
  
  DKMS packages usually look in /lib/modules for kernel sources, since that
  is the standard location, but our packages was looking directly in
  /usr/src.  This fixes the problem.
  
  Reported-by: Alban Browaeys pra...@yahoo.com
  Tested-by: Alban Browaeys pra...@yahoo.com
  Signed-off-by: Ben Pfaff b...@nicira.com
  ---
  Somehow this bug fix did not make it to branches for 1.3 or 1.4.  I've
  now cherry-picked it to both branches, so the next Debian upload
  should incorporate the fix.
  
  I see that we should really be using ' instead of ; in the make
  rule.  I sent out a patch.
 
 Thanks Ben, I plan to make make a fresh upload for this.

Thanks.

It might be wise to hold off for:
http://openvswitch.org/pipermail/dev/2012-February/014947.html
or to plan to make another new upload after it hits.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#659685: [ovs-dev] Bug#659685: Bug#659685: fails to build the kernel module

2012-02-13 Thread Simon Horman
On Mon, Feb 13, 2012 at 05:35:15PM -0800, Ben Pfaff wrote:
 On Tue, Feb 14, 2012 at 09:31:18AM +0900, Simon Horman wrote:
  On Mon, Feb 13, 2012 at 10:10:18AM -0800, Ben Pfaff wrote:
   On Tue, Feb 14, 2012 at 01:54:28AM +0800, Thomas Goirand wrote:
On 02/14/2012 01:22 AM, Ben Pfaff wrote:
 Would it be possible for you to provide your make.log?

I've attached it to this mail.
   
   Here's the root of the problem:
  checking for Linux build directory... 
   /usr/src/linux-headers-3.1.0-1-686-pae
  checking for Linux source directory... configure: error: cannot find 
   source directory (please use --with-linux-source)
   
   I see that this was already fixed on master with the following commit:
   
   Subject: [PATCH] debian: Look in /lib/modules instead of /usr/src for 
   DKMS kernel sources.
   
   DKMS packages usually look in /lib/modules for kernel sources, since that
   is the standard location, but our packages was looking directly in
   /usr/src.  This fixes the problem.
   
   Reported-by: Alban Browaeys pra...@yahoo.com
   Tested-by: Alban Browaeys pra...@yahoo.com
   Signed-off-by: Ben Pfaff b...@nicira.com
   ---
   Somehow this bug fix did not make it to branches for 1.3 or 1.4.  I've
   now cherry-picked it to both branches, so the next Debian upload
   should incorporate the fix.
   
   I see that we should really be using ' instead of ; in the make
   rule.  I sent out a patch.
  
  Thanks Ben, I plan to make make a fresh upload for this.
 
 Thanks.
 
 It might be wise to hold off for:
 http://openvswitch.org/pipermail/dev/2012-February/014947.html
 or to plan to make another new upload after it hits.

I am planing to include that patch in my upload.
I was not planing to wait for it to hit the git repo
but I can if you prefer.

I have confirmed that with the patch at the link above and other
patches it depends on applied the resulting package installs on my system -
though it should be said that the package that is currently present in
the archive is also installable on my system.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#659685: [ovs-dev] Bug#659685: Bug#659685: fails to build the kernel module

2012-02-13 Thread Ben Pfaff
On Tue, Feb 14, 2012 at 12:16:25PM +0900, Simon Horman wrote:
 On Mon, Feb 13, 2012 at 05:35:15PM -0800, Ben Pfaff wrote:
  On Tue, Feb 14, 2012 at 09:31:18AM +0900, Simon Horman wrote:
   On Mon, Feb 13, 2012 at 10:10:18AM -0800, Ben Pfaff wrote:
On Tue, Feb 14, 2012 at 01:54:28AM +0800, Thomas Goirand wrote:
 On 02/14/2012 01:22 AM, Ben Pfaff wrote:
  Would it be possible for you to provide your make.log?
 
 I've attached it to this mail.

Here's the root of the problem:
   checking for Linux build directory... 
/usr/src/linux-headers-3.1.0-1-686-pae
   checking for Linux source directory... configure: error: cannot find 
source directory (please use --with-linux-source)

I see that this was already fixed on master with the following commit:

Subject: [PATCH] debian: Look in /lib/modules instead of /usr/src for 
DKMS kernel sources.

DKMS packages usually look in /lib/modules for kernel sources, since 
that
is the standard location, but our packages was looking directly in
/usr/src.  This fixes the problem.

Reported-by: Alban Browaeys pra...@yahoo.com
Tested-by: Alban Browaeys pra...@yahoo.com
Signed-off-by: Ben Pfaff b...@nicira.com
---
Somehow this bug fix did not make it to branches for 1.3 or 1.4.  I've
now cherry-picked it to both branches, so the next Debian upload
should incorporate the fix.

I see that we should really be using ' instead of ; in the make
rule.  I sent out a patch.
   
   Thanks Ben, I plan to make make a fresh upload for this.
  
  Thanks.
  
  It might be wise to hold off for:
  http://openvswitch.org/pipermail/dev/2012-February/014947.html
  or to plan to make another new upload after it hits.
 
 I am planing to include that patch in my upload.

That makes sense.

 I was not planing to wait for it to hit the git repo
 but I can if you prefer.

I don't think that is necessary.  I tested it before I posted it, and
you said that you tested it too, and that is good enough for me.

 I have confirmed that with the patch at the link above and other
 patches it depends on applied the resulting package installs on my system -
 though it should be said that the package that is currently present in
 the archive is also installable on my system.

As on mine.

Thanks,

Ben.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#659685: [ovs-dev] Bug#659685: Bug#659685: fails to build the kernel module

2012-02-13 Thread Simon Horman
On Mon, Feb 13, 2012 at 08:07:36PM -0800, Ben Pfaff wrote:
 On Tue, Feb 14, 2012 at 12:16:25PM +0900, Simon Horman wrote:
  On Mon, Feb 13, 2012 at 05:35:15PM -0800, Ben Pfaff wrote:
   On Tue, Feb 14, 2012 at 09:31:18AM +0900, Simon Horman wrote:
On Mon, Feb 13, 2012 at 10:10:18AM -0800, Ben Pfaff wrote:
 On Tue, Feb 14, 2012 at 01:54:28AM +0800, Thomas Goirand wrote:
  On 02/14/2012 01:22 AM, Ben Pfaff wrote:
   Would it be possible for you to provide your make.log?
  
  I've attached it to this mail.
 
 Here's the root of the problem:
checking for Linux build directory... 
 /usr/src/linux-headers-3.1.0-1-686-pae
checking for Linux source directory... configure: error: cannot 
 find source directory (please use --with-linux-source)
 
 I see that this was already fixed on master with the following commit:
 
 Subject: [PATCH] debian: Look in /lib/modules instead of /usr/src for 
 DKMS kernel sources.
 
 DKMS packages usually look in /lib/modules for kernel sources, since 
 that
 is the standard location, but our packages was looking directly in
 /usr/src.  This fixes the problem.
 
 Reported-by: Alban Browaeys pra...@yahoo.com
 Tested-by: Alban Browaeys pra...@yahoo.com
 Signed-off-by: Ben Pfaff b...@nicira.com
 ---
 Somehow this bug fix did not make it to branches for 1.3 or 1.4.  I've
 now cherry-picked it to both branches, so the next Debian upload
 should incorporate the fix.
 
 I see that we should really be using ' instead of ; in the make
 rule.  I sent out a patch.

Thanks Ben, I plan to make make a fresh upload for this.
   
   Thanks.
   
   It might be wise to hold off for:
   http://openvswitch.org/pipermail/dev/2012-February/014947.html
   or to plan to make another new upload after it hits.
  
  I am planing to include that patch in my upload.
 
 That makes sense.
 
  I was not planing to wait for it to hit the git repo
  but I can if you prefer.
 
 I don't think that is necessary.  I tested it before I posted it, and
 you said that you tested it too, and that is good enough for me.

Thanks, I have now uploaded 1.4.0-2.

  I have confirmed that with the patch at the link above and other
  patches it depends on applied the resulting package installs on my system -
  though it should be said that the package that is currently present in
  the archive is also installable on my system.
 
 As on mine.
 
 Thanks,
 
 Ben.
 



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org