Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
Il 03/06/2012 22:33, Thorsten Alteholz ha scritto: > Hi Giulio, > > On Sun, 3 Jun 2012, Giulio Paci wrote: >> You are right, that link still points to the upload you reviewed the >> first time: new uploads did not overwrote those file, due to the section >> change. > > oh, no, this has been my first time looking at that package. I did not checked your name carefully... I just got confused by the message. :-) >> The right url is: >> http://mentors.debian.net/debian/pool/main/s/shotdetect/shotdetect_1.0.86-1.dsc >> > > Is there a reason to use debhelper 7? Not that I am aware, just some old files being copied. > The pedantic info from lintian > goes away with something like: debhelper (>=9),(of course you need > to change debian/compat as well). > If you use 'dh' in the rules file, dh9 should automatically take care of > the hardening-stuff (this is a release goal for wheezy). I am sure that > there is also a way for cdbs. I just uploaded a new version of the package which depends on debhelper >= 9; lintian seems not to report the warnings you pointed out anymore. and the software is still working. > So if you don't have a sponsor yet and let those complaints from lintian > disappear, I will upload the package. I do not have a sponsor yet, so you are welcome! Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
Hi Giulio, On Sun, 3 Jun 2012, Giulio Paci wrote: You are right, that link still points to the upload you reviewed the first time: new uploads did not overwrote those file, due to the section change. oh, no, this has been my first time looking at that package. The right url is: http://mentors.debian.net/debian/pool/main/s/shotdetect/shotdetect_1.0.86-1.dsc Is there a reason to use debhelper 7? The pedantic info from lintian goes away with something like: debhelper (>=9),(of course you need to change debian/compat as well). If you use 'dh' in the rules file, dh9 should automatically take care of the hardening-stuff (this is a release goal for wheezy). I am sure that there is also a way for cdbs. So if you don't have a sponsor yet and let those complaints from lintian disappear, I will upload the package. Thorsten P: shotdetect source: package-lacks-versioned-build-depends-on-debhelper 7 N: N:The package either doesn't declare a versioned build dependency on N:debhelper or does not declare a versioned build dependency on a new N:enough version of debhelper to satisfy the declared compatibility level. N: N:Recommended practice is to always declare an explicit versioned N:dependency on debhelper equal to or greater than the compatibility level N:used by the package, even if the versioned dependency isn't strictly N:necessary. Having a versioned dependency also helps with backports to N:older releases and correct builds on partially updated systems. N: N:Refer to the debhelper(7) manual page for details. N: N:Severity: pedantic, Certainty: certain N: N:Check: debhelper, Type: source N: W: shotdetect: hardening-no-fortify-functions usr/bin/shotdetect N: N:This package provides an ELF binary that lacks the use of fortified libc N:functions. Either there are no potentially unfortified functions called N:by any routines, all unfortified calls have already been fully validated N:at compile-time, or the package was not built with the default Debian N:compiler flags defined by dpkg-buildflags. If built using N:dpkg-buildflags directly, be sure to import CPPFLAGS. N: N:NB: Due to false-positives, Lintian ignores some unprotected functions N:(e.g. memcpy). N: N:Refer to http://wiki.debian.org/Hardening and N:http://bugs.debian.org/673112 for details. N: N:Severity: normal, Certainty: possible N: N:Check: binaries, Type: binary, udeb N: -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
Hi Thorsten, Il 03/06/2012 16:06, Thorsten Alteholz ha scritto: > Hi Giulio, > >>> - I don't think you should install AUTHORS; it contains a single name, >>> and that information is in debian/copyright already. >>> >>> The NEWS file seems pretty useless as well. >>> >>> The README file is just plain confusing. >> >> Those files are not installed anymore. >> >> I just re-uploaded the package here: >> http://mentors.debian.net/debian/pool/contrib/s/shotdetect/shotdetect_1.0.86-1.dsc >> > > are you sure about the new upload? > > At leaset these files are still in the generated deb-file!? You are right, that link still points to the upload you reviewed the first time: new uploads did not overwrote those file, due to the section change. The right url is: http://mentors.debian.net/debian/pool/main/s/shotdetect/shotdetect_1.0.86-1.dsc Thank you again for looking at it. Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
Hi Giulio, - I don't think you should install AUTHORS; it contains a single name, and that information is in debian/copyright already. The NEWS file seems pretty useless as well. The README file is just plain confusing. Those files are not installed anymore. I just re-uploaded the package here: http://mentors.debian.net/debian/pool/contrib/s/shotdetect/shotdetect_1.0.86-1.dsc are you sure about the new upload? At leaset these files are still in the generated deb-file!? Thorsten -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
Hi Benoît, thank you again for these notices. Il 06/03/2012 23:25, Benoît Knecht ha scritto: > Giulio Paci wrote: >> thank you for your comment. I updated the package, adding the missing >> libxslt1-dev dependency and fixing a couple of other minor issues. > > A few things to look into: > > - Your man page is quite thin. Please expand it using full words > instead of abbreviations (img, thumb, etc.) and full sentences. Try > explaining what each option does. > > For instance, '-o' takes a path as an argument; to what, a directory > or a file? What happens if both and XML file and a thumbnail are to > be generated? > > Likewise, the description of '-s' doesn't help me at all. What is > the range of the threshold? Is it a float or an integer? What does > it represent? > > For '-w', what is a waveform? > > You also need to escape the space between 'January,' and '2012'. I fixed the man page as much as I was able of the issue above. I think that now the man page is much more useful. > - debian/patches/compilation_fixes.patch contains a lot of whitespace > fixes, most of them in comments; please remove those to make it > easier to understand. Now the changes are only those that are really necessary (I am not removing trailing spaces anymore). > - Why are you putting your package in contrib/misc? As far as I can > see, it doesn't depend on a non-free package, so the video section > seems more appropriate. You are right. I also changed the section to video. > - ltmain.sh is GPL-2+, and the FSF is its copyright holder; this > should be reflected in debian/copyright. Use > > licensecheck -r --copyright . > > to make sure you're not missing anything else. Thank you for the hint. I think that all the files have their copyright and license correctly reported now. > - I don't think you should install AUTHORS; it contains a single name, > and that information is in debian/copyright already. > > The NEWS file seems pretty useless as well. > > The README file is just plain confusing. Those files are not installed anymore. I just re-uploaded the package here: http://mentors.debian.net/debian/pool/contrib/s/shotdetect/shotdetect_1.0.86-1.dsc Cheers, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
Giulio Paci wrote: > thank you for your comment. I updated the package, adding the missing > libxslt1-dev dependency and fixing a couple of other minor issues. A few things to look into: - Your man page is quite thin. Please expand it using full words instead of abbreviations (img, thumb, etc.) and full sentences. Try explaining what each option does. For instance, '-o' takes a path as an argument; to what, a directory or a file? What happens if both and XML file and a thumbnail are to be generated? Likewise, the description of '-s' doesn't help me at all. What is the range of the threshold? Is it a float or an integer? What does it represent? For '-w', what is a waveform? You also need to escape the space between 'January,' and '2012'. - debian/patches/compilation_fixes.patch contains a lot of whitespace fixes, most of them in comments; please remove those to make it easier to understand. - Why are you putting your package in contrib/misc? As far as I can see, it doesn't depend on a non-free package, so the video section seems more appropriate. - ltmain.sh is GPL-2+, and the FSF is its copyright holder; this should be reflected in debian/copyright. Use licensecheck -r --copyright . to make sure you're not missing anything else. - I don't think you should install AUTHORS; it contains a single name, and that information is in debian/copyright already. The NEWS file seems pretty useless as well. The README file is just plain confusing. Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
Hi Benoît, thank you for your comment. I updated the package, adding the missing libxslt1-dev dependency and fixing a couple of other minor issues. Cheers, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
tags 662026 moreinfo thanks Hi Giulio, Giulio Paci wrote: > I am looking for a sponsor for my package "shotdetect" > > * Package name: shotdetect >Version : 1.0.86-1 >Upstream Author : Johan MATHE > * URL : http://shotdetect.nonutc.fr/ > * License : LGPL-2.1+ >Section : misc > > It builds those binary packages: > > shotdetect - scene change detector You seem to be missing a dependency: [...] checking for gcc... gcc checking whether we are using the GNU C compiler... yes checking whether gcc accepts -g... yes checking for gcc option to accept ISO C89... none needed checking dependency style of gcc... none checking for libxml libraries >= ... 2.7.8 found configure: error: xslt-config not found. Please reinstall the libxslt >= 1.1.0 distribution make: *** [debian/stamp-autotools] Error 1 dpkg-buildpackage: error: debian/rules build gave error exit status 2 Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#662026: RFS: shotdetect/1.0.86-1 [ITP]
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "shotdetect" * Package name: shotdetect Version : 1.0.86-1 Upstream Author : Johan MATHE * URL : http://shotdetect.nonutc.fr/ * License : LGPL-2.1+ Section : misc It builds those binary packages: shotdetect - scene change detector To access further information about this package, please visit the following URL: http://mentors.debian.net/package/shotdetect Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/contrib/s/shotdetect/shotdetect_1.0.86-1.dsc More information about shotdetect can be obtained from http://shotdetect.nonutc.fr/. Regards, Giulio Paci -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (990, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.1.7geppetto (SMP w/2 CPU cores) Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org