Bug#662794: nmudiff: Please, add a non-dd template for those who can not upload NMUs
Le jeudi 08 mars 2018 à 02:44:21+0100, Mattia Rizzolo a écrit : > On Wed, Mar 07, 2018 at 11:41:08PM +0100, Pierre-Elliott Bécue wrote: > > In the other cases, it only adds a tag pending, which is not in > > contradiction with not being a DD, as a pending tag only means that the > > changes are included in the package's vcs and will be included in the next > > release. > > That's not true. > Despite being from a time before me, I know that the 'pending' tag long > predates the common usage of a VCS for packaging. > It just means the change has been added to the maintainer's working > tree, whatever that means. > In the case of a NMU it just has a different meaning of being already > uploaded to a delayed queue (or not, you can do a NMU by announcing you > will upload in 5 days without using the technicality of the delayed > upload queue). Consider that usually NMUs are not committed anywhere in > the maintainer's space. Yes, you're right, I kind of interpreted pending according to what I see now, but it's biased as it doesn't reflect the full reality. > > I think the appropriate answer to your remarks is to include your template > > feature, and add a --no-pending-tag argument to prevent the pending tag from > > being added to the mail. > > > > Apart from that, I don't see how it would make a real difference between > > being > > DD/DM or just a contributor. > > As a non-DD I'd probably look for a template that says something like > "I've prepared …… and I'm now looking for sponsorship for an upload to > DELAYED/whatever", with the idea that then whenever a sponsor uploads > just adds the 'pending' tag. > But I've been a DD for too long, I don't remember anymore my troubles > with NMUs when I wasn't yet a DD, what about you? The fact that a non-DD would ask for sponsorship seems quite relevant to me. It seems to fit with my proposition doesn't it? Thanks, -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. signature.asc Description: PGP signature
Bug#662794: nmudiff: Please, add a non-dd template for those who can not upload NMUs
On Wed, Mar 07, 2018 at 11:41:08PM +0100, Pierre-Elliott Bécue wrote: > In the other cases, it only adds a tag pending, which is not in > contradiction with not being a DD, as a pending tag only means that the > changes are included in the package's vcs and will be included in the next > release. That's not true. Despite being from a time before me, I know that the 'pending' tag long predates the common usage of a VCS for packaging. It just means the change has been added to the maintainer's working tree, whatever that means. In the case of a NMU it just has a different meaning of being already uploaded to a delayed queue (or not, you can do a NMU by announcing you will upload in 5 days without using the technicality of the delayed upload queue). Consider that usually NMUs are not committed anywhere in the maintainer's space. > I think the appropriate answer to your remarks is to include your template > feature, and add a --no-pending-tag argument to prevent the pending tag from > being added to the mail. > > Apart from that, I don't see how it would make a real difference between being > DD/DM or just a contributor. As a non-DD I'd probably look for a template that says something like "I've prepared …… and I'm now looking for sponsorship for an upload to DELAYED/whatever", with the idea that then whenever a sponsor uploads just adds the 'pending' tag. But I've been a DD for too long, I don't remember anymore my troubles with NMUs when I wasn't yet a DD, what about you? -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#662794: nmudiff: Please, add a non-dd template for those who can not upload NMUs
Dear Mònica, Six years. That's really a long time span. I answer to your email address (I'll see if a bounce comes back) because you submitted this bug, and I'm currently giving a try at reviewing & including the patches submitted by the users. Maybe you do not really care anymore about this feature, but it's worth a try. Thanks for your patch. For now, I think it lacks a little specification. The nmudiff does not upload anything in a practical point of view. The only upload reference in the text in in the case you provide the delay argument, which would be nonsense if you are no DD. In the other cases, it only adds a tag pending, which is not in contradiction with not being a DD, as a pending tag only means that the changes are included in the package's vcs and will be included in the next release. But, indeed, in some cases, you might not want to add this pending tag. I think the appropriate answer to your remarks is to include your template feature, and add a --no-pending-tag argument to prevent the pending tag from being added to the mail. Apart from that, I don't see how it would make a real difference between being DD/DM or just a contributor. I'll give it a week to see if you are still around and willing to discuss it, and otherwise mix your patch with the changes I suggested. Cheers, and, sorry that you got no answer for so long. -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them. signature.asc Description: PGP signature
