Bug#663577: irssi-scripts-20120326 new release
Hi Daniel, On Thu, May 03, 2012 at 07:50:16PM -0500, Daniel Echeverry wrote: Hi Ryan I updated the copyright file with license information found in the header of each script. I hope all is well now :) This all looks great, you've even improved accuracy from the previous copyright file in a few cases. I am uploading the package now. Thanks for your contribution! Cheers, Ryan -- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#663577: irssi-scripts-20120326 new release
Hi Daniel, On Sun, Apr 29, 2012 at 01:34:48PM -0500, Daniel Echeverry wrote: Hi, I have reviewed all the scripts from the list, I fix some typos, but there are other scripts that have 2 different licenses. Below I show you the scripts that were settled and those who need to reviewed again. [snip script output] Thanks for settling these. [1]: Declare a header with a license and below another license ( is it necessary contact the upstream ?) Fixed: error found and fixed OK: OK --- For this case it is necessary to contact the upstream to verify the license? I have looked at many of these and it seems the problem your are noticing is they have a license text block as a comment at the top, but the license specified for the %IRSSI settings is not referring to that specific license. Since the license setting allows plain text without a standard format, I beleive that the authors have simply been less precise here without realizing the potential confusion. As long as they specify the same type of license, but the block is more precise about the specific license versions, I think it will be fine for us to just use the license text block which is more precise and limiting. Thank you very much!! Thank you again for your work, and patience, on this! I may be able to work on this tonight, but hope to get this uploaded by tomorrow, if not. Cheers, Ryan -- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#663577: irssi-scripts-20120326 new release
2012/5/3 Ryan Niebur r...@debian.org: Hi Daniel, On Sun, Apr 29, 2012 at 01:34:48PM -0500, Daniel Echeverry wrote: Hi, I have reviewed all the scripts from the list, I fix some typos, but there are other scripts that have 2 different licenses. Below I show you the scripts that were settled and those who need to reviewed again. [snip script output] Thanks for settling these. [1]: Declare a header with a license and below another license ( is it necessary contact the upstream ?) Fixed: error found and fixed OK: OK --- For this case it is necessary to contact the upstream to verify the license? I have looked at many of these and it seems the problem your are noticing is they have a license text block as a comment at the top, but the license specified for the %IRSSI settings is not referring to that specific license. Since the license setting allows plain text without a standard format, I beleive that the authors have simply been less precise here without realizing the potential confusion. As long as they specify the same type of license, but the block is more precise about the specific license versions, I think it will be fine for us to just use the license text block which is more precise and limiting. Thank you very much!! Thank you again for your work, and patience, on this! I may be able to work on this tonight, but hope to get this uploaded by tomorrow, if not. Cheers, Ryan -- Hi Ryan I updated the copyright file with license information found in the header of each script. I hope all is well now :) Thank you very much -- Epsilon http://wiki.debian.org/DanielEcheverry http://www.rinconinformatico.net http://enchulatucelu.com http://www.todopdf.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#663577: irssi-scripts-20120326 new release
2012/4/28 Ryan Niebur r...@debian.org: Hello. I expect it may require a bit of verification in case there is a bug (or if licenses really needed a change), as I have not looked over it entirely thoroughly. But here is the output of my script: DIFF: openurl.pl changed from GPL-2.0 to DIFF: fserve.pl changed from GPL-2.0+ to GPL-2.0 DIFF: xauth.pl changed from GPL-2.0+ to GPL-2.0 DIFF: noteserve.pl changed from GPL-2.0 to DIFF: linkshort.pl changed from GPL-2.0 to DIFF: foreach_user.pl changed from GPL-2.0+ to DIFF: nickserv.pl changed from GPL-2.0+ to GPL-1.0 DIFF: doc.pl changed from GPL-2.0+ to GPL-1.0 DIFF: fakectcp.pl changed from GPL-2.0+ to GPL-1.0 DIFF: gpgvalidator.pl changed from GPL-2.0+ to GPL-2.0 DIFF: xmmsinfo.pl changed from GPL-2.0+ to GPL-2.0 DIFF: ignore_log.pl changed from GPL-2.0+ to DIFF: dancer_hide_477.pl changed from GPL-2.0+ to GPL-1.0 DIFF: opnotice.pl changed from GPL-2.0+ to GPL-2.0 DIFF: fuckem.pl changed from GPL-2.0+ to GPL-1.0 DIFF: quizgr.pl changed from GPL-2.0+ to DIFF: akftp.pl changed from GPL-2.0+ to GPL-2.0 DIFF: active_notify.pl changed from GPL-2.0+ to DIFF: modelist-r.pl changed from GPL-2.0 to DIFF: autoreminder.pl changed from GPL-2.0+ to GPL-2.0 DIFF: schwaebisch.pl changed from GPL-2.0+ to GPL-2.0 DIFF: warnkick.pl changed from GPL-2.0+ to GPL-1.0 DIFF: phpdoc.pl changed from GPL-2.0+ to DIFF: freenode_filter.pl changed from GPL-2.0+ to GPL-1.0 DIFF: washnicks.pl changed from GPL-1.0 to DIFF: imdb.pl changed from GPL-1.0 to DIFF: challenge.pl changed from GPL-2.0 to GPL-2.0+ DIFF: bitlbee_tab_completion.pl changed from GPL-2.0 to DIFF: ixmmsa.pl changed from GPL-2.0+ to GPL-1.0 DIFF: away_hilight_notice.pl changed from GPL-2.0+ to GPL-1.0 DIFF: paste_huggie.pl changed from GPL-2.0+ to GPL-2.0 DIFF: xcmd.pl changed from GPL-2.0+ to GPL-2.0 DIFF: tvmusor.pl changed from BSD to BSDL DIFF: scripthelp.pl changed from GPL-2.0+ to DIFF: ipupdate.pl changed from GPL-1.0 to DIFF: kline_warning.pl changed from GPL-2.0+ to GPL-1.0 DIFF: iMPD.pl changed from GPL-2.0+ to DIFF: wordscramble.pl changed from GPL-2.0+ to GPL-2.0 DIFF: findbot.pl changed from GPL-2.0+ to GPL-1.0 DIFF: urlgrab.pl changed from GPL-2.0+ to DIFF: mkick.pl changed from GPL-2.0 to DIFF: emaildb1.0.pl changed from GPL-2.0+ to DIFF: quiz.pl changed from GPL-2.0+ to GPL-2.0 DIFF: active_notice.pl changed from GPL-2.0+ to On Sat, Apr 28, 2012 at 02:09:59PM -0500, Daniel Echeverry wrote: [..] Hi Ryan. Ok, if you want you can send me the modifications that are required, and I will make them right away. Thank you very much!! -- Epsilon http://wiki.debian.org/DanielEcheverry http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user -- Hi, I have reviewed all the scripts from the list, I fix some typos, but there are other scripts that have 2 different licenses. Below I show you the scripts that were settled and those who need to reviewed again. -- DIFF: openurl.pl changed from GPL-2.0 to GPL-2.0 - Fixed DIFF: fserve.pl changed from GPL-2.0+ to GPL-2.0 - [1] DIFF: xauth.pl changed from GPL-2.0+ to GPL-2.0 - Fixed DIFF: noteserve.pl changed from GPL-2.0 to- Fixed DIFF: linkshort.pl changed from GPL-2.0 to- Not found DIFF: foreach_user.pl changed from GPL-2.0+ to- Fixed DIFF: nickserv.pl changed from GPL-2.0+ to GPL-1.0- [1] DIFF: doc.pl changed from GPL-2.0+ to GPL-1.0 - [1] DIFF: fakectcp.pl changed from GPL-2.0+ to GPL-1.0- [1] DIFF: gpgvalidator.pl changed from GPL-2.0+ to GPL-2.0- [1] DIFF: xmmsinfo.pl changed from GPL-2.0+ to GPL-2.0- [1] DIFF: ignore_log.pl changed from GPL-2.0+ to - [1] DIFF: dancer_hide_477.pl changed from GPL-2.0+ to GPL-1.0 - [1] DIFF: opnotice.pl changed from GPL-2.0+ to GPL-2.0- [1] DIFF: fuckem.pl changed from GPL-2.0+ to GPL-1.0 - [1] DIFF: quizgr.pl changed from GPL-2.0+ to - [1] DIFF: akftp.pl changed from GPL-2.0+ to GPL-2.0 - [1] DIFF: active_notify.pl changed from GPL-2.0+ to - [1] DIFF: modelist-r.pl changed from GPL-2.0 to - Fixed DIFF: autoreminder.pl changed from GPL-2.0+ to GPL-2.0- [1] DIFF: schwaebisch.pl changed from GPL-2.0+ to GPL-2.0 - [1] DIFF: warnkick.pl changed from GPL-2.0+ to GPL-1.0- [1] DIFF: phpdoc.pl changed from GPL-2.0+ to - [1] DIFF: freenode_filter.pl changed from GPL-2.0+ to GPL-1.0 - [1] DIFF: washnicks.pl changed from GPL-1.0 to- Fixed DIFF: imdb.pl changed from GPL-1.0 to - Fixed
Bug#663577: irssi-scripts-20120326 new release
Hello Daniel, Your new changes look good. Since I didn't trust myself to do a thorough reivew of the new copyright file (it seems like more than a person could reasonably handle in one sitting), I've written a script which compares it with the old version, which seems to have noticed some possible discrepancies. I will make the minor corrections for those tonight, if needed, before completing my review. Thanks for the patience, your contributions are appreciated. Cheers, Ryan On Sun, Apr 22, 2012 at 01:05:32PM -0500, Daniel Echeverry wrote: El dÃa 19 de abril de 2012 04:06, Ryan Niebur r...@debian.org escribió: Hi Daniel, Thanks for your work on this, and I apologize for the delay in response. On Fri, Apr 13, 2012 at 02:39:10PM -0500, Daniel Echeverry wrote: Hi, This week I've been working on packaging a new version of irssi-scripts. I closed some bugs and updated some of the scripts. I uploaded the package to debian mentors. [1] Additionally, I added a copyright.new in debian/, This file is copyright copyright DEP5 Update to 1.0 format. Could you check out the new version and the new copyright file? I've reviewed your packaging work now and overall it looks really good. Though I do wonder, have you used a git repository to track your changes? If not, we currently use a repository located here: http://anonscm.debian.org/gitweb/?p=collab-maint/irssi-scripts.git This would be preferable because it helps to make collaborating and reviewing changes easier (this would also replace the need to build and upload the source package to mentors). I think it should be okay for us to allow you to push changes to the repository there, if you want...are you a member of collab-maint on alioth? Anyways, the only major issue I've noticed is that this detail got removed from debian/rules, but the executable permission is relied on by the script: # log2ansi.pl will run outside irssi, so it needs the executable bit chmod +x $D/usr/share/irssi/scripts/log2ansi.pl So, we need to set the executable permission on this file during build. Some other more minor things I noticed are: The debian/copyright.new file looks very good, however I think the GPL-2.0 license definition should replace the text about receiving a copy of the license with a reference to /usr/share/common-licenses, as you have done with the GPL-2.0+ block. Also, the License:GPL-2.0+ is missing a space after the colon. I think it should be fine to replace debian/copyright with your debian/copyright.new once these small improvements are made. With regards to dependencies on perl and perl-modules, this is really not necessary since the base perl, which is all that is required for most scripts, is always installed. In debian/README.Debian there is an explanation of how the dependencies are chosen (at least 3 scripts = Suggests, at least 20 scripts = Recommends), and it looks like there are actually more scripts which depend on libwww-perl than perl or perl-modules, from the list in debian/README.Debian. I'm not opposed to changing how this is done if there is value added in doing so, but if we make that choice we will need to update debian/README.Debian as well (and should possibly treat the other dependencies consistently). It might be better to just explain the way we do this to the requestor of this change instead. There were a couple patches (go.pl-multiple-networks.diff and away.pl.diff) which used to have links to bug reports instead of proper headers, and you've replaced those with DEP5 patch headers (which is great, thanks!), but I think it could be useful to still have the old bug references included within the new DEP5 information. [1]: http://mentors.debian.net/debian/pool/main/i/irssi-scripts/ irssi-scripts_20120326.dsc Thank you very much!! No, thank you! I will be able to sponsor this upload once we address the above mentioned items and I do a final review, but first I also want to hear back about if and how you want to make use of the git repository for collaboration. Cheers, Ryan -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk+P1XwACgkQMihv+PacasXwggCeOmqsvrr2lfcGsBM1VPA2LFxg hjEAn1oLlpICofxeicOIMAndpUxkVwok =MyTD -END PGP SIGNATURE- Hi, I have fixed all the points you mentioned, and I updated the git repository on Alioth,Could you please check out again the package[1]? Thank You very much!! [1]: http://anonscm.debian.org/gitweb/?p=collab-maint/irssi-scripts.git;a=summary -- Epsilon http://wiki.debian.org/DanielEcheverry http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user -- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#663577: irssi-scripts-20120326 new release
2012/4/28 Ryan Niebur r...@debian.org: Hello Daniel, Your new changes look good. Since I didn't trust myself to do a thorough reivew of the new copyright file (it seems like more than a person could reasonably handle in one sitting), I've written a script which compares it with the old version, which seems to have noticed some possible discrepancies. I will make the minor corrections for those tonight, if needed, before completing my review. Thanks for the patience, your contributions are appreciated. Cheers, Ryan On Sun, Apr 22, 2012 at 01:05:32PM -0500, Daniel Echeverry wrote: El día 19 de abril de 2012 04:06, Ryan Niebur r...@debian.org escribió: Hi Daniel, Thanks for your work on this, and I apologize for the delay in response. On Fri, Apr 13, 2012 at 02:39:10PM -0500, Daniel Echeverry wrote: Hi, This week I've been working on packaging a new version of irssi-scripts. I closed some bugs and updated some of the scripts. I uploaded the package to debian mentors. [1] Additionally, I added a copyright.new in debian/, This file is copyright copyright DEP5 Update to 1.0 format. Could you check out the new version and the new copyright file? I've reviewed your packaging work now and overall it looks really good. Though I do wonder, have you used a git repository to track your changes? If not, we currently use a repository located here: http://anonscm.debian.org/gitweb/?p=collab-maint/irssi-scripts.git This would be preferable because it helps to make collaborating and reviewing changes easier (this would also replace the need to build and upload the source package to mentors). I think it should be okay for us to allow you to push changes to the repository there, if you want...are you a member of collab-maint on alioth? Anyways, the only major issue I've noticed is that this detail got removed from debian/rules, but the executable permission is relied on by the script: # log2ansi.pl will run outside irssi, so it needs the executable bit chmod +x $D/usr/share/irssi/scripts/log2ansi.pl So, we need to set the executable permission on this file during build. Some other more minor things I noticed are: The debian/copyright.new file looks very good, however I think the GPL-2.0 license definition should replace the text about receiving a copy of the license with a reference to /usr/share/common-licenses, as you have done with the GPL-2.0+ block. Also, the License:GPL-2.0+ is missing a space after the colon. I think it should be fine to replace debian/copyright with your debian/copyright.new once these small improvements are made. With regards to dependencies on perl and perl-modules, this is really not necessary since the base perl, which is all that is required for most scripts, is always installed. In debian/README.Debian there is an explanation of how the dependencies are chosen (at least 3 scripts = Suggests, at least 20 scripts = Recommends), and it looks like there are actually more scripts which depend on libwww-perl than perl or perl-modules, from the list in debian/README.Debian. I'm not opposed to changing how this is done if there is value added in doing so, but if we make that choice we will need to update debian/README.Debian as well (and should possibly treat the other dependencies consistently). It might be better to just explain the way we do this to the requestor of this change instead. There were a couple patches (go.pl-multiple-networks.diff and away.pl.diff) which used to have links to bug reports instead of proper headers, and you've replaced those with DEP5 patch headers (which is great, thanks!), but I think it could be useful to still have the old bug references included within the new DEP5 information. [1]: http://mentors.debian.net/debian/pool/main/i/irssi-scripts/ irssi-scripts_20120326.dsc Thank you very much!! No, thank you! I will be able to sponsor this upload once we address the above mentioned items and I do a final review, but first I also want to hear back about if and how you want to make use of the git repository for collaboration. Cheers, Ryan -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk+P1XwACgkQMihv+PacasXwggCeOmqsvrr2lfcGsBM1VPA2LFxg hjEAn1oLlpICofxeicOIMAndpUxkVwok =MyTD -END PGP SIGNATURE- Hi, I have fixed all the points you mentioned, and I updated the git repository on Alioth,Could you please check out again the package[1]? Thank You very much!! [1]: http://anonscm.debian.org/gitweb/?p=collab-maint/irssi-scripts.git;a=summary -- Epsilon http://wiki.debian.org/DanielEcheverry http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user -- Hi Ryan. Ok, if you want you can send me the modifications that are required, and I will make them right away. Thank
Bug#663577: irssi-scripts-20120326 new release
Hello. I expect it may require a bit of verification in case there is a bug (or if licenses really needed a change), as I have not looked over it entirely thoroughly. But here is the output of my script: DIFF: openurl.pl changed from GPL-2.0 to DIFF: fserve.pl changed from GPL-2.0+ to GPL-2.0 DIFF: xauth.pl changed from GPL-2.0+ to GPL-2.0 DIFF: noteserve.pl changed from GPL-2.0 to DIFF: linkshort.pl changed from GPL-2.0 to DIFF: foreach_user.pl changed from GPL-2.0+ to DIFF: nickserv.pl changed from GPL-2.0+ to GPL-1.0 DIFF: doc.pl changed from GPL-2.0+ to GPL-1.0 DIFF: fakectcp.pl changed from GPL-2.0+ to GPL-1.0 DIFF: gpgvalidator.pl changed from GPL-2.0+ to GPL-2.0 DIFF: xmmsinfo.pl changed from GPL-2.0+ to GPL-2.0 DIFF: ignore_log.pl changed from GPL-2.0+ to DIFF: dancer_hide_477.pl changed from GPL-2.0+ to GPL-1.0 DIFF: opnotice.pl changed from GPL-2.0+ to GPL-2.0 DIFF: fuckem.pl changed from GPL-2.0+ to GPL-1.0 DIFF: quizgr.pl changed from GPL-2.0+ to DIFF: akftp.pl changed from GPL-2.0+ to GPL-2.0 DIFF: active_notify.pl changed from GPL-2.0+ to DIFF: modelist-r.pl changed from GPL-2.0 to DIFF: autoreminder.pl changed from GPL-2.0+ to GPL-2.0 DIFF: schwaebisch.pl changed from GPL-2.0+ to GPL-2.0 DIFF: warnkick.pl changed from GPL-2.0+ to GPL-1.0 DIFF: phpdoc.pl changed from GPL-2.0+ to DIFF: freenode_filter.pl changed from GPL-2.0+ to GPL-1.0 DIFF: washnicks.pl changed from GPL-1.0 to DIFF: imdb.pl changed from GPL-1.0 to DIFF: challenge.pl changed from GPL-2.0 to GPL-2.0+ DIFF: bitlbee_tab_completion.pl changed from GPL-2.0 to DIFF: ixmmsa.pl changed from GPL-2.0+ to GPL-1.0 DIFF: away_hilight_notice.pl changed from GPL-2.0+ to GPL-1.0 DIFF: paste_huggie.pl changed from GPL-2.0+ to GPL-2.0 DIFF: xcmd.pl changed from GPL-2.0+ to GPL-2.0 DIFF: tvmusor.pl changed from BSD to BSDL DIFF: scripthelp.pl changed from GPL-2.0+ to DIFF: ipupdate.pl changed from GPL-1.0 to DIFF: kline_warning.pl changed from GPL-2.0+ to GPL-1.0 DIFF: iMPD.pl changed from GPL-2.0+ to DIFF: wordscramble.pl changed from GPL-2.0+ to GPL-2.0 DIFF: findbot.pl changed from GPL-2.0+ to GPL-1.0 DIFF: urlgrab.pl changed from GPL-2.0+ to DIFF: mkick.pl changed from GPL-2.0 to DIFF: emaildb1.0.pl changed from GPL-2.0+ to DIFF: quiz.pl changed from GPL-2.0+ to GPL-2.0 DIFF: active_notice.pl changed from GPL-2.0+ to On Sat, Apr 28, 2012 at 02:09:59PM -0500, Daniel Echeverry wrote: [..] Hi Ryan. Ok, if you want you can send me the modifications that are required, and I will make them right away. Thank you very much!! -- Epsilon http://wiki.debian.org/DanielEcheverry http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user -- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#663577: irssi-scripts-20120326 new release
El día 19 de abril de 2012 04:06, Ryan Niebur r...@debian.org escribió: Hi Daniel, Thanks for your work on this, and I apologize for the delay in response. On Fri, Apr 13, 2012 at 02:39:10PM -0500, Daniel Echeverry wrote: Hi, This week I've been working on packaging a new version of irssi-scripts. I closed some bugs and updated some of the scripts. I uploaded the package to debian mentors. [1] Additionally, I added a copyright.new in debian/, This file is copyright copyright DEP5 Update to 1.0 format. Could you check out the new version and the new copyright file? I've reviewed your packaging work now and overall it looks really good. Though I do wonder, have you used a git repository to track your changes? If not, we currently use a repository located here: http://anonscm.debian.org/gitweb/?p=collab-maint/irssi-scripts.git This would be preferable because it helps to make collaborating and reviewing changes easier (this would also replace the need to build and upload the source package to mentors). I think it should be okay for us to allow you to push changes to the repository there, if you want...are you a member of collab-maint on alioth? Anyways, the only major issue I've noticed is that this detail got removed from debian/rules, but the executable permission is relied on by the script: # log2ansi.pl will run outside irssi, so it needs the executable bit chmod +x $D/usr/share/irssi/scripts/log2ansi.pl So, we need to set the executable permission on this file during build. Some other more minor things I noticed are: The debian/copyright.new file looks very good, however I think the GPL-2.0 license definition should replace the text about receiving a copy of the license with a reference to /usr/share/common-licenses, as you have done with the GPL-2.0+ block. Also, the License:GPL-2.0+ is missing a space after the colon. I think it should be fine to replace debian/copyright with your debian/copyright.new once these small improvements are made. With regards to dependencies on perl and perl-modules, this is really not necessary since the base perl, which is all that is required for most scripts, is always installed. In debian/README.Debian there is an explanation of how the dependencies are chosen (at least 3 scripts = Suggests, at least 20 scripts = Recommends), and it looks like there are actually more scripts which depend on libwww-perl than perl or perl-modules, from the list in debian/README.Debian. I'm not opposed to changing how this is done if there is value added in doing so, but if we make that choice we will need to update debian/README.Debian as well (and should possibly treat the other dependencies consistently). It might be better to just explain the way we do this to the requestor of this change instead. There were a couple patches (go.pl-multiple-networks.diff and away.pl.diff) which used to have links to bug reports instead of proper headers, and you've replaced those with DEP5 patch headers (which is great, thanks!), but I think it could be useful to still have the old bug references included within the new DEP5 information. [1]: http://mentors.debian.net/debian/pool/main/i/irssi-scripts/ irssi-scripts_20120326.dsc Thank you very much!! No, thank you! I will be able to sponsor this upload once we address the above mentioned items and I do a final review, but first I also want to hear back about if and how you want to make use of the git repository for collaboration. Cheers, Ryan -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAk+P1XwACgkQMihv+PacasXwggCeOmqsvrr2lfcGsBM1VPA2LFxg hjEAn1oLlpICofxeicOIMAndpUxkVwok =MyTD -END PGP SIGNATURE- Hi, I have fixed all the points you mentioned, and I updated the git repository on Alioth,Could you please check out again the package[1]? Thank You very much!! [1]: http://anonscm.debian.org/gitweb/?p=collab-maint/irssi-scripts.git;a=summary -- Epsilon http://wiki.debian.org/DanielEcheverry http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#663577: irssi-scripts-20120326 new release
Hi Daniel, Thanks for your work on this, and I apologize for the delay in response. On Fri, Apr 13, 2012 at 02:39:10PM -0500, Daniel Echeverry wrote: Hi, This week I've been working on packaging a new version of irssi-scripts. I closed some bugs and updated some of the scripts. I uploaded the package to debian mentors. [1] Additionally, I added a copyright.new in debian/, This file is copyright copyright DEP5 Update to 1.0 format. Could you check out the new version and the new copyright file? I've reviewed your packaging work now and overall it looks really good. Though I do wonder, have you used a git repository to track your changes? If not, we currently use a repository located here: http://anonscm.debian.org/gitweb/?p=collab-maint/irssi-scripts.git This would be preferable because it helps to make collaborating and reviewing changes easier (this would also replace the need to build and upload the source package to mentors). I think it should be okay for us to allow you to push changes to the repository there, if you want...are you a member of collab-maint on alioth? Anyways, the only major issue I've noticed is that this detail got removed from debian/rules, but the executable permission is relied on by the script: # log2ansi.pl will run outside irssi, so it needs the executable bit chmod +x $D/usr/share/irssi/scripts/log2ansi.pl So, we need to set the executable permission on this file during build. Some other more minor things I noticed are: The debian/copyright.new file looks very good, however I think the GPL-2.0 license definition should replace the text about receiving a copy of the license with a reference to /usr/share/common-licenses, as you have done with the GPL-2.0+ block. Also, the License:GPL-2.0+ is missing a space after the colon. I think it should be fine to replace debian/copyright with your debian/copyright.new once these small improvements are made. With regards to dependencies on perl and perl-modules, this is really not necessary since the base perl, which is all that is required for most scripts, is always installed. In debian/README.Debian there is an explanation of how the dependencies are chosen (at least 3 scripts = Suggests, at least 20 scripts = Recommends), and it looks like there are actually more scripts which depend on libwww-perl than perl or perl-modules, from the list in debian/README.Debian. I'm not opposed to changing how this is done if there is value added in doing so, but if we make that choice we will need to update debian/README.Debian as well (and should possibly treat the other dependencies consistently). It might be better to just explain the way we do this to the requestor of this change instead. There were a couple patches (go.pl-multiple-networks.diff and away.pl.diff) which used to have links to bug reports instead of proper headers, and you've replaced those with DEP5 patch headers (which is great, thanks!), but I think it could be useful to still have the old bug references included within the new DEP5 information. [1]: http://mentors.debian.net/debian/pool/main/i/irssi-scripts/ irssi-scripts_20120326.dsc Thank you very much!! No, thank you! I will be able to sponsor this upload once we address the above mentioned items and I do a final review, but first I also want to hear back about if and how you want to make use of the git repository for collaboration. Cheers, Ryan signature.asc Description: Digital signature
Bug#663577: irssi-scripts-20120326 new release
On Thu, Apr 19, 2012 at 02:06:04AM -0700, Ryan Niebur wrote: There were a couple patches (go.pl-multiple-networks.diff and away.pl.diff) which used to have links to bug reports instead of proper headers, and you've replaced those with DEP5 patch headers (which is great, thanks!), but I think it could be useful to still have the old bug references included within the new DEP5 information. And of course, I meant DEP3 here.. -- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#663577: irssi-scripts-20120326 new release
Hi, This week I've been working on packaging a new version of irssi-scripts. I closed some bugs and updated some of the scripts. I uploaded the package to debian mentors. [1] Additionally, I added a copyright.new in debian/, This file is copyright copyright DEP5 Update to 1.0 format. Could you check out the new version and the new copyright file? [1]: http://mentors.debian.net/debian/pool/main/i/irssi-scripts/irssi-scripts_20120326.dsc Thank you very much!! -- Epsilon http://wiki.debian.org/DanielEcheverry http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user
