Bug#664903: Please enable hardened build flags

2012-04-10 Thread Marc Dequènes (Duck)

tag 664903 + pending
thanks


Coin,

Quoting Carlos Alberto Lopez Perez clo...@igalia.com:


Patch attached


Sorry, but this patch is not suitable:
  - missing build-dependency on hardening-includes
  - using hardening-includes is deprecated in favor of  
dpkg-buildflags only (via /usr/share/dpkg/buildflags.mk) +  
DEB_BUILD_MAINT_OPTIONS (as stated in your linked documentation btw ;-)


Nevertheless, thanks for pushing me into this. I'm gonna upload  
something soon (and ratbox-ircd should follow soon).


Regards.

--
Marc Dequènes (Duck)


pgpaGraynpZVX.pgp
Description: PGP Digital Signature


Bug#664903: Please enable hardened build flags

2012-03-21 Thread Carlos Alberto Lopez Perez
Package: ircd-ratbox
Version: 3.0.7.dfsg-1
Tags: patch, security


Please enable hardened build flags through dpkg-buildflags.

http://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
http://wiki.debian.org/Hardening#Using_Hardening_Options


Patch attached


-- 
~~~
Carlos Alberto Lopez Perez   http://neutrino.es
Igalia - Free Software Engineeringhttp://www.igalia.com
~~~

--- a/ircd-ratbox-3.0.7.dfsg/debian/rules	2011-11-08 00:02:46.0 +0100
+++ b/ircd-ratbox-3.0.7.dfsg/debian/rules	2012-03-21 20:48:11.373352108 +0100
@@ -2,6 +2,12 @@
 
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/class/autotools.mk
+include /usr/share/hardening-includes/hardening.make
+
+CFLAGS=$(shell dpkg-buildflags --get CFLAGS)
+LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS)
+CFLAGS+=$(HARDENING_CFLAGS)
+LDFLAGS+=$(HARDENING_LDFLAGS)
 
 DEB_CONFIGURE_EXTRA_FLAGS := --enable-ipv6 --enable-services \
 	--prefix=/usr \


signature.asc
Description: OpenPGP digital signature