Bug#665448: [Monotone-debian] Bug#665448: monotone: FTBFS: testsuite failure

2012-03-25 Thread Thomas Moschny 
Hi,

this is a mini-patch I recently added to the Fedora package, to build
against newer PCRE. It deletes '(?=\C)' from the list of regular
expressions in .mtn-ignore expected to throw an error.

The man page of PCRE states that \C is not allowed in lookbehind
assertions, iff in UTF8 mode. I did not yet verify whether we are
actually processing the ignore file patterns in UTF8 mode or not.
Anyway, removing that pattern fixed the build for now.

Regards,
Thomas
diff -up monotone-1.0/test/func/syntax_errors_in_.mtn-ignore/mtn-ignore.orig monotone-1.0/test/func/syntax_errors_in_.mtn-ignore/mtn-ignore
--- monotone-1.0/test/func/syntax_errors_in_.mtn-ignore/mtn-ignore.orig	2011-03-26 07:41:05.0 +0100
+++ monotone-1.0/test/func/syntax_errors_in_.mtn-ignore/mtn-ignore	2012-02-15 19:40:06.282866594 +0100
@@ -21,7 +21,6 @@ abc\3
 [[:fnord:]]
 \\x{123456}
 (?(0))
-(?=\C)
 \l
 (?C256)
 (?C1

Bug#665448: monotone: FTBFS: testsuite failure

2012-03-25 Thread Francis Russell 
On 24/03/12 18:28, Ludovic Brenta wrote:

 Please find the time to investigate and correct this problem.  I suspect
 something to do with libpcre3.  I'll sponsor an upload as soon as you
 can fix the problem.  If you need help, scream.
 

I've pushed a fixed version, see the patch for details. The problematic
regex still appears to be present in the latest upstream version so I'll
also send a message to monotone-devel.

Francis



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#665448: [Monotone-debian] Bug#665448: Bug#665448: monotone: FTBFS: testsuite failure

2012-03-25 Thread Francis Russell 
On 25/03/12 20:40, Thomas Moschny wrote:
 Hi,
 
 this is a mini-patch I recently added to the Fedora package, to build
 against newer PCRE. It deletes '(?=\C)' from the list of regular
 expressions in .mtn-ignore expected to throw an error.

I wish you'd sent that a few hours earlier :)

 The man page of PCRE states that \C is not allowed in lookbehind
 assertions, iff in UTF8 mode. I did not yet verify whether we are
 actually processing the ignore file patterns in UTF8 mode or not.
 Anyway, removing that pattern fixed the build for now.

It looks like the test is dependent on pcre3 recognising that regex as
invalid as it'll match all the file names otherwise, which is not the
intended behaviour. Removing it is probably the proper thing to do anyway.

Francis



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#665448: monotone: FTBFS: testsuite failure

2012-03-24 Thread Ludovic Brenta 
Richard and Francis,

Please find the time to investigate and correct this problem.  I suspect
something to do with libpcre3.  I'll sponsor an upload as soon as you
can fix the problem.  If you need help, scream.

-- 
Ludovic Brenta.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org