Package: geeqie
Version: 1:1.0-10
Severity: normal
Tags: patch

Dear Maintainer,
For some reason lossless rotation commands in geeqie
(/usr/share/geeqie/applications/rotate* and
/usr/lib/geeqie/geeqie-rotate)
call exiftran with -p option (Preserve timestamps (atime + mtime) when
doing inplace editing).

Keeping timestamps is probably a good idea, but it prevents geeqie from
regenerating thumbnail for an image (looks like the geeqie only checks
image mtime when deciding if thumbnail is up-to-date).

So, rotating image with geeqie leaves you with properly fotated image
and out-of-date, unrotated thumbnail.

Solution is straightforward: remove -p option from exiftran calls.

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.0.0-1-686-pae (SMP w/4 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages geeqie depends on:
ii  geeqie-common       1:1.0-10
ii  libc6               2.13-27
ii  libexiv2-9          0.20-2.1
ii  libgcc1             1:4.7.0-1
ii  libgdk-pixbuf2.0-0  2.24.1-1
ii  libglib2.0-0        2.32.0-4
ii  libgtk2.0-0         2.24.10-1
ii  liblcms1            1.19.dfsg-1+b1
ii  liblircclient0      0.9.0~pre1-1
ii  libpango1.0-0       1.29.4-3+b1
ii  libstdc++6          4.7.0-1

Versions of packages geeqie recommends:
pn  exiftran         2.07-10
pn  exiv2            <none>
pn  imagemagick      8:6.7.4.0-4
pn  librsvg2-common  2.36.0-5
pn  ufraw-batch      <none>
pn  zenity           <none>

Versions of packages geeqie suggests:
pn  geeqie-dbg     <none>
pn  gimp           2.6.12-1+b2
pn  libjpeg-progs  8d-1
pn  ufraw          <none>
pn  xpaint         <none>

-- debconf-show failed
diff --git a/debian/plugins/rotate-270.desktop b/debian/plugins/rotate-270.desktop
index 8484344..9309271 100644
--- a/debian/plugins/rotate-270.desktop
+++ b/debian/plugins/rotate-270.desktop
@@ -5,7 +5,7 @@ Name=Losslessly rotate JPEG image counterclockwise
 
 # call the helper script
 TryExec=exiftran
-Exec=exiftran -p -2 -i -g %f
+Exec=exiftran -2 -i -g %f
 
 # Desktop files that are usable only in Geeqie should be marked like this:
 Categories=X-Geeqie;
diff --git a/debian/plugins/rotate-90.desktop b/debian/plugins/rotate-90.desktop
index ec61fbc..085c665 100644
--- a/debian/plugins/rotate-90.desktop
+++ b/debian/plugins/rotate-90.desktop
@@ -5,7 +5,7 @@ Name=Losslessly rotate JPEG image clockwise
 
 # call the helper script
 TryExec=exiftran
-Exec=exiftran -p -9 -i -g %f
+Exec=exiftran -9 -i -g %f
 
 # Desktop files that are usable only in Geeqie should be marked like this:
 Categories=X-Geeqie;
diff --git a/plugins/rotate/geeqie-rotate b/plugins/rotate/geeqie-rotate
index 1c1184e..9fbd31f 100755
--- a/plugins/rotate/geeqie-rotate
+++ b/plugins/rotate/geeqie-rotate
@@ -20,7 +20,7 @@ rotate()
     case "$ext" in
 	jpg|jpeg) 
 		[ -n "$gq_orientation" ] && exiv2 -M "set Exif.Image.Orientation $gq_orientation" "$1"
-		if exiftran -aip "$1" ; then
+		if exiftran -ai "$1" ; then
 		    # exiftran ignores xmp, set it manually
 		    exiv2 -M "set Xmp.tiff.Orientation 1" "$1"
 		    #http://dev.exiv2.org/issues/show/639

Reply via email to