Bug#671730: /etc/lsb-base is there. Do mv /etc/lsb-base-logging.sh /etc/lsb-base/logging.sh
Package: lsb-base
Version: 4.1+Debian2
Severity: wishlist
Tags: patch
File: /lib/lsb/init-functions
I think it is more obvious, and less cluttering /etc:
--- a/init-functions2012-04-24 22:23:11.0 +0300
+++ b/init-functions2012-05-06 15:51:43.0 +0300
@@ -395,7 +395,7 @@ log_action_end_msg () {
log_action_end_msg_post $@
}
-# Hooks for /etc/lsb-base-logging.sh
+# Hooks for /etc/lsb-base/logging.sh
log_daemon_msg_pre () {
if log_use_fancy_output; then
/bin/echo -n []
@@ -446,4 +446,4 @@ log_action_end_msg_pre () {
log_action_end_msg_post () { :; }
FANCYTTY=
-[ -e /etc/lsb-base-logging.sh ] . /etc/lsb-base-logging.sh || true
+[ -e /etc/lsb-base/logging.sh ] . /etc/lsb-base/logging.sh || true
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671730: /etc/lsb-base is there. Do mv /etc/lsb-base-logging.sh /etc/lsb-base/logging.sh
On 05/06/2012 09:17 AM, Regid Ichira wrote: I think it is more obvious, and less cluttering /etc: I'm not sure how replacing a file with a directory creates less clutter in /etc. It would be different if there were multiple lsb-base-* files we could move in there. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671730: /etc/lsb-base is there. Do mv /etc/lsb-base-logging.sh /etc/lsb-base/logging.sh
In my opinion, it is a matter of putting the file where it belongs. So one wouldn't have to consider lsb twice when looking for something else in /etc. And, in my case, the directory is empty. --- On Sun, 5/6/12, Jeff Licquia licq...@debian.org wrote: From: Jeff Licquia licq...@debian.org Subject: Re: Bug#671730: /etc/lsb-base is there. Do mv /etc/lsb-base-logging.sh /etc/lsb-base/logging.sh To: Regid Ichira regi...@yahoo.com, 671...@bugs.debian.org Date: Sunday, May 6, 2012, 2:39 PM On 05/06/2012 09:17 AM, Regid Ichira wrote: I think it is more obvious, and less cluttering /etc: I'm not sure how replacing a file with a directory creates less clutter in /etc. It would be different if there were multiple lsb-base-* files we could move in there. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671730: /etc/lsb-base is there. Do mv /etc/lsb-base-logging.sh /etc/lsb-base/logging.sh
retitle 671730 /etc/lsb-base is unused; consider removing it severity 671730 minor tags 671730 - patch thanks On 05/06/2012 11:06 AM, Regid Ichira wrote: And, in my case, the directory is empty. There's the problem; we create the directory, but don't use it. Since /etc/lsb-base-logging.sh has been a well-known path since at least 2005, there should be a clear and compelling reason to move it and incur all the hassle of checking for old versions, moving them, etc. I've looked through the package, and can't find any place where the directory is used for anything. So I'd vote that we just drop the directory. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671730: /etc/lsb-base is there. Do mv /etc/lsb-base-logging.sh /etc/lsb-base/logging.sh
Le dimanche, 6 mai 2012 18.31:40, vous avez écrit : I've looked through the package, and can't find any place where the directory is used for anything. So I'd vote that we just drop the directory. Agreed, I'll make sure it is dropped from the next upload. Cheers, OdyX -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671730: /etc/lsb-base is there. Do mv /etc/lsb-base-logging.sh /etc/lsb-base/logging.sh
On 06/05/12 23:14, Didier Raboud wrote: Le dimanche, 6 mai 2012 18.31:40, vous avez écrit : I've looked through the package, and can't find any place where the directory is used for anything. So I'd vote that we just drop the directory. Agreed, I'll make sure it is dropped from the next upload. Cheers, OdyX Hi. Please excuse my tresspassing into this discussion, but wouldn't putting lsb-base configuration vars in a file in the /etc/default directory (something like /etc/default/lsb-base) be more in accordance with the Debian Policy and FHM recommendations? This would mean dropping /etc/lsb-base-logging.sh and altering the /lib/lsb/init-functions to account for this change. Regards, -- Fita Adrian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671730: /etc/lsb-base is there. Do mv /etc/lsb-base-logging.sh /etc/lsb-base/logging.sh
On 05/06/2012 05:23 PM, Adrian Fita wrote: Hi. Please excuse my tresspassing into this discussion, but wouldn't putting lsb-base configuration vars in a file in the /etc/default directory (something like /etc/default/lsb-base) be more in accordance with the Debian Policy and FHM recommendations? This would mean dropping /etc/lsb-base-logging.sh and altering the /lib/lsb/init-functions to account for this change. This justification works better for creating new files than for moving existing files, as I mentioned earlier. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
