Bug#671979: (no subject)
tags 671979 + patch thanks Hello, I've prepared small patch to fix this one. Just add pkg-config to Build-Depends. If you (maintainer) don't have a time to upload this one, I'm going to go on with NMU. -- Pozdrawiam / Kind regards, Artur Rona diff -Nru qtads-2.1.1/debian/changelog qtads-2.1.1/debian/changelog --- qtads-2.1.1/debian/changelog2011-04-02 22:28:05.0 +0200 +++ qtads-2.1.1/debian/changelog2012-06-07 13:39:59.0 +0200 @@ -1,3 +1,11 @@ +qtads (2.1.1-1.1) unstable; urgency=low + + * Non-maintainer upload. + * debian/control: +- Fix FTBFS, add pkg-config to Build-Depends. (Closes: #671979) + + -- Artur Rona ari-tc...@tlen.pl Thu, 07 Jun 2012 13:37:14 +0200 + qtads (2.1.1-1) unstable; urgency=low * New upstream release. diff -Nru qtads-2.1.1/debian/control qtads-2.1.1/debian/control --- qtads-2.1.1/debian/control 2011-04-02 22:29:28.0 +0200 +++ qtads-2.1.1/debian/control 2012-06-07 13:37:10.0 +0200 @@ -2,7 +2,7 @@ Section: games Priority: optional Maintainer: Daniel Schepler schep...@debian.org -Build-Depends: debhelper (= 6), libqt4-dev (= 4:4.5), libsdl-mixer1.2-dev, libsdl-sound1.2-dev, cdbs (= 0.4.50) +Build-Depends: debhelper (= 6), libqt4-dev (= 4:4.5), libsdl-mixer1.2-dev, libsdl-sound1.2-dev, cdbs (= 0.4.50), pkg-config Standards-Version: 3.9.1 Package: qtads
Bug#671979: (no subject)
On Thu, Jun 7, 2012 at 4:49 AM, Artur Rona ari-tc...@tlen.pl wrote: tags 671979 + patch thanks Hello, I've prepared small patch to fix this one. Just add pkg-config to Build-Depends. If you (maintainer) don't have a time to upload this one, I'm going to go on with NMU. Sorry I haven't gotten around to looking into it in more detail -- but from the build log I saw, it looks like it's qt4-qmake that should have a Depends on pkg-config. Unless qmake can run on some .pro files without pkg-config present, and qtads.pro calls pkg-config itself... I'll try to find some time this coming weekend to update qtads and frobtads to newer upstream versions. -- Daniel Schepler -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671979: (no subject)
On 07/06/12 17:27, Daniel Schepler wrote: On Thu, Jun 7, 2012 at 4:49 AM, Artur Ronaari-tc...@tlen.pl wrote: tags 671979 + patch thanks Hello, I've prepared small patch to fix this one. Just add pkg-config to Build-Depends. If you (maintainer) don't have a time to upload this one, I'm going to go on with NMU. Sorry I haven't gotten around to looking into it in more detail -- but from the build log I saw, it looks like it's qt4-qmake that should have a Depends on pkg-config. Unless qmake can run on some .pro files without pkg-config present, and qtads.pro calls pkg-config itself... qtads.pro uses qmake's support for pkg-config and never calls it directly. pkg-config support is shipped with Qt in mkspecs/features/link_pkgconfig.prf. It assumes pkg-config is present on the system. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671979: (no subject)
W dniu 2012-06-07 22:02, Nikos Chantziaras pisze: qtads.pro uses qmake's support for pkg-config and never calls it directly. pkg-config support is shipped with Qt in mkspecs/features/link_pkgconfig.prf. It assumes pkg-config is present on the system. Maybe in theory. In practise, pbuilder gives FTBFS in result. BTW, can you please upgrade qtads to 2.1.3? -- Pozdrawiam / Kind regards, Artur Rona -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671979: (no subject)
On 08/06/12 00:04, Artur Rona wrote: W dniu 2012-06-07 22:02, Nikos Chantziaras pisze: qtads.pro uses qmake's support for pkg-config and never calls it directly. pkg-config support is shipped with Qt in mkspecs/features/link_pkgconfig.prf. It assumes pkg-config is present on the system. Maybe in theory. In practise, pbuilder gives FTBFS in result. If qmake in Debian doesn't depend on pkg-config, then that's to be expected. qmake is a build system that uses pkg-config. Most Qt applications don't make use of that functionality though. BTW, can you please upgrade qtads to 2.1.3? I'm not the Debian maintainer. I'm qtads upstream, chipping-in to point out that qmake should most probably depend on pkg-config :-) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671979: (no subject)
On Thu, Jun 7, 2012 at 3:42 PM, Nikos Chantziaras rea...@hotmail.com wrote: If qmake in Debian doesn't depend on pkg-config, then that's to be expected. qmake is a build system that uses pkg-config. Most Qt applications don't make use of that functionality though. I'm not the Debian maintainer. I'm qtads upstream, chipping-in to point out that qmake should most probably depend on pkg-config :-) If qmake can function without pkg-config, that makes the dependency at most a Recommends. And if most Qt applications don't use the pkg-config functionality, then a Suggests seems most appropriate. (Cc to qt4-qmake package maintainers to get input on this point.) In either case, the original bug report would be correct that qtads should be Build-Depending on pkg-config. -- Daniel Schepler -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#671979: (no subject)
On Jue 07 Jun 2012 23:26:55 Daniel Schepler escribió: On Thu, Jun 7, 2012 at 3:42 PM, Nikos Chantziaras rea...@hotmail.com wrote: If qmake in Debian doesn't depend on pkg-config, then that's to be expected. qmake is a build system that uses pkg-config. Most Qt applications don't make use of that functionality though. I'm not the Debian maintainer. I'm qtads upstream, chipping-in to point out that qmake should most probably depend on pkg-config :-) If qmake can function without pkg-config, that makes the dependency at most a Recommends. And if most Qt applications don't use the pkg-config functionality, then a Suggests seems most appropriate. (Cc to qt4-qmake package maintainers to get input on this point.) In either case, the original bug report would be correct that qtads should be Build-Depending on pkg-config. Most Qt applications do not need to use pkg-config. If an app needs an external library which ships a .pc file (libusb, for example), then the programmer needs to call pkg-config from within the .pro. So, it's the app that requires pkg-config and not qmake. For what I understand of the bug report, this is the case. Although part of Debian's Qt-KDE team, I don't usually hack in Qt itself (at least in it's packaging), but I think the team will agree that pkg-config should not be even a Suggest. If they don't... well, someone may change that ;-) Kinds regards, Lisandro. -- Theory and practice sometimes clash. And when that happens, theory loses. Every single time. Linus Benedict Torvalds. Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ signature.asc Description: This is a digitally signed message part.
Bug#671979: (no subject)
On Thursday, June 07, 2012 08:15:41 PM Lisandro Damián Nicanor Pérez Meyer wrote: Most Qt applications do not need to use pkg-config. If an app needs an external library which ships a .pc file (libusb, for example), then the programmer needs to call pkg-config from within the .pro. So, it's the app that requires pkg-config and not qmake. For what I understand of the bug report, this is the case. Although part of Debian's Qt-KDE team, I don't usually hack in Qt itself (at least in it's packaging), but I think the team will agree that pkg-config should not be even a Suggest. If they don't... well, someone may change that ;-) Looking at qtads.pro, it contains: CONFIG += link_pkgconfig PKGCONFIG += sdl So it looks like there's an optional qmake feature to ease using pkg-config. -- Daniel Schepler -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
