Bug#672561: Re: Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h
Hi, Balint. On May 20 2014, Balint Reczey wrote: On 05/12/2012 08:46 AM, Reinhard Tartler wrote: That's excellent news! Thanks for working on it and count me in as supporter (i.e., put me to Uploaders). Handbrake is now in Debian and uses libavresample. How about closing this bug? The missing header stopped being an issue, I think. Yes, it stopped. I'm closing it. I don't know how things will impact getting handbrake being compiled with ffmpeg, but I guess that we can always file a new bug when that time comes. BTW, thanks for getting a version of handbrake in Debian that doesn't need to be totally mutilated. I was waiting for a new release before getting my hands on it, but now the packaging and updating is trivial for future versions of handbrake. Thanks, -- Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h
Hi Rogério, On 21.05.2014 22:19, Rogério Brito wrote: I don't know how things will impact getting handbrake being compiled with ffmpeg, but I guess that we can always file a new bug when that time comes. Handbrake compiles fine with FFmpeg, but to get it to compile with the Debian FFmpeg packages, one has to teach it to use pkg-config to determine the FFmpeg linker flags. This is due to the fact that the Debian FFmpeg packages use library names like libavcodec-ffmpeg and thus linking with '-lavcodec' fails. The attached handbrake_pkg-config.patch does that. With it applied you can simply add alternative build-dependencies to the FFmpeg development packages instead of the Libav ones, as the other patch does. Then handbrake compiles fine with the Debian FFmpeg packages, if they are installed instead of the Libav ones. Best regards, Andreas PS: Thanks again for filing the FFmpeg RFP bug. diff --git a/debian/patches/pkg-config.patch b/debian/patches/pkg-config.patch new file mode 100644 index 000..4ec87ee --- /dev/null +++ b/debian/patches/pkg-config.patch @@ -0,0 +1,36 @@ +Description: Use pkg-config to check for FFMPEG + +Author: Andreas Cadhalpun andreas.cadhal...@googlemail.com +Last-Update: 2014-05-21 + +--- handbrake-0.9.9+svn6032+dfsg1.orig/gtk/configure.ac handbrake-0.9.9+svn6032+dfsg1/gtk/configure.ac +@@ -183,7 +183,9 @@ case $host in + ;; + esac + +-HB_LIBS=-lhandbrake -la52 -lavresample -lavformat -lavcodec -lavutil -ldvdnav -ldvdread -lmp3lame -lvorbis -lvorbisenc -logg -lsamplerate -lx264 -lswscale -ltheoraenc -ltheoradec -lz -lbz2 -lpthread -lbluray -lass -lfontconfig -lfreetype -lxml2 -ldl ++PKG_CHECK_MODULES([FFMPEG], [libavresample libavformat libavcodec libavutil libswscale]) ++ ++HB_LIBS=-lhandbrake -la52 $FFMPEG_LIBS -ldvdnav -ldvdread -lmp3lame -lvorbis -lvorbisenc -logg -lsamplerate -lx264 -ltheoraenc -ltheoradec -lz -lbz2 -lpthread -lbluray -lass -lfontconfig -lfreetype -lxml2 -ldl + + if test x$use_fdk_aac = xyes ; then + HB_LIBS+= -lfdk-aac +--- handbrake-0.9.9+svn6032+dfsg1.orig/test/module.defs handbrake-0.9.9+svn6032+dfsg1/test/module.defs +@@ -11,10 +11,13 @@ TEST.exe = $(BUILD/)$(call TARGET.exe,$( + + TEST.libs = $(LIBHB.a) + ++FFMPEG_LIBS = $(shell $(PKGCONFIG.exe) --libs libavcodec libavformat libavutil libavresample libswscale) ++FFMPEG_NAMES = $(subst -l,,$(FFMPEG_LIBS)) ++ + TEST.GCC.l = \ +-a52 ass avcodec avformat avutil avresample dvdnav dvdread \ ++a52 ass $(FFMPEG_NAMES) dvdnav dvdread \ + fontconfig mp3lame ogg \ +-samplerate swscale theoraenc theoradec vorbis vorbisenc x264 \ ++samplerate theoraenc theoradec vorbis vorbisenc x264 \ + bluray freetype xml2 bz2 z + + ifeq (1,$(FEATURE.qsv)) diff --git a/debian/patches/series b/debian/patches/series index b887273..4e453ae 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,3 +1,4 @@ 001-Do-not-require-wget-or-curl.patch 002-Remove-embedded-downloaded-copies-of-various-librari.patch 004-link-fix-add-ldl.patch +pkg-config.patch diff --git a/debian/control b/debian/control index 0e34047..2f7da07 100644 --- a/debian/control +++ b/debian/control @@ -16,10 +16,10 @@ Build-Depends: intltool, liba52-0.7.4-dev (= 0.7.4-17), libass-dev, - libavcodec-dev (= 6:10~), - libavformat-dev (= 6:10~), - libavresample-dev (= 6:10~), - libavutil-dev (= 6:10~), + libavcodec-dev (= 6:10~) | libavcodec-ffmpeg-dev, + libavformat-dev (= 6:10~) | libavformat-ffmpeg-dev, + libavresample-dev (= 6:10~) | libavresample-ffmpeg-dev, + libavutil-dev (= 6:10~) | libavutil-ffmpeg-dev, libbluray-dev, libbz2-dev, libdbus-glib-1-dev, @@ -38,7 +38,7 @@ Build-Depends: libnotify-dev (= 0.7.3), libogg-dev, libsamplerate0-dev, - libswscale-dev, + libswscale-dev | libswscale-ffmpeg-dev, libtheora-dev, libtool, libvorbis-dev,
Bug#672561: Re: Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h
Hi Rogério, On 05/12/2012 08:46 AM, Reinhard Tartler wrote: bug 672561 wishlist tags 672561 wontfix stop On Sat, May 12, 2012 at 7:39 AM, Rogério Brito rbr...@ime.usp.br wrote: Package: libavcodec-dev Severity: important Hi. The libavcodec-dev package is missing /usr/include/libavcodec/audioconvert.h. This file is needed by handbrake. If I clone the libav git tree, checkout the v0.8.2 tag and copy that file to /usr/include/avcodec, then I am able to successfully compile handbrake with Debian's libav, without needing to download things from outside. The problem with that is that audioconvert.h is not part of the public API. Moreover, most of the APIs have already been removed in current libav/master in favor of the newly introduced libavresample library. Therefore, I do not think it would be a good idea to start shipping this header. The proper long-term solution is to port handbrake to 'libavresample' (not yet uploaded to experimental, the packaging needs review, and is not going to be included in wheezy). As short-term workaround, I'd suggest to copy the parts of audioconvert.h and audioconvert.c to the handbrake packaging. BTW, regarding handbrake, I am down to few packages now that need to be taken from outside debian for it to compile, namely: * MODULES += contrib/libdvdread * MODULES += contrib/libdvdnav * MODULES += contrib/mpeg2dec Everything else works with packages in Debian *or* with packages in the pkg-multimedia git repositories (e.g., libmkv, faac, libmp4v2). That's excellent news! Thanks for working on it and count me in as supporter (i.e., put me to Uploaders). Handbrake is now in Debian and uses libavresample. How about closing this bug? The missing header stopped being an issue, I think. Cheers, Balint -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#456165: ITP: handbrake -- Rips and encodes DVDs (was Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h)
Am Samstag, den 12.05.2012, 11:40 -0400 schrieb Andres Mejia: I just noticed that libmkv was written specifically for handbrake. In this case, I wouldn't even bother uploading libmkv separately and just use whatever libmkv ships with handbrake. Really? I didn't know. I just read somewhere that it was forked off of the MKV muxing code of the x264 frontend. I'd consider the libmkv package ready for upload, BTW, but you already guessed that yourself. ;) - Fabian -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h
On Sat, May 12, 2012 at 1:39 AM, Rogério Brito rbr...@ime.usp.br wrote: Package: libavcodec-dev Severity: important Hi. The libavcodec-dev package is missing /usr/include/libavcodec/audioconvert.h. Audioconvert is not a public header in either libav or ffmpeg. What is suppose to be used for this functionality is libavresample or libswresample. This file is needed by handbrake. If I clone the libav git tree, checkout the v0.8.2 tag and copy that file to /usr/include/avcodec, then I am able to successfully compile handbrake with Debian's libav, without needing to download things from outside. BTW, regarding handbrake, I am down to few packages now that need to be taken from outside debian for it to compile, namely: * MODULES += contrib/libdvdread * MODULES += contrib/libdvdnav * MODULES += contrib/mpeg2dec Does handbrake used patched versions of these libs or can it use these libs as released upstream? Everything else works with packages in Debian *or* with packages in the pkg-multimedia git repositories (e.g., libmkv, faac, libmp4v2). Ping Fabian. Was libmkv ready for upload? Could vo-aacenc be used instead of faac? Also, as I mentioned in another email, libmp4v2 should be replaced with libav. mp4v2 is seeing less and less development and it's probably better to look into replacing use of mp4v2 anyway. Regards, -- Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC http://rb.doesntexist.org/blog : Projects : https://github.com/rbrito/ DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintain...@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers Also next time, please leave out things unrelated to a bug in it's bug report. -- ~ Andres -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h
Hi there. On Sat, May 12, 2012 at 3:07 AM, Andres Mejia amejia...@gmail.com wrote: On Sat, May 12, 2012 at 1:39 AM, Rogério Brito rbr...@ime.usp.br wrote: Package: libavcodec-dev Severity: important Hi. The libavcodec-dev package is missing /usr/include/libavcodec/audioconvert.h. Audioconvert is not a public header in either libav or ffmpeg. What is suppose to be used for this functionality is libavresample or libswresample. I'm just getting it to compile, at first, and they use that. They probably need a cluebat, then, if that is not a public interface. The problem here is that they use AVAudioConvert, which is present only in that header. I'm not exactly sure if I want to patch this so heavily as to fix the use of that interface. This file is needed by handbrake. If I clone the libav git tree, checkout the v0.8.2 tag and copy that file to /usr/include/avcodec, then I am able to successfully compile handbrake with Debian's libav, without needing to download things from outside. BTW, regarding handbrake, I am down to few packages now that need to be taken from outside debian for it to compile, namely: * MODULES += contrib/libdvdread * MODULES += contrib/libdvdnav * MODULES += contrib/mpeg2dec Does handbrake used patched versions of these libs or can it use these libs as released upstream? I have yet to see which patches can be dropped and which don't. OTOH, the basics compile and a brief test here works. :) Everything else works with packages in Debian *or* with packages in the pkg-multimedia git repositories (e.g., libmkv, faac, libmp4v2). Ping Fabian. Was libmkv ready for upload? I think it is fine as is. Not sure if the legal stuff (debian/copyright etc.) is all in place for an upload to unstable. Could vo-aacenc be used instead of faac? I still have to study that to see what can be done and how similar the interfaces are. Also, as I mentioned in another email, libmp4v2 should be replaced with libav. mp4v2 is seeing less and less development and it's probably better to look into replacing use of mp4v2 anyway. That's the same story as with vo-aacenc/faac. Also next time, please leave out things unrelated to a bug in it's bug report. OK, but the excitement is really huge and I couldn't help sending some side comments. :) Feel free to reply to the bug only the parts pertaining to the bug and to the mailing list the other parts (please, keep me CCed). Thanks. P.S.: Now, it compiles with Debian's mpeg2, which is one fewer embedded library. -- Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC http://rb.doesntexist.org/blog : Projects : https://github.com/rbrito/ DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h
On May 12, 2012 2:22 AM, Rogério Brito rbr...@ime.usp.br wrote: Hi there. On Sat, May 12, 2012 at 3:07 AM, Andres Mejia amejia...@gmail.com wrote: On Sat, May 12, 2012 at 1:39 AM, Rogério Brito rbr...@ime.usp.br wrote: Package: libavcodec-dev Severity: important Hi. The libavcodec-dev package is missing /usr/include/libavcodec/audioconvert.h. Audioconvert is not a public header in either libav or ffmpeg. What is suppose to be used for this functionality is libavresample or libswresample. I'm just getting it to compile, at first, and they use that. They probably need a cluebat, then, if that is not a public interface. The problem here is that they use AVAudioConvert, which is present only in that header. I'm not exactly sure if I want to patch this so heavily as to fix the use of that interface. This file is needed by handbrake. If I clone the libav git tree, checkout the v0.8.2 tag and copy that file to /usr/include/avcodec, then I am able to successfully compile handbrake with Debian's libav, without needing to download things from outside. BTW, regarding handbrake, I am down to few packages now that need to be taken from outside debian for it to compile, namely: * MODULES += contrib/libdvdread * MODULES += contrib/libdvdnav * MODULES += contrib/mpeg2dec Does handbrake used patched versions of these libs or can it use these libs as released upstream? I have yet to see which patches can be dropped and which don't. OTOH, the basics compile and a brief test here works. :) Everything else works with packages in Debian *or* with packages in the pkg-multimedia git repositories (e.g., libmkv, faac, libmp4v2). Ping Fabian. Was libmkv ready for upload? I think it is fine as is. Not sure if the legal stuff (debian/copyright etc.) is all in place for an upload to unstable. Could vo-aacenc be used instead of faac? I still have to study that to see what can be done and how similar the interfaces are. Also, as I mentioned in another email, libmp4v2 should be replaced with libav. mp4v2 is seeing less and less development and it's probably better to look into replacing use of mp4v2 anyway. That's the same story as with vo-aacenc/faac. Also next time, please leave out things unrelated to a bug in it's bug report. OK, but the excitement is really huge and I couldn't help sending some side comments. :) Feel free to reply to the bug only the parts pertaining to the bug and to the mailing list the other parts (please, keep me CCed). Thanks. P.S.: Now, it compiles with Debian's mpeg2, which is one fewer embedded library. -- Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC http://rb.doesntexist.org/blog : Projects : https://github.com/rbrito/ DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br Keep up the great work. You may also want to create an ITP bug for handbrake now. ~ Andres
Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h
bug 672561 wishlist tags 672561 wontfix stop On Sat, May 12, 2012 at 7:39 AM, Rogério Brito rbr...@ime.usp.br wrote: Package: libavcodec-dev Severity: important Hi. The libavcodec-dev package is missing /usr/include/libavcodec/audioconvert.h. This file is needed by handbrake. If I clone the libav git tree, checkout the v0.8.2 tag and copy that file to /usr/include/avcodec, then I am able to successfully compile handbrake with Debian's libav, without needing to download things from outside. The problem with that is that audioconvert.h is not part of the public API. Moreover, most of the APIs have already been removed in current libav/master in favor of the newly introduced libavresample library. Therefore, I do not think it would be a good idea to start shipping this header. The proper long-term solution is to port handbrake to 'libavresample' (not yet uploaded to experimental, the packaging needs review, and is not going to be included in wheezy). As short-term workaround, I'd suggest to copy the parts of audioconvert.h and audioconvert.c to the handbrake packaging. BTW, regarding handbrake, I am down to few packages now that need to be taken from outside debian for it to compile, namely: * MODULES += contrib/libdvdread * MODULES += contrib/libdvdnav * MODULES += contrib/mpeg2dec Everything else works with packages in Debian *or* with packages in the pkg-multimedia git repositories (e.g., libmkv, faac, libmp4v2). That's excellent news! Thanks for working on it and count me in as supporter (i.e., put me to Uploaders). -- regards, Reinhard -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#456165: ITP: handbrake -- Rips and encodes DVDs (was Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h)
On Sat, May 12, 2012 at 5:07 AM, Rogério Brito rbr...@ime.usp.br wrote: Hi, all. On Sat, May 12, 2012 at 3:46 AM, Reinhard Tartler siret...@gmail.com wrote: The problem with that is that audioconvert.h is not part of the public API. Moreover, most of the APIs have already been removed in current libav/master in favor of the newly introduced libavresample library. Therefore, I do not think it would be a good idea to start shipping this header. OK. The proper long-term solution is to port handbrake to 'libavresample' (not yet uploaded to experimental, the packaging needs review, and is not going to be included in wheezy). As short-term workaround, I'd suggest to copy the parts of audioconvert.h and audioconvert.c to the handbrake packaging. For the quick and dirty solution, I did just that, but the packaging is crufty. As I need to get some sleep right now, it will be great to see the package gain some love from others, even if we can't upload handbrake due to licensing and dependencies in time for wheezy. OTOH, it never hurts to be able to have the package in source form ready for a compilation to be used as we see fit, while the package has not hit the main archive. That's excellent news! Thanks for working on it and count me in as supporter (i.e., put me to Uploaders). Just did that and pushed my current changes to the repo: http://anonscm.debian.org/gitweb/?p=pkg-multimedia/handbrake.git I hope that others will join me in getting it slowly in shape. Regards, -- Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC http://rb.doesntexist.org/blog : Projects : https://github.com/rbrito/ DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintain...@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers I just noticed that libmkv was written specifically for handbrake. In this case, I wouldn't even bother uploading libmkv separately and just use whatever libmkv ships with handbrake. -- ~ Andres -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#456165: ITP: handbrake -- Rips and encodes DVDs (was Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h)
On Sat, May 12, 2012 at 5:40 PM, Andres Mejia amejia...@gmail.com wrote: I just noticed that libmkv was written specifically for handbrake. In this case, I wouldn't even bother uploading libmkv separately and just use whatever libmkv ships with handbrake. TBH, I agree. Fabian, this does not mean that your work on git+ssh://git.debian.org/git/pkg-multimedia/libmkv was in vain. As soon as some other package uses it, we can use your packaging and upload to debian. But until then, we gain little to nothing by shipping it outside of handbrake -- regards, Reinhard -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#456165: ITP: handbrake -- Rips and encodes DVDs (was Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h)
On Sat, May 12, 2012 at 1:36 PM, Reinhard Tartler siret...@gmail.com wrote: On Sat, May 12, 2012 at 5:40 PM, Andres Mejia amejia...@gmail.com wrote: I just noticed that libmkv was written specifically for handbrake. In this case, I wouldn't even bother uploading libmkv separately and just use whatever libmkv ships with handbrake. TBH, I agree. Fabian, this does not mean that your work on git+ssh://git.debian.org/git/pkg-multimedia/libmkv was in vain. As soon as some other package uses it, we can use your packaging and upload to debian. But until then, we gain little to nothing by shipping it outside of handbrake -- regards, Reinhard I was going off by the assumption that handbrake ships with libmkv, but I found it doesn't. It simply downloads libmkv. I think it will be easier to upload libmkv instead. -- ~ Andres -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#672561: libavcodec-dev: Missing /usr/include/libavcodec/audioconvert.h
Package: libavcodec-dev Severity: important Hi. The libavcodec-dev package is missing /usr/include/libavcodec/audioconvert.h. This file is needed by handbrake. If I clone the libav git tree, checkout the v0.8.2 tag and copy that file to /usr/include/avcodec, then I am able to successfully compile handbrake with Debian's libav, without needing to download things from outside. BTW, regarding handbrake, I am down to few packages now that need to be taken from outside debian for it to compile, namely: * MODULES += contrib/libdvdread * MODULES += contrib/libdvdnav * MODULES += contrib/mpeg2dec Everything else works with packages in Debian *or* with packages in the pkg-multimedia git repositories (e.g., libmkv, faac, libmp4v2). Regards, -- Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC http://rb.doesntexist.org/blog : Projects : https://github.com/rbrito/ DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org