Bug#676538: pgadmin3: Linked against dbg libraries.

[George Danchev]

On Monday 11 June 2012 13:17:35 Gerfried Fuchs wrote:
--cut--
> > A possibly annoying detail for the debug package (pgadmin3-dbg)would be
> > that a single build is used for both debug and non-debug variants and
> > build with -O2 (-ggdb -O2) which may lead to unexpected results for the
> > debugging variant [1]. Of course, this could be dealt with by
> > unconditionally building the source package with -O0.
> 
>  I wonder how that is any different to any other -dbg package.  From
> what I understand, -O2 is the default to compile with unless
> DEB_BUILD_OPTIONS does include "noopt".  See debian-policy 4.9.1
> "debian/rules and DEB_BUILD_OPTIONS".

Yeah, I know... I only mentioned that because pgadmin3's --enable-debug uses 
"-g -O0" for building for some reason, thus in some rare cases -O0 vs. -02 
might make a difference for -g (although I don't have any hard data to back up 
such a claim for pgadmin3 sources), while on the vast majority of packages -O2 
combined with -g would be just fine. Thus handling it on per package basis is 
not entirely baseless.

Whatever, I guess that "punishing" the -dbg package with -g -O2 instead of 
"punishing" the non-dbg package with -O0, is an appropriate course of action. 
Users can always fetch the source and rebuild with "noopt" if they want to 
skip -O2 optimizations while debugging.

-- 
pub 4096R/0E4BD0AB 



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#676538: pgadmin3: Linked against dbg libraries.

[Gerfried Fuchs]

* George Danchev  [2012-06-11 12:37:59 CEST]:
> On Monday 11 June 2012 10:51:34 Gerfried Fuchs wrote:
> > * George Danchev  [2012-06-09 12:31:08 CEST]:
> > > dropping libwxgtk2.8-dbg from build-depends and also dropping the
> > > configure option --enable-debug is enough to get pgadmin3 stripped and
> > > not depending on any *dbg packages, as well as providing detached
> > > debugging symbols with pgadmin3-dbg. The simple patch is now attached.
> > 
> >  Actually, no, it isn't.  Have you tried it?  That will bring us back
> > #652099, an empty -dbg package.
> 
> Actually, I haven't tried to load the symbols in gdb, but now I did and I can 
> see that there are none to load from /usr/lib/debug/usr/bin/pgadmin3.
> This is due to -g not being passed if BUILD_DEBUG is not defined, since 
> --enable-debug is not passed. So far so good, the "offending" snippet found 
> in 
> acinclude.m4 and configure is:
> 
> CFLAGS=`echo $CFLAGS | sed -e "s/-g //g"`
> CXXFLAGS=`echo $CXXFLAGS | sed -e "s/-g //g"`

 Yes, that's why I went the (wrong) way of using --enable-debug in the
first place. :)

> A possibly annoying detail for the debug package (pgadmin3-dbg)would be that 
> a 
> single build is used for both debug and non-debug variants and build with -O2 
> (-ggdb -O2) which may lead to unexpected results for the debugging variant 
> [1]. Of course, this could be dealt with by unconditionally building the 
> source package with -O0.

 I wonder how that is any different to any other -dbg package.  From
what I understand, -O2 is the default to compile with unless
DEB_BUILD_OPTIONS does include "noopt".  See debian-policy 4.9.1
"debian/rules and DEB_BUILD_OPTIONS".

 If you want to have that changed it should be done on higher grounds,
not on specific package levels.

* George Danchev  [2012-06-11 12:56:10 CEST]:
> > CFLAGS = -Wall -ggdb
> > CXXFLAGS = -Wall -ggdb
> 
> Actually bypassing their sed by using the default level -g2 would be more 
> appropriate as a match for -g.

 Thanks for that suggestion, I'm giving it a try and in case it works
like expected (which I assume) I'll upload it ASAP.

 Enjoy,
Rhonda
-- 
Fühlst du dich mutlos, fass endlich Mut, los  |
Fühlst du dich hilflos, geh raus und hilf, los| Wir sind Helden
Fühlst du dich machtlos, geh raus und mach, los   | 23.55: Alles auf Anfang
Fühlst du dich haltlos, such Halt und lass los|



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#676538: pgadmin3: Linked against dbg libraries.

[George Danchev]

> CFLAGS = -Wall -ggdb
> CXXFLAGS = -Wall -ggdb

Actually bypassing their sed by using the default level -g2 would be more 
appropriate as a match for -g.

-- 
pub 4096R/0E4BD0AB 



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#676538: pgadmin3: Linked against dbg libraries.

[George Danchev]

On Monday 11 June 2012 10:51:34 Gerfried Fuchs wrote:
> tags 676538 - patch
> thanks
> 
> * George Danchev  [2012-06-09 12:31:08 CEST]:
> > dropping libwxgtk2.8-dbg from build-depends and also dropping the
> > configure option --enable-debug is enough to get pgadmin3 stripped and
> > not depending on any *dbg packages, as well as providing detached
> > debugging symbols with pgadmin3-dbg. The simple patch is now attached.
> 
>  Actually, no, it isn't.  Have you tried it?  That will bring us back
> #652099, an empty -dbg package.

Actually, I haven't tried to load the symbols in gdb, but now I did and I can 
see that there are none to load from /usr/lib/debug/usr/bin/pgadmin3.
This is due to -g not being passed if BUILD_DEBUG is not defined, since 
--enable-debug is not passed. So far so good, the "offending" snippet found in 
acinclude.m4 and configure is:

CFLAGS=`echo $CFLAGS | sed -e "s/-g //g"`
CXXFLAGS=`echo $CXXFLAGS | sed -e "s/-g //g"`

The easiest way to bypass their "stripping of -g" by debian/rules would be to 
change:

CFLAGS = -Wall -g
CXXFLAGS = -Wall -g

to:

CFLAGS = -Wall -ggdb
CXXFLAGS = -Wall -ggdb

Then -ggdb propages and gdb can happily read them:

$ gdb pgadmin3
GNU gdb (GDB) 7.4.1-debian
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
...
Reading symbols from /usr/bin/pgadmin3...Reading symbols from 
/usr/lib/debug/usr/bin/pgadmin3...done.
done.



A possibly annoying detail for the debug package (pgadmin3-dbg)would be that a 
single build is used for both debug and non-debug variants and build with -O2 
(-ggdb -O2) which may lead to unexpected results for the debugging variant 
[1]. Of course, this could be dealt with by unconditionally building the 
source package with -O0.



[1] -02 is not that aggressive, but anyway from gcc man-page:

"GCC allows you to use -g with -O.  The shortcuts taken by optimized code may 
occasionally produce surprising results: some variables you declared may not 
exist at all; flow of control may briefly move where you did not expect it; 
some 
statements may not be executed because they compute constant results or their 
values were already at hand; some statements may execute in different places 
because they were moved out of loops.
"

>  I am willing to reopen #647916 and tag it wontfixed and drop the -dbg
> package if there isn't a solution to this.  Also, this misleading wx-dbg
> package might be the reason for #676626, so that part should get rid of
> anyway.  My fault to believe that the -dbg namespace is all the same.
> 
>  Thanks for the headsup, will get rid of the -dbg package if no other
> solution pops up soon, want 1.14.2 in wheezy.

You're welcome. I want that in wheezy too and I hope you will find the above 
cheat appealing.

-- 
pub 4096R/0E4BD0AB 



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#676538: pgadmin3: Linked against dbg libraries.

[Gerfried Fuchs]

tags 676538 - patch
thanks

* George Danchev  [2012-06-09 12:31:08 CEST]:
> dropping libwxgtk2.8-dbg from build-depends and also dropping the
> configure option --enable-debug is enough to get pgadmin3 stripped and
> not depending on any *dbg packages, as well as providing detached
> debugging symbols with pgadmin3-dbg. The simple patch is now attached.

 Actually, no, it isn't.  Have you tried it?  That will bring us back
#652099, an empty -dbg package.

 I am willing to reopen #647916 and tag it wontfixed and drop the -dbg
package if there isn't a solution to this.  Also, this misleading wx-dbg
package might be the reason for #676626, so that part should get rid of
anyway.  My fault to believe that the -dbg namespace is all the same.

 Thanks for the headsup, will get rid of the -dbg package if no other
solution pops up soon, want 1.14.2 in wheezy.

 Enjoy,
Rhonda
-- 
Fühlst du dich mutlos, fass endlich Mut, los  |
Fühlst du dich hilflos, geh raus und hilf, los| Wir sind Helden
Fühlst du dich machtlos, geh raus und mach, los   | 23.55: Alles auf Anfang
Fühlst du dich haltlos, such Halt und lass los|



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#676538: pgadmin3: Linked against dbg libraries.

[George Danchev]

Package: pgadmin3
Version: 1.14.0-2
Tags: patch
Followup-For: Bug #676538

Hi,

dropping libwxgtk2.8-dbg from build-depends and also dropping the
configure option --enable-debug is enough to get pgadmin3 stripped and
not depending on any *dbg packages, as well as providing detached
debugging symbols with pgadmin3-dbg. The simple patch is now attached.
diff -Naur pgadmin3-1.14.2.orig/debian/control pgadmin3-1.14.2/debian/control
--- pgadmin3-1.14.2.orig/debian/control	2012-06-09 10:11:02.0 +
+++ pgadmin3-1.14.2/debian/control	2012-06-09 10:11:24.0 +
@@ -4,7 +4,7 @@
 Maintainer: Gerfried Fuchs 
 Build-Depends: debhelper (>= 7), libpq-dev (>= 8.1), devscripts,
   libwxgtk2.8-dev, libxml2-dev, libxslt1-dev, dpkg-dev (>= 1.13.19),
-  autotools-dev, postgresql-server-dev-all (>= 117~), quilt, libwxgtk2.8-dbg
+  autotools-dev, postgresql-server-dev-all (>= 117~), quilt
 Standards-Version: 3.9.3
 Homepage: http://www.pgadmin.org/
 Vcs-Svn: svn://svn.debian.org/svn/pkg-postgresql/trunk/pgadmin3/
diff -Naur pgadmin3-1.14.2.orig/debian/rules pgadmin3-1.14.2/debian/rules
--- pgadmin3-1.14.2.orig/debian/rules	2012-06-09 10:11:02.0 +
+++ pgadmin3-1.14.2/debian/rules	2012-06-09 10:11:28.0 +
@@ -56,8 +56,7 @@
 		--mandir=\$${prefix}/share/man \
 		--infodir=\$${prefix}/share/info \
 		--disable-dependency-tracking \
-		--with-wx=/usr \
-		--enable-debug
+		--with-wx=/usr 
 
 build: build-arch build-indep
 build-arch: build-stamp

Bug#676538: pgadmin3: Linked against dbg libraries.

[George Danchev]

Package: pgadmin3
Version: 1.14.0-2
Followup-For: Bug #676538

After a short discussion in irc#d-devel [1] it turns out that:

* Nothing built with wx*-dbg should ever get uploaded, since
the configure option --enable-debug of pgadmin also imply
quite a different runtime behaviour. These are not simply detached
debugging symbols, but also additional code is also engaged.
Hence, please don't build with --enable-debug.

* Building it once with CC -g (for the debug package) and then simply
stripping that with dh_strip (for the non-debug one) would nicely avoid
the double build, and still get us debug and non-debug variants.


[1] irc session log

 Myon: I just Followup-For: Bug #676538 [ suggested building it 
twice --(disable|enable)-debug ]
 flightplan: eww no.  things shouldn't be shipping wx-dbg versions in the 
distro :(
 flightplan: what's wrong with simply building it once, and then using 
dh_strip?
 Myon: the wx-dbg packages are thpethial
 Myon: yeah, that's better
 thpwhat?
 it's not just -g.  it's a bunch of extra runtime code too.  and they 
aren't binary compatible with the non -dbg builds
 hmm
 ron:  then we should simply get rid of pgadmin3-dbg?
 well, that doesn't prevent pgadmin3 from providing standard debugging 
symbols, does it?
 the name confusion is awkward, but they were named that long before we 
had detached symbol -dbg packages
 ol was going to change that for the next release
 flightplan: yes.  nothing built with wx-dbg should ever get uploaded. but 
building pgadmin with -g and the normal wx packages is fine



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#676538: pgadmin3: Linked against dbg libraries.

[George Danchev]

Package: pgadmin3
Version: 1.14.0-2
Followup-For: Bug #676538

The applied "solution" to resolve the bug #652099 [1]
("dbg package doesn't provide debugging symbols")
led to non-debug package of 'pgadmin3' depending on
megs of wx*-dbg's. What needs to be done is to build
it twice:

* once with --disable-debug (for pgadmin3)

* and once again with --enable-debug (resp. pgadmin3-dbg)

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=652099



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#676538: pgadmin3: Linked against dbg libraries.

[Christian Marillat]

Package: pgadmin3
Version: 1.14.2-1
Severity: important

Dear Maintainer,

pgadmin3 depends on libwxbase2.8-dbg and libwxgtk2.8-dbg instead of
libwxbase2.8 and libwxgtk2.8

Christian

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 3.4.0 (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pgadmin3 depends on:
ii  libc6 2.13-33
ii  libgcc1   1:4.7.0-12
ii  libkrb5-3 1.10.1+dfsg-1
ii  libpq59.1.4-1
ii  libstdc++64.7.0-12
ii  libwxbase2.8-dbg  2.8.12.1-11
ii  libwxgtk2.8-dbg   2.8.12.1-11
ii  libxml2   2.8.0+dfsg1-3
ii  libxslt1.11.1.26-12+b1
ii  pgadmin3-data 1.14.2-1

Versions of packages pgadmin3 recommends:
pn  pgagent
ii  postgresql-client-9.0 [postgresql-client]  9.0.6-1

Versions of packages pgadmin3 suggests:
pn  postgresql-contrib  

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org