Bug#677252: would you accept a backported patch for musicbrainz5 in kdemultimedia, for wheezy?Hi Jon!
Hi,
Alle domenica 24 giugno 2012, Jon Dowland ha scritto:
On Tue, Jun 19, 2012 at 08:47:19PM -0300, Lisandro Damián Nicanor
Pérez Meyer wrote:
kdemultimedia creates lots of binaries [0]. Do you know exactly
which of them use the old mb?
Yes, it's libkcddb4 and kscd.
Please **note** that I'm mostly speaking **for myself**: *if* the
patches are accepted upstream and we manage to get them before the
freeze (we uploaded kdemultimedia a few days ago, so we will wait
for it to enter unstable), I don't think there will be much
problem in applying them.
I don't think upstream are likely to accept these patches. My
understanding is that the version we're talking about is considered
stable by upstream and so they won't accept further changes. Their
focus is on the next release (which has moved away from the
monolithic packaging). However I am not very familiar with KDE
upstream, and perhaps they would consider the patches after all. The
turn-around to get them accepted upstream would rule this out for
wheezy, though.
This is correct, usually KDE stable series are feature- and string-
frozen, and that includes also dependencies.
However, at this point a KDE 4.8.5 is not that likely (although it has
not been totally ruled out yet), so a backport would not be much
helpful.
The patches themselves, when I write them, are backports from the git
repositories for kcddb and kscd.
libkcddb has been converted already to MB5 for the future KDE 4.9;
attached there is a preliminary backport I did (warning: it is not
tested, not even to compile!) wrt kdemultimedia 4.8.x.
However, kscd has not been ported upstream yet.
There are presently three packages relying on mb3 still:
[...]
There's a slim chance we can get the migration to musicbrainz5 done
in time for wheezy.
One important question is: if libkcddb and kscd in Wheezy still use MB3,
except the issues mentioned earlier about multi-discs, which kind of
issues would they have? Would they still be able to search/fetch/uploadd
disc info in, say, the next couple of years?
(Since I'm no MB-literate, I'm asking to know more about the current
situation, and to eventually decide whether me or the team should invest
in this.)
Thanks,
--
Pino Toscano
Author: Richard Lärkäng lark...@gmail.com
Author: Pino Toscano p...@kde.org p...@debian.org
Description: Port libkcddb to MusicBrainz5
Apply the serie of upstream commits that port libkcddb to MusicBrainz5
(passing through MusicBrainz4), which are part of KDE 4.9.
It includes also a bugfix for year reading (KDE bug #300091).
.
The patch has been slightly modified to not change the libkcddb version,
and to not enable Musicbrainz lookup by default (keeping the behaviour
of kdemultimedia 4.8.x).
Applied-Upstream: commit:57902715f4592ef44da39835ace42242f96e0a3a
Applied-Upstream: commit:4c71ec9c617b4d442a42a7b2c4c57eb333c1
Applied-Upstream: commit:fa6acd9986779659e9aac8c2cf85e735e7632f85
Applied-Upstream: commit:79b80e1ec090beedf9061cae75a04c39ae5309eb
Applied-Upstream: commit:35880a3bca3c8bf88b07b143d20b5b51ce339a21
Applied-Upstream: commit:95ab6c638ea90e3241bd1950b937c52c34cd7c99
Applied-Upstream: commit:a2d2a670fb5ac1a733f35b3358d00b8981a4a459
Last-Update: 2012-06-28
--- a/libkcddb/CMakeLists.txt
+++ b/libkcddb/CMakeLists.txt
@@ -3,19 +3,22 @@ project(libkcddb)
add_subdirectory( test )
add_subdirectory( kcmcddb )
-if(MUSICBRAINZ3_FOUND)
-set(HAVE_MUSICBRAINZ3 1)
-include_directories(${MUSICBRAINZ3_INCLUDE_DIR})
+macro_optional_find_package(MusicBrainz5)
+macro_log_feature(MUSICBRAINZ5_FOUND MusicBrainz5 A library that provides access to metadata lookup on the MusicBrainz server http://www.musicbrainz.org; FALSE Music metadata lookup for KDE multimedia applications through libkcddb. You need version 5.x of libmusicbrainz)
+
+if(MUSICBRAINZ5_FOUND)
+set(HAVE_MUSICBRAINZ5 1)
+include_directories(${MUSICBRAINZ5_INCLUDE_DIR})
set(libmusicbrainz_SRCS ${libmusicbrainz_SRCS}
musicbrainz/musicbrainzlookup.cpp
musicbrainz/asyncmusicbrainzlookup.cpp)
set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${KDE4_ENABLE_EXCEPTIONS})
-else(MUSICBRAINZ3_FOUND)
-set(HAVE_MUSICBRAINZ3 0)
+else(MUSICBRAINZ5_FOUND)
+set(HAVE_MUSICBRAINZ5 0)
set(libmusicbrainz_SRCS)
-endif(MUSICBRAINZ3_FOUND)
+endif(MUSICBRAINZ5_FOUND)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/config-musicbrainz.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-musicbrainz.h )
@@ -58,9 +61,9 @@ kde4_add_kcfg_files(kcddb_LIB_SRCS confi
kde4_add_library(kcddb SHARED ${kcddb_LIB_SRCS})
target_link_libraries(kcddb ${KDE4_KDEUI_LIBS} ${KDE4_KIO_LIBS})
-if(MUSICBRAINZ3_FOUND)
-target_link_libraries(kcddb ${MUSICBRAINZ3_LIBRARIES})
-endif(MUSICBRAINZ3_FOUND)
+if(MUSICBRAINZ5_FOUND)
+target_link_libraries(kcddb ${MUSICBRAINZ5_LIBRARIES})
+endif(MUSICBRAINZ5_FOUND)
set_target_properties(kcddb PROPERTIES VERSION ${GENERIC_LIB_VERSION} SOVERSION ${GENERIC_LIB_SOVERSION} )
Bug#677252: would you accept a backported patch for musicbrainz5 in kdemultimedia, for wheezy?Hi Jon!
On Tue, Jun 19, 2012 at 08:47:19PM -0300, Lisandro Damián Nicanor Pérez Meyer wrote: kdemultimedia creates lots of binaries [0]. Do you know exactly which of them use the old mb? Yes, it's libkcddb4 and kscd. Please **note** that I'm mostly speaking **for myself**: *if* the patches are accepted upstream and we manage to get them before the freeze (we uploaded kdemultimedia a few days ago, so we will wait for it to enter unstable), I don't think there will be much problem in applying them. I don't think upstream are likely to accept these patches. My understanding is that the version we're talking about is considered stable by upstream and so they won't accept further changes. Their focus is on the next release (which has moved away from the monolithic packaging). However I am not very familiar with KDE upstream, and perhaps they would consider the patches after all. The turn-around to get them accepted upstream would rule this out for wheezy, though. The patches themselves, when I write them, are backports from the git repositories for kcddb and kscd. The reworking I need to do is mostly fixing the paths to files in the diffs (since they've moved about). Most of the changes are simple substitutions (mb4_* to mb5_*, etc.). 4:4.8.4-1 is now in unstable. I will most likely work on the patch on Tuesday. There are presently three packages relying on mb3 still: kdemultimedia, goobox and gnome-mplayer. The goobox patch is written, I just need to convince the maintainer. Gnome-mplayer is yet to be patched so I'll be working on that on Tuesday too. There's a slim chance we can get the migration to musicbrainz5 done in time for wheezy. Thanks! -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#677252: would you accept a backported patch for musicbrainz5 in kdemultimedia, for wheezy?
Hi folks, I filed #677252 against kdemultimedia as part of a larger effort to transition all Debian packages away from earlier libmusicbrainz versions, and I've been hoping to achieve this in time for wheezy. All versions prior to mb4 (which was never packaged for Debian) use an older, deprecated musicbrainz API which has a number of problems, not least with multi-disc releases. So all double-albums are messed up for example. (You can see the progress of my bugs/patches etc. at http://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=libmusicbrainz5;users=j...@debian.org) I've looked at kdemultimedia and it looks like I need to adapt two backported patches from upstream, which is mostly straightforward but will require a bit of time from me to get familiar with KDE and KDE packaging, etc. I'd really like to see this done for wheezy but it's not worth me embarking on it unless there's a chance you'd accept the patch. So, would you? Please let me know ⺠It's 99% a sed-job (mb_* to mb5_*); there are a small number of deprecated functions that need replacing but I don't think kdemultimedia makes heavy use of them. Many thanks! -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#677252: would you accept a backported patch for musicbrainz5 in kdemultimedia, for wheezy?Hi Jon!
Hi Jon! On Mar 19 Jun 2012 10:52:54 Jon Dowland escribió: Hi folks, I filed #677252 against kdemultimedia as part of a larger effort to transition all Debian packages away from earlier libmusicbrainz versions, and I've been hoping to achieve this in time for wheezy. [snip] I've looked at kdemultimedia and it looks like I need to adapt two backported patches from upstream, which is mostly straightforward but will require a bit of time from me to get familiar with KDE and KDE packaging, etc. kdemultimedia creates lots of binaries [0]. Do you know exactly which of them use the old mb? Pino told me to check if kcddb 4.9 has switched to mb5 and it did, but I don't know for sure if any other package is using it. I'd really like to see this done for wheezy but it's not worth me embarking on it unless there's a chance you'd accept the patch. So, would you? Please let me know ⺠It's 99% a sed-job (mb_* to mb5_*); there are a small number of deprecated functions that need replacing but I don't think kdemultimedia makes heavy use of them. Please **note** that I'm mostly speaking **for myself**: *if* the patches are accepted upstream and we manage to get them before the freeze (we uploaded kdemultimedia a few days ago, so we will wait for it to enter unstable), I don't think there will be much problem in applying them. [0] http://packages.debian.org/source/sid/kdemultimedia Kinds regards, Lisandro. -- Gabardinas Windows 95. Se cuelgan solas. Lisandro Damián Nicanor Pérez Meyer http://perezmeyer.com.ar/ http://perezmeyer.blogspot.com/ signature.asc Description: This is a digitally signed message part.
