Bug#678776: libpixels-java: FTBFS: The local variable w is never read

2012-06-25 Thread Martín Ferrari 
Niels,

On Sun, Jun 24, 2012 at 6:03 PM, Niels Thykier ni...@thykier.net wrote:

 I have attached an example patch to work around the issue.  It will
 make use of default-jdk and newer javahelper features instead of
 gcj-jdk and dh_javadoc.

 Please note this patch will also correct the clean rule (which fails
 to clean the pixels.jar).

Thank you very much for the patch. I am currently merging it in my
tree and will upload today an updated package.



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#678776: libpixels-java: FTBFS: The local variable w is never read

2012-06-24 Thread Lucas Nussbaum 
Source: libpixels-java
Version: 2.1.3+svn.42-1
Severity: serious
Tags: wheezy sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20120624 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
  debian/rules build
 dh_testdir
 touch build-arch-stamp
 dh_testdir
 jh_build pixels.jar src/main/java
 find src/main/java -name *.java -and -type f -print0 | xargs -0 
 /usr/lib/jvm/java-gcj/bin/javac -cp :debian/_jh_build.pixels -d 
 debian/_jh_build.pixels -source 1.5 -target 1.5
 --
 1. WARNING in src/main/java/com/jhlabs/image/CropFilter.java (at line 127)
   int w = src.getWidth();
   ^
 The local variable w is never read
 --
 2. WARNING in src/main/java/com/jhlabs/image/CropFilter.java (at line 128)
   int h = src.getHeight();
   ^
 The local variable h is never read
 --
 --
 3. WARNING in src/main/java/com/jhlabs/image/GradientFilter.java (at line 21)
   import java.util.*;
  ^
 The import java.util is never used
 --
 4. WARNING in src/main/java/com/jhlabs/image/GradientFilter.java (at line 154)
   int rgb1, rgb2;
   
 The local variable rgb1 is never read
 --
 5. WARNING in src/main/java/com/jhlabs/image/GradientFilter.java (at line 154)
   int rgb1, rgb2;
 
 The local variable rgb2 is never read
 --
 --
 6. WARNING in src/main/java/com/jhlabs/image/SparkleFilter.java (at line 19)
   import java.awt.image.*;
  ^^
 The import java.awt.image is never used
 --
 7. WARNING in src/main/java/com/jhlabs/image/SparkleFilter.java (at line 29)
   private int width, height;
   ^
 The field SparkleFilter.width is never read locally
 --
 8. WARNING in src/main/java/com/jhlabs/image/SparkleFilter.java (at line 29)
   private int width, height;
  ^^
 The field SparkleFilter.height is never read locally
 --
 --
 9. WARNING in src/main/java/com/jhlabs/image/TileImageFilter.java (at line 29)
   private int tileWidth;
   ^
 The field TileImageFilter.tileWidth is never read locally
 --
 10. WARNING in src/main/java/com/jhlabs/image/TileImageFilter.java (at line 
 30)
   private int tileHeight;
   ^^
 The field TileImageFilter.tileHeight is never read locally
 --
 --
 11. WARNING in src/main/java/com/jhlabs/image/MotionBlurFilter.java (at line 
 28)
   private float falloff = 1.0f;
 ^^^
 The field MotionBlurFilter.falloff is never read locally
 --
 --
 12. WARNING in src/main/java/com/jhlabs/image/TransitionFilter.java (at line 
 23)
   import java.util.*;
  ^
 The import java.util is never used
 --
 13. WARNING in src/main/java/com/jhlabs/image/TransitionFilter.java (at line 
 54)
   private TransitionFilter() {
   ^^
 The constructor TransitionFilter() is never used locally
 --
 --
 14. WARNING in src/main/java/com/jhlabs/image/ScratchFilter.java (at line 8)
   import java.awt.geom.*;
  ^
 The import java.awt.geom is never used
 --
 --
 15. WARNING in src/main/java/com/jhlabs/image/PolarFilter.java (at line 19)
   import java.awt.*;
  
 The import java.awt is never used
 --
 --
 16. WARNING in src/main/java/com/jhlabs/image/ErodeFilter.java (at line 20)
   import java.awt.image.*;
  ^^
 The import java.awt.image is never used
 --
 --
 17. WARNING in src/main/java/com/jhlabs/image/DiffuseFilter.java (at line 19)
   import java.awt.*;
  
 The import java.awt is never used
 --
 18. WARNING in src/main/java/com/jhlabs/image/DiffuseFilter.java (at line 21)
   import com.jhlabs.math.*;
  ^^^
 The import com.jhlabs.math is never used
 --
 --
 19. WARNING in src/main/java/com/jhlabs/image/SaturationFilter.java (at line 
 7)
   import java.awt.*;
  
 The import java.awt is never used
 --
 20. WARNING in src/main/java/com/jhlabs/image/SaturationFilter.java (at line 
 8)
   import java.awt.image.*;
  ^^
 The import java.awt.image is never used
 --
 --
 21. WARNING in src/main/java/com/jhlabs/image/MaskFilter.java (at line 19)
   import java.awt.*;
  
 The import java.awt is never used
 --
 22. WARNING in src/main/java/com/jhlabs/image/MaskFilter.java (at line 20)
   import java.awt.image.*;
  ^^
 The import java.awt.image is never used
 --
 23. WARNING in src/main/java/com/jhlabs/image/MaskFilter.java (at line 21)
   import java.io.*;

Bug#678776: libpixels-java: FTBFS: The local variable w is never read

2012-06-24 Thread Niels Thykier 
Package: libpixels-java
Tags: patch
Followup-For: Bug #678776

Hi,

I have attached an example patch to work around the issue.  It will
make use of default-jdk and newer javahelper features instead of
gcj-jdk and dh_javadoc.

Please note this patch will also correct the clean rule (which fails
to clean the pixels.jar).

~Niels
diff -u libpixels-java-2.1.3+svn.42/debian/rules libpixels-java-2.1.3+svn.42/debian/rules
--- libpixels-java-2.1.3+svn.42/debian/rules
+++ libpixels-java-2.1.3+svn.42/debian/rules
@@ -3,7 +3,7 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
-export JAVA_HOME=/usr/lib/jvm/java-gcj
+export JAVA_HOME=/usr/lib/jvm/default-java
 
 # Put depended upon jars in here
 # export CLASSPATH=
@@ -17,13 +17,13 @@
 build-indep: build-indep-stamp
 build-indep-stamp:
 	dh_testdir
-	jh_build pixels.jar src/main/java
+	jh_build
 	touch $@
 
 clean:
 	dh_testdir
 	dh_testroot
-	jh_build --clean pixels.jar src/main/java
+	jh_build --clean
 	dh_clean build-stamp build-indep-stamp build-arch-stamp
 
 install-indep: build-indep
@@ -42,8 +42,7 @@
 	dh_install -i
 	dh_installdocs -i
 	dh_installchangelogs -i
-	dh_javadoc -i --sourcedir=src/main/java com.jhlabs.composite \
-		com.jhlabs.image com.jhlabs.math com.jhlabs.vecmath
+	jh_installjavadoc -i
 	jh_installlibs -i pixels.jar
 	jh_depends -i
 	dh_compress -i
diff -u libpixels-java-2.1.3+svn.42/debian/control libpixels-java-2.1.3+svn.42/debian/control
--- libpixels-java-2.1.3+svn.42/debian/control
+++ libpixels-java-2.1.3+svn.42/debian/control
@@ -2,8 +2,8 @@
 Section: java
 Priority: optional
 Maintainer: Martín Ferrari tin...@debian.org
-Build-Depends: debhelper ( 5), javahelper
-Build-Depends-Indep: gcj-jdk, ant
+Build-Depends: debhelper ( 5), javahelper (= 0.40~)
+Build-Depends-Indep: default-jdk, ant
 Standards-Version: 3.9.0.0
 Homepage: https://pixels.dev.java.net/
 Vcs-Browser: http://canterville.mine.nu/wsvn/debian/trunk/libpixels-java
diff -u libpixels-java-2.1.3+svn.42/debian/changelog libpixels-java-2.1.3+svn.42/debian/changelog
--- libpixels-java-2.1.3+svn.42/debian/changelog
+++ libpixels-java-2.1.3+svn.42/debian/changelog
@@ -1,3 +1,16 @@
+libpixels-java (2.1.3+svn.42-1.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Use default-jdk instead gcj-jdk.  (Closes: #678776)
+  * Replace dh_javadoc with jh_installjavadoc.
+  * Use debian/javabuild instead of calling jh_build with
+arguments.  This makes jh_build clean up the jar it
+builds automatically.
+  * Remove useless arguments to jh_clean - they are ignored
+anyway.
+
+ -- Niels Thykier ni...@thykier.net  Sun, 24 Jun 2012 18:41:34 +0200
+
 libpixels-java (2.1.3+svn.42-1) unstable; urgency=low
 
   * New upstream release
only in patch2:
unchanged:
--- libpixels-java-2.1.3+svn.42.orig/debian/javabuild
+++ libpixels-java-2.1.3+svn.42/debian/javabuild
@@ -0,0 +1 @@
+pixels.jar src/main/java
only in patch2:
unchanged:
--- libpixels-java-2.1.3+svn.42.orig/debian/libpixels-java.javadoc
+++ libpixels-java-2.1.3+svn.42/debian/libpixels-java.javadoc
@@ -0,0 +1 @@
+internal
only in patch2:
unchanged:
--- libpixels-java-2.1.3+svn.42.orig/debian/libpixels-java.doc-base.javadoc
+++ libpixels-java-2.1.3+svn.42/debian/libpixels-java.doc-base.javadoc
@@ -0,0 +1,9 @@
+Document: libpixels-java
+Title: API JavaDoc for libpixels-java
+Author: 
+Abstract: This the API JavaDoc for libpixels-java
+Section: Programming/Java
+
+Format: HTML
+Index: /usr/share/doc/libpixels-java/api
+Files: /usr/share/doc/libpixels-java/api/*.html
only in patch2:
unchanged:
--- libpixels-java-2.1.3+svn.42.orig/debian/.javahelper_clean
+++ libpixels-java-2.1.3+svn.42/debian/.javahelper_clean
@@ -0,0 +1 @@
+debian/libpixels-java.doc-base.javadoc

Bug#678776: libpixels-java: FTBFS: The local variable w is never read

2012-06-24 Thread Niels Thykier 
On 2012-06-24 18:55, Niels Thykier wrote:
 Package: libpixels-java
 Tags: patch
 Followup-For: Bug #678776
 
 Hi,
 
 I have attached an example patch to work around the issue.  It will
 make use of default-jdk and newer javahelper features instead of
 gcj-jdk and dh_javadoc.
 
 Please note this patch will also correct the clean rule (which fails
 to clean the pixels.jar).
 
 ~Niels

Sorry, I attached a bad version of the patch.  Here is the corrected one.

~Niels

diff -u libpixels-java-2.1.3+svn.42/debian/rules 
libpixels-java-2.1.3+svn.42/debian/rules
--- libpixels-java-2.1.3+svn.42/debian/rules
+++ libpixels-java-2.1.3+svn.42/debian/rules
@@ -3,7 +3,7 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
-export JAVA_HOME=/usr/lib/jvm/java-gcj
+export JAVA_HOME=/usr/lib/jvm/default-java
 
 # Put depended upon jars in here
 # export CLASSPATH=
@@ -17,13 +17,13 @@
 build-indep: build-indep-stamp
 build-indep-stamp:
dh_testdir
-   jh_build pixels.jar src/main/java
+   jh_build
touch $@
 
 clean:
dh_testdir
dh_testroot
-   jh_build --clean pixels.jar src/main/java
+   jh_clean
dh_clean build-stamp build-indep-stamp build-arch-stamp
 
 install-indep: build-indep
@@ -42,8 +42,7 @@
dh_install -i
dh_installdocs -i
dh_installchangelogs -i
-   dh_javadoc -i --sourcedir=src/main/java com.jhlabs.composite \
-   com.jhlabs.image com.jhlabs.math com.jhlabs.vecmath
+   jh_installjavadoc -i
jh_installlibs -i pixels.jar
jh_depends -i
dh_compress -i
diff -u libpixels-java-2.1.3+svn.42/debian/control 
libpixels-java-2.1.3+svn.42/debian/control
--- libpixels-java-2.1.3+svn.42/debian/control
+++ libpixels-java-2.1.3+svn.42/debian/control
@@ -2,8 +2,8 @@
 Section: java
 Priority: optional
 Maintainer: Martín Ferrari tin...@debian.org
-Build-Depends: debhelper ( 5), javahelper
-Build-Depends-Indep: gcj-jdk, ant
+Build-Depends: debhelper ( 5), javahelper (= 0.40~)
+Build-Depends-Indep: default-jdk, ant
 Standards-Version: 3.9.0.0
 Homepage: https://pixels.dev.java.net/
 Vcs-Browser: http://canterville.mine.nu/wsvn/debian/trunk/libpixels-java
diff -u libpixels-java-2.1.3+svn.42/debian/changelog 
libpixels-java-2.1.3+svn.42/debian/changelog
--- libpixels-java-2.1.3+svn.42/debian/changelog
+++ libpixels-java-2.1.3+svn.42/debian/changelog
@@ -1,3 +1,15 @@
+libpixels-java (2.1.3+svn.42-1.1) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Use default-jdk instead gcj-jdk.  (Closes: #678776)
+  * Replace dh_javadoc with jh_installjavadoc.
+  * Use debian/javabuild instead of calling jh_build with
+arguments.  This makes jh_build clean up the jar it
+builds automatically.
+  * Replace jh_build --clean with jh_clean.
+
+ -- Niels Thykier ni...@thykier.net  Sun, 24 Jun 2012 18:41:34 +0200
+
 libpixels-java (2.1.3+svn.42-1) unstable; urgency=low
 
   * New upstream release
only in patch2:
unchanged:
--- libpixels-java-2.1.3+svn.42.orig/debian/javabuild
+++ libpixels-java-2.1.3+svn.42/debian/javabuild
@@ -0,0 +1 @@
+pixels.jar src/main/java
only in patch2:
unchanged:
--- libpixels-java-2.1.3+svn.42.orig/debian/libpixels-java.javadoc
+++ libpixels-java-2.1.3+svn.42/debian/libpixels-java.javadoc
@@ -0,0 +1 @@
+internal