Bug#679888: gnome-commander: Port to libpoppler25 API
Michael, Alessio, Alle venerdì 13 luglio 2012, Pino Toscano ha scritto: Alle lunedì 2 luglio 2012, Andy Whitcroft ha scritto: We are using this patch in Ubuntu to handle the changes in libpoppler's API version 19 to version 25/26. Please consider for Debian. This patch is -not- compatible with the Poppler (0.18.x) currently in Debian, so it does not fit. The patch provided in the upstream bug report, though, should work with poppler = 0.20 and previous versions, so if you (gnome-commander Debian mantainers) want to fix this bug (upstream currently seems... not really reactive in general) please consider that one. Could be it possible to integrate the patch provided in the upstream bug report [1], so gnome-commander can just be recompiled (and work) with poppler 0.20.x? (Note that patch needs autoreconf, since it touches autotools stuff.) [1] https://bugzilla.gnome.org/show_bug.cgi?id=676303 Thanks, -- Pino Toscano signature.asc Description: This is a digitally signed message part.
Bug#679888: gnome-commander: Port to libpoppler25 API
Ciao Pino, On Mon, Jul 1, 2013 at 10:14 AM, Pino Toscano p...@debian.org wrote: Could be it possible to integrate the patch provided in the upstream bug report [1], so gnome-commander can just be recompiled (and work) with poppler 0.20.x? (Note that patch needs autoreconf, since it touches autotools stuff.) If you have time, please go ahead committing the patch to the master branch. Regarding the autoreconf thing, I'd suggest to add support for dh-autoreconf, feel free to apply the solution you like most though. Keep up the great work! -- Alessio Treglia | www.alessiotreglia.com Debian Developer | ales...@debian.org Ubuntu Core Developer| quadris...@ubuntu.com 0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#679888: gnome-commander: Port to libpoppler25 API
Hi, Alle lunedì 1 luglio 2013, Alessio Treglia ha scritto: On Mon, Jul 1, 2013 at 10:14 AM, Pino Toscano p...@debian.org wrote: Could be it possible to integrate the patch provided in the upstream bug report [1], so gnome-commander can just be recompiled (and work) with poppler 0.20.x? (Note that patch needs autoreconf, since it touches autotools stuff.) If you have time, please go ahead committing the patch to the master branch. Done. Regarding the autoreconf thing, I'd suggest to add support for dh-autoreconf, feel free to apply the solution you like most though. I had dh-autoreconf in mind too, so I picked it since you also suggested it. Feel free to review at will and upload (with your own changes) whenever you can/want/etc. Thanks, -- Pino Toscano signature.asc Description: This is a digitally signed message part.
Bug#679888: gnome-commander: Port to libpoppler25 API
Package: gnome-commander
Version: 1.2.8.15-3
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu quantal ubuntu-patch
Dear Maintainer,
We are using this patch in Ubuntu to handle the changes in libpoppler's
API version 19 to version 25/26. Please consider for Debian.
* Track changes to libpoppler25 API.
Thanks for considering the patch.
-apw
-- System Information:
Debian Release: wheezy/sid
APT prefers precise-updates
APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500,
'precise-proposed'), (500, 'precise'), (100, 'precise-backports')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-26-generic (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru gnome-commander-1.2.8.15/debian/patches/series gnome-commander-1.2.8.15/debian/patches/series
--- gnome-commander-1.2.8.15/debian/patches/series 2012-05-13 23:26:36.0 +0100
+++ gnome-commander-1.2.8.15/debian/patches/series 2012-06-13 16:01:51.0 +0100
@@ -3,3 +3,4 @@
0002-strrchr_instead_of_g_strrstr.patch
0003-g_ascii_strcasecmp_instead_of_g_strcasecmp.patch
werror-format-security.diff
+track_libpoppler25_abi_changes
diff -Nru gnome-commander-1.2.8.15/debian/patches/track_libpoppler25_abi_changes gnome-commander-1.2.8.15/debian/patches/track_libpoppler25_abi_changes
--- gnome-commander-1.2.8.15/debian/patches/track_libpoppler25_abi_changes 1970-01-01 01:00:00.0 +0100
+++ gnome-commander-1.2.8.15/debian/patches/track_libpoppler25_abi_changes 2012-06-13 16:01:51.0 +0100
@@ -0,0 +1,28 @@
+Description: track libpoppler25 API changes
+ Track changes to the libpoppler25 API.
+ .
+ setErrorFunction - setErrorCallback -- interface replaced
+Author: Andy Whitcroft a...@ubuntu.com
+Last-Update: 2012-06-13
+Index: gnome-commander-1.2.8.15/src/tags/gnome-cmd-tags-poppler.cc
+===
+--- gnome-commander-1.2.8.15.orig/src/tags/gnome-cmd-tags-poppler.cc 2011-12-06 19:10:29.0 +
gnome-commander-1.2.8.15/src/tags/gnome-cmd-tags-poppler.cc 2012-06-13 15:43:29.648428595 +0100
+@@ -41,7 +41,7 @@
+ static regex_t rxDate;
+ static gboolean rxDate_OK;
+
+-static void noErrorReporting(int pos, char *msg, va_list args)
++static void noErrorReporting(void *data, ErrorCategory category, int pos, char *msg)
+ {
+ }
+ #endif
+@@ -52,7 +52,7 @@
+ #ifdef HAVE_PDF
+ rxDate_OK = regcomp (rxDate, ^(D:)?([12][019][0-9][0-9]([01][0-9]([0-3][0-9]([012][0-9]([0-5][0-9]([0-5][0-9])?)?)?)?)?), REG_EXTENDED)==0;
+
+-setErrorFunction(noErrorReporting);
++setErrorCallback(noErrorReporting, NULL);
+ #endif
+ }
+
