Bug#681064: [Pkg-octave-devel] Bug#681064: octave: does not configure properly

2012-07-11 Thread Santiago Vila
On Tue, 10 Jul 2012, Rafael Laboissiere wrote:

 I suspect that your system has some file left over from another package
 that may be causing the problem.  If this is true, then what you are
 reporting is a real bug that must be fixed, but it is perhaps not caused
 by the octave package.

I can assure that there is a real bug here, because this happened on
twenty different computers at work, and everything I did was normal,
i.e. apt-get update, apt-get upgrade, apt-get dist-upgrade,
dpkg --purge not-needed-package, etc.

I will not change the severity again because I don't want to start a
bug severity war, but I still think this bug deserves a freeze exception
(i.e. it should be RC).

After the analysis by Thomas Weber, do you still need a precise way to
reproduce this?



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#681064: [Pkg-octave-devel] Bug#681064: Bug#681064: octave: does not configure properly

2012-07-11 Thread Sébastien Villemot
severity 681064 serious
tags 681064 = confirmed
thanks

Santiago Vila sanv...@unex.es writes:

 On Tue, 10 Jul 2012, Rafael Laboissiere wrote:

 I suspect that your system has some file left over from another package
 that may be causing the problem.  If this is true, then what you are
 reporting is a real bug that must be fixed, but it is perhaps not caused
 by the octave package.

 I can assure that there is a real bug here, because this happened on
 twenty different computers at work, and everything I did was normal,
 i.e. apt-get update, apt-get upgrade, apt-get dist-upgrade,
 dpkg --purge not-needed-package, etc.

 I will not change the severity again because I don't want to start a
 bug severity war, but I still think this bug deserves a freeze exception
 (i.e. it should be RC).

This is also my opinion. I am also convinced that the problem is
real. I'm therefor setting the severity back to serious.

 After the analysis by Thomas Weber, do you still need a precise way to
 reproduce this?

No, we have isolated the cause and we will implement the solution
shortly.

Thanks for your feedback,

-- 
 .''`.Sébastien Villemot
: :' :Debian Maintainer
`. `' http://www.dynare.org/sebastien
  `-  GPG Key: 4096R/381A7594


pgpFxg2xJXZvI.pgp
Description: PGP signature


Bug#681064: [Pkg-octave-devel] Bug#681064: octave: does not configure properly

2012-07-11 Thread Rafael Laboissiere
* Santiago Vila sanv...@unex.es [2012-07-11 16:02]:

 On Tue, 10 Jul 2012, Rafael Laboissiere wrote:
 
  I suspect that your system has some file left over from another package
  that may be causing the problem.  If this is true, then what you are
  reporting is a real bug that must be fixed, but it is perhaps not caused
  by the octave package.
 
 I can assure that there is a real bug here, because this happened on
 twenty different computers at work, and everything I did was normal,
 i.e. apt-get update, apt-get upgrade, apt-get dist-upgrade,
 dpkg --purge not-needed-package, etc.
 
 I will not change the severity again because I don't want to start a
 bug severity war, but I still think this bug deserves a freeze exception
 (i.e. it should be RC).
 
 After the analysis by Thomas Weber, do you still need a precise way to
 reproduce this?

At any rate, the following is a reproducible bug:

$ sudo rmdir /usr/share/octave/packages/
$ sudo octave --silent --no-history --no-init-file --no-window-system 
--eval pkg ('rebuild');
error: could not find the file or path /usr/share/octave/packages
error: called from:
error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 1234, column 5
error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 418, column 16
error:   /usr/share/octave/3.6.2/m/startup/octaverc at line 26, column 1

I think that this is an upstream problem and I agree with you that this
bug deserves a freeze exception.  Sébastien has already set the severity
level to serious again.

For fixing the bug, I propose the patch attached below, that changes the
code in pkg.m.  To the other members of the DOG: please, tell me what you
think about the patch.  I am also wondering what we should do now. 
Should we create a wheezy branch in our Git repository and make an
RC-fixing release with version number, say, 3.6.2-2.wheezy.1?

Rafael
Description: Create packages directory, if is does not exist
 This package avoids failing errors when pkg('rebuild') is called and
 the /usr/share/octave/packages does not exist.  Note that a similar
 code exists already in pkg.m when treating the directory in archprefix.
Author: Rafael Laboissiere raf...@laboissiere.net
Bug-Debian: http://bugs.debian.org/681064
Forwarded: no
Last-Update: 2012-07-11

--- octave-3.6.2.orig/scripts/pkg/pkg.m
+++ octave-3.6.2/scripts/pkg/pkg.m
@@ -415,7 +415,13 @@ function [local_packages, global_package
 global_packages = archprefix;
   elseif (length (files) = 1  nargout = 2  ischar (files{1}))
 prefix = files{1};
-prefix = absolute_pathname (prefix);
+try
+  prefix = absolute_pathname (prefix);
+catch
+  mkdir (prefix);
+  warning (creating the directory %s\n, prefix);
+  prefix = absolute_pathname (prefix);
+end_try_catch
 local_packages = prefix;
 user_prefix = true;
 if (length (files) = 2  ischar (files{2}))


Bug#681064: [Pkg-octave-devel] Bug#681064: Bug#681064: octave: does not configure properly

2012-07-11 Thread Jordi Gutiérrez Hermoso
On 11 July 2012 12:44, Rafael Laboissiere raf...@laboissiere.net wrote:
 At any rate, the following is a reproducible bug:

 $ sudo rmdir /usr/share/octave/packages/
 $ sudo octave --silent --no-history --no-init-file --no-window-system 
 --eval pkg ('rebuild');
 error: could not find the file or path /usr/share/octave/packages
 error: called from:
 error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 1234, column 5
 error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 418, column 16
 error:   /usr/share/octave/3.6.2/m/startup/octaverc at line 26, column 1
[snip]
 For fixing the bug, I propose the patch attached below, that changes the
 code in pkg.m.

I'm not sure the fix in the catch block is right. What if creating the
directory fails? Or do we know at that point that this is a writable
location?

- Jordi G. H.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#681064: [Pkg-octave-devel] Bug#681064: Bug#681064: octave: does not configure properly

2012-07-11 Thread Rafael Laboissiere
* Jordi Gutiérrez Hermoso jord...@octave.org [2012-07-11 13:02]:

 On 11 July 2012 12:44, Rafael Laboissiere raf...@laboissiere.net wrote:
  At any rate, the following is a reproducible bug:
 
  $ sudo rmdir /usr/share/octave/packages/
  $ sudo octave --silent --no-history --no-init-file --no-window-system 
  --eval pkg ('rebuild');
  error: could not find the file or path /usr/share/octave/packages
  error: called from:
  error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 1234, column 5
  error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 418, column 16
  error:   /usr/share/octave/3.6.2/m/startup/octaverc at line 26, column 1
 [snip]
  For fixing the bug, I propose the patch attached below, that changes the
  code in pkg.m.
 
 I'm not sure the fix in the catch block is right. What if creating the
 directory fails? Or do we know at that point that this is a writable
 location?

Well, in pkg.m we have already this:

try
  archprefix = absolute_pathname (archprefix);
catch
  mkdir (archprefix);
  warning (creating the directory %s\n, archprefix);
  archprefix = absolute_pathname (archprefix);
end_try_catch

My fix regarding the prefix variable was inspired in the code above.
Your criticisms would also apply to this.

BTW, should we move this discussion to the octave-maintainers mailing
list?

Rafael



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#681064: [Pkg-octave-devel] Bug#681064: Bug#681064: Bug#681064: octave: does not configure properly

2012-07-11 Thread Rafael Laboissiere
* Rafael Laboissiere raf...@laboissiere.net [2012-07-11 19:58]:

 * Jordi Gutiérrez Hermoso jord...@octave.org [2012-07-11 13:02]:
 
  On 11 July 2012 12:44, Rafael Laboissiere raf...@laboissiere.net wrote:
   At any rate, the following is a reproducible bug:
  
   $ sudo rmdir /usr/share/octave/packages/
   $ sudo octave --silent --no-history --no-init-file --no-window-system 
   --eval pkg ('rebuild');
   error: could not find the file or path /usr/share/octave/packages
   error: called from:
   error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 1234, column 5
   error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 418, column 16
   error:   /usr/share/octave/3.6.2/m/startup/octaverc at line 26, 
   column 1
  [snip]
   For fixing the bug, I propose the patch attached below, that changes the
   code in pkg.m.
  
  I'm not sure the fix in the catch block is right. What if creating the
  directory fails? Or do we know at that point that this is a writable
  location?
 
 Well, in pkg.m we have already this:
 
 try
   archprefix = absolute_pathname (archprefix);
 catch
   mkdir (archprefix);
   warning (creating the directory %s\n, archprefix);
   archprefix = absolute_pathname (archprefix);
 end_try_catch
 
 My fix regarding the prefix variable was inspired in the code above.
 Your criticisms would also apply to this.
 
 BTW, should we move this discussion to the octave-maintainers mailing
 list?

I submitted a bug report (#36830) about this bug on the Savannah bug
tracker.

Rafael



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#681064: octave: does not configure properly

2012-07-10 Thread Santiago Vila
Package: octave
Version: 3.6.2-2
Severity: serious

I had a wheezy system which was updated to wheezy last week.

After apt-get update; apt-get upgrade; apt-get dist-upgrade today I decided
to install octave and octave-info, then purge octave3.2 and octave3.2-info.

Now octave does not configure:

# dpkg --pending --configure 
Setting up octave (3.6.2-2) ...
warning: X11 DISPLAY environment variable not set
error: could not find the file or path /usr/share/octave/packages
error: called from:
error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 1234, column 5
error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 418, column 16
error:   /usr/share/octave/3.6.2/m/startup/octaverc at line 26, column 1

dpkg: error processing octave (--configure):
 subprocess installed post-installation script returned error exit status 1
Processing triggers for menu ...
Errors were encountered while processing:
 octave


Attached complete (gzipped) dpkg.log for today in case it's useful to
diagnose the problem.

Thanks.

dpkg.log.gz
Description: Binary data


Bug#681064: [Pkg-octave-devel] Bug#681064: octave: does not configure properly

2012-07-10 Thread Rafael Laboissiere
package octave
tags 681064 unreproducible moreinfo
severity 681064 normal
thanks

* Santiago Vila sanv...@unex.es [2012-07-10 13:23]:

 Package: octave
 Version: 3.6.2-2
 Severity: serious
 
 I had a wheezy system which was updated to wheezy last week.
 
 After apt-get update; apt-get upgrade; apt-get dist-upgrade today I decided
 to install octave and octave-info, then purge octave3.2 and octave3.2-info.
 
 Now octave does not configure:
 
 # dpkg --pending --configure 
 Setting up octave (3.6.2-2) ...
 warning: X11 DISPLAY environment variable not set
 error: could not find the file or path /usr/share/octave/packages
 error: called from:
 error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 1234, column 5
 error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 418, column 16
 error:   /usr/share/octave/3.6.2/m/startup/octaverc at line 26, column 1
 
 dpkg: error processing octave (--configure):
  subprocess installed post-installation script returned error exit status 1
 Processing triggers for menu ...
 Errors were encountered while processing:
  octave

I cannot reproduce the problem in my testing system as today.  I am
hereby downgrading the severity level of this bug report from serious
to normal.

The following is what I did.  First, I put this in /etc/apt/preferences:

##
Package: *
Pin: release a=testing
Pin-Priority: 650

Package: *
Pin: release a=stable
Pin-Priority: 550
##

I then purged all Octave-related packages from my system and issued the
commands:

aptitude update
aptitude install octave3.2
aptitude install octave
aptitude purge octave3.2

and everything went fine.

I suspect that your system has some file left over from another package
that may be causing the problem.  If this is true, then what you are
reporting is a real bug that must be fixed, but it is perhaps not caused
by the octave package.

Unless you provide us with a precise way to reproduce the problem, we
will keep the severity level of this report below the release-critical
threshold.

Best,

Rafael



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#681064: [Pkg-octave-devel] Bug#681064: Bug#681064: octave: does not configure properly

2012-07-10 Thread Sébastien Villemot
Rafael Laboissiere raf...@laboissiere.net writes:

 The following is what I did.  First, I put this in /etc/apt/preferences:

 ##
 Package: *
 Pin: release a=testing
 Pin-Priority: 650

 Package: *
 Pin: release a=stable
 Pin-Priority: 550
 ##

 I then purged all Octave-related packages from my system and issued the
 commands:

 aptitude update
 aptitude install octave3.2
 aptitude install octave
 aptitude purge octave3.2
 
 and everything went fine.

What do you get if you do the following? (which seems to correspond to
what the reporter did)

  aptitude install octave3.2
  aptitude remove octave3.2
  aptitude install octave
  aptitude purge octave3.2

(note that octave3.2 is first remove, then purged).

-- 
 .''`.Sébastien Villemot
: :' :Debian Maintainer
`. `' http://www.dynare.org/sebastien
  `-  4096R/381A7594: 2069 1DFC C2C9 8C47 9529  84EE 0001 8C22 381A 7594


pgpnqymYzbf5K.pgp
Description: PGP signature


Bug#681064: [Pkg-octave-devel] Bug#681064: octave: does not configure properly

2012-07-10 Thread Thomas Weber
Hi Santiago, 

On Tue, Jul 10, 2012 at 01:23:44PM +0200, Santiago Vila wrote:
 Package: octave
 Version: 3.6.2-2
 Severity: serious
 
 I had a wheezy system which was updated to wheezy last week.
 
 After apt-get update; apt-get upgrade; apt-get dist-upgrade today I decided
 to install octave and octave-info, then purge octave3.2 and octave3.2-info.
 
 Now octave does not configure:

Please create the directory
/usr/share/octave/packages
That workaround should let you finish the installation.

Thomas



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#681064: [Pkg-octave-devel] Bug#681064: octave: does not configure properly

2012-07-10 Thread Thomas Weber
On Tue, Jul 10, 2012 at 01:23:44PM +0200, Santiago Vila wrote:
 After apt-get update; apt-get upgrade; apt-get dist-upgrade today I decided
 to install octave and octave-info, then purge octave3.2 and octave3.2-info.
 
 Now octave does not configure:
 
 # dpkg --pending --configure 
 Setting up octave (3.6.2-2) ...
 warning: X11 DISPLAY environment variable not set
 error: could not find the file or path /usr/share/octave/packages
 error: called from:
 error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 1234, column 5
 error:   /usr/share/octave/3.6.2/m/pkg/pkg.m at line 418, column 16
 error:   /usr/share/octave/3.6.2/m/startup/octaverc at line 26, column 1

When removing the package, octave3.2's postrm file is run, which
(correctly) removes the empty directory /usr/share/octave/packages.
octave 3.6 is then installed and brings this directory with it. When
purging octave3.2 later, its postrm is run *again* and removes the
directory (which now belongs to octave 3.6).

I guess the best fix is to change octave 3.6 postinst file to recreate this
directory if it does not exist.
The good news is that we will not run again into this as octave 3.6
brings this directory with it. 

Thomas



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org