Bug#687405: audiofile: FTBFS: test failed
Hi. Il 12/09/2012 15:06, Lucas Nussbaum ha scritto: During a rebuild of all packages in *wheezy*, your package failed to build on amd64. I can't reproduce it. I tried with a testing cowbuilder (managed via debomatic) on amd64. Tests are just fine and the binary package is produced correctly. [==] Running 4 tests from 1 test case. [--] Global test environment set-up. [--] 4 tests from Miscellaneous [ RUN ] Miscellaneous.AIFF Audio File Library: could not open file '/tmp/test' [error 3] miscellaneous.cpp:72: Failure Value of: file Actual: false Expected: true Audio File Library: '/tmp/test': unrecognized audio file format [error 0] miscellaneous.cpp:91: Failure Value of: file Actual: false Expected: true [ FAILED ] Miscellaneous.AIFF (1 ms) [ RUN ] Miscellaneous.AIFFC Audio File Library: could not open file '/tmp/test' [error 3] miscellaneous.cpp:72: Failure Value of: file Actual: false Expected: true Audio File Library: '/tmp/test': unrecognized audio file format [error 0] miscellaneous.cpp:91: Failure Value of: file Actual: false Expected: true All the failures appear related to the /tmp/test file with unrecognized audio file format. Lucas, could it be some strange configuration in your build environment (for example, /tmp not really available, or with limited space)? Thanks, Giovanni. -- Giovanni Mascellani mascell...@poisson.phc.unipi.it Pisa, Italy Web: http://poisson.phc.unipi.it/~mascellani Jabber: g.mascell...@jabber.org / giova...@elabor.homelinux.org signature.asc Description: OpenPGP digital signature
Bug#687405: audiofile: FTBFS: test failed
On 15/09/12 at 10:53 +0200, Giovanni Mascellani wrote: Hi. Il 12/09/2012 15:06, Lucas Nussbaum ha scritto: During a rebuild of all packages in *wheezy*, your package failed to build on amd64. I can't reproduce it. I tried with a testing cowbuilder (managed via debomatic) on amd64. Tests are just fine and the binary package is produced correctly. [==] Running 4 tests from 1 test case. [--] Global test environment set-up. [--] 4 tests from Miscellaneous [ RUN ] Miscellaneous.AIFF Audio File Library: could not open file '/tmp/test' [error 3] miscellaneous.cpp:72: Failure Value of: file Actual: false Expected: true Audio File Library: '/tmp/test': unrecognized audio file format [error 0] miscellaneous.cpp:91: Failure Value of: file Actual: false Expected: true [ FAILED ] Miscellaneous.AIFF (1 ms) [ RUN ] Miscellaneous.AIFFC Audio File Library: could not open file '/tmp/test' [error 3] miscellaneous.cpp:72: Failure Value of: file Actual: false Expected: true Audio File Library: '/tmp/test': unrecognized audio file format [error 0] miscellaneous.cpp:91: Failure Value of: file Actual: false Expected: true All the failures appear related to the /tmp/test file with unrecognized audio file format. Lucas, could it be some strange configuration in your build environment (for example, /tmp not really available, or with limited space)? It shouldn't be the case. However, using '/tmp/test' is a bit fragile, isn't it? Lucas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687405: audiofile: FTBFS: test failed
tag 687405 + patch
thanks
Il 15/09/2012 11:08, Lucas Nussbaum ha scritto:
All the failures appear related to the /tmp/test file with unrecognized
audio file format. Lucas, could it be some strange configuration in your
build environment (for example, /tmp not really available, or with
limited space)?
It shouldn't be the case. However, using '/tmp/test' is a bit fragile,
isn't it?
Ok, the attached patch should fix the problem. However, it is quite a
complicated and hard to maintain patch for a rather minor thing (it is a
FTBFS, but it happens only under certain conditions and it just a small
technical issue in the testing platform). I don't feel comfortable with
uploading it without hearing back from the maintainer.
Giovanni.
--
Giovanni Mascellani mascell...@poisson.phc.unipi.it
Pisa, Italy
Web: http://poisson.phc.unipi.it/~mascellani
Jabber: g.mascell...@jabber.org / giova...@elabor.homelinux.org
Index: audiofile/test/miscellaneous.cpp
===
--- audiofile.orig/test/miscellaneous.cpp 2012-09-15 18:47:55.747463233
+0200
+++ audiofile/test/miscellaneous.cpp2012-09-15 19:42:52.563324587 +0200
@@ -50,7 +50,7 @@
const int kNumMiscellaneous = sizeof (kMiscellaneous) / sizeof (Miscellaneous);
-const char kTestFileName[] = /tmp/test;
+char kTestFileName[] = /tmp/testXX;
void writeMiscellaneous(int fileFormat)
{
@@ -143,6 +143,7 @@
int main(int argc, char **argv)
{
+ int tmp = mkstemp(kTestFileName);
::testing::InitGoogleTest(argc, argv);
return RUN_ALL_TESTS();
}
Index: audiofile/test/aes.cpp
===
--- audiofile.orig/test/aes.cpp 2012-09-15 18:26:18.783517776 +0200
+++ audiofile/test/aes.cpp 2012-09-15 19:42:52.555324584 +0200
@@ -34,7 +34,7 @@
#include string.h
#include unistd.h
-static const char *kTestFileName = /tmp/test.aiff;
+static char kTestFileName[] = /tmp/test.aiffXX;
TEST(AES, AIFF)
{
@@ -68,6 +68,7 @@
int main(int argc, char **argv)
{
+ int tmp = mkstemp(kTestFileName);
::testing::InitGoogleTest(argc, argv);
return RUN_ALL_TESTS();
}
Index: audiofile/test/channelmatrix.cpp
===
--- audiofile.orig/test/channelmatrix.cpp 2012-09-15 18:26:18.783517776
+0200
+++ audiofile/test/channelmatrix.cpp2012-09-15 19:42:52.559324586 +0200
@@ -30,7 +30,7 @@
#include audiofile.h
#include gtest/gtest.h
-const char *kTestFileName = /tmp/test.aiff;
+char kTestFileName[] = /tmp/test.aiffXX;
template typename T
void testChannelMatrixReading(int sampleFormat, int sampleWidth)
@@ -213,6 +213,7 @@
int main(int argc, char **argv)
{
+ int tmp = mkstemp(kTestFileName);
::testing::InitGoogleTest(argc, argv);
return RUN_ALL_TESTS();
}
Index: audiofile/test/floattoint.cpp
===
--- audiofile.orig/test/floattoint.cpp 2012-09-15 18:26:18.783517776 +0200
+++ audiofile/test/floattoint.cpp 2012-09-15 19:42:52.559324586 +0200
@@ -40,13 +40,14 @@
protected:
virtual void SetUp()
{
+ int tmp = mkstemp(FloatToIntTest::kTestFileName);
}
virtual void TearDown()
{
::unlink(kTestFileName);
}
- static const char *kTestFileName;
+ static char kTestFileName[];
static AFfilehandle createTestFile(int sampleWidth)
{
@@ -67,7 +68,7 @@
}
};
-const char *FloatToIntTest::kTestFileName = /tmp/test.aiff;
+char FloatToIntTest::kTestFileName[] = /tmp/test.aiffXX;
static const int8_t kMinInt8 = std::numeric_limitsint8_t::min();
static const int8_t kMaxInt8 = std::numeric_limitsint8_t::max();
Index: audiofile/test/inttofloat.cpp
===
--- audiofile.orig/test/inttofloat.cpp 2012-09-15 18:26:18.787517776 +0200
+++ audiofile/test/inttofloat.cpp 2012-09-15 19:42:52.563324587 +0200
@@ -40,13 +40,14 @@
protected:
virtual void SetUp()
{
+ int tmp = mkstemp(IntToFloatTest::kTestFileName);
}
virtual void TearDown()
{
::unlink(kTestFileName);
}
- static const char *kTestFileName;
+ static char kTestFileName[];
static AFfilehandle createTestFile(int sampleWidth)
{
@@ -66,7 +67,7 @@
}
};
-const char *IntToFloatTest::kTestFileName = /tmp/test.aiff;
+char IntToFloatTest::kTestFileName[] = /tmp/test.aiffXX;
static const int8_t kMinInt8 = std::numeric_limitsint8_t::min();
static const int8_t kMaxInt8 = std::numeric_limitsint8_t::max();
Index: audiofile/test/large.cpp
===
--- audiofile.orig/test/large.cpp 2012-09-15 18:26:18.787517776 +0200
+++ audiofile/test/large.cpp
Bug#687405: audiofile: FTBFS: test failed
Il 15/09/2012 22:58, Giovanni Mascellani ha scritto: Il 15/09/2012 11:08, Lucas Nussbaum ha scritto: All the failures appear related to the /tmp/test file with unrecognized audio file format. Lucas, could it be some strange configuration in your build environment (for example, /tmp not really available, or with limited space)? It shouldn't be the case. However, using '/tmp/test' is a bit fragile, isn't it? Ok, the attached patch should fix the problem. However, it is quite a complicated and hard to maintain patch for a rather minor thing (it is a FTBFS, but it happens only under certain conditions and it just a small technical issue in the testing platform). I don't feel comfortable with uploading it without hearing back from the maintainer. I also sent the patch upstream: https://github.com/mpruett/audiofile/pull/11 Giovanni. -- Giovanni Mascellani mascell...@poisson.phc.unipi.it Pisa, Italy Web: http://poisson.phc.unipi.it/~mascellani Jabber: g.mascell...@jabber.org / giova...@elabor.homelinux.org signature.asc Description: OpenPGP digital signature
Bug#687405: audiofile: FTBFS: test failed
Source: audiofile Version: 0.3.4-1 Severity: serious Tags: wheezy sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20120912 qa-ftbfs Justification: FTBFS in wheezy on amd64 Hi, During a rebuild of all packages in *wheezy*, your package failed to build on amd64. Relevant part: make[5]: Entering directory `/«PKGBUILDDIR»/test' [==] Running 1 test from 1 test case. [--] Global test environment set-up. [--] 1 test from AES [ RUN ] AES.AIFF [ OK ] AES.AIFF (1 ms) [--] 1 test from AES (1 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (1 ms total) [ PASSED ] 1 test. PASS: aes [==] Running 12 tests from 1 test case. [--] Global test environment set-up. [--] 12 tests from ChannelMatrix [ RUN ] ChannelMatrix.ReadInt8 [ OK ] ChannelMatrix.ReadInt8 (0 ms) [ RUN ] ChannelMatrix.ReadInt16 [ OK ] ChannelMatrix.ReadInt16 (0 ms) [ RUN ] ChannelMatrix.ReadInt24 [ OK ] ChannelMatrix.ReadInt24 (1 ms) [ RUN ] ChannelMatrix.ReadInt32 [ OK ] ChannelMatrix.ReadInt32 (0 ms) [ RUN ] ChannelMatrix.ReadFloat [ OK ] ChannelMatrix.ReadFloat (0 ms) [ RUN ] ChannelMatrix.ReadDouble [ OK ] ChannelMatrix.ReadDouble (1 ms) [ RUN ] ChannelMatrix.WriteInt8 [ OK ] ChannelMatrix.WriteInt8 (0 ms) [ RUN ] ChannelMatrix.WriteInt16 [ OK ] ChannelMatrix.WriteInt16 (1 ms) [ RUN ] ChannelMatrix.WriteInt24 [ OK ] ChannelMatrix.WriteInt24 (0 ms) [ RUN ] ChannelMatrix.WriteInt32 [ OK ] ChannelMatrix.WriteInt32 (1 ms) [ RUN ] ChannelMatrix.WriteFloat [ OK ] ChannelMatrix.WriteFloat (1 ms) [ RUN ] ChannelMatrix.WriteDouble [ OK ] ChannelMatrix.WriteDouble (0 ms) [--] 12 tests from ChannelMatrix (5 ms total) [--] Global test environment tear-down [==] 12 tests from 1 test case ran. (29 ms total) [ PASSED ] 12 tests. PASS: channelmatrix [==] Running 12 tests from 12 test cases. [--] Global test environment set-up. [--] 1 test from Data [ RUN ] Data.Null [ OK ] Data.Null (0 ms) [--] 1 test from Data (0 ms total) [--] 1 test from Channels [ RUN ] Channels.Null [ OK ] Channels.Null (0 ms) [--] 1 test from Channels (0 ms total) [--] 1 test from Rate [ RUN ] Rate.Null [ OK ] Rate.Null (0 ms) [--] 1 test from Rate (0 ms total) [--] 1 test from Compression [ RUN ] Compression.Null [ OK ] Compression.Null (0 ms) [--] 1 test from Compression (0 ms total) [--] 1 test from SampleFormat [ RUN ] SampleFormat.Null [ OK ] SampleFormat.Null (0 ms) [--] 1 test from SampleFormat (1 ms total) [--] 1 test from ByteOrder [ RUN ] ByteOrder.Null [ OK ] ByteOrder.Null (0 ms) [--] 1 test from ByteOrder (0 ms total) [--] 1 test from DataOffset [ RUN ] DataOffset.Null [ OK ] DataOffset.Null (0 ms) [--] 1 test from DataOffset (0 ms total) [--] 1 test from FrameCount [ RUN ] FrameCount.Null [ OK ] FrameCount.Null (0 ms) [--] 1 test from FrameCount (1 ms total) [--] 1 test from AES [ RUN ] AES.Null [ OK ] AES.Null (0 ms) [--] 1 test from AES (0 ms total) [--] 1 test from Setup [ RUN ] Setup.Null [ OK ] Setup.Null (0 ms) [--] 1 test from Setup (0 ms total) [--] 1 test from File [ RUN ] File.Bad [ OK ] File.Bad (1 ms) [--] 1 test from File (1 ms total) [--] 1 test from Query [ RUN ] Query.Bad [ OK ] Query.Bad (0 ms) [--] 1 test from Query (0 ms total) [--] Global test environment tear-down [==] 12 tests from 12 test cases ran. (4 ms total) [ PASSED ] 12 tests. PASS: error PASS: floatto24 [==] Running 4 tests from 1 test case. [--] Global test environment set-up. [--] 4 tests from FloatToIntTest [ RUN ] FloatToIntTest.Int8 [ OK ] FloatToIntTest.Int8 (0 ms) [ RUN ] FloatToIntTest.Int16 [ OK ] FloatToIntTest.Int16 (0 ms) [ RUN ] FloatToIntTest.Int24 [ OK ] FloatToIntTest.Int24 (1 ms) [ RUN ] FloatToIntTest.Int32 [ OK ] FloatToIntTest.Int32 (0 ms) [--] 4 tests from FloatToIntTest (1 ms total) [--] Global test environment tear-down [==] 4 tests from 1 test case ran. (2 ms total) [ PASSED ] 4 tests. PASS: floattoint [==] Running 4 tests from 1 test case. [--] Global test environment set-up. [--] 4 tests from IntToFloatTest [ RUN ] IntToFloatTest.Int8 [ OK ] IntToFloatTest.Int8 (0 ms) [ RUN ] IntToFloatTest.Int16 [ OK ] IntToFloatTest.Int16 (0 ms) [ RUN ]
