Bug#688603: mlterm: diff for NMU version 3.1.2-1.2
Hi Ahmed On Mon, Oct 01, 2012 at 01:31:01AM +0200, أحمد المحمودي wrote: On Sat, Sep 29, 2012 at 08:55:18AM +0200, Sven Joachim wrote: case $1 in install|upgrade) if dpkg --compare-versions $2 lt 3.0.9 ; then People who had already upgraded from earlier versions will still have an empty directory, so the version should be adjusted. rmdir /usr/share/doc/mlterm The directory is not guaranteed to be empty at this time. Also, you want to protect this with || true to make the script idempotent (see Policy §6.2). ---end quoted text--- Thanks for your comments, I fixed the above issues in the attached script (still not tested). Any news on this? Regards, Salvatore signature.asc Description: Digital signature
Bug#688603: mlterm: diff for NMU version 3.1.2-1.2
Hello, On Tue, Oct 30, 2012 at 07:39:37AM +0100, Salvatore Bonaccorso wrote: Any news on this? ---end quoted text--- The fix is committed to git: http://anonscm.debian.org/gitweb/?p=collab-maint/mlterm.git;a=commit;h=732766172c77c36bf03c3281065f6eea51c60451 -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 signature.asc Description: Digital signature
Bug#688604: Bug#688603: mlterm: diff for NMU version 3.1.2-1.2
On Sat, Sep 29, 2012 at 08:55:18AM +0200, Sven Joachim wrote: case $1 in install|upgrade) if dpkg --compare-versions $2 lt 3.0.9 ; then People who had already upgraded from earlier versions will still have an empty directory, so the version should be adjusted. rmdir /usr/share/doc/mlterm The directory is not guaranteed to be empty at this time. Also, you want to protect this with || true to make the script idempotent (see Policy §6.2). ---end quoted text--- Thanks for your comments, I fixed the above issues in the attached script (still not tested). -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 #!/bin/sh set -e case $1 in install|upgrade) if dpkg --compare-versions $2 lt 3.1.2-1.1 ; then rm -rf /usr/share/doc/mlterm || true fi ;; abort-upgrade) ;; *) echo preinst called with unknown argument \`$1' 2 exit 1 ;; esac #DEBHELPER# exit 0 signature.asc Description: Digital signature
Bug#688603: mlterm: diff for NMU version 3.1.2-1.2
Hey Ahmed and Kenshi On Fri, Sep 28, 2012 at 08:25:28AM +0200, أحمد المحمودي wrote: On Fri, Sep 28, 2012 at 08:54:30AM +0900, Kenshi Muto wrote: mlterm is mostly maintained by Ahmed. Ahmed, could you tell me what you think about? ---end quoted text--- Well, it is the same fix that was done in 3.1.2-1.1 for mlterm mlterm.tiny Yet I think it is better to do the fix in .preinst instead of .postinst as the file attached. Note that I didn't test that fix yet. Thanks for your reply Ahmed. Yes I think you are correct and your solution should works too correctly (untested your solution). Only thinking aloud: Would it be safer to check in addition against current version in wheezy, for the already happened updates for people who did Squeeze - current Testing, and if we still have empty directories where should be symlinks to mlterm-common replace them? Thanks for your work! Regards, Salvatore signature.asc Description: Digital signature
Bug#688603: mlterm: diff for NMU version 3.1.2-1.2
On 2012-09-28 08:25 +0200, أحمد المحمودي wrote: On Fri, Sep 28, 2012 at 08:54:30AM +0900, Kenshi Muto wrote: mlterm is mostly maintained by Ahmed. Ahmed, could you tell me what you think about? Well, it is the same fix that was done in 3.1.2-1.1 for mlterm mlterm.tiny Yet I think it is better to do the fix in .preinst instead of .postinst as the file attached. Note that I didn't test that fix yet. I am afraid that your proposed fix will not work correctly. #!/bin/sh set -e case $1 in install|upgrade) if dpkg --compare-versions $2 lt 3.0.9 ; then People who had already upgraded from earlier versions will still have an empty directory, so the version should be adjusted. rmdir /usr/share/doc/mlterm The directory is not guaranteed to be empty at this time. Also, you want to protect this with || true to make the script idempotent (see Policy §6.2). Cheers, Sven -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#688603: mlterm: diff for NMU version 3.1.2-1.2
On Fri, Sep 28, 2012 at 08:54:30AM +0900, Kenshi Muto wrote: mlterm is mostly maintained by Ahmed. Ahmed, could you tell me what you think about? ---end quoted text--- Well, it is the same fix that was done in 3.1.2-1.1 for mlterm mlterm.tiny Yet I think it is better to do the fix in .preinst instead of .postinst as the file attached. Note that I didn't test that fix yet. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0xEDDDA1B7 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 #!/bin/sh set -e case $1 in install|upgrade) if dpkg --compare-versions $2 lt 3.0.9 ; then rmdir /usr/share/doc/mlterm fi ;; abort-upgrade) ;; *) echo preinst called with unknown argument \`$1' 2 exit 1 ;; esac #DEBHELPER# exit 0 signature.asc Description: Digital signature
Bug#688603: mlterm: diff for NMU version 3.1.2-1.2
Hi, mlterm is mostly maintained by Ahmed. Ahmed, could you tell me what you think about? At Thu, 27 Sep 2012 19:27:36 +0200, Salvatore Bonaccorso wrote: [1 multipart/mixed (7bit)] [1.1 text/plain; us-ascii (7bit)] Control: tags 688603 + patch Control: tags 688604 + patch Control: tags 688605 + patch Control: tags 688606 + patch Hi Kenshi The attached debdiff should fix this issue and is following the 'standard' procedure on lastly discovered policy 12.5 violation bugs. Do you have time to do the upload or are you fine with me doing a NMU upload? -- Kenshi Muto km...@debian.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
