Bug#689894: Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2)
Package: jabber-muc Version: 0.8-3 Severity: serious Tags: patch Dear Maintainer, Andreas Beckmann deb...@abeckmann.de reported in -devel that your package (as well as 27 others) ships a folder either in /var/run or /var/lock. This is forbidden by policy. Lintian detects the problem and warns as follow: /var/run may be a temporary filesystem, so any directories or files needed /there must be created dynamically at boot time. Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for details. Severity: serious, Certainty: possible Check: files, Type: binary, udeb which is why I am reporting this bug with severity serious (and there fore, release critical). Please fix your package. I have attached what I believe is a good fix the problem, however, I haven't tried it, and I haven't tested if something more for creating the necessary folder at runtime should be added. Please make sure to test before applying the patch blindly. Cheers, Thomas Goirand (zigo) Missing: runtime creation of /var/run/jabberd2 + chmod 755 / chown jabber:jabber diff -u jabber-muc-0.8/debian/dirs jabber-muc-0.8/debian/dirs --- jabber-muc-0.8/debian/dirs +++ jabber-muc-0.8/debian/dirs @@ -4,5 +4,4 @@ etc/jabberd2/component.d var/log/jabberd2 -var/run/jabberd2 var/spool/jabber-muc/rooms var/spool/jabber-muc/rooms-logs diff -u jabber-muc-0.8/debian/postinst jabber-muc-0.8/debian/postinst --- jabber-muc-0.8/debian/postinst +++ jabber-muc-0.8/debian/postinst @@ -14,8 +14,6 @@ chmod 750 /etc/jabberd2 chown jabber:jabber /var/log/jabberd2 chmod 750 /var/log/jabberd2 -chown jabber:jabber /var/run/jabberd2 -chmod 755 /var/run/jabberd2 ;; abort-upgrade|abort-remove|abort-deconfigure) diff -u jabber-muc-0.8/debian/postrm jabber-muc-0.8/debian/postrm --- jabber-muc-0.8/debian/postrm +++ jabber-muc-0.8/debian/postrm @@ -7,7 +7,7 @@ # remove the user database rm -f /var/spool/jabber-muc/rooms/* # the application should remove these on exit -rm -f /var/run/jabberd2/muc.pid +rm -f /var/run/jabberd2/* # need better way of detecting whether these exist or not rm -f /var/log/jabberd2/mu-conference.log* # remove any empty directories diff -u jabber-muc-0.8/debian/changelog jabber-muc-0.8/debian/changelog --- jabber-muc-0.8/debian/changelog +++ jabber-muc-0.8/debian/changelog @@ -1,3 +1,10 @@ +jabber-muc (0.8-3.1) unstable; urgency=low + + * Non-maintainer upload. + * Do not ship /var/run/jabberd2 in the package (Closes: #XX). + + -- Thomas Goirand z...@debian.org Sat, 06 Oct 2012 18:28:00 +0800 + jabber-muc (0.8-3) unstable; urgency=low * jabberd2-muc.xml:
Bug#689894: Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2)
tags 689894 - patch thanks On 07/10/2012 17:06, Thomas Goirand wrote: Please fix your package. I have attached what I believe is a good fix the problem, however, I haven't tried it, and I haven't tested if something more for creating the necessary folder at runtime should be added. Please make sure to test before applying the patch blindly. Can you please explain how your patch fixes the problem? AFAICS, you don't re-create /var/run/jabberd2 anywhere. Regards, -- Mehdi Dogguy مهدي الدڤي -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#689894: Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2)
On 10/08/2012 12:19 AM, Mehdi Dogguy wrote: tags 689894 - patch thanks On 07/10/2012 17:06, Thomas Goirand wrote: Please fix your package. I have attached what I believe is a good fix the problem, however, I haven't tried it, and I haven't tested if something more for creating the necessary folder at runtime should be added. Please make sure to test before applying the patch blindly. Can you please explain how your patch fixes the problem? AFAICS, you don't re-create /var/run/jabberd2 anywhere. Regards, Right. for this one. I haven't find out yet where to add the creation of the run dir for at least 2 packages. As I couldn't remember which package were needed it, this is why I wrote the last paragraph, telling that it should be checked (eg: packages should be installed and run at least once, which by the way is always a good idea). Thomas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#689894: Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2)
On 07/10/2012 19:07, Thomas Goirand wrote: On 10/08/2012 12:19 AM, Mehdi Dogguy wrote: tags 689894 - patch thanks On 07/10/2012 17:06, Thomas Goirand wrote: Please fix your package. I have attached what I believe is a good fix the problem, however, I haven't tried it, and I haven't tested if something more for creating the necessary folder at runtime should be added. Please make sure to test before applying the patch blindly. Can you please explain how your patch fixes the problem? AFAICS, you don't re-create /var/run/jabberd2 anywhere. Right. for this one. Not only… I haven't find out yet where to add the creation of the run dir for at least 2 packages. As I couldn't remember which package were needed it. Then do not add patch tag where there is no patch. Regards, -- Mehdi Dogguy مهدي الدڤي -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
