Bug#694077: Package review

[Jérôme Lebleu]

Hi Lisandro,

Le 25/08/2019 à 17:33, Lisandro Damián Nicanor Pérez Meyer a écrit :
> On Sun, 25 Aug 2019 at 12:26, Lisandro Damián Nicanor Pérez Meyer
>  wrote:
> [snip]
>>
>> Mmm, I'm not entirely sure if the code in plugins/hid is
>> DFSG-compliant. It's license it's too lax. I think I'll upload it non
>> the less in the meantime, and see what FTP masters think.
> 
> Better yet, I looked for previous art within Debian and found:
> 
> 
> 
> And more specifiically:
> 
> 
> 
> As you can see the license is much clearer there. This is something
> that must be solved before uploading. Ideally by fixing it upstream,
> but a patch might do the work in the meantime.

Thanks a lot for your report and your research. I have submitted a patch
that Massimo has already merged! He also just published a new release
which includes it - and other patches. It is just the perfect timing!

Moreover, he also opened an issue to discuss about the Debian packaging
and tell some things to change for cross-compiling here:

  https://github.com/mcallegari/qlcplus/issues/1191.

Also, the ola plugin is currently not integrated but I plan to have a
look after this first release. Is it okay for you?

I have successfully build the package for 4.12.2 and so released and
pushed it. I let you have a look and upload it if everything looks fine!

Cheers,

Jérôme

Bug#694077: Package review

[Lisandro Damián Nicanor Pérez Meyer]

On Sun, 25 Aug 2019 at 12:26, Lisandro Damián Nicanor Pérez Meyer
 wrote:
[snip]
>
> Mmm, I'm not entirely sure if the code in plugins/hid is
> DFSG-compliant. It's license it's too lax. I think I'll upload it non
> the less in the meantime, and see what FTP masters think.

Better yet, I looked for previous art within Debian and found:



And more specifiically:



As you can see the license is much clearer there. This is something
that must be solved before uploading. Ideally by fixing it upstream,
but a patch might do the work in the meantime.

Cheers, Lisandro.

-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Bug#694077: Package review

[Lisandro Damián Nicanor Pérez Meyer]

If you go for the patch approach add a Comment field in the copyright
file, so reviewers know what to expect-.

On Sun, 25 Aug 2019 at 12:33, Lisandro Damián Nicanor Pérez Meyer
 wrote:
>
> On Sun, 25 Aug 2019 at 12:26, Lisandro Damián Nicanor Pérez Meyer
>  wrote:
> [snip]
> >
> > Mmm, I'm not entirely sure if the code in plugins/hid is
> > DFSG-compliant. It's license it's too lax. I think I'll upload it non
> > the less in the meantime, and see what FTP masters think.
>
> Better yet, I looked for previous art within Debian and found:
>
> 
>
> And more specifiically:
>
> 
>
> As you can see the license is much clearer there. This is something
> that must be solved before uploading. Ideally by fixing it upstream,
> but a patch might do the work in the meantime.
>
> Cheers, Lisandro.
>
> --
> Lisandro Damián Nicanor Pérez Meyer
> http://perezmeyer.com.ar/
> http://perezmeyer.blogspot.com/



-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Bug#694077: Package review

[Lisandro Damián Nicanor Pérez Meyer]

Hi!

On Sun, 25 Aug 2019 at 06:22, Jérôme Lebleu  wrote:
>
> Le 24/08/2019 à 22:26, Lisandro Damián Nicanor Pérez Meyer a écrit :
> > please release it (dch -r), push it and I'll upload.
>
> It is now done and pushed, thanks in advance!
>
> I tried again to build the package and didn't have any failure this
> time. The one that didn't pass was at this line:
>
>
> https://github.com/mcallegari/qlcplus/blob/QLC+_4.12.1/engine/test/mastertimer/mastertimer_test.cpp#L197
>
> We will see if this test fails on the Debian build system too. In that
> case, we will maybe have to add DEFINES+=SKIP_TEST as it is done when
> travis is used:
>
>
> https://github.com/mcallegari/qlcplus/blob/QLC%2B_4.12.1/engine/test/mastertimer/mastertimer.pro#L18
>
> I should ask Massimo in that case since this variable name can be ambiguous.

Mmm, I'm not entirely sure if the code in plugins/hid is
DFSG-compliant. It's license it's too lax. I think I'll upload it non
the less in the meantime, and see what FTP masters think.

-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Bug#694077: Package review

[Jérôme Lebleu]

Le 24/08/2019 à 22:26, Lisandro Damián Nicanor Pérez Meyer a écrit :
> please release it (dch -r), push it and I'll upload.

It is now done and pushed, thanks in advance!

I tried again to build the package and didn't have any failure this
time. The one that didn't pass was at this line:


https://github.com/mcallegari/qlcplus/blob/QLC+_4.12.1/engine/test/mastertimer/mastertimer_test.cpp#L197

We will see if this test fails on the Debian build system too. In that
case, we will maybe have to add DEFINES+=SKIP_TEST as it is done when
travis is used:


https://github.com/mcallegari/qlcplus/blob/QLC%2B_4.12.1/engine/test/mastertimer/mastertimer.pro#L18

I should ask Massimo in that case since this variable name can be ambiguous.

Bug#694077: Package review

[Lisandro Damián Nicanor Pérez Meyer]

please release it (dch -r), push it and I'll upload.

On Tue, 20 Aug 2019 at 09:07, Lisandro Damián Nicanor Pérez Meyer
 wrote:
>
> Hi!
>
> El mar., 20 ago. 2019 05:35, Jérôme Lebleu  escribió:
>>
>> Hi Lisandro,
>>
>> I am happy to read from you!
>>
>> Le 19/08/2019 à 21:42, Lisandro Damián Nicanor Pérez Meyer a écrit :
>> > I'm afraid it's failing to build from source:
>> >
>> > x86_64-linux-gnu/qt5 -isystem 
>> > /usr/include/x86_64-linux-gnu/qt5/QtMultimedia -isystem 
>> > /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem 
>> > /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem 
>> > /usr/include/x86_64-linux-gnu/qt5/QtScript -isystem 
>> > /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -isystem /usr/include/libdrm 
>> > -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o qlcfixturedefcache.o 
>> > qlcfixturedefcache.cpp
>> > qlcfixturedef.cpp: In member function ‘QLCPhysical 
>> > QLCFixtureDef::physical() const’:
>> > qlcfixturedef.cpp:342:12: error: implicitly-declared 
>> > ‘QLCPhysical::QLCPhysical(const QLCPhysical&)’ is deprecated 
>> > [-Werror=deprecated-copy]
>> >   342 | return m_physical;
>> >   |^~
>> > In file included from qlcfixturedef.h:28,
>> >  from qlcfixturemode.h:29,
>> >  from qlcfixturedef.cpp:28:
>> > qlcphysical.h:78:18: note: because ‘QLCPhysical’ has user-provided 
>> > ‘QLCPhysical& QLCPhysical::operator=(const QLCPhysical&)’
>> >78 | QLCPhysical& operator=(const QLCPhysical& physical);
>> >   |  ^~~~
>> > cc1plus: all warnings being treated as errors
>> > make[3]: *** [Makefile:1206: qlcfixturedef.o] Error 1
>> > make[3]: *** Waiting for unfinished jobs
>> > make[3]: Leaving directory '/<>/engine/src'
>> > make[2]: *** [Makefile:90: sub-src-make_first-ordered] Error 2
>> > make[2]: Leaving directory '/<>/engine'
>> > make[1]: *** [Makefile:96: sub-engine-make_first-ordered] Error 2
>> > make[1]: Leaving directory '/<>'
>> > dh_auto_build: make -j2 returned exit code 2
>> > make: *** [debian/rules:14: build] Error 255
>> > dpkg-buildpackage: error: debian/rules build subprocess returned exit 
>> > status 2
>> > 
>> > Build finished at 2019-08-19T19:38:24Z
>> >
>> >
>> > Could it be the switch to gcc-9?
>>
>> Thanks for your report, I have just discovered that yesterday too. Yes
>> it should be the switch to gcc-9 as there were no errors before... I
>> have added -Wno-error=deprecated-copy for the moment to makes this
>> warnings not be errors. I will take the time as soon as possible to
>> report it upstream, if it is not meanwhile fixed. Is it also okay for a
>> first upload too?
>
>
> I think it is.



-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Bug#694077: Package review

[Lisandro Damián Nicanor Pérez Meyer]

Hi!

El mar., 20 ago. 2019 05:35, Jérôme Lebleu  escribió:

> Hi Lisandro,
>
> I am happy to read from you!
>
> Le 19/08/2019 à 21:42, Lisandro Damián Nicanor Pérez Meyer a écrit :
> > I'm afraid it's failing to build from source:
> >
> > x86_64-linux-gnu/qt5 -isystem
> /usr/include/x86_64-linux-gnu/qt5/QtMultimedia -isystem
> /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem
> /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem
> /usr/include/x86_64-linux-gnu/qt5/QtScript -isystem
> /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -isystem /usr/include/libdrm
> -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o qlcfixturedefcache.o
> qlcfixturedefcache.cpp
> > qlcfixturedef.cpp: In member function ‘QLCPhysical
> QLCFixtureDef::physical() const’:
> > qlcfixturedef.cpp:342:12: error: implicitly-declared
> ‘QLCPhysical::QLCPhysical(const QLCPhysical&)’ is deprecated
> [-Werror=deprecated-copy]
>
> >   342 | return m_physical;
> >   |^~
> > In file included from qlcfixturedef.h:28,
> >  from qlcfixturemode.h:29,
> >  from qlcfixturedef.cpp:28:
> > qlcphysical.h:78:18: note: because ‘QLCPhysical’ has user-provided
> ‘QLCPhysical& QLCPhysical::operator=(const QLCPhysical&)’
>
> >78 | QLCPhysical& operator=(const QLCPhysical& physical);
> >   |  ^~~~
> > cc1plus: all warnings being treated as errors
> > make[3]: *** [Makefile:1206: qlcfixturedef.o] Error 1
> > make[3]: *** Waiting for unfinished jobs
> > make[3]: Leaving directory '/<>/engine/src'
> > make[2]: *** [Makefile:90: sub-src-make_first-ordered] Error 2
> > make[2]: Leaving directory '/<>/engine'
> > make[1]: *** [Makefile:96: sub-engine-make_first-ordered] Error 2
> > make[1]: Leaving directory '/<>'
> > dh_auto_build: make -j2 returned exit code 2
> > make: *** [debian/rules:14: build] Error 255
> > dpkg-buildpackage: error: debian/rules build subprocess returned exit
> status 2
> >
> 
> > Build finished at 2019-08-19T19:38:24Z
> >
> >
> > Could it be the switch to gcc-9?
>
> Thanks for your report, I have just discovered that yesterday too. Yes
> it should be the switch to gcc-9 as there were no errors before... I
> have added -Wno-error=deprecated-copy for the moment to makes this
> warnings not be errors. I will take the time as soon as possible to
> report it upstream, if it is not meanwhile fixed. Is it also okay for a
> first upload too?
>

I think it is.

>

Bug#694077: Package review

[Jérôme Lebleu]

Hi Lisandro,

I am happy to read from you!

Le 19/08/2019 à 21:42, Lisandro Damián Nicanor Pérez Meyer a écrit :
> I'm afraid it's failing to build from source:
> 
> x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtMultimedia 
> -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem 
> /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem 
> /usr/include/x86_64-linux-gnu/qt5/QtScript -isystem 
> /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -isystem /usr/include/libdrm 
> -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o qlcfixturedefcache.o 
> qlcfixturedefcache.cpp 
> qlcfixturedef.cpp: In member function ‘QLCPhysical QLCFixtureDef::physical() 
> const’:
> qlcfixturedef.cpp:342:12: error: implicitly-declared 
> ‘QLCPhysical::QLCPhysical(const QLCPhysical&)’ is deprecated 
> [-Werror=deprecated-copy] 
>  
>   342 | return m_physical;
>   |^~
> In file included from qlcfixturedef.h:28,
>  from qlcfixturemode.h:29,
>  from qlcfixturedef.cpp:28:
> qlcphysical.h:78:18: note: because ‘QLCPhysical’ has user-provided 
> ‘QLCPhysical& QLCPhysical::operator=(const QLCPhysical&)’ 
> 
>78 | QLCPhysical& operator=(const QLCPhysical& physical);
>   |  ^~~~
> cc1plus: all warnings being treated as errors
> make[3]: *** [Makefile:1206: qlcfixturedef.o] Error 1
> make[3]: *** Waiting for unfinished jobs
> make[3]: Leaving directory '/<>/engine/src'
> make[2]: *** [Makefile:90: sub-src-make_first-ordered] Error 2
> make[2]: Leaving directory '/<>/engine'
> make[1]: *** [Makefile:96: sub-engine-make_first-ordered] Error 2
> make[1]: Leaving directory '/<>'
> dh_auto_build: make -j2 returned exit code 2
> make: *** [debian/rules:14: build] Error 255
> dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
> 
> Build finished at 2019-08-19T19:38:24Z
> 
> 
> Could it be the switch to gcc-9? 

Thanks for your report, I have just discovered that yesterday too. Yes
it should be the switch to gcc-9 as there were no errors before... I
have added -Wno-error=deprecated-copy for the moment to makes this
warnings not be errors. I will take the time as soon as possible to
report it upstream, if it is not meanwhile fixed. Is it also okay for a
first upload too?

Cheers,

Jérôme

Bug#694077: Package review

[Lisandro Damián Nicanor Pérez Meyer]

I'm afraid it's failing to build from source:

x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtMultimedia 
-isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem 
/usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem 
/usr/include/x86_64-linux-gnu/qt5/QtScript -isystem 
/usr/include/x86_64-linux-gnu/qt5/QtCore -I. -isystem /usr/include/libdrm 
-I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o qlcfixturedefcache.o 
qlcfixturedefcache.cpp 
qlcfixturedef.cpp: In member function ‘QLCPhysical QLCFixtureDef::physical() 
const’:
qlcfixturedef.cpp:342:12: error: implicitly-declared 
‘QLCPhysical::QLCPhysical(const QLCPhysical&)’ is deprecated 
[-Werror=deprecated-copy]   
   
  342 | return m_physical;
  |^~
In file included from qlcfixturedef.h:28,
 from qlcfixturemode.h:29,
 from qlcfixturedef.cpp:28:
qlcphysical.h:78:18: note: because ‘QLCPhysical’ has user-provided 
‘QLCPhysical& QLCPhysical::operator=(const QLCPhysical&)’   
  
   78 | QLCPhysical& operator=(const QLCPhysical& physical);
  |  ^~~~
cc1plus: all warnings being treated as errors
make[3]: *** [Makefile:1206: qlcfixturedef.o] Error 1
make[3]: *** Waiting for unfinished jobs
make[3]: Leaving directory '/<>/engine/src'
make[2]: *** [Makefile:90: sub-src-make_first-ordered] Error 2
make[2]: Leaving directory '/<>/engine'
make[1]: *** [Makefile:96: sub-engine-make_first-ordered] Error 2
make[1]: Leaving directory '/<>'
dh_auto_build: make -j2 returned exit code 2
make: *** [debian/rules:14: build] Error 255
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

Build finished at 2019-08-19T19:38:24Z


Could it be the switch to gcc-9? 

Bug#694077: Package review

[Lisandro Damián Nicanor Pérez Meyer]

On 19/08/13 11:06, Jérôme Lebleu wrote:
> Hi Lisandro,
> 
> Thanks a lot for your review and all your advice! It gives me more
> motivation to follow through this package.

Great! I've looked into the changes and really liked what I saw :-)
 
> On Sat, 3 Aug 2019 23:27:28 -0300 Lisandro Damián Nicanor Pérez Meyer
>  wrote:
> > = debian/changelog
> > 
> > As it's the first upload the only line really needed is:
> > 
> > * Initial release (Closes: #694077)
> 
> It's done.
> 
> > = debian/patches
> > 
> > Why are you disabling patches? The patch description is not clear
> > about it. I had to read debian/rules to know why :-)
> > 
> > Try this:
> > 
> > override_dh_auto_test-arch:
> > xvfb-run -a -s "-screen 0 1024x768x24 +extension RANDR
> > +extension RENDER +extension GLX +extension EGL" \
> > dh_auto_test --max-parallel=1 --
> > QT_PLUGIN_PATH=$(CURDIR)/plugins QML2_IMPORT_PATH=$(CURDIR)/qml
> > 
> > The Qt5 version seems to use QML so the above should work. This comes
> > from qt3d's debian/rules.
> > 
> > After that override the -indep target:
> > 
> > override_dh_auto_test-indep:
> > 
> > 
> > And leave no commands in it. This is because this package does not
> > seems to have testes for arch:all binary packages (I might be wrong
> > though).
> 
> I have try to understand all of this first, so I went step by step and I
> succeed to pass the tests with only:
> 
> override_dh_auto_test-arch:
>   xvfb-run -a dh_auto_test
> 
> More work was needed, I let you review it at
> https://salsa.debian.org/jlebleu-guest/qlcplus/commit/54a466af5361321638350cbf8ee2ba2a2893c30d.

Looks good, I'll be compiling it hopeully today.

> > = debian/copyright
> > 
> > Massimo Callegari's copyright should go at least up to 2018:
> > 
> >2012-2018 Massimo Callegari 
> > 
> > You are missing many copyright entries and licenses. Please start with:
> > 
> > grep -iRn copyright *
> > 
> > in the project's root directory. You will find many people nott yest listed.
> 
> Indeed!... I have tried to add all missing entries.
> 
> I also try to fix all other warnings reported by lintian. There are
> still some Info however:
> 
>  * I: qlcplus: hardening-no-fortify-functions
> usr/lib/x86_64-linux-gnu/qt5/plugins/qlcplus/libmidiplugin.so
> 
>I would say that it is a false-positive since it is the only one but
> I don't know enough to be sure. What do you think?

We can start by leaving it as it is.

>  * I: qlcplus: desktop-entry-lacks-keywords-entry
> usr/share/applications/qlcplus-fixtureeditor.desktop
>I: qlcplus: desktop-entry-lacks-keywords-entry
> usr/share/applications/qlcplus.desktop
> 
>I will see to purpose a patch upstream first.

Great. Also not strictly necessary for a fir upload.

> Finally, I have - at least - ask to be the owner of this bug as Wouter
> was okay with that.
> 
> > Feel free to ping me for sponsorship!!!
> 
> Thanks for your proposal, I am really interested in! In fact, I first
> ask a friend of mine, with whom I try to maintain another package, but
> he seems quite busy with many other projects. Moreover, having the
> sponsor of someone else can only be enriching.

Great!

Bug#694077: Package review

[Jérôme Lebleu]

Hi Lisandro,

Thanks a lot for your review and all your advice! It gives me more
motivation to follow through this package.

On Sat, 3 Aug 2019 23:27:28 -0300 Lisandro Damián Nicanor Pérez Meyer
 wrote:
> = debian/changelog
> 
> As it's the first upload the only line really needed is:
> 
> * Initial release (Closes: #694077)

It's done.

> = debian/patches
> 
> Why are you disabling patches? The patch description is not clear
> about it. I had to read debian/rules to know why :-)
> 
> Try this:
> 
> override_dh_auto_test-arch:
> xvfb-run -a -s "-screen 0 1024x768x24 +extension RANDR
> +extension RENDER +extension GLX +extension EGL" \
> dh_auto_test --max-parallel=1 --
> QT_PLUGIN_PATH=$(CURDIR)/plugins QML2_IMPORT_PATH=$(CURDIR)/qml
> 
> The Qt5 version seems to use QML so the above should work. This comes
> from qt3d's debian/rules.
> 
> After that override the -indep target:
> 
> override_dh_auto_test-indep:
> 
> 
> And leave no commands in it. This is because this package does not
> seems to have testes for arch:all binary packages (I might be wrong
> though).

I have try to understand all of this first, so I went step by step and I
succeed to pass the tests with only:

override_dh_auto_test-arch:
xvfb-run -a dh_auto_test

More work was needed, I let you review it at
https://salsa.debian.org/jlebleu-guest/qlcplus/commit/54a466af5361321638350cbf8ee2ba2a2893c30d.

> = debian/copyright
> 
> Massimo Callegari's copyright should go at least up to 2018:
> 
>2012-2018 Massimo Callegari 
> 
> You are missing many copyright entries and licenses. Please start with:
> 
> grep -iRn copyright *
> 
> in the project's root directory. You will find many people nott yest listed.

Indeed!... I have tried to add all missing entries.

I also try to fix all other warnings reported by lintian. There are
still some Info however:

 * I: qlcplus: hardening-no-fortify-functions
usr/lib/x86_64-linux-gnu/qt5/plugins/qlcplus/libmidiplugin.so

   I would say that it is a false-positive since it is the only one but
I don't know enough to be sure. What do you think?

 * I: qlcplus: desktop-entry-lacks-keywords-entry
usr/share/applications/qlcplus-fixtureeditor.desktop
   I: qlcplus: desktop-entry-lacks-keywords-entry
usr/share/applications/qlcplus.desktop

   I will see to purpose a patch upstream first.

Finally, I have - at least - ask to be the owner of this bug as Wouter
was okay with that.

> Feel free to ping me for sponsorship!!!

Thanks for your proposal, I am really interested in! In fact, I first
ask a friend of mine, with whom I try to maintain another package, but
he seems quite busy with many other projects. Moreover, having the
sponsor of someone else can only be enriching.

Cheers,

Jérôme

Bug#694077: Package review

[Lisandro Damián Nicanor Pérez Meyer]

On Sat, 3 Aug 2019 at 23:30, Lisandro Damián Nicanor Pérez Meyer
 wrote:
>
> = debian/changelog
>
> As it's the first upload the only line really needed is:
>
> * Initial release (Closes: #694077)
>
> = debian/patches
>
> Why are you disabling patches? The patch description is not clear
> about it. I had to read debian/rules to know why :-)
>
> Try this:
>
> override_dh_auto_test-arch:
> xvfb-run -a -s "-screen 0 1024x768x24 +extension RANDR
> +extension RENDER +extension GLX +extension EGL" \
> dh_auto_test --max-parallel=1 --
> QT_PLUGIN_PATH=$(CURDIR)/plugins QML2_IMPORT_PATH=$(CURDIR)/qml
>
> The Qt5 version seems to use QML so the above should work. This comes
> from qt3d's debian/rules.

And of course, you need more build dependencies, namely:

xauth ,
xvfb ,

Extre tip: this is totally up to you, but I certainly like what
devscripts' wrap-and-sort does :-) Try it out!



-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/

Bug#694077: Package review

[Lisandro Damián Nicanor Pérez Meyer]

= debian/changelog

As it's the first upload the only line really needed is:

* Initial release (Closes: #694077)

= debian/patches

Why are you disabling patches? The patch description is not clear
about it. I had to read debian/rules to know why :-)

Try this:

override_dh_auto_test-arch:
xvfb-run -a -s "-screen 0 1024x768x24 +extension RANDR
+extension RENDER +extension GLX +extension EGL" \
dh_auto_test --max-parallel=1 --
QT_PLUGIN_PATH=$(CURDIR)/plugins QML2_IMPORT_PATH=$(CURDIR)/qml

The Qt5 version seems to use QML so the above should work. This comes
from qt3d's debian/rules.

After that override the -indep target:

override_dh_auto_test-indep:


And leave no commands in it. This is because this package does not
seems to have testes for arch:all binary packages (I might be wrong
though).

= debian/copyright

Massimo Callegari's copyright should go at least up to 2018:

   2012-2018 Massimo Callegari 

You are missing many copyright entries and licenses. Please start with:

grep -iRn copyright *

in the project's root directory. You will find many people nott yest listed.

Feel free to ping me for sponsorship!!!

Lisandro.

-- 
Lisandro Damián Nicanor Pérez Meyer
http://perezmeyer.com.ar/
http://perezmeyer.blogspot.com/