Bug#695500: d-i-n-i: #695500 is apparently a grub-mkimage (or debian-installer) bug
Control: severity -1 important Steven Chamberlain ste...@pyro.eu.org (2014-02-04): tags 695500 + moreinfo block 695500 by 711799 user debian-...@lists.debian.org usertags 695500 kfreebsd Not going to keep an RC bug tagged moreinfo for a month at serious severity, so downgrading. Mraw, KiBi. signature.asc Description: Digital signature
Bug#695500: d-i-n-i: #695500 is apparently a grub-mkimage (or debian-installer) bug
Steven Chamberlain ste...@pyro.eu.org (2014-02-04): Going from GRUB 2.00-18 to 2.00-22, I don't see error: variable `prefix' isn't set any more. It would be nice to know if the problem is still reproducible, although this is blocked by #711799 KiBi, please may I commit the attached change anyway (prompted by Colin Watson's suggestion in [0]) for the sake of clarity? Sure, please go ahead; thanks. Mraw, KiBi. signature.asc Description: Digital signature
Bug#695500: d-i-n-i: #695500 is apparently a grub-mkimage (or debian-installer) bug
tags 695500 + moreinfo block 695500 by 711799 user debian-...@lists.debian.org usertags 695500 kfreebsd thanks Going from GRUB 2.00-18 to 2.00-22, I don't see error: variable `prefix' isn't set any more. It would be nice to know if the problem is still reproducible, although this is blocked by #711799 KiBi, please may I commit the attached change anyway (prompted by Colin Watson's suggestion in [0]) for the sake of clarity? [0]: http://bugs.debian.org/695500#117 Thanks, Regards, -- Steven Chamberlain ste...@pyro.eu.org commit da4cf9db9bc674d1c9b6d8df9d8e6f1c99914d18 Author: Steven Chamberlain ste...@pyro.eu.org Date: Tue Feb 4 03:26:24 2014 + Remove gPXE workaround on kfreebsd and hurd The bug affecting gPXE was fixed already in GRUB 2.00 (as #635877) diff --git a/debian/changelog b/debian/changelog index 46c1a01..31a4bcc 100644 --- a/debian/changelog +++ b/debian/changelog @@ -12,6 +12,10 @@ debian-installer (201312xx) UNRELEASED; urgency=low * Add MIPS Octeon images. * Add MIPSEL Loongson 2E images. + [ Steven Chamberlain ] + * Remove gPXE workaround on kfreebsd and hurd (fixed already in +GRUB 2.00 as #635877) + -- Martin Michlmayr t...@cyrius.com Sat, 14 Dec 2013 10:13:09 + debian-installer (20131211) unstable; urgency=low diff --git a/build/config/hurd.cfg b/build/config/hurd.cfg index 21091fc..c2b82fe 100644 --- a/build/config/hurd.cfg +++ b/build/config/hurd.cfg @@ -114,14 +114,9 @@ arch_netboot_dir: fi # Generate grub2pxe - grub-mkimage -O i386-pc --prefix=(pxe)/$(NETBOOT_PATH) \ - -o $(TEMP_NETBOOT_DIR)/core.img \ + grub-mkimage -O i386-pc-pxe --prefix=(pxe)/$(NETBOOT_PATH) \ + -o $(TEMP_NETBOOT_DIR)/$(NETBOOT_PATH)/grub2pxe \ $(GRUB_MODULES) $(GRUB_MODULES_PXE) - # workaround a gPXE bug - sed -i -e 's/\x02\xb0\xad\x1b/\x03\xb0\xad\x1b/' $(TEMP_NETBOOT_DIR)/core.img - cat $(GRUB_MODDIR)/pxeboot.img $(TEMP_NETBOOT_DIR)/core.img \ - $(TEMP_NETBOOT_DIR)/$(NETBOOT_PATH)/grub2pxe - rm $(TEMP_NETBOOT_DIR)/core.img # This symlink is not strictly required, but it allows more usual # dhcp server setups to work without modification. diff --git a/build/config/kfreebsd.cfg b/build/config/kfreebsd.cfg index 080111a..e7baf9a 100644 --- a/build/config/kfreebsd.cfg +++ b/build/config/kfreebsd.cfg @@ -137,14 +137,9 @@ arch_netboot_dir: fi # Generate grub2pxe - grub-mkimage -O i386-pc --prefix=(pxe)/$(NETBOOT_PATH) \ - -o $(TEMP_NETBOOT_DIR)/core.img \ + grub-mkimage -O i386-pc-pxe --prefix=(pxe)/$(NETBOOT_PATH) \ + -o $(TEMP_NETBOOT_DIR)/$(NETBOOT_PATH)/grub2pxe \ $(GRUB_MODULES) $(GRUB_MODULES_PXE) - # workaround a gPXE bug - sed -i -e 's/\x02\xb0\xad\x1b/\x03\xb0\xad\x1b/' $(TEMP_NETBOOT_DIR)/core.img - cat $(GRUB_MODDIR)/pxeboot.img $(TEMP_NETBOOT_DIR)/core.img \ - $(TEMP_NETBOOT_DIR)/$(NETBOOT_PATH)/grub2pxe - rm $(TEMP_NETBOOT_DIR)/core.img # This symlink is not strictly required, but it allows more usual # dhcp server setups to work without modification.
Bug#695500: d-i-n-i: #695500 is apparently a grub-mkimage (or debian-installer) bug
On Sun, Oct 13, 2013 at 10:27:27PM +0200, Didier 'OdyX' Raboud wrote: I spent some more time debugging this RC bug by setting up my server and testing the PXE boot of kfreebsd-i386 on two different laptops; the results are: * the error: prefix is not set error always appears when using the wheezy grub2pxe; it also happens with the current sid grub2pxe [0]; * the resistance to this error apparently depends on the PXE implementation: - my acer Aspire One displays the error and then proceeds to displaying grub, then allowing the boot of the kfreebsd-i386 installer; - my ThinkPad X220 displays the error and stops; - kvm launched locally with [1] proceeds to grub; [0] http://http.debian.net/debian/dists/sid/main/installer-kfreebsd-i386/20130430/images/netboot/grub2pxe [1] kvm -m 256 -net nic -net - user,bootfile=/grub2pxe,tftp=/usr/lib/debian-installer/images/7.0/kfreebsd-amd64/gtk/ As debian-installer-netboot-images is only copying these files from the mirrors, I don't think it is the correct source package to track this bug. The above tests now make me think that this is either a problem of debian-installer calling grub-mkimage wrongly in build/config/kfreebsd.cfg or a bug in grub-mkimage not incorporating the prefix correctly when creating a PXE image. I was staring at this bug for the nth time, and noticed something. debian-installer is calling grub-mkimage with the i386-pc image type when building netboot images, the same way as it does when building CD images. This is very probably wrong; it should be using i386-pc-pxe instead. The difference between these image types is that i386-pc prefixes the image with diskboot.img, while i386-pc-pxe prefixes the image with pxeboot.img. The former tries to read core.img off the local hard disk, while the latter assumes that it's already been read into memory and just jumps to it. It is absolutely wrong to use i386-pc for an image that isn't installed to a local disk. I suspect that the reason everyone is terribly confused about reproducing this is that it will depend on what you happen to have installed on your local disk, as well as what KVM's PXE environment happens to provide as the drive reference. Could you try this patch and see if it helps? I'm betting that it will at least be much closer to functional. diff --git a/build/config/hurd.cfg b/build/config/hurd.cfg index 21091fc..a40a977 100644 --- a/build/config/hurd.cfg +++ b/build/config/hurd.cfg @@ -114,7 +114,7 @@ arch_netboot_dir: fi # Generate grub2pxe - grub-mkimage -O i386-pc --prefix=(pxe)/$(NETBOOT_PATH) \ + grub-mkimage -O i386-pc-pxe --prefix=(pxe)/$(NETBOOT_PATH) \ -o $(TEMP_NETBOOT_DIR)/core.img \ $(GRUB_MODULES) $(GRUB_MODULES_PXE) # workaround a gPXE bug diff --git a/build/config/kfreebsd.cfg b/build/config/kfreebsd.cfg index 080111a..1b05133 100644 --- a/build/config/kfreebsd.cfg +++ b/build/config/kfreebsd.cfg @@ -137,7 +137,7 @@ arch_netboot_dir: fi # Generate grub2pxe - grub-mkimage -O i386-pc --prefix=(pxe)/$(NETBOOT_PATH) \ + grub-mkimage -O i386-pc-pxe --prefix=(pxe)/$(NETBOOT_PATH) \ -o $(TEMP_NETBOOT_DIR)/core.img \ $(GRUB_MODULES) $(GRUB_MODULES_PXE) # workaround a gPXE bug Thanks, -- Colin Watson [cjwat...@debian.org] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#695500: d-i-n-i: #695500 is apparently a grub-mkimage (or debian-installer) bug
Hi! On 06/12/13 13:41, Colin Watson wrote: [...] i386-pc prefixes the image with diskboot.img, while i386-pc-pxe prefixes the image with pxeboot.img. Prefixes core.img with diskboot.img?? I know that i386-pc-pxe prefixes with pxeboot.img however. After that we had this weird thing: cat $(GRUB_MODDIR)/pxeboot.img $(TEMP_NETBOOT_DIR)/core.img \ $(TEMP_NETBOOT_DIR)/$(NETBOOT_PATH)/grub2pxe As far as I remember, that would produce the same output as if i386-pc-pxe had been used, except for a sed hack which is applied to core.img first: sed -i -e 's/\x02\xb0\xad\x1b/\x03\xb0\xad\x1b/' $(TEMP_NETBOOT_DIR)/core.img Since that sed hack is no longer needed as of GRUB 2.00, I've been waiting for it to migrate to testing, then intended to clean up the whole thing with this commit: http://lists.debian.org/1374529181-96367-2-git-send-email-ste...@pyro.eu.org Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#695500: d-i-n-i: #695500 is apparently a grub-mkimage (or debian-installer) bug
Control: reassign -1 src:debian-installer 20120828 , grub-common 1.99-27 Control: tags -1 -moreinfo Control: affects -1 +debian-installer-7.0-netboot-kfreebsd-i386 Control: affects -1 +debian-installer-7.0-netboot-kfreebsd-amd64 Hi all, I spent some more time debugging this RC bug by setting up my server and testing the PXE boot of kfreebsd-i386 on two different laptops; the results are: * the error: prefix is not set error always appears when using the wheezy grub2pxe; it also happens with the current sid grub2pxe [0]; * the resistance to this error apparently depends on the PXE implementation: - my acer Aspire One displays the error and then proceeds to displaying grub, then allowing the boot of the kfreebsd-i386 installer; - my ThinkPad X220 displays the error and stops; - kvm launched locally with [1] proceeds to grub; [0] http://http.debian.net/debian/dists/sid/main/installer-kfreebsd-i386/20130430/images/netboot/grub2pxe [1] kvm -m 256 -net nic -net - user,bootfile=/grub2pxe,tftp=/usr/lib/debian-installer/images/7.0/kfreebsd-amd64/gtk/ As debian-installer-netboot-images is only copying these files from the mirrors, I don't think it is the correct source package to track this bug. The above tests now make me think that this is either a problem of debian-installer calling grub-mkimage wrongly in build/config/kfreebsd.cfg or a bug in grub-mkimage not incorporating the prefix correctly when creating a PXE image. I'm therefore hereby reassigning this bug to both these packages (in their wheezy versions) and marking it as affecting the correct d-i-n-i binary packages. Cheers, OdyX signature.asc Description: This is a digitally signed message part.
