Bug#696981: Info received (Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908)
control: tag -1 + patch
I had a closer look at the problem, and figured out why the warning
show up. The issue is that $data in the call to Storable::nstore() is
undefined. A fix for this is to wrap the call writing data in a if
(defined $data) condition like this:
diff -ur munin-2.0.21/master/lib/Munin/Master/Utils.pm
munin-2.0.21-pere/master/lib/Munin/Master/Utils.pm
--- munin-2.0.21/master/lib/Munin/Master/Utils.pm 2014-04-22
21:29:32.0 +0200
+++ munin-2.0.21-pere/master/lib/Munin/Master/Utils.pm 2014-10-10
09:17:13.328179704 +0200
@@ -859,11 +859,13 @@
my $storable_filename_tmp = $storable_filename . .tmp.$$;
- # Write datafile.storable, in network order to be architecture indep
-Storable::nstore($data, $storable_filename_tmp);
+ if (defined $data) {
+ # Write datafile.storable, in network order to be architecture
indep
+ Storable::nstore($data, $storable_filename_tmp);
- # Atomic commit
- rename ($storable_filename_tmp, $storable_filename);
+ # Atomic commit
+ rename ($storable_filename_tmp, $storable_filename);
+ }
}
sub munin_writeconfig_storable {
This get rid of the warning in the cron email triggered by trying to
store nothing in /var/lib/munin/htmlconf.storable.tmp.$pid. But the
cron email is still sent out, this time with another and more
understandable message:
[FATAL] There is nothing to do here, since there are no nodes with
any plugins. Please refer to http://munin-monitoring.org/wiki/FAQ_no_graphs
So one step forward, one step back. But anyway, I suggest to include
the patch in munin, to avoid the confusing message.
--
Happy hacking
Petter Reinholdtsen
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908
[Steve Schnepp] This bug has popped up also seemingly randomly on fresh install of other distrib. It was always caused by no node being configured, or more exactly the single node being incorrectly configured. There was a mismatch between the naming config of the node in the master and in the node (which usually are both on the same host when this triggers) Could you check if that's the case in your install ? In my case, there is no node configured at all. The attached file is the generated configuration, showing no node, and there is nothing in the .d directory. Are you able to reproduce it too? -- Happy hacking Petter Reinholdtsen # Munin server configuration generated from cron using sitesummary # data by /usr/sbin/sitesummary-update-munin # Do not edit, it will be overwritten. # Edit /etc/munin/munin.conf.pre and # /etc/munin/munin.conf.post instead. dbdir /var/lib/munin htmldir /var/cache/munin/www logdir /var/log/munin rundir /var/run/munin tmpldir /etc/munin/templates # (Exactly one) directory to include all files from. # includedir /etc/munin/munin-conf.d
Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908
Oh. Looking at your config file, it seems the munin package fails to automatically setup the local node. Then, since there is no node that is successfully polled, it emits this log message. Is the Debian Edu configuration phase different from a vanilla Debian install ? Btw, I admit that the message could be much more user-friendly. -- Steve Schnepp http://blog.pwkf.org/tag/munin -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908
[Steve Schnepp] Oh. Looking at your config file, it seems the munin package fails to automatically setup the local node. It probably do not fail to do so. The config is overwritten by sitesummary. Then, since there is no node that is successfully polled, it emits this log message. It is not a log message. It is a message picked up by cron and emailed. If it was a log message, there would not be a problem, as the logs are rotated. :) Is the Debian Edu configuration phase different from a vanilla Debian install ? The Debian Edu (aka sitesummary) configuration for munin is generated using information submitted by the clients using the sitesummary-client package. In this case, no client have been able to submit information yet, and thus the generated munin configuration contain no nodes. Btw, I admit that the message could be much more user-friendly. The problem is not its message content, it is the fact that it is emailed every 5 minutes to the root user, thus filling up /var/ with emails. I would expect munin to not complain in cron when asked to not do anything (which would be the request to it with a configuration file without any nodes :). Can you change it to not complain when no node is listed? -- Happy hacking Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908
Control: found -1 2.0.21-2 [Petter Reinholdtsen] Perhaps you can reproduce it using the Debian Edu Wheezy test installation? I installed using Norwegian Bokmål and Main-Server + Workstation as the profile. The ISO is available via rsync from ftp.skolelinux.org::cd-edu-testing-nolocal-netinst/debian-edu-amd64-i386-NETINST-1.iso I'm testing Debian Edu Jessie these days, and noticed that when installing the Main-Server profile, this munin issue is yet again filling up the mail box for root. The trigger is probably that the sitesummary collector system is not yet working, so the machine itself is not registered in sitesummary and thus the munin configuration generated from sitesummary data is empty. Just mentioning it here in case you want to test it yourself. Note that the Main Server installation is not yet without hickups. See URL: https://lists.debian.org/debian-edu/2014/08/msg00061.html for hints on how to work around them until we have weeded out the problems. Note, the current message is not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 863. :) -- Happy hacking Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908
This bug has popped up also seemingly randomly on fresh install of other distrib. It was always caused by no node being configured, or more exactly the single node being incorrectly configured. There was a mismatch between the naming config of the node in the master and in the node (which usually are both on the same host when this triggers) Could you check if that's the case in your install ? -- Steve Schnepp Le 20 août 2014 23:27, Petter Reinholdtsen p...@hungry.com a écrit : Control: found -1 2.0.21-2 [Petter Reinholdtsen] Perhaps you can reproduce it using the Debian Edu Wheezy test installation? I installed using Norwegian Bokmål and Main-Server + Workstation as the profile. The ISO is available via rsync from ftp.skolelinux.org: :cd-edu-testing-nolocal-netinst/debian-edu-amd64-i386-NETINST-1.iso I'm testing Debian Edu Jessie these days, and noticed that when installing the Main-Server profile, this munin issue is yet again filling up the mail box for root. The trigger is probably that the sitesummary collector system is not yet working, so the machine itself is not registered in sitesummary and thus the munin configuration generated from sitesummary data is empty. Just mentioning it here in case you want to test it yourself. Note that the Main Server installation is not yet without hickups. See URL: https://lists.debian.org/debian-edu/2014/08/msg00061.html for hints on how to work around them until we have weeded out the problems. Note, the current message is not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 863. :) -- Happy hacking Petter Reinholdtsen
Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908
Hi, I'm currently running into the same issue and did some debugging with the help of the #munin guys. The conditions to trigger this bug seem to be: munin never ran successfully. munin-node is not installed, thus no munin can't pull the default 'localhost' client, so /var/lib/munin/*storable doesn't get created, which causes the actual error message. A workaround could be: * install munin (or already have a 'broken' munin installation) * install munin-node * wait for '*/5 * * * *' cronjob or run munin-cron manually (as user munin) * purge munin-node (probably followed by autoremove --purge) * find a way to get rid of localhost.localdomain entries and add your real hosts I'm not sure if that'll work reliable. Also, I'm not sure if this is actually the core bug. Cheers, Julius -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908
Package: munin Version: 2.0.6-1 I discovered this on a freshly installed Debian Edu/Wheezy Main-Server. The root mail box (/var/mail/root) fill up with messages from cron about munin: From munin@postoffice.intern Sun Dec 30 09:45:02 2012 Return-path: munin@postoffice.intern Envelope-to: root@postoffice.intern Delivery-date: Sun, 30 Dec 2012 09:45:02 +0100 Received: from munin by skolelinuxtest with local (Exim 4.80 #2 (Debian)) id 1TpEVy-0001D1-J4 for root@postoffice.intern; Sun, 30 Dec 2012 09:45:02 +0100 From: root@postoffice.intern (Cron Daemon) To: root@postoffice.intern Subject: Cron munin@skolelinuxtest if [ -x /usr/bin/munin-cron ]; then /usr/bin/munin-cron; fi Content-Type: text/plain; charset=UTF-8 X-Cron-Env: MAILTO=root X-Cron-Env: SHELL=/bin/sh X-Cron-Env: HOME=/var/lib/munin X-Cron-Env: PATH=/usr/bin:/bin X-Cron-Env: LOGNAME=munin Message-Id: E1TpEVy-0001D1-J4@skolelinuxtest Sender: CronDaemon munin@postoffice.intern Date: Sun, 30 Dec 2012 09:45:02 +0100 not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908 The munin setup on the machine in question is as far as I can see, the default from a fresh munin installation. The automatically generated configuration is not yet present (which is another bug somewhere else :-). Please change munin to not send emails in its default configuration, as this will slowly fill up the /var/ partition if no-one check the root email regularly. -- Happy hacking Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908
This message is currently my white whale... It seems to pops up on many installs, yet I (upstream) still didn't manage to reproduce it accurately. And every time I have it, it only appears on the first run on munin-html via munin-cron. So, I *know* the warning is here, and I'll fix it as soon as I have some time for extensive testings. On a side note, I think that sending email per default is a feature. The fact that /var fills up is due to the previous bug and not from having too much emails. Big thx for the bug report (as it was previously reported only on rpm-based distros) Steve
Bug#696981: munin: Cron job warn about not a reference at /usr/share/perl5/Munin/Master/Utils.pm line 908
[Steve Schnepp] This message is currently my white whale... It seems to pops up on many installs, yet I (upstream) still didn't manage to reproduce it accurately. And every time I have it, it only appears on the first run on munin-html via munin-cron. So, I *know* the warning is here, and I'll fix it as soon as I have some time for extensive testings. Perhaps you can reproduce it using the Debian Edu Wheezy test installation? I installed using Norwegian Bokmål and Main-Server + Workstation as the profile. The ISO is available via rsync from ftp.skolelinux.org::cd-edu-testing-nolocal-netinst/debian-edu-amd64-i386-NETINST-1.iso -- Happy hacking Petter Reinholdtsen -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
