Bug#698253: vorbisgain: '-a' option incorrectly described in man page
Hello again, gwern. After some investigation, here's my final impression. The original manpage included the following line: vorbisgain -a -f -r music/*.ogg We changed that, since -r would not work if no directories were given: vorbisgain -a -f -r music/ That brings us to your problem, which I believe can be solved with the option -s. As described in the manpage: -s, --silent Sliently skip any non-Vorbis files found. Vorbis files that can't be processed for some reason are skipped as well, though not silently. Default is to stop when such files are encountered. I believe this would solve your problem, since vorbisgain.c will try and process all files unless -s is set. Please try this and let me know if it works for you. If that's the case, I will fix the manpage and push a new vorbisgain package revision. Otherwise, we'll contact upstream. Regards. On Tue, Jan 15, 2013 at 07:14:34PM -0500, gwern wrote: Package: vorbisgain Version: 0.37-2 Severity: minor Dear Maintainer, The vorbisgain man page states: Calculate the album gain and peak, in addition to the track gain and peak, for all .ogg files in the directory music (and all subdirecto‐ ries). All files in one directory are treated as belonging to the same album. Files that already have ReplayGain tags are not re-calculated. Note the quotes, as they cause the shell to not do any filename glob‐ bing: vorbisgain -a -f -r music/ However, this does not work as described; on my own music collection: $ vorbisgain -a -f -r music/ Processing directory 'music/alisonkrauss': Tags present; no files processed Processing directory 'music/amv': Couldn't open file '1985.avi' as vorbis: Input is not an Ogg bitstream. The amv/ directory contains non-.ogg files, and apparently vorbisgain assumes all files will be .ogg. Either the description is misleading about only running on all .ogg files since it actually runs on all files, or vorbisgain is not properly ignoring non-.ogg files. Since there are many files one might wish to keep with one's music (CUE files come to mind), I suspect it is the latter. -- System Information: Debian Release: 7.0 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'testing'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8) Shell: /bin/sh linked to /bin/dash Versions of packages vorbisgain depends on: ii libc6 2.13-37 ii libogg0 1.3.0-4 ii libvorbis0a 1.3.2-1.3 ii libvorbisfile3 1.3.2-1.3 vorbisgain recommends no packages. vorbisgain suggests no packages. -- no debconf information -- Daniel Martí - mv...@mvdan.cc - GPG 0x58BF72C3 pgpT9halAOBxz.pgp Description: PGP signature
Bug#698253: vorbisgain: '-a' option incorrectly described in man page
Looks like adding -s to the doc example would fix it: $ vorbisgain -s -a -f -r music/ Processing directory 'music/alisonkrauss': Tags present; no files processed Processing directory 'music/amv': Tags present; no files processed Processing directory 'music/angelsairwaves': Tags present; no files processed ... -- gwern http://www.gwern.net -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#698253: vorbisgain: '-a' option incorrectly described in man page
Hello gwern, Thank you for the feedback. I'll look into it and release a new version as soon as possible. Regards. -- Daniel Martí - mv...@mvdan.cc - GPG 0x58BF72C3 pgpQfKBpcwhKh.pgp Description: PGP signature
Bug#698253: vorbisgain: '-a' option incorrectly described in man page
Package: vorbisgain Version: 0.37-2 Severity: minor Dear Maintainer, The vorbisgain man page states: Calculate the album gain and peak, in addition to the track gain and peak, for all .ogg files in the directory music (and all subdirecto‐ ries). All files in one directory are treated as belonging to the same album. Files that already have ReplayGain tags are not re-calculated. Note the quotes, as they cause the shell to not do any filename glob‐ bing: vorbisgain -a -f -r music/ However, this does not work as described; on my own music collection: $ vorbisgain -a -f -r music/ Processing directory 'music/alisonkrauss': Tags present; no files processed Processing directory 'music/amv': Couldn't open file '1985.avi' as vorbis: Input is not an Ogg bitstream. The amv/ directory contains non-.ogg files, and apparently vorbisgain assumes all files will be .ogg. Either the description is misleading about only running on all .ogg files since it actually runs on all files, or vorbisgain is not properly ignoring non-.ogg files. Since there are many files one might wish to keep with one's music (CUE files come to mind), I suspect it is the latter. -- System Information: Debian Release: 7.0 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'testing'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8) Shell: /bin/sh linked to /bin/dash Versions of packages vorbisgain depends on: ii libc6 2.13-37 ii libogg0 1.3.0-4 ii libvorbis0a 1.3.2-1.3 ii libvorbisfile3 1.3.2-1.3 vorbisgain recommends no packages. vorbisgain suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
