Bug#699148: unblock: celery/2.5.3-2
Hi! Michael Fladischer mich...@fladi.at writes: On 2013-02-28 21:27, Adam D. Barratt wrote: Any news on an upload? 2.5.3-3 is prepared in SVN but paravoid (my sponsor on celery) seems to be busy. Uploaded Christoph -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699148: unblock: celery/2.5.3-2
On Fri, Mar 01, 2013 at 12:13:06AM -0800, Christoph Egger wrote: Michael Fladischer mich...@fladi.at writes: On 2013-02-28 21:27, Adam D. Barratt wrote: Any news on an upload? 2.5.3-3 is prepared in SVN but paravoid (my sponsor on celery) seems to be busy. Uploaded JFYI, r23622 | fladi-guest | 2013-03-01 07:46:25 + (Fri, 01 Mar 2013) | 2 lines i.e. 40 minutes ago, after I sent a mail to Michael :) But thanks for handling that, appreciated. Regards, Faidon -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699148: unblock: celery/2.5.3-2
On Sat, Feb 9, 2013 at 10:35:50 +0100, Julien Cristau wrote: On Sat, Feb 9, 2013 at 08:17:44 +0100, Michael Fladischer wrote: Julien Cristau, 02/08/2013 10:48 PM: I guess that should be fine then, but your postrm doesn't seem to delete any logfiles? I'll add this to postrm prior to deleting the user. A `rm -rf /var/log/celery` should be fine I guess. Sounds good. Why is that in the if deluser exists block? Cheers, Julien signature.asc Description: Digital signature
Bug#699148: unblock: celery/2.5.3-2
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2013-03-01 11:33, Julien Cristau wrote: Why is that in the if deluser exists block? Because without deluser the user/group would not be removed. So I decided to only remove the logfiles if the user/group are gone, so to to generate a scenario where files with uid/gid are on the system with no username/group assigned. - -- Michael Fladischer Fladi.at -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlEwhdYACgkQeJ3z1zFMUGa/ogCggqHvgDI0YSx7iCtoPznllvU2 aBkAniHExyfNiNnG3Zc0n1/v3nWQV+tH =e8v5 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699148: unblock: celery/2.5.3-2
On Fri, Mar 1, 2013 at 11:41:26 +0100, Michael Fladischer wrote: On 2013-03-01 11:33, Julien Cristau wrote: Why is that in the if deluser exists block? Because without deluser the user/group would not be removed. So I decided to only remove the logfiles if the user/group are gone, so to to generate a scenario where files with uid/gid are on the system with no username/group assigned. Removing log files on purge unconditionally doesn't generate such a scenario, so I'm not sure I understand what you're saying. Cheers, Julien signature.asc Description: Digital signature
Bug#699148: unblock: celery/2.5.3-2
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2013-03-01 11:43, Julien Cristau wrote: Removing log files on purge unconditionally doesn't generate such a scenario, so I'm not sure I understand what you're saying. My understanding was that it has to be insured that when a user is removed, I need to make sure that no files that are owned by this user are to be left on the filesystem. I know what you mean, that I could remove the logfiles directory no matter what happens to the user/group. I can do this in celery-2.5.3-4 if you deem this a better way to handle it. Cheers, - -- Michael Fladischer Fladi.at -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlEwim0ACgkQeJ3z1zFMUGYULwCePbyUaboFiuTQC1oIII94Sp3i v8kAn3dD9wDiw3Cajy1FAopU2O6V5aPQ =3urk -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699148: unblock: celery/2.5.3-2
On Fri, Mar 1, 2013 at 12:01:01 +0100, Michael Fladischer wrote: On 2013-03-01 11:43, Julien Cristau wrote: Removing log files on purge unconditionally doesn't generate such a scenario, so I'm not sure I understand what you're saying. My understanding was that it has to be insured that when a user is removed, I need to make sure that no files that are owned by this user are to be left on the filesystem. Correct. Better keep the user around than leave unowned files on disk. I know what you mean, that I could remove the logfiles directory no matter what happens to the user/group. I can do this in celery-2.5.3-4 if you deem this a better way to handle it. I do. Thanks, Julien signature.asc Description: Digital signature
Bug#699148: unblock: celery/2.5.3-2
On Sat, 2013-02-09 at 10:35 +0100, Julien Cristau wrote: On Sat, Feb 9, 2013 at 08:17:44 +0100, Michael Fladischer wrote: Also, /usr/share/pyshared/celery as home dir for the user seems kind of weird... Would /var/lib/celery be a better choice? I would be emptpy though. I think so. Or /nonexistent, I guess, if it's not used for anything. Any news on an upload? Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699148: unblock: celery/2.5.3-2
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2013-02-28 21:27, Adam D. Barratt wrote: Any news on an upload? 2.5.3-3 is prepared in SVN but paravoid (my sponsor on celery) seems to be busy. Cheers, - -- Michael Fladischer Fladi.at -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlEwTiEACgkQeJ3z1zFMUGZrpgCdH1oB+9oH6E4lpNHf/ktooD1c D5kAoILthBpjr5JovfuqTG+uSYqf90Au =dqbX -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699148: unblock: celery/2.5.3-2
On Sat, Feb 9, 2013 at 08:17:44 +0100, Michael Fladischer wrote: Julien Cristau, 02/08/2013 10:48 PM: I guess that should be fine then, but your postrm doesn't seem to delete any logfiles? I'll add this to postrm prior to deleting the user. A `rm -rf /var/log/celery` should be fine I guess. Sounds good. Also, /usr/share/pyshared/celery as home dir for the user seems kind of weird... Would /var/lib/celery be a better choice? I would be emptpy though. I think so. Or /nonexistent, I guess, if it's not used for anything. Thanks, Julien signature.asc Description: Digital signature
Bug#699148: unblock: celery/2.5.3-2
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Cristau, 01/30/2013 09:57 PM: How do you make sure no file owned by that user remains on the system? (If you don't, then don't remove the user, it doesn't hurt to keep it around) Thanks for your feedback. The package does not create any files owned by the celery user except for the logfiles. If this qualifies for keeping the user, I'll just drop the postrm in a 2.5.3-3 upload. Cheers, - -- Michael Fladischer Fladi.at -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlEVOqgACgkQeJ3z1zFMUGYvXgCdEsyc2dDBGCxHKF/PFzR1t8QW srgAn2JVljyDX2oLulzHMJNNXTTQ4vYL =RQiN -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699148: unblock: celery/2.5.3-2
On Fri, Feb 8, 2013 at 18:49:28 +0100, Michael Fladischer wrote: Julien Cristau, 01/30/2013 09:57 PM: How do you make sure no file owned by that user remains on the system? (If you don't, then don't remove the user, it doesn't hurt to keep it around) Thanks for your feedback. The package does not create any files owned by the celery user except for the logfiles. If this qualifies for keeping the user, I'll just drop the postrm in a 2.5.3-3 upload. I guess that should be fine then, but your postrm doesn't seem to delete any logfiles? Also, /usr/share/pyshared/celery as home dir for the user seems kind of weird... Cheers, Julien signature.asc Description: Digital signature
Bug#699148: unblock: celery/2.5.3-2
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julien Cristau, 02/08/2013 10:48 PM: I guess that should be fine then, but your postrm doesn't seem to delete any logfiles? I'll add this to postrm prior to deleting the user. A `rm -rf /var/log/celery` should be fine I guess. Also, /usr/share/pyshared/celery as home dir for the user seems kind of weird... Would /var/lib/celery be a better choice? I would be emptpy though. Cheers thank you! - -- Michael Fladischer Fladi.at -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlEV+BYACgkQeJ3z1zFMUGbRewCgi/OKsJzRwYlHngu5aH2RPBTe SaIAoJRZmoUA0tTYd3J5cIefRSpFeC/t =kv6Z -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#699148: unblock: celery/2.5.3-2
Control: tag -1 moreinfo On Mon, Jan 28, 2013 at 07:57:36 +0100, Michael Fladischer wrote: diff -Nru celery-2.5.3/debian/python-celery.postrm celery-2.5.3/debian/python-celery.postrm --- celery-2.5.3/debian/python-celery.postrm 1970-01-01 01:00:00.0 +0100 +++ celery-2.5.3/debian/python-celery.postrm 2013-01-27 23:32:21.0 +0100 @@ -0,0 +1,23 @@ +#!/bin/sh + +set -e + +case $1 in +purge) +if [ -x $(command -v deluser) ]; then +deluser --quiet --system celery /dev/null || true How do you make sure no file owned by that user remains on the system? (If you don't, then don't remove the user, it doesn't hurt to keep it around) Cheers, Julien signature.asc Description: Digital signature
Bug#699148: unblock: celery/2.5.3-2
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please unblock package celery 2.5.3-2 fixes #697195 (RC) which was caused by the user celery not being created in postinst. The attached debdiff introduces a new dependency on adduser and postinst/postrm maintainer scripts to take care of creation/removal of the user celery. unblock celery/2.5.3-2 - -- System Information: Debian Release: 7.0 APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.7-trunk-amd64 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlEGIV0ACgkQeJ3z1zFMUGa59wCdHVdTU4HktmZRPBbIH9syvEGc 8oEAoIP+AKFXpqlXUszbsySEb3sMc7G0 =JeZK -END PGP SIGNATURE- diff -Nru celery-2.5.3/debian/changelog celery-2.5.3/debian/changelog --- celery-2.5.3/debian/changelog 2012-05-30 16:04:38.0 +0200 +++ celery-2.5.3/debian/changelog 2013-01-22 13:02:04.0 +0100 @@ -1,3 +1,10 @@ +celery (2.5.3-2) unstable; urgency=low + + * Create user celery in maintainer scripts (Closes: #697195). + * Update year in d/copyright. + + -- Michael Fladischer fladischermich...@fladi.at Sun, 13 Jan 2013 19:10:12 +0100 + celery (2.5.3-1) unstable; urgency=low * New upstream release. diff -Nru celery-2.5.3/debian/control celery-2.5.3/debian/control --- celery-2.5.3/debian/control 2012-05-30 16:04:38.0 +0200 +++ celery-2.5.3/debian/control 2013-01-22 13:02:04.0 +0100 @@ -36,7 +36,8 @@ Package: python-celery Architecture: all -Depends: python-amqplib, +Depends: adduser, + python-amqplib, python-anyjson (= 0.3.1), python-cl, python-dateutil (= 1.5), diff -Nru celery-2.5.3/debian/copyright celery-2.5.3/debian/copyright --- celery-2.5.3/debian/copyright 2012-05-30 16:04:38.0 +0200 +++ celery-2.5.3/debian/copyright 2013-01-22 13:02:04.0 +0100 @@ -16,7 +16,7 @@ License: BSD Files: debian/* -Copyright: 2012, Michael Fladischer +Copyright: 2012-2013, Michael Fladischer 2010, Elliot Murphy License: BSD-solem diff -Nru celery-2.5.3/debian/python-celery.postinst celery-2.5.3/debian/python-celery.postinst --- celery-2.5.3/debian/python-celery.postinst 1970-01-01 01:00:00.0 +0100 +++ celery-2.5.3/debian/python-celery.postinst 2013-01-27 23:32:21.0 +0100 @@ -0,0 +1,29 @@ +#!/bin/sh + +set -e + +case $1 in +configure|reconfigure) +adduser \ +--system \ +--quiet \ +--home /usr/share/pyshared/celery \ +--no-create-home \ +--group \ +celery +;; + +abort-upgrade|abort-remove|abort-deconfigure) +exit 0 +;; + +*) +echo postinst called with unknown argument \`$1' 2 +exit 1 +;; +esac + +#DEBHELPER# + +exit 0 + diff -Nru celery-2.5.3/debian/python-celery.postrm celery-2.5.3/debian/python-celery.postrm --- celery-2.5.3/debian/python-celery.postrm 1970-01-01 01:00:00.0 +0100 +++ celery-2.5.3/debian/python-celery.postrm 2013-01-27 23:32:21.0 +0100 @@ -0,0 +1,23 @@ +#!/bin/sh + +set -e + +case $1 in +purge) +if [ -x $(command -v deluser) ]; then +deluser --quiet --system celery /dev/null || true +deluser --group --system --quiet --only-if-empty celery || true +else +echo 2 not removing celery system account and group because deluser command was not found +fi + ;; +remove|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear) + ;; +*) + echo postrm called with unknown argument \`$1' 2 +exit 1 +esac + +#DEBHELPER# + +exit 0
