Bug#703607: Please include Cypress PS/2 Trackpad driver in linux-image-3.2.0-*
On 03:29 Wed 27 Mar , Ben Hutchings wrote: On Tue, 2013-03-26 at 12:37 +0200, Apollon Oikonomopoulos wrote: Hi Ben, On 18:20 Sun 24 Mar , Ben Hutchings wrote: On Thu, 2013-03-21 at 12:21 +0200, Apollon Oikonomopoulos wrote: The trackpad driver from 3.9rc1 is not trivial to backport since the kernel's multitouch input API has changed significantly. I would still prefer to use a backport of the upstream version, so we can be sure that the functionality is equivalent and there shouldn't be a regression when users upgrade to the later upstream version. Could you test the attached series of patches? Ben. Thanks for the quick response, unfortunately the kernel with the patchset applied failed to build at first. I did build-test before sending you patches, but I must have failed to refresh the patch files after my last changes. Sorry about that. Patch 8 looks like fixing a crasher rather than a compile error. Yes, it was a NULL pointer dereference causing the kernel to crash at module load time. I used it for a couple of hours yesterday and it's been stable sofar. Thanks again, Apollon -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#703607: Please include Cypress PS/2 Trackpad driver in linux-image-3.2.0-*
On Wed, 2013-03-27 at 08:49 +0200, Apollon Oikonomopoulos wrote: On 03:29 Wed 27 Mar , Ben Hutchings wrote: On Tue, 2013-03-26 at 12:37 +0200, Apollon Oikonomopoulos wrote: Hi Ben, On 18:20 Sun 24 Mar , Ben Hutchings wrote: On Thu, 2013-03-21 at 12:21 +0200, Apollon Oikonomopoulos wrote: The trackpad driver from 3.9rc1 is not trivial to backport since the kernel's multitouch input API has changed significantly. I would still prefer to use a backport of the upstream version, so we can be sure that the functionality is equivalent and there shouldn't be a regression when users upgrade to the later upstream version. Could you test the attached series of patches? Ben. Thanks for the quick response, unfortunately the kernel with the patchset applied failed to build at first. I did build-test before sending you patches, but I must have failed to refresh the patch files after my last changes. Sorry about that. Patch 8 looks like fixing a crasher rather than a compile error. Yes, it was a NULL pointer dereference causing the kernel to crash at module load time. I used it for a couple of hours yesterday and it's been stable sofar. Great. I'll queue these up for the next upload. Ben. -- Ben Hutchings I'm not a reverse psychological virus. Please don't copy me into your sig. signature.asc Description: This is a digitally signed message part
Bug#703607: Please include Cypress PS/2 Trackpad driver in linux-image-3.2.0-*
Hi Ben, On 18:20 Sun 24 Mar , Ben Hutchings wrote: On Thu, 2013-03-21 at 12:21 +0200, Apollon Oikonomopoulos wrote: The trackpad driver from 3.9rc1 is not trivial to backport since the kernel's multitouch input API has changed significantly. I would still prefer to use a backport of the upstream version, so we can be sure that the functionality is equivalent and there shouldn't be a regression when users upgrade to the later upstream version. Could you test the attached series of patches? Ben. Thanks for the quick response, unfortunately the kernel with the patchset applied failed to build at first. The attached patches, when applied on top of your patches, build and seem to work correctly. I'll also test with an older Macbook to see if other drivers break with this patchset. Regards, Apollon From 90b1e99d6eaa37bb6770542762d3eb8f607e97b5 Mon Sep 17 00:00:00 2001 From: Apollon Oikonomopoulos apol...@skroutz.gr Date: Tue, 26 Mar 2013 11:33:54 +0200 Subject: [PATCH 6/8] Fix input_mt_set_matrix call input_mt_set_matrix was called with an invalid number of arguments from within input_mt_assign_slots. Fix the call by removing the first argument, which is incompatible with the function's signature. --- drivers/input/input-mt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c index c164d49..de1ac22 100644 --- a/drivers/input/input-mt.c +++ b/drivers/input/input-mt.c @@ -387,7 +387,7 @@ int input_mt_assign_slots(struct input_dev *dev, int *slots, if (num_pos 1) return 0; - nrc = input_mt_set_matrix(dev, mt, pos, num_pos); + nrc = input_mt_set_matrix(mt, pos, num_pos); find_reduced_matrix(mt-red, num_pos, nrc / num_pos, nrc); input_mt_set_slots(mt, slots, num_pos); -- 1.7.10.4 From 9969ed45b929fd1819a060578560dfe8126a56b0 Mon Sep 17 00:00:00 2001 From: Apollon Oikonomopoulos apol...@skroutz.gr Date: Tue, 26 Mar 2013 11:34:28 +0200 Subject: [PATCH 7/8] Cypress PS/2: use input_mt_init_slots_flags Debian-specific: call input_mt_init_slots_flags to initialize the Cypress PS/2 driver, instead of input_mt_init_slots. --- drivers/input/mouse/cypress_ps2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/cypress_ps2.c b/drivers/input/mouse/cypress_ps2.c index f51765f..4e366b9 100644 --- a/drivers/input/mouse/cypress_ps2.c +++ b/drivers/input/mouse/cypress_ps2.c @@ -386,7 +386,7 @@ static int cypress_set_input_params(struct input_dev *input, input_set_abs_params(input, ABS_MT_POSITION_Y, 0, cytp-tp_max_abs_y, 0, 0); input_set_abs_params(input, ABS_MT_PRESSURE, 0, 255, 0, 0); - ret = input_mt_init_slots(input, CYTP_MAX_MT_SLOTS, + ret = input_mt_init_slots_flags(input, CYTP_MAX_MT_SLOTS, INPUT_MT_DROP_UNUSED|INPUT_MT_TRACK); if (ret 0) return ret; -- 1.7.10.4 From b540394376bba90fe33ab759e332d7d60b406a99 Mon Sep 17 00:00:00 2001 From: Apollon Oikonomopoulos apol...@skroutz.gr Date: Tue, 26 Mar 2013 12:07:43 +0200 Subject: [PATCH 8/8] input_mt_init_slots_flags: fix slot initialization input_mt_init_slots_flags used an invalid pointer to initialize the slots as unused. Fix this by passing the correcto pointer (mt-slots[i] instead of dev-mt[i]). --- drivers/input/input-mt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c index de1ac22..8129f1f 100644 --- a/drivers/input/input-mt.c +++ b/drivers/input/input-mt.c @@ -90,7 +90,7 @@ int input_mt_init_slots_flags(struct input_dev *dev, unsigned int num_slots, /* Mark slots as 'unused' */ for (i = 0; i num_slots; i++) - input_mt_set_value(dev-mt[i], ABS_MT_TRACKING_ID, -1); + input_mt_set_value(mt-slots[i], ABS_MT_TRACKING_ID, -1); dev-mt = mt-slots[0]; return 0; -- 1.7.10.4
Bug#703607: Please include Cypress PS/2 Trackpad driver in linux-image-3.2.0-*
On Sun, Mar 24, 2013 at 06:20:01PM +, Ben Hutchings wrote: Control: severity -1 important This is a bit off-topic, but I'm not sure it warrants a different bug report (feel free to clone): I recently had to support a friend who bought a Dell E6230 and installed Wheezy, but couldn't get the touchpad working (it was detected as a regular PS2 Mouse). The E6230 is a May 2012 release laptop, otherwise identical to the E6220, which had a regular ALPS touchpad with support backported to wheezy in the first days of the freeze. It turns out that the E6230 has a Rushmore ALPS touchpad. Support for those was exists in upstream by 1302bac33d9e88cd43e482191a806998f3ed43cc, committed Feb 13, will be in 3.9. cd401204873101245287afc07271b39c79194d9c is probably part of that series too. The support is hence bleeding-edge, but the E6230/E6430/E6530 laptops are out for quite some time and are very popular -- it's basically the 12/14/15 inch Latitudes that are on sale now. I tried backporting that patch and failed miserably. I'm not sure how much more work would it be to apply them and if they'll be accepted into Debian if they have to pull a dozen more commits, esp. this late in the cycle. I'll let you be the judge of that, I was impressed you changed this to important :) FWIW, I built psmouse.ko straight of 3.9 and the touchpad works as a charm on that laptop. I can also do more extensive testing with a 3.2 + patches, albeit with a bit of an increased turnaround as I don't own that laptop. Thanks, Faidon -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#703607: Please include Cypress PS/2 Trackpad driver in linux-image-3.2.0-*
On Tue, 2013-03-26 at 12:37 +0200, Apollon Oikonomopoulos wrote: Hi Ben, On 18:20 Sun 24 Mar , Ben Hutchings wrote: On Thu, 2013-03-21 at 12:21 +0200, Apollon Oikonomopoulos wrote: The trackpad driver from 3.9rc1 is not trivial to backport since the kernel's multitouch input API has changed significantly. I would still prefer to use a backport of the upstream version, so we can be sure that the functionality is equivalent and there shouldn't be a regression when users upgrade to the later upstream version. Could you test the attached series of patches? Ben. Thanks for the quick response, unfortunately the kernel with the patchset applied failed to build at first. I did build-test before sending you patches, but I must have failed to refresh the patch files after my last changes. Sorry about that. Patch 8 looks like fixing a crasher rather than a compile error. The attached patches, when applied on top of your patches, build and seem to work correctly. I'll also test with an older Macbook to see if other drivers break with this patchset. Thanks. Ben. -- Ben Hutchings I'm not a reverse psychological virus. Please don't copy me into your sig. signature.asc Description: This is a digitally signed message part
Bug#703607: Please include Cypress PS/2 Trackpad driver in linux-image-3.2.0-*
Package: src:linux Version: 3.2.39-2 Severity: wishlist Dear Maintainer, Please include the driver for the Cypress PS/2 Trackpad found in newer Dell laptops (Dell XPS 12 and XPS 13) in wheezy's 3.2 kernel. Without this driver the trackpad works as a plain PS/2 mouse with no additional features (tap-to-click, scroll, multitouch support etc). The driver has been merged upstream in 3.9rc1, but a version for 3.2 exists in Ubuntu Precise Pangolin's kernel for Dell's project Sputnik[1]. This version has mostly found its way in Ubuntu's mainline kernel as well AFAICT. The relevant commits from [1] are: 31d910b UBUNTU: SAUCE: Input: fix Cypress PS/2 Trackpad in Dell XPS12 4cb50f2 UBUNTU: SAUCE: input: Cypress PS/2 Trackpad list additional contributors 710840c UBUNTU: SAUCE: input: Cypress PS/2 Trackpad fix taps turning into hardware clicks dc4298f UBUNTU: SAUCE: input: Cypress PS/2 Trackpad fix lost sync upon palm contact b0827c3 UBUNTU: SAUCE: input: Cypress PS/2 Trackpad fix multi-source, double-click 58a51d6 UBUNTU: SAUCE: input: Cypress PS/2 Trackpad fix disabling tap-to-click b0868fe UBUNTU: SAUCE: input: Cypress PS/2 Trackpad move PSMOUSE_CYPRESS enum e49b04c UBUNTU: SAUCE: input: Cypress PS/2 Trackpad link driver into psmouse-base a36670e UBUNTU: SAUCE: input: Cypress PS/2 Trackpad set default debug_level=0 ca0b397 UBUNTU: SAUCE: input: Cypress PS/2 Trackpad fix no-config stubs a6bc484 UBUNTU: SAUCE: input: Cypress PS/2 Trackpad eliminate dead code cd01bae UBUNTU: SAUCE: input: Cypress PS/2 Trackpad code style cleanup e8b4fed UBUNTU: SAUCE: input: Cypress PS/2 Trackpad mouse driver They apply cleanly to Debian's 3.2.39-2 with the exception of an ubuntu-specific build-system file not needed in Debian. The kernel builds successfully and the trackpad seems to function properly using the synaptics X11 driver. The trackpad driver from 3.9rc1 is not trivial to backport since the kernel's multitouch input API has changed significantly. [1] git://kernel.ubuntu.com/kamal/ubuntu-precise.git http://kernel.ubuntu.com/git?p=kamal/ubuntu-precise.git;a=shortlog;h=refs/heads/dellxps Regards, Apollon -- Package-specific info: ** Version: Linux version 3.2.0-4-amd64 (debian-ker...@lists.debian.org) (gcc version 4.6.3 (Debian 4.6.3-15) ) #1 SMP Debian 3.2.39-2 ** Command line: BOOT_IMAGE=/vmlinuz-3.2.0-4-amd64 root=/dev/mapper/ssd-root ro ** Not tainted -- System Information: Debian Release: 7.0 APT prefers testing-updates APT policy: (500, 'testing-updates'), (500, 'testing'), (90, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores) Locale: LANG=el_GR.UTF-8, LC_CTYPE=el_GR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages linux-image-3.2.0-4-amd64 depends on: ii debconf [debconf-2.0] 1.5.49 ii initramfs-tools [linux-initramfs-tool] 0.109 ii kmod9-2 ii linux-base 3.5 ii module-init-tools 9-2 Versions of packages linux-image-3.2.0-4-amd64 recommends: ii firmware-linux-free 3.2 Versions of packages linux-image-3.2.0-4-amd64 suggests: pn debian-kernel-handbook none ii grub-pc 1.99-27 ii linux-doc-3.2 3.2.39-2 Versions of packages linux-image-3.2.0-4-amd64 is related to: pn firmware-atherosnone pn firmware-bnx2 none pn firmware-bnx2x none pn firmware-brcm80211 none pn firmware-intelwimax none pn firmware-ipw2x00none pn firmware-ivtv none pn firmware-iwlwifinone pn firmware-libertas none pn firmware-linux none ii firmware-linux-nonfree 0.36+wheezy.1 pn firmware-myricomnone pn firmware-netxen none pn firmware-qlogic none pn firmware-ralink none pn firmware-realteknone pn xen-hypervisor none -- debconf information excluded -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
