Bug#703902: [Piuparts-devel] Bug#703902: Bug#703902: RFC: feature/adequate

2013-05-17 Thread Holger Levsen
Hi Jakub,

On Donnerstag, 16. Mai 2013, Jakub Wilk wrote:
 It would be good to print a warning if adequate exits with non-zero exit
 code. As as said on IRC, this would normally indicate a bug in adequate
 itself, but let's not sweep such bugs under the carpet. :) /wishlist

right. do you know a way to force adequate like this? Or will I have to link 
it to false to test my code? :)
 
 Typo: installatiom - installation
 Other than that, it looks good to me.

Thanks for the review!

 I'm also now considering to always run adequate if it's installed, and
 as such turn the --adequate switch into an --no-adequate switch. What
 do you think? (And defaulting to only warn on adequate failures, which
 can be changed with --fail-if-inadequate.)
 No strong opinion about this

I think I will do it. It's not set in stone anyway, so should complains arise, 
it's trivial to change.


cheers,
Holger




signature.asc
Description: This is a digitally signed message part.


Bug#703902: [Piuparts-devel] Bug#703902: Bug#703902: RFC: feature/adequate

2013-05-17 Thread Jakub Wilk

* Holger Levsen hol...@layer-acht.org, 2013-05-17, 14:16:
It would be good to print a warning if adequate exits with non-zero 
exit code. As as said on IRC, this would normally indicate a bug in 
adequate itself, but let's not sweep such bugs under the carpet. :) 
/wishlist
right. do you know a way to force adequate like this? Or will I have to 
link it to false to test my code? :)


Maybe ask it to check a non-existent package:

$ adequate piupartz
dpkg-query: no packages found matching piupartz
dpkg-query -W: failed at /usr/bin/adequate line 174.
$ echo $?
1

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org