Bug#704037: [Piuparts-devel] Bug#704037: piuparts: fail with umount while mounting /proc/sys/fs/binfmt_misc

[Holger Levsen]

control: tags -1 + pending

On Thu, Dec 22, 2016 at 11:52:55AM +0100, Antonio Ospite wrote:
> Ping.

thanks for the ping, patience and the patch! I've applied it and will
now deploy it on piuparts.d.o… the next piuparts upload will probably
happen sometime this year or early in January :)


-- 
cheers,
Holger


signature.asc
Description: Digital signature

Bug#704037: [Piuparts-devel] Bug#704037: piuparts: fail with umount while mounting /proc/sys/fs/binfmt_misc

[Antonio Ospite]

On Sun, 11 Dec 2016 19:55:13 +
Holger Levsen  wrote:

> control: tags -1 + patch
> thanks
> 
> Hi Antonio,
> 
> On Sun, Dec 11, 2016 at 07:40:23PM +0100, Antonio Ospite wrote:
> > I am attaching a patch which adds the workaround.
> 
> awesome, thanks!
[...]
>
> I'm basically about to leave for
> https://reproducible-builds.org/events/berlin2016/ so it will take some
> days til I'll find time to apply this. Feel free to ping me again in a
> week!
> 
> 

Ping.

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Bug#704037: [Piuparts-devel] Bug#704037: piuparts: fail with umount while mounting /proc/sys/fs/binfmt_misc

[Holger Levsen]

control: tags -1 + patch
thanks

Hi Antonio,

On Sun, Dec 11, 2016 at 07:40:23PM +0100, Antonio Ospite wrote:
> I am attaching a patch which adds the workaround.

awesome, thanks!
 
> I also reported the issue to binfmt-support:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847788

awesome, thanks!

:)

I'm basically about to leave for
https://reproducible-builds.org/events/berlin2016/ so it will take some
days til I'll find time to apply this. Feel free to ping me again in a
week!


-- 
cheers,
Holger


signature.asc
Description: Digital signature

Bug#704037: [Piuparts-devel] Bug#704037: piuparts: fail with umount while mounting /proc/sys/fs/binfmt_misc

[Antonio Ospite]

On Fri, 9 Dec 2016 19:58:17 +
Holger Levsen  wrote:

> On Wed, Dec 07, 2016 at 10:15:25AM +0100, Antonio Ospite wrote:
> > Ping. Is the change from below OK? If it is I will send a proper patch.
> 
> yes, please send a git patch. +thanks!
> 
> also a debian bug against the binfmt-support package would be
> appreciated, so that it also gets fixed properly there.
> 

Hi Holger,

I am attaching a patch which adds the workaround.

I also reported the issue to binfmt-support:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847788

Thanks,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
>From 5a5ae7619afadbc97f607a4d8370496333e8299f Mon Sep 17 00:00:00 2001
From: Antonio Ospite 
Date: Sun, 11 Dec 2016 17:16:14 +0100
Subject: [PATCH] Umount /proc/sys/fs/binfmt_misc to work around a binfmt bug

Some java packages (e.g. "signtos") trigger update-binfmts, which mounts
/proc/sys/fs/binfmt_misc but never unmounts it.

When dealing with such scenario piuparts cannot unmount the chroot
successfully because /proc results busy.

Work around the issue by force-unmounting /proc/sys/fs/binfmt_misc
before anything else.

The same workaround was also used in other projects:
https://bugs.launchpad.net/ubuntu/+source/binfmt-support/+bug/534211
https://lists.debian.org/debian-live/2007/01/msg00039.html

Closes: #704037
---
 piuparts.py | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/piuparts.py b/piuparts.py
index dbf2b18d..f9b0b126 100644
--- a/piuparts.py
+++ b/piuparts.py
@@ -1577,6 +1577,12 @@ class Chroot:
 
 def unmount_all(self):
 """Unmount everything we mount()ed into the chroot."""
+
+# Workaround to unmount /proc/sys/fs/binfmt_misc which is mounted by
+# update-binfmts but never unmounted, see:
+# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704037
+run(["umount", self.relative("/proc/sys/fs/binfmt_misc")], ignore_errors=True)
+
 for mountpoint in reversed(self.mounts):
 run(["umount", mountpoint], ignore_errors=True)
 
-- 
2.11.0

Bug#704037: [Piuparts-devel] Bug#704037: piuparts: fail with umount while mounting /proc/sys/fs/binfmt_misc

[Holger Levsen]

On Wed, Dec 07, 2016 at 10:15:25AM +0100, Antonio Ospite wrote:
> Ping. Is the change from below OK? If it is I will send a proper patch.

yes, please send a git patch. +thanks!

also a debian bug against the binfmt-support package would be
appreciated, so that it also gets fixed properly there.


-- 
cheers,
Holger


signature.asc
Description: Digital signature

Bug#704037: [Piuparts-devel] Bug#704037: piuparts: fail with umount while mounting /proc/sys/fs/binfmt_misc

[Holger Levsen]

Hi Hideki, 

thanks for the bug report!

On Mittwoch, 27. März 2013, Hideki Yamane wrote:
  I've got a fail with piuparts as attached log.
  It seems that binfmt-support package causes this, but in other virtualbox
  environment it works fine.

so both tests were made in virtualbox? Or was the failing made in a chroot and 
the non failing in virtualbox?


cheers,
Holger


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#704037: [Piuparts-devel] Bug#704037: piuparts: fail with umount while mounting /proc/sys/fs/binfmt_misc

[Hideki Yamane]

Hi Holger,

On Wed, 27 Mar 2013 10:57:47 +0100
Holger Levsen hol...@layer-acht.org wrote:
 so both tests were made in virtualbox? Or was the failing made in a chroot 
 and 
 the non failing in virtualbox?

 fail- chroot (sid, it's my desktop, so not minimal)
 success - virtualbox (sid, minimal)



-- 
Regards,

 Hideki Yamane henrich @ debian.or.jp/org
 http://wiki.debian.org/HidekiYamane


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org