Bug#704985: git-daemon-sysvinit: GIT_DAEMON_BASE_PATH missing in /etc/default/git-daemon
On Thu, 21 Nov 2013 15:29:49 -0800 Jonathan Nieder jrnie...@gmail.com wrote: Hi, Antonio Ospite wrote: having this fixed would be really good. Thanks for looking into it. Does the patch I proposed at [1] look right and work (i.e., can I have your ack for it), or should it be tweaked in some way? Hi Jonathan, from the git-daemon man page I see that in --base-path=path the path is a sort of Git root (i.e. where actual repositories are) but for URLs, so I think it makes sense to set it equal to the 'directory' argument as a default value. In your patch that would mean to use: GIT_DAEMON_BASE_PATH=/var/lib/git that is the same value as GIT_DAEMON_DIRECTORY. Thanks, Antonio Curious, Jonathan [1] http://bugs.debian.org/704985#10 -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#704985: git-daemon-sysvinit: GIT_DAEMON_BASE_PATH missing in /etc/default/git-daemon
On 11/22/2013 12:29 AM, Jonathan Nieder wrote: Does the patch I proposed at [1] look right and work It does for (at least) me, yes. -- Address:Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern Email: daniel.baum...@progress-technologies.net Internet: http://people.progress-technologies.net/~daniel.baumann/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#704985: git-daemon-sysvinit: GIT_DAEMON_BASE_PATH missing in /etc/default/git-daemon
tags 704985 + pending quit Daniel Baumann wrote: On 11/22/2013 12:29 AM, Jonathan Nieder wrote: Does the patch I proposed at [1] look right and work It does for (at least) me, yes. Thanks for looking it over. Applied. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#704985: git-daemon-sysvinit: GIT_DAEMON_BASE_PATH missing in /etc/default/git-daemon
Package: git-daemon-sysvinit Version: 1:1.8.4.3-1 Followup-For: Bug #704985 Dear Maintainer, having this fixed would be really good. Maybe even in a future stable point release if possible. JFYI my setup is something like: --- GIT_DAEMON_ENABLE=true GIT_DAEMON_USER=git GIT_DAEMON_BASE_PATH=/home/git/repositories GIT_DAEMON_DIRECTORY=/home/git/repositories --- Thanks, Antonio -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (900, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.12.0-ao2 (SMP w/1 CPU core) Locale: LANG=it_IT.utf8, LC_CTYPE=it_IT.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages git-daemon-sysvinit depends on: ii adduser 3.113+nmu3 ii git 1:1.8.4.3-1 git-daemon-sysvinit recommends no packages. git-daemon-sysvinit suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#704985: git-daemon-sysvinit: GIT_DAEMON_BASE_PATH missing in /etc/default/git-daemon
Hi, Antonio Ospite wrote: having this fixed would be really good. Thanks for looking into it. Does the patch I proposed at [1] look right and work (i.e., can I have your ack for it), or should it be tweaked in some way? Curious, Jonathan [1] http://bugs.debian.org/704985#10 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#704985: git-daemon-sysvinit: GIT_DAEMON_BASE_PATH missing in /etc/default/git-daemon
tags 704985 + patch owner 704985 Daniel Baumann daniel.baum...@progress-technologies.net quit Hi, Alexander Dahl wrote: when changing GIT_DAEMON_DIRECTORY in the /etc/default/git-daemon coming with the package to e.g. /srv/repos/git the git-daemon is still called with --base-path=/var/cache because GIT_DAEMON_BASE_PATH has the default value from /etc/init.d/git-daemon but is not included in /etc/default/git-daemon which leads to a path not found error. I could fix this by adding GIT_DAEMON_BASE_PATH='/srv/repos' to my /etc/default/git-daemon so I guess it would be nice to deliver a better template or default /etc/default/git-daemon containg GIT_DAEMON_BASE_PATH or improve /usr/share/doc/git-daemon/README* Good idea. How about this patch? Thanks and sorry for the slow reply, Jonathan diff --git i/debian/changelog w/debian/changelog index b68ea590..a1c5a12c 100644 --- i/debian/changelog +++ w/debian/changelog @@ -1,3 +1,10 @@ +git (1:1.8.4~rc2-1.1) experimental; urgency=low + + * git-daemon-sysvinit: advertise GIT_DAEMON_BASE_PATH in +/etc/default/git-daemon (thx Alexander Dahl; closes: #704985). + + -- Jonathan Nieder jrnie...@gmail.com Sun, 11 Aug 2013 11:59:57 -0700 + git (1:1.8.4~rc2-1) unstable; urgency=low * new upstream release candidate. diff --git i/debian/git-daemon.default w/debian/git-daemon.default index fd62168c..356bb3d2 100644 --- i/debian/git-daemon.default +++ w/debian/git-daemon.default @@ -8,6 +8,7 @@ GIT_DAEMON_ENABLE=false GIT_DAEMON_USER=gitdaemon +GIT_DAEMON_BASE_PATH=/var/lib GIT_DAEMON_DIRECTORY=/var/lib/git # Additional options that are passed to the Daemon. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#704985: git-daemon-sysvinit: GIT_DAEMON_BASE_PATH missing in /etc/default/git-daemon
Package: git-daemon-sysvinit Version: 1:1.7.10.4-2 Severity: minor Dear Maintainer, when changing GIT_DAEMON_DIRECTORY in the /etc/default/git-daemon coming with the package to e.g. /srv/repos/git the git-daemon is still called with --base-path=/var/cache because GIT_DAEMON_BASE_PATH has the default value from /etc/init.d/git-daemon but is not included in /etc/default/git-daemon which leads to a path not found error. I could fix this by adding GIT_DAEMON_BASE_PATH='/srv/repos' to my /etc/default/git-daemon so I guess it would be nice to deliver a better template or default /etc/default/git-daemon containg GIT_DAEMON_BASE_PATH or improve /usr/share/doc/git-daemon/README* HTH Greets Alex -- System Information: Debian Release: 7.0 APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 3.2.0-4-686-pae (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages git-daemon-sysvinit depends on: ii adduser 3.113+nmu3 ii git 1:1.7.10.4-2 git-daemon-sysvinit recommends no packages. git-daemon-sysvinit suggests no packages. -- no debconf information pgpejKng8tNeK.pgp Description: PGP signature
