Bug#705607: 1.0 breaks alignment != left

2014-03-05 Thread Yuri D'Elia
Package: dunst
Followup-For: Bug #705607

I upgraded again to dunst 1.0 today, and it seems that it has been resolved,
suggesting some likely library issue.

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (800, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.13-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dunst depends on:
ii  libc62.18-4
ii  libcairo21.12.16-2
ii  libdbus-1-3  1.8.0-2
ii  libfreetype6 2.5.2-1
ii  libglib2.0-0 2.38.2-5
ii  libpango-1.0-0   1.36.2-2
ii  libpangocairo-1.0-0  1.36.2-2
ii  libx11-6 2:1.6.2-1
ii  libxdg-basedir1  1.2.0-1
ii  libxext6 2:1.3.2-1
ii  libxft2  2.3.1-2
ii  libxinerama1 2:1.1.3-1
ii  libxss1  1:1.2.2-1

dunst recommends no packages.

dunst suggests no packages.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#705607: 1.0 breaks alignment != left

2014-03-05 Thread Yuri D'Elia
Package: dunst
Version: 1.0.0-2
Followup-For: Bug #705607

The problem is caused by pango not knowing the final layout width when 
rendering.
The attached patch fixes the problem.
--- dunst-1.0.0.Orig/x.c	2014-03-05 12:41:03.274349758 +0100
+++ dunst-1.0.0/x.c	2014-03-05 14:46:01.670678667 +0100
@@ -160,6 +160,17 @@
 
 }
 
+static void r_update_layouts_width(GSList *layouts, int width)
+{
+width -= 2 * settings.h_padding;
+width -= 2 * settings.frame_width;
+
+for (GSList *iter = layouts; iter; iter = iter-next) {
+colored_layout *cl = iter-data;
+pango_layout_set_width(cl-l, width * PANGO_SCALE);
+}
+}
+
 static void free_colored_layout(void *data)
 {
 colored_layout *cl = data;
@@ -379,6 +390,10 @@
 int width = dim.w;
 int height = dim.h;
 
+	if (have_dynamic_width()  settings.align != left) {
+r_update_layouts_width(layouts, width);
+}
+
 cairo_t *c;
 cairo_surface_t *image_surface = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, width, height);
 c = cairo_create(image_surface);


Bug#705607: 1.0 breaks alignment != left

2013-04-17 Thread Yuri D'Elia

Package: dunst
Version: 1.0.0-1
Severity: normal

In the last update, if the alignment setting is set to anything but 
left, the content of the notification is broken.


With center, only half of the text is visible.
With right no text is visible at all, and dunst sometimes enter in an 
endless loop (and needs to be killed).



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#705607: 1.0 breaks alignment != left

2013-04-17 Thread Sascha Kruse
On Wed, Apr 17, 2013 at 02:58:43PM +0200, Yuri D'Elia wrote:
 
 In the last update, if the alignment setting is set to anything but
 left, the content of the notification is broken.
 
 With center, only half of the text is visible.
 With right no text is visible at all, and dunst sometimes enter in
 an endless loop (and needs to be killed).

I can't reproduce this behaviour. Does this problem persist when you use
the default config? 

dunst -conf /path/to/default/dunstrc -align left|center|right

Do you get any output when running dunst from a terminal while this
happens? Can you please provide your config file? And a screenshot might
also be helpful.

Thank you,
Sascha


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org