Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
Hi, Schloss (25/04/2013): > Package: debian-installer > Severity: serious > > Default x86_64 Installation CD of Wheezy has next bug: > - while it is asking to install bootloader it isn't asking where to > install bootloader > > In this case, when I install Debian from usb-flash-drive on another > usb-hard-drive and those names are, for example, /dev/sdb and /dev/sdc, > I need to install bootloader to /dev/sdc (or /dev/sdb). But installer > always install bootloader to /dev/sda. Of course, I already had another > system on /dev/sda, and it was CentOS, so I needed resque disk to > recover my bootloader from /dev/sda. > > Going further, when I need to install Debian on a dozen of > usb-hard-drives, each time I need to resque my bootloader on main system > on /dev/sda. for the record: http://www.debian.org/devel/debian-installer/errata Mraw, KiBi. signature.asc Description: Digital signature
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
Quoting Vincent McIntyre (vincent.mcint...@csiro.au): > b) modify po/sublevel1/template.po to point to the new question like this: > #. Type: select > #. Choices > #: ../choose-mirror-bin.templates.http-in:2001 > #: ../choose-mirror-bin.templates.ftp.sel-in:2001 > +#: ../grub-installer.templates:29001 > msgid "enter information manually" > msgstr "" That isn't needed, as long as you take care to use the very exact same string. template.pot files are anyway automatically generated and PO files are updated accordingly. Then the PO files *in the package* will be updated during the same daily cron job. signature.asc Description: Digital signature
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
Vincent McIntyre wrote: > I found the string, in po/sublevel1, here's the templates.po > #. Type: select > #. Choices > #: ../choose-mirror-bin.templates.http-in:2001 > #: ../choose-mirror-bin.templates.ftp.sel-in:2001 > msgid "enter information manually" > msgstr "" > > Is it the case that I need to > a) give a unique number to the new question in grub-installer/po/templates.pot A cron job should take care of this, as long as an identical string is used in the templates file. -- see shy jo signature.asc Description: Digital signature
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
Hi, just another how-to-reproduce: run d-i on a system with /boot on RAID 1 and / on LVM on RAID 10 on five discs. d-i (priority=low) asks whether to install grub2 to the MBR, I say yes, and it installs to /dev/sda, so I’ll have to, later, in the installed system, reconfigure it to tell it to install to all discs. Why isn’t the normal postinst of the grub-pc run in-target with debconf pass-through instead? That one WFM… bye, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-314 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Boris Esser, Sebastian Mancke -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
Hi Joey
thank you for your helpful comments. I'm working on fixing the issues.
I do have one question because I'm completely new to the translation
side of things...
On Thu, Apr 25, 2013 at 08:28:27AM -0400, Joey Hess wrote:
>
> There are also some hardcoded user-visible strings embedded in the code,
> which need to be a) moved to the template and b) somehow translated
> 3 months ago. I don't think that "(An entry dialog will appear)" adds
> anything to the $manual_entry string ("Enter device manually").
> There is an "enter information manually" string in choose-mirror that
> could be copied, with full translations.
>
I found the string, in po/sublevel1, here's the templates.po
#. Type: select
#. Choices
#: ../choose-mirror-bin.templates.http-in:2001
#: ../choose-mirror-bin.templates.ftp.sel-in:2001
msgid "enter information manually"
msgstr ""
Is it the case that I need to
a) give a unique number to the new question in grub-installer/po/templates.pot
b) modify po/sublevel1/template.po to point to the new question like this:
#. Type: select
#. Choices
#: ../choose-mirror-bin.templates.http-in:2001
#: ../choose-mirror-bin.templates.ftp.sel-in:2001
+#: ../grub-installer.templates:29001
msgid "enter information manually"
msgstr ""
Cheers
Vince
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
Gaudenz Steinlin wrote: > Do you know how the problem can be triggerd. As far as I remember only > some installation from USB are affected and I don't know if the > difference between those affected and those unaffected has ever been > identified. If I know that I'm testing the right test case, I'm willing > to try your patch. Well, the patch always prompts with a menu, so essentially you don't need to reproduce the problem case to test it. I'd be more concerned about testing it on different architectures. Particularly ones without a /dev/disk/by-id/ -- see shy jo signature.asc Description: Digital signature
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
Vincent McIntyre wrote:
> It's entirely possible this patch is not the full resolution of the various
> issues people have reported but I'm posting it to get feedback on the
> approach and get some help with correctly integrating it into d-i.
This adds a new translatable template, which it is far too late in the
release process to get translated. I think this problem could be
finessed by copying the text of the short description and first paragraph of
the grub-installer/bootdev template.
(Ideally into a common template that is SUBSTED into both to avoid bloat.)
There are also some hardcoded user-visible strings embedded in the code,
which need to be a) moved to the template and b) somehow translated
3 months ago. I don't think that "(An entry dialog will appear)" adds
anything to the $manual_entry string ("Enter device manually").
There is an "enter information manually" string in choose-mirror that
could be copied, with full translations.
device_list() builds a comma-delimited list; it could be that the
description of a device contains a comma (eg, "Foo Corp, Inc. mega super
drive"),
and so it needs to be sanitized.
+# make sure this question is displayed at least once
+db_fset grub-installer/choose_bootdev seen false
That is unncessary in d-i; d-i always re-asks seen questions.
(And it's very bad style to ever mess with seen flags, in any use of
debconf. You will cause bugs that are hard to find.)
--
see shy jo
signature.asc
Description: Digital signature
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
On Thu, Apr 25, 2013 at 09:33:01AM +0200, Gaudenz Steinlin wrote:
>
> Hi Vince
>
> >
> > Please see my working (for me), tested, waiting-for-review patch [1]
> > sent to the -boot list yesterday.
>
> Do you know how the problem can be triggerd. As far as I remember only
> some installation from USB are affected and I don't know if the
> difference between those affected and those unaffected has ever been
> identified. If I know that I'm testing the right test case, I'm willing
> to try your patch.
>
As I try to explain in the patch it seems to me that the issue is this:
- the program tries to make an intelligent guess about which device the
installer is mounted on and avoid that device. But in the case of USB
sticks it is quite difficult to tell. There is discussion of this in
#696877.
- in the 'while' loop starting at line 593 it typically asks the question
grub-installer/only-debian or grub-installer/with-other-os.
If it gets a 'true' ('yes') answer, it sets bootdev=$default_bootdev
and exits the loop with no further questions to the user.
If it gets a 'false' ('no') answer it should ask grub-installer/bootdev
ie give the user a chance to input the device name they want.
I'm assuming that this affects some installs and not others because there
are different enumeration orders on different systems.
It's entirely possible this patch is not the full resolution of the various
issues people have reported but I'm posting it to get feedback on the
approach and get some help with correctly integrating it into d-i.
It also needs tests on arches other than amd64/i386 and probably with
systems that require EFI.
Hope you can find time to apply the patch, build grub-installer and test.
I didn't rebuild the entire installer image when testing. I built the udeb
and after tasksel was done I scp'd it onto the test machine and installed
it with udpkg. I ran 'sh /usr/bin/grub-installer /target' on tty2, for some
reason I could not get it to work with the main menu on tty1.
Cheers
Vince
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
Hi Vince Vincent McIntyre writes: >> Sadly, this issue will probably be in wheezy as nobody digged enough >> to tackle this down and we get rid of it before the last version of >> D-I is released. > > > Please see my working (for me), tested, waiting-for-review patch [1] > sent to the -boot list yesterday. Do you know how the problem can be triggerd. As far as I remember only some installation from USB are affected and I don't know if the difference between those affected and those unaffected has ever been identified. If I know that I'm testing the right test case, I'm willing to try your patch. Gaudenz -- Ever tried. Ever failed. No matter. Try again. Fail again. Fail better. ~ Samuel Beckett ~ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
> Sadly, this issue will probably be in wheezy as nobody digged enough > to tackle this down and we get rid of it before the last version of > D-I is released. Please see my working (for me), tested, waiting-for-review patch [1] sent to the -boot list yesterday. Cheers Vince [1] https://lists.debian.org/debian-boot/2013/04/msg00396.html -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
reassign 706112 grub-installer thanks Quoting Schloss (schloss.kirchlau...@yandex.ru): > Package: debian-installer > Severity: serious > > Default x86_64 Installation CD of Wheezy has next bug: > - while it is asking to install bootloader it isn't asking where to > install bootloader > > In this case, when I install Debian from usb-flash-drive on another > usb-hard-drive and those names are, for example, /dev/sdb and /dev/sdc, > I need to install bootloader to /dev/sdc (or /dev/sdb). But installer > always install bootloader to /dev/sda. Of course, I already had another > system on /dev/sda, and it was CentOS, so I needed resque disk to > recover my bootloader from /dev/sda. It's not always but, yes, there are cases (not clearly identified yet) where grub-installer does the wrong thing. Sadly, this issue will probably be in wheezy as nobody digged enough to tackle this down and we get rid of it before the last version of D-I is released. Let's reassign this bug to where it belongs: grub-installer. signature.asc Description: Digital signature
Bug#706112: debian-installer: Wheezy installer always install bootloader in /dev/sda
Package: debian-installer Severity: serious Default x86_64 Installation CD of Wheezy has next bug: - while it is asking to install bootloader it isn't asking where to install bootloader In this case, when I install Debian from usb-flash-drive on another usb-hard-drive and those names are, for example, /dev/sdb and /dev/sdc, I need to install bootloader to /dev/sdc (or /dev/sdb). But installer always install bootloader to /dev/sda. Of course, I already had another system on /dev/sda, and it was CentOS, so I needed resque disk to recover my bootloader from /dev/sda. Going further, when I need to install Debian on a dozen of usb-hard-drives, each time I need to resque my bootloader on main system on /dev/sda. -- System Information: Debian Release: 7.0 APT prefers testing-updates APT policy: (500, 'testing-updates'), (500, 'testing') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
