Bug#707077: obsolete conffiles: s/may/should/

2013-10-16 Thread Charles Plessy
Le Tue, Oct 15, 2013 at 04:27:06PM -0700, Jonathan Nieder a écrit :
> Charles Plessy wrote:
> 
> > --- a/upgrading-checklist.sgml
> > +++ b/upgrading-checklist.sgml
> > @@ -62,6 +62,12 @@ Unreleased.
> >  9.1.1.8
> >The exception to the FHS for the /selinux was removed.
> >
> > +10.7.3
> > +  During package upgrades, the removal of obsolete configuration 
> > files
> > +  without local changes is now recommended (should) instead of
> > +  suggested (may).  Note the dpkg-maintscript-helper
> > +  tool, available from the dpkg package since
> > +  Wheezy.
> 
> I'd say
> 
>   Packages should remove all obsolete configuration files without
>   local changes during upgrades.  The dpkg-maintscript-helper
>   tool, available from the dpkg package since
>   Wheezy, can help with this.
>   
> 
> to emphasize what packagers have to do instead of what changed in the
> text.

Thanks for the improvement.  I pushed the changes with it.

Cheers,

-- 
Charles Plessy
Tsurumi, Kanagawa, Japan


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#707077: obsolete conffiles: s/may/should/

2013-10-15 Thread Jonathan Nieder
Charles Plessy wrote:

> --- a/upgrading-checklist.sgml
> +++ b/upgrading-checklist.sgml
> @@ -62,6 +62,12 @@ Unreleased.
>  9.1.1.8
>The exception to the FHS for the /selinux was removed.
>
> +10.7.3
> +  During package upgrades, the removal of obsolete configuration files
> +  without local changes is now recommended (should) instead of
> +  suggested (may).  Note the dpkg-maintscript-helper
> +  tool, available from the dpkg package since
> +  Wheezy.

I'd say

  Packages should remove all obsolete configuration files without
  local changes during upgrades.  The dpkg-maintscript-helper
  tool, available from the dpkg package since
  Wheezy, can help with this.
  

to emphasize what packagers have to do instead of what changed in the
text.

But even without that tweak, this patch looks fine.

Thanks much for taking care of it.
Jonathan


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#707077: obsolete conffiles: s/may/should/

2013-10-15 Thread Charles Plessy
Le Tue, Oct 15, 2013 at 11:20:42AM -0700, Jonathan Nieder a écrit :
> Charles Plessy wrote:
> > Le Tue, Oct 15, 2013 at 03:07:29PM +0800, Paul Wise a écrit :
> >> On Mon, 2013-05-06 at 15:18 +0800, Paul Wise wrote:
> 
> >>> In policy section 10.7.3 Behavior, there is this sentence:
> >>>
> >>> Obsolete configuration files without local changes may be
> >>> removed by the package during upgrade.
> >>>
> >>> I would like to suggest that "may" be replaced with "should".
> 
> Seconded.

Thanks Paul for the ping and Jonathan for the assessment.  I second that
change as well.  I attached what I will commit soon unless some corrections
are proposed.

Cheers,

-- 
Charles Plessy
Tsurumi, Kanagawa, Japan
>From 4c3856a09e30d0dfe9bc0cb2594e0d83daf82706 Mon Sep 17 00:00:00 2001
From: Charles Plessy 
Date: Wed, 16 Oct 2013 08:13:01 +0900
Subject: [PATCH] Policy: on upgrades, recommend removing obsolete unchanged
 conf. files.

Wording: Paul Wise 
Seconded: Jonathan Nieder 
Seconded: Charles Plessy 
Closes: #707077
---
 debian/changelog | 5 +
 policy.sgml  | 6 --
 upgrading-checklist.sgml | 6 ++
 3 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 103f90a..0ef998e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -49,6 +49,11 @@ debian-policy (3.9.5.0) UNRELEASED; urgency=low
 Seconded: Steve Langasek 
 Seconded: Julien Cristau 
 Closes: #707183
+  * Policy: on upgrades, recommend removing obsolete unchanged conf. files.
+Wording: Paul Wise 
+Seconded: Jonathan Nieder 
+Seconded: Charles Plessy 
+Closes: #707077
   * debconf_spec: Document the 'escape' capability.
 Wording: Jonathan Nieder 
 Seconded: Charles Plessy 
diff --git a/policy.sgml b/policy.sgml
index 113429b..138d320 100644
--- a/policy.sgml
+++ b/policy.sgml
@@ -9009,8 +9009,10 @@ ln -fs ../sbin/sendmail debian/tmp/usr/bin/runq
 		  package is purged.
 	  
 	
-	Obsolete configuration files without local changes may be
-	removed by the package during upgrade.
+	Obsolete configuration files without local changes should be
+	removed by the package during upgrade.
+	  The dpkg-maintscript-helper tool, available from the
+	  dpkg package, can help for this task.
 	  
 
 	  
diff --git a/upgrading-checklist.sgml b/upgrading-checklist.sgml
index a77413d..f06ca80 100644
--- a/upgrading-checklist.sgml
+++ b/upgrading-checklist.sgml
@@ -62,6 +62,12 @@ Unreleased.
 9.1.1.8
   The exception to the FHS for the /selinux was removed.
   
+10.7.3
+  During package upgrades, the removal of obsolete configuration files
+  without local changes is now recommended (should) instead of
+  suggested (may).  Note the dpkg-maintscript-helper
+  tool, available from the dpkg package since
+  Wheezy.
 10.10
   The name of the files and directories installed by binary packages
   must be encoded in UTF-8 and should be restricted to ASCII when possible.
-- 
1.8.4.rc3



Bug#707077: obsolete conffiles: s/may/should/

2013-10-15 Thread Jonathan Nieder
Charles Plessy wrote:
> Le Tue, Oct 15, 2013 at 03:07:29PM +0800, Paul Wise a écrit :
>> On Mon, 2013-05-06 at 15:18 +0800, Paul Wise wrote:

>>> In policy section 10.7.3 Behavior, there is this sentence:
>>>
>>> Obsolete configuration files without local changes may be
>>> removed by the package during upgrade.
>>>
>>> I would like to suggest that "may" be replaced with "should".

Seconded.

Thanks,
Jonathan


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#707077: obsolete conffiles: s/may/should/

2013-10-15 Thread Charles Plessy
Le Tue, Oct 15, 2013 at 03:07:29PM +0800, Paul Wise a écrit :
> On Mon, 2013-05-06 at 15:18 +0800, Paul Wise wrote:
> 
> > In policy section 10.7.3 Behavior, there is this sentence:
> > 
> > Obsolete configuration files without local changes may be
> > removed by the package during upgrade.
> > 
> > I would like to suggest that "may" be replaced with "should".
> 
> Ping, what is the status of this?

Hi Paul and everybody,

in May I opened #707077 for tracking this issue; let's use it.

Are there objections to Paul's proposition ?

Cheers,

-- 
Charles Plessy
Tsurumi, Kanagawa, Japan


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#707077: obsolete conffiles: s/may/should/

2013-05-07 Thread Charles Plessy
Package: debian-policy
Severity: wishlist

Le Mon, May 06, 2013 at 06:09:48PM +0800, Paul Wise a écrit :
> 
> $ dpkg-query -W -f='${Conffiles}\n' | grep obsolete | wc -l
> 8
> 
> On a machine that has been running for a few years with apt pinned to
> experimental (then sid, testing), there are 59:
> 
> $ dpkg-query -W -f='${Conffiles}\n' | grep obsolete | wc -l
> 59
> 
> On master.debian.org there is only one:
> 
> pabs@master:~$ dpkg-query -W -f='${Conffiles}\n' | grep obsolete | wc -l
> 1
> 
> So the vast majority of packages obey this suggestion.

Hi Paul,

this is for the conffiles, but as worded in your suggestion, packages should
also do this for the other configuration files.

Anyway, I do not think that the Policy 3.9.5 will be uploaded soon (it still
needs to get sections on the triggers and on multi-arch), so this leaves some
time to see how well received is the idea, and if unexpected shortcomings are
found.

Would you or somebody else have time for one more round of advocacy ?  If I
understand well, since the Wheezy release it is not needed anymore to
pre-depend on dpkg to use dpkg-maintscript-helper, so passing this message
would be a good opportunity to spread the idea.

Cheers,

-- 
Charles Plessy
Tsurumi, Kanagawa, Japan


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org