Bug#707925: espeak: Makefile overrides compiler flags from the environment

2013-05-12 Thread Jason White
Package: espeak
Version: 1.47.07-1
Severity: normal

This is the latest Espeak package from the Git repository (not yet uploaded).

The makefile overrides CXXFLAGS, hence the flags supplied by debian/rules are
never applied. In particular, debug symbols are not generated.

Here's a proposed patch.


From cf92768d5d2a46dd3f253eacd82e577fcec9753d Mon Sep 17 00:00:00 2001
From: Jason White ja...@jasonjgw.net
Date: Sun, 12 May 2013 18:10:40 +1000
Subject: [PATCH] Don't override compiler flags from the environment in
 Makefile.

---
 debian/patches/compiler-flags | 13 +
 debian/patches/series |  1 +
 2 files changed, 14 insertions(+)
 create mode 100644 debian/patches/compiler-flags

diff --git a/debian/patches/compiler-flags b/debian/patches/compiler-flags
new file mode 100644
index 000..efe1add
--- /dev/null
+++ b/debian/patches/compiler-flags
@@ -0,0 +1,13 @@
+Index: espeak/src/Makefile
+===
+--- espeak.orig/src/Makefile   2013-05-12 17:08:13.919581196 +1000
 espeak/src/Makefile2013-05-12 17:13:29.755725063 +1000
+@@ -93,7 +93,7 @@
+ OBJS3=$(patsubst %.cpp,%.o,$(SRCS3))
+ LIBS3=-lstdc++ -L . -lespeak
+ 
+-CXXFLAGS=-O2
++CXXFLAGS?=-O2
+ 
+ 
+ all: $(BIN_NAME) $(LIB_NAME) $(STATIC_LIB_NAME) $(BIN2_NAME)
diff --git a/debian/patches/series b/debian/patches/series
index 9c398d1..60983b0 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
+compiler-flags
 sonic
-- 
1.8.1.3


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#707925: espeak: Makefile overrides compiler flags from the environment

2013-05-12 Thread Luke Yelavich
tags 707925 pending
thanks

On Sun, May 12, 2013 at 06:27:47PM EST, Jason White wrote:
 Package: espeak
 Version: 1.47.07-1
 Severity: normal
 
 This is the latest Espeak package from the Git repository (not yet uploaded).
 
 The makefile overrides CXXFLAGS, hence the flags supplied by debian/rules are
 never applied. In particular, debug symbols are not generated.
 
 Here's a proposed patch.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#707925: espeak: Makefile overrides compiler flags from the environment

2013-05-12 Thread Jason White
Luke Yelavich luke.yelav...@canonical.com wrote:
 tags 707925 pending

Still need to revert 8325799240b78caa949697860fb1c43a8d0fa814
the newer patch supersedes the one I sent with the bug report.

Thanks.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#707925: espeak: Makefile overrides compiler flags from the environment

2013-05-12 Thread Luke Yelavich
Oh right, wasn't really paying attension, just popped them both in. Will do, 
thanks.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org