Bug#709431: now 10 test failures

2013-06-05 Thread Praveen A
Hi Sam,

We can try and fix these test failures in parallel to fixing rack
compatibility issue. Just try gem install rack -v 1.4.5 and use
dpkg-buildpackage. Once the rack issue is solved, we just have to upload
shoulda-matchers.

Praveen

On Jun 5, 2013 1:31 AM, Praveen A prav...@debian.org wrote:

[I think it is better to discuss on the bug now as it is specific to
shoulda-matchers]

Hi Sam,

After applying your patch I got to just 10 test failures with about
461 passing. See the attached log.

Praveen


Bug#709431: now 10 test failures

2013-06-05 Thread Sam Ruby

On 06/05/2013 04:53 AM, Praveen A wrote:

Hi Sam,

We can try and fix these test failures in parallel to fixing rack
compatibility issue. Just try gem install rack -v 1.4.5 and use
dpkg-buildpackage. Once the rack issue is solved, we just have to upload
shoulda-matchers.


At the moment, I'm taking the errors at face value, i.e., I'm assuming 
that shoulda is working correctly, and is correctly pointing out that 
action_controller is broken.


Incidentally, the autorun warnings are easily correctable:

https://github.com/rails/rails/commit/e8dd88ac81b474cf076222ac20ff718a52872e2c

And there is a better fix: remove '/unit' (or '/autorun') entirely.

- Sam Ruby


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#709431: now 10 test failures

2013-06-05 Thread Praveen A
2013/6/5 Sam Ruby ru...@intertwingly.net:
 At the moment, I'm taking the errors at face value, i.e., I'm assuming that
 shoulda is working correctly, and is correctly pointing out that
 action_controller is broken.

ok.

 Incidentally, the autorun warnings are easily correctable:

 https://github.com/rails/rails/commit/e8dd88ac81b474cf076222ac20ff718a52872e2c

 And there is a better fix: remove '/unit' (or '/autorun') entirely.

I tried this, but I get the same warning.

http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-actionpack-3.2.git;a=commitdiff;h=11b46933998b8bed8c768bc275234d7cdffd1792

http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-activesupport-3.2.git;a=commitdiff;h=369b7391e2165c8b19cd0234ab8ec8e0eea39edf

 - Sam Ruby


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#709431: now 10 test failures

2013-06-04 Thread Praveen A
[I think it is better to discuss on the bug now as it is specific to
shoulda-matchers]

Hi Sam,

After applying your patch I got to just 10 test failures with about
461 passing. See the attached log.

Praveen


ruby-shoulda-matchers.testlog
Description: Binary data