Bug#711469: [Pkg-openldap-devel] Bug#711469: Can we have libslapi-dev back please:
On Wed, Nov 08, 2017 at 10:18:13AM +0100, Florian Schlichting wrote: Hi, thank you for pinging the bug, and for the patch. I intend to make an upload in the coming weeks and I will definitely evaluate this addition. Do you have a convenient test case that I could use for verifying the result? Like, what kind of test case? How do you test libldap2-dev? I was thinking of source for a hello-world slapi plugin that I could compile and run to ensure the header(s)/library(ies) have been installed sanely (and contents were properly processed by the build, etc). It's OK, I'm sure I'll find an example out on the web once I look. I think the issue behind this bug is the question whether a single-header -dev package is worthwhile, or if it could just be included in the general libldap2-dev package. I'm fine either way, I just need include/slapi-plugin.h be available in any Debian package. I don't think merging it into libldap2-dev is an option. libslapi-2.4.so.2.10.7 itself is shipped in slapd and the -dev package needs to depend on that to avoid shipping a broken symlink. BTW #650501 is also a request to ship more headers that are part of the openldap shared library API. In my understanding, shipping headers for shared libraries is a risk-free thing to do (unless you don't want people to use your shared library, but then what's the point of having it in the first place?) so I think that bug could also be acted upon without worrying too much. I will look at that one again. I think the headers it's talking about (slap.h and so on) are internal to slapd and not part of any ABI contract. If any other package were to depend on them, we'd have to go through some machinations (and probably manual work) to track ABI. At any rate I'd be hesitant to provide them if they aren't installed by upstream's "make install" - I will check that.
Bug#711469: [Pkg-openldap-devel] Bug#711469: Can we have libslapi-dev back please:
Hi Ryan, thanks for taking this up, and more generally for giving the openldap package so much love the last few years! > Hi, thank you for pinging the bug, and for the patch. I intend to make an > upload in the coming weeks and I will definitely evaluate this addition. Do > you have a convenient test case that I could use for verifying the result? Like, what kind of test case? How do you test libldap2-dev? There's no additional binary or something being built that would need to be tested. The build should result in a new binary package slapi-dev, which contains the unmodified /include/slapi-plugin.h from the upstream source, as well as a shared library symlink: -rw-r--r-- root/root 38351 2017-08-10 19:12 ./usr/include/slapi-plugin.h lrwxrwxrwx root/root 0 2017-08-10 19:12 ./usr/lib/x86_64-linux-gnu/libslapi.so -> libslapi-2.4.so.2.10.7 I think the issue behind this bug is the question whether a single-header -dev package is worthwhile, or if it could just be included in the general libldap2-dev package. I'm fine either way, I just need include/slapi-plugin.h be available in any Debian package. BTW #650501 is also a request to ship more headers that are part of the openldap shared library API. In my understanding, shipping headers for shared libraries is a risk-free thing to do (unless you don't want people to use your shared library, but then what's the point of having it in the first place?) so I think that bug could also be acted upon without worrying too much. Florian
Bug#711469: [Pkg-openldap-devel] Bug#711469: Can we have libslapi-dev back please:
On Tue, Nov 07, 2017 at 03:07:04PM +0100, Florian Schlichting wrote: Control: tags 711469 + patch Hi, thank you for pinging the bug, and for the patch. I intend to make an upload in the coming weeks and I will definitely evaluate this addition. Do you have a convenient test case that I could use for verifying the result? Thanks Ryan
