Bug#714542: [Build-common-hackers] Bug#714542: cdbs: Please use -- long option prefixes for Perl's Module::Build build system
Quoting Leon Timmermans (2013-06-30 21:49:40) As we take pride in CDBS being backporting-friendly, it would be nice if you could also test in a Squeeze (i.e. oldstable) environment that the change doesn't break things that far back either. The 'new style' arguments were introduced in Module::Build 0.17, released in March 2003. Backwards compatibility really shouldn't be an issue. Thanks for this reassuring data point! - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#714542: cdbs: Please use -- long option prefixes for Perl's Module::Build build system
Package: cdbs Version: 0.4.121 Severity: normal Tags: patch -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 While packaging Module::Build::Tiny [0], I stumbled about a problem in debhelper which is also present in cdbs. In the perl-build-vars makefile, it uses the key=var type of passing options. While this works fine with Module::Build which accepts all kinds of styles, if fails with Module::Build::Tiny, which insists on the --key value style. I've discussed this with upstream [1], who pointed out that - - using the -- long prefix version is a next-gen-perl-build-tool thing - - which is based on the now developped Build.PL spec [2] - - will probably be required by more consumers of Build.PL in the future At the moment we have one package waiting for Module::Build::Tiny in git but more are piling up on the CPAN. AFAICS, using the -- long prefix variant works just fine for traditional Module::Build using packages, so this change is backwards compatible. Find attached a patch against 1/class/perl-build-vars.mk.in. I've tested it by building around a dozen Build.PL using packages with cdbs and this patch, and I haven't seen any problems. Cheers, gregor [0] https://metacpan.org/release/Module-Build-Tiny [1] https://rt.cpan.org/Ticket/Display.html?id=85006 [2] https://github.com/Perl-Toolchain-Gang/cpan-api-buildpl/blob/master/lib/CPAN/API/BuildPL.pm - -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'experimental'), (500, 'testing'), (500, 'stable'), (500, 'oldstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.9-1-amd64 (SMP w/4 CPU cores) Locale: LANG=C, LC_CTYPE=de_AT.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash cdbs depends on no packages. Versions of packages cdbs recommends: ii autotools-dev 20130515.1 Versions of packages cdbs suggests: ii devscripts 2.13.2 - -- no debconf information -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJR0Fg2AAoJELs6aAGGSaoGrZoP/20ddjO3rRW0gsMUbzpGGB21 C33Wd6FJ1uL1n0v6I+59a3j4ocjN/KF1+RWXb7Ak3tdkEs7HNuOqO5rFb+ImRyNp 3wRyCqlY6KDWAq/J0/j6F+a9eAlpOJM1ameFjYk0oMIm7SpDtwhMUg5PJY0wxVms WjftmRgx5v9xGZx9W7Hb7iXVmHtYrApyg9EqYFWEqucCMIZfs39+A8xU8UF9xSVY IiT7BewAdpj3dTdtRroQ0/E++23Jl9UuSgrTFOq5ez3nAMZRzCT473QvoTo7t0VW XjCcox9J/7xgxRzTkbvem7s+DtRSOGpmOakH6Ogemh9Ga4aDRse6p7zD1rNIh8Zz 9d5ZKhV+bpXGWiPIJKaDS4UrN/MtrxeJMka+DB4veJqGqPoR4TULo1NTiFsOLmSW qV5hkV9/TS0ZqaMzXs9gZXfK9V/Pu0GDYrxWwRLf0uyaqWkhhU+0DqT2mqJmkt05 SNbj6jr+z1UfYO1IscxSJVHJZBkVKaoFOef7h1xmySX8U+4rDxntFVFNmXstlPqL pe8L+tDb0WzHq4fEQDAuhJH9whyr/rI2RdTviB2PWzXdlz7WRevqR1E9W1TEVwuW 0RstgMakEFUu2IfSBFLk24Ck1+jNR2TAn/JuNwo/1+9QpO5ZUNCrIq8GbhU3pMW7 lSfmLRL3tjvX9LYHIxXx =QQCn -END PGP SIGNATURE- diff --git a/1/class/perl-build-vars.mk.in b/1/class/perl-build-vars.mk.in index f20fdc7..ffaeb5c 100644 --- a/1/class/perl-build-vars.mk.in +++ b/1/class/perl-build-vars.mk.in @@ -26,13 +26,13 @@ include $(_cdbs_class_path)/perl-vars.mk$(_cdbs_makefile_suffix) #DEB_PERL_CONFIGURE_TARGET = DEB_PERL_CONFIGURE_ARGS ?= --installdirs vendor --config ccflags=$(or $(CFLAGS_$(cdbs_curpkg)),$(CFLAGS)) --config cxxflags=$(or $(CXXFLAGS_$(cdbs_curpkg)),$(CXXFLAGS)) --config ldflags=$(or $(LDFLAGS_$(cdbs_curpkg)),$(LDFLAGS)) -DEB_PERL_CONFIGURE_FLAGS ?= destdir=$(cdbs_perl_curdestdir) +DEB_PERL_CONFIGURE_FLAGS ?= --destdir $(cdbs_perl_curdestdir) DEB_PERL_BUILD_TARGET ?= build # Run tests by default, and loudly DEB_PERL_CHECK_TARGET ?= test -DEB_PERL_CHECK_FLAGS ?= verbose=1 +DEB_PERL_CHECK_FLAGS ?= --verbose 1 DEB_PERL_INSTALL_TARGET ?= install
Bug#714542: cdbs: Please use -- long option prefixes for Perl's Module::Build build system
Hi Gregor, Quoting gregor herrmann (2013-06-30 18:09:26) While packaging Module::Build::Tiny [0], I stumbled about a problem in debhelper which is also present in cdbs. In the perl-build-vars makefile, it uses the key=var type of passing options. While this works fine with Module::Build which accepts all kinds of styles, if fails with Module::Build::Tiny, which insists on the --key value style. [snip] Thanks for the detailed bugreport and patch. Find attached a patch against 1/class/perl-build-vars.mk.in. I've tested it by building around a dozen Build.PL using packages with cdbs and this patch, and I haven't seen any problems. As we take pride in CDBS being backporting-friendly, it would be nice if you could also test in a Squeeze (i.e. oldstable) environment that the change doesn't break things that far back either. Regards, - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#714542: cdbs: Please use -- long option prefixes for Perl's Module::Build build system
On Sun, 30 Jun 2013 20:53:41 +0200, Jonas Smedegaard wrote: Quoting gregor herrmann (2013-06-30 18:09:26) While packaging Module::Build::Tiny [0], I stumbled about a problem in debhelper which is also present in cdbs. In the perl-build-vars makefile, it uses the key=var type of passing options. While this works fine with Module::Build which accepts all kinds of styles, if fails with Module::Build::Tiny, which insists on the --key value style. [snip] Thanks for the detailed bugreport and patch. You're welcome. Find attached a patch against 1/class/perl-build-vars.mk.in. I've tested it by building around a dozen Build.PL using packages with cdbs and this patch, and I haven't seen any problems. As we take pride in CDBS being backporting-friendly, it would be nice if you could also test in a Squeeze (i.e. oldstable) environment that the change doesn't break things that far back either. Good point. And easy to do with cdbs since it has no rev-deps :) I've now built ~10 random packges which use cdbs and have a Build.PL in a squeeze cowbuilder chroot (with the patched cdbs), and all looks good, options are passed with -- and everything ends up where it's supposed to be. Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/ `. `' Member of VIBE!AT SPI, fellow of the Free Software Foundation Europe `- NP: Funny Van Dannen: Die Liebe signature.asc Description: Digital signature
Bug#714542: cdbs: Please use -- long option prefixes for Perl's Module::Build build system
As we take pride in CDBS being backporting-friendly, it would be nice if you could also test in a Squeeze (i.e. oldstable) environment that the change doesn't break things that far back either. The 'new style' arguments were introduced in Module::Build 0.17, released in March 2003. Backwards compatibility really shouldn't be an issue. Leon -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#714542: cdbs: Please use -- long option prefixes for Perl's Module::Build build system
Quoting gregor herrmann (2013-06-30 21:43:35) On Sun, 30 Jun 2013 20:53:41 +0200, Jonas Smedegaard wrote: Quoting gregor herrmann (2013-06-30 18:09:26) Find attached a patch against 1/class/perl-build-vars.mk.in. I've tested it by building around a dozen Build.PL using packages with cdbs and this patch, and I haven't seen any problems. As we take pride in CDBS being backporting-friendly, it would be nice if you could also test in a Squeeze (i.e. oldstable) environment that the change doesn't break things that far back either. Good point. And easy to do with cdbs since it has no rev-deps :) Thanks for noticing ;-) I've now built ~10 random packges which use cdbs and have a Build.PL in a squeeze cowbuilder chroot (with the patched cdbs), and all looks good, options are passed with -- and everything ends up where it's supposed to be. Excellent! Thanks a bunch. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
