Bug#716653: moreutils: FTBFS on hurd-i386

2013-07-11 Thread Joey Hess
Pino Toscano wrote:
 moreutils 0.49 does not compile on GNU/Hurd yet.
 
 The two attached patches fix the issues in two tools:

I've applied this.. Is that all that was needed to get everything to
build or is there additional porting to do?

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#716653: moreutils: FTBFS on hurd-i386

2013-07-11 Thread Pino Toscano
Alle giovedì 11 luglio 2013, Joey Hess ha scritto:
 Pino Toscano wrote:
  moreutils 0.49 does not compile on GNU/Hurd yet.
 
  The two attached patches fix the issues in two tools:
 I've applied this..

Thanks!

 Is that all that was needed to get everything to
 build or is there additional porting to do?

The two patches were all I needed to get moreutils build on the Hurd.

I occasionally use few of the moreutils tools, so I played with a couple 
(including ifdata) and they seemed working.
Of course if we (Hurd porters and users) find issues in the tools 
themselves (and not somewhere else in the stack), we will report them.

Thanks,
-- 
Pino Toscano


signature.asc
Description: This is a digitally signed message part.


Bug#716653: moreutils: FTBFS on hurd-i386

2013-07-10 Thread Pino Toscano
Source: moreutils
Version: 0.49
Severity: important
Tags: patch
User: debian-h...@lists.debian.org
Usertags: hurd

Hi,

moreutils 0.49 does not compile on GNU/Hurd yet.

The two attached patches fix the issues in two tools:
* hurd-ifdata.diff (for ifdata)
  include net/if.h on Hurd (needed for struct ifreq  co)
* hurd-parallel.diff (for parallel)
  WEXITED is not provided by Hurd's glibc yet, so I changed the check
  for __FreeBSD_kernel__ to a generic check for WEXITED not defined
  already

[1] 
https://buildd.debian.org/status/fetch.php?pkg=moreutilsarch=hurd-i386ver=0.49stamp=1373495739

Thanks,
-- 
Pino
--- a/ifdata.c
+++ b/ifdata.c
@@ -14,6 +14,10 @@
 	#include net/if.h
 #endif
 
+#if defined(__GNU__)
+	#include net/if.h
+#endif
+
 #include netinet/in.h
 #include errno.h
 #include fcntl.h
--- a/parallel.c
+++ b/parallel.c
@@ -32,7 +32,7 @@
 #include sys/wait.h
 #include unistd.h
 
-#if defined(__FreeBSD_kernel__)
+#if !defined(WEXITED)
 #define WEXITED 0
 #endif