Bug#718258: libgphoto2-2: turns on libusbx debugging by default

[Martin Pitt]

Hey Markus,

Markus Koschany [2013-07-29 15:36 +0200]:
> this change has been already incorporated in the latest upstream release
> of libgphoto2. I suggest upgrading to version 2.5.2 which fixes the bug
> automatically.

Right, I know, but we don't yet have that in Debian (I guess since
there is no current maintainer). Hence I thought I'd send a patch
here, as this was introduced by the recent NMU.

Thanks,

Martin
-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)


signature.asc
Description: Digital signature

Bug#718258: libgphoto2-2: turns on libusbx debugging by default

[Markus Koschany]

On 29.07.2013 15:13, Martin Pitt wrote:
> tag 718258 patch
> user ubuntu-de...@lists.ubuntu.com
> usertags 718258 origin-ubuntu saucy ubuntu-patch
> thanks
> 
> Hello again,
> 
> Martin Pitt [2013-07-29 14:47 +0200]:
>> The change from libusb to libusbx in libgphoto2 now somehow turned on libusbx
>> debugging by default:
> 
> Tested debdiff (uploaded to Ubuntu).

Hello,

this change has been already incorporated in the latest upstream release
of libgphoto2. I suggest upgrading to version 2.5.2 which fixes the bug
automatically.

Regards,

Markus




signature.asc
Description: OpenPGP digital signature

Bug#718258: libgphoto2-2: turns on libusbx debugging by default

[Martin Pitt]

tag 718258 patch
user ubuntu-de...@lists.ubuntu.com
usertags 718258 origin-ubuntu saucy ubuntu-patch
thanks

Hello again,

Martin Pitt [2013-07-29 14:47 +0200]:
> The change from libusb to libusbx in libgphoto2 now somehow turned on libusbx
> debugging by default:

Tested debdiff (uploaded to Ubuntu).

Martin
-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
diff -Nru libgphoto2-2.4.14/debian/changelog libgphoto2-2.4.14/debian/changelog
--- libgphoto2-2.4.14/debian/changelog  2013-07-25 23:28:36.0 +0200
+++ libgphoto2-2.4.14/debian/changelog  2013-07-29 14:54:42.0 +0200
@@ -1,3 +1,11 @@
+libgphoto2 (2.4.14-2.3ubuntu1) saucy; urgency=low
+
+  * Add 02-libusbx_no_debug.patch: Disable libusbx debugging messages by
+default. They can be turned back on with $LIBUSB_DEBUG if necessary.
+(LP: #1206104, Closes: #718258)
+
+ -- Martin Pitt   Mon, 29 Jul 2013 14:54:17 +0200
+
 libgphoto2 (2.4.14-2.3) unstable; urgency=low
 
   * Non-maintainer upload.
diff -Nru libgphoto2-2.4.14/debian/patches/02-libusbx_no_debug.patch 
libgphoto2-2.4.14/debian/patches/02-libusbx_no_debug.patch
--- libgphoto2-2.4.14/debian/patches/02-libusbx_no_debug.patch  1970-01-01 
01:00:00.0 +0100
+++ libgphoto2-2.4.14/debian/patches/02-libusbx_no_debug.patch  2013-07-29 
14:54:14.0 +0200
@@ -0,0 +1,17 @@
+Description: Disable libusbx debugging messages by default. They can be turned 
back on with $LIBUSB_DEBUG if necessary.
+Author: Martin Pitt 
+Bug-Ubuntu: https://launchpad.net/bugs/1206104
+Bug-Debian: http://bugs.debian.org/718258
+
+Index: libgphoto2-2.4.14/libgphoto2_port/libusb1/libusb1.c
+===
+--- libgphoto2-2.4.14.orig/libgphoto2_port/libusb1/libusb1.c   2013-07-29 
14:48:49.0 +0200
 libgphoto2-2.4.14/libgphoto2_port/libusb1/libusb1.c2013-07-29 
14:52:26.250620640 +0200
+@@ -260,7 +260,6 @@
+   port->pl->config = port->pl->interface = port->pl->altsetting = -1;
+ 
+   libusb_init (&port->pl->ctx);
+-  libusb_set_debug (port->pl->ctx, 255);
+ 
+ #if 0
+   usb_init ();
diff -Nru libgphoto2-2.4.14/debian/patches/series 
libgphoto2-2.4.14/debian/patches/series
--- libgphoto2-2.4.14/debian/patches/series 2013-07-25 23:25:22.0 
+0200
+++ libgphoto2-2.4.14/debian/patches/series 2013-07-29 14:52:11.0 
+0200
@@ -2,3 +2,4 @@
 #11_hurd_no_path_max_bsdsource
 01-increase_max_entries.patch
 kFreeBSD-ENODATA.patch
+02-libusbx_no_debug.patch


signature.asc
Description: Digital signature

Bug#718258: libgphoto2-2: turns on libusbx debugging by default

[Martin Pitt]

Package: libgphoto2-2
Version: 2.4.14-2.3

Hello,

The change from libusb to libusbx in libgphoto2 now somehow turned on libusbx
debugging by default:

$ gphoto2 --auto-detect
libusbx: debug [libusb_get_device_list]
libusbx: debug [discovered_devs_append] need to increase capacity
libusbx: debug [libusb_get_device_descriptor]

The same can be seen when starting shotwell, so it's not a problem in the
gphoto2 binary. It does not happen with "lsusb", so it seems it's also not a
problem with libusbx itself.

Thanks for considering,

Martin

-- 
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)


signature.asc
Description: Digital signature