Package: fancontrol
Version: 1:3.1.2-6
Severity: normal
Tags: patch upstream


A rename of the fancontrol config-file /etc/fancontrol results in an
error message when '/etc/init.d/fancontrol start' is called even if
CONF is set corretly.
The CONF-variable is not passed through in the 'start' case at least.

Have a look at the patch.


-- System Information:
Debian Release: 6.0.7
  APT prefers oldstable-updates
  APT policy: (500, 'oldstable-updates'), (500, 'oldstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-bpo.2-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=de_DE (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages fancontrol depends on:
ii  lsb-base                3.2-23.2squeeze1 Linux Standard Base 3.2 init scrip

fancontrol recommends no packages.

fancontrol suggests no packages.

-- Configuration Files:
/etc/init.d/fancontrol changed:
.. /lib/lsb/init-functions
[ -f /etc/default/rcS ] && . /etc/default/rcS
PATH=/bin:/usr/bin:/sbin:/usr/sbin
DAEMON=/usr/sbin/fancontrol
DESC="fan speed regulator"
NAME="fancontrol"
PIDFILE=/var/run/fancontrol.pid
CONF=/etc/fancontrol.conf
test -x $DAEMON || exit 0
case "$1" in
  start)
        if [ -f $CONF ] ; then
                if $DAEMON --check $CONF 1>/dev/null 2>/dev/null ; then
                        log_daemon_msg "Starting $DESC" "$NAME"
                        start-stop-daemon --start --quiet --background 
--pidfile $PIDFILE --startas $DAEMON $CONF
                        log_end_msg $?
                else
                        log_failure_msg "Not starting fancontrol, broken 
configuration file; please re-run pwmconfig."
                fi
        else
                if [ "$VERBOSE" != no ]; then
                        log_warning_msg "Not starting fancontrol; run pwmconfig 
first."
                fi
        fi
        ;;
  stop)
        log_daemon_msg "Stopping $DESC" "$NAME"
        start-stop-daemon --stop --quiet --pidfile $PIDFILE --oknodo --startas 
$DAEMON
        rm -f $PIDFILE
        log_end_msg $?
        ;;
  restart)
        $0 stop
        sleep 3
        $0 start
        ;;
  force-reload)
        if start-stop-daemon --stop --test --quiet --pidfile $PIDFILE --startas 
$DAEMON ; then
                $0 restart
        fi
        ;;
  status)
        status_of_proc $DAEMON $NAME && exit 0 || exit $?
        ;;
  *)
        log_success_msg "Usage: /etc/init.d/fancontrol 
{start|stop|restart|force-reload|status}"
        exit 1
        ;;
esac
exit 0


-- no debconf information
--- /tmp/fancontrol     2013-08-19 17:55:40.634568822 +0200
+++ /etc/init.d/fancontrol      2013-08-19 17:54:20.845714678 +0200
@@ -25,9 +25,9 @@
 case "$1" in
   start)
        if [ -f $CONF ] ; then
-               if $DAEMON --check 1>/dev/null 2>/dev/null ; then
+               if $DAEMON --check $CONF 1>/dev/null 2>/dev/null ; then
                        log_daemon_msg "Starting $DESC" "$NAME"
-                       start-stop-daemon --start --quiet --background 
--pidfile $PIDFILE --startas $DAEMON
+                       start-stop-daemon --start --quiet --background 
--pidfile $PIDFILE --startas $DAEMON $CONF
                        log_end_msg $?
                else
                        log_failure_msg "Not starting fancontrol, broken 
configuration file; please re-run pwmconfig."
--- /tmp/fancontrol     2013-08-19 17:55:40.634568822 +0200
+++ /etc/init.d/fancontrol      2013-08-19 17:54:20.845714678 +0200
@@ -25,9 +25,9 @@
 case "$1" in
   start)
        if [ -f $CONF ] ; then
-               if $DAEMON --check 1>/dev/null 2>/dev/null ; then
+               if $DAEMON --check $CONF 1>/dev/null 2>/dev/null ; then
                        log_daemon_msg "Starting $DESC" "$NAME"
-                       start-stop-daemon --start --quiet --background 
--pidfile $PIDFILE --startas $DAEMON
+                       start-stop-daemon --start --quiet --background 
--pidfile $PIDFILE --startas $DAEMON $CONF
                        log_end_msg $?
                else
                        log_failure_msg "Not starting fancontrol, broken 
configuration file; please re-run pwmconfig."

Reply via email to