Bug#720670: aptitude-robot: FTBFS with perl 5.18: test failures

2013-08-26 Thread Elmar Heeb
Control: tag -1 - unreproducible + confirmed
Control: retitle -1 FTBFS when only Moose is installed

On 25.Aug.2013, at 15:31 , gregor herrmann gre...@debian.org wrote:
 On Sat, 24 Aug 2013 13:23:16 +0100, Dominic Hargreaves wrote:
 TOPDIR=/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14 
 prove -I/build/dom-aptitude-robot
 _1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14 
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2
 .14/t
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/001_help-option.t
  . ok
 Use of uninitialized value in concatenation (.) or string at 
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/a
 ptitude-robot-1.2.14/aptitude-robot line 99.
 Use of uninitialized value in concatenation (.) or string at 
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/a
 ptitude-robot-1.2.14/aptitude-robot line 103.
 
 #   Failed test 'check for error string'
 #   at 
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/010_simple-calls.t
  line 22.
 #  got: 'Error:  is not a aptitude-robot config directory'
 # expected: 'Error: /dev/null is not a aptitude-robot config directory'
 
 That's an interesting case, and I can't reproduce it.
 From the output above it looks like config_dir is not set, but I
 don't see how this can happen; and it doesn't seem to be Perl 5.18
 related.
 
 Anyway, I'm sure Elmar and Axel know their code better and can come
 up with some insights :)

Finally, we could reproduce this bug.  It has nothing to do with perl 5.18 but 
with Moose vs. Mouse.

aptitude-robot uses Any::Moose which defaults to Mouse unless Moose is already 
installed on the system.  With Mouse it would run the tests without problems 
but with Moose (and no Mouse installed) we get exactly the errors Dominic 
reported.

We still need to find out why Moose would trigger these errors when Mouse does 
not.  Ultimately however, this is the motivation to replace Mouse with Moo, 
which was planned anyway.

Regards -- Elmar



signature.asc
Description: Message signed with OpenPGP using GPGMail


Bug#720670: aptitude-robot: FTBFS with perl 5.18: test failures

2013-08-26 Thread gregor herrmann
On Mon, 26 Aug 2013 12:36:10 +0200, Elmar Heeb wrote:

  That's an interesting case, and I can't reproduce it.
  From the output above it looks like config_dir is not set, but I
  don't see how this can happen; and it doesn't seem to be Perl 5.18
  related.
  
  Anyway, I'm sure Elmar and Axel know their code better and can come
  up with some insights :)
 
 Finally, we could reproduce this bug.  It has nothing to do with perl 5.18 
 but with Moose vs. Mouse.
 
 aptitude-robot uses Any::Moose which defaults to Mouse unless Moose
 is already installed on the system. With Mouse it would run the
 tests without problems but with Moose (and no Mouse installed) we
 get exactly the errors Dominic reported.

Nice catch!
 
Cheers,
gregor


-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT  SPI, fellow of the Free Software Foundation Europe
   `-   NP: Das Internationale Format: Seit Dem Man Mich


signature.asc
Description: Digital signature


Bug#720670: aptitude-robot: FTBFS with perl 5.18: test failures

2013-08-25 Thread gregor herrmann
Control: tag -1 + unreproducible

On Sat, 24 Aug 2013 13:23:16 +0100, Dominic Hargreaves wrote:

 Source: aptitude-robot
 Version: 1.2.14-1
 Severity: serious
 Justification: transition imminent
 User: debian-p...@lists.debian.org
 Usertags: perl-5.18-transition
 Tags: sid jessie
 
 This package FTBFS with perl 5.18:
 
 TOPDIR=/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14 
 prove -I/build/dom-aptitude-robot
 _1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14 
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2
 .14/t
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/001_help-option.t
  . ok
 Use of uninitialized value in concatenation (.) or string at 
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/a
 ptitude-robot-1.2.14/aptitude-robot line 99.
 Use of uninitialized value in concatenation (.) or string at 
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/a
 ptitude-robot-1.2.14/aptitude-robot line 103.
 
 #   Failed test 'check for error string'
 #   at 
 /build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/010_simple-calls.t
  line 22.
 #  got: 'Error:  is not a aptitude-robot config directory'
 # expected: 'Error: /dev/null is not a aptitude-robot config directory'

That's an interesting case, and I can't reproduce it.
From the output above it looks like config_dir is not set, but I
don't see how this can happen; and it doesn't seem to be Perl 5.18
related.

Anyway, I'm sure Elmar and Axel know their code better and can come
up with some insights :)


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT  SPI, fellow of the Free Software Foundation Europe
   `-   NP: Cat Stevens: I'm Gonna Get Me A Gun


signature.asc
Description: Digital signature


Bug#720670: aptitude-robot: FTBFS with perl 5.18: test failures

2013-08-24 Thread Dominic Hargreaves
Source: aptitude-robot
Version: 1.2.14-1
Severity: serious
Justification: transition imminent
User: debian-p...@lists.debian.org
Usertags: perl-5.18-transition
Tags: sid jessie

This package FTBFS with perl 5.18:

TOPDIR=/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14 
prove -I/build/dom-aptitude-robot
_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2
.14/t
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/001_help-option.t
 . ok
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/a
ptitude-robot-1.2.14/aptitude-robot line 99.
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/a
ptitude-robot-1.2.14/aptitude-robot line 103.

#   Failed test 'check for error string'
#   at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/010_simple-calls.t
 line 22.
#  got: 'Error:  is not a aptitude-robot config directory'
# expected: 'Error: /dev/null is not a aptitude-robot config directory'
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/a
ptitude-robot-1.2.14/aptitude-robot line 99.
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/a
ptitude-robot-1.2.14/aptitude-robot line 103.

#   Failed test 'empty config dir should result in `aptitude full-upgrade ~U 
!~ahold`'
#   at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/010_simple-calls.t
 line 30.
# Structures begin differing at:
#  $got-[0] = Does not exist
# $expected-[0] = 'aptitude'

#   Failed test 'no error reported'
#   at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/010_simple-calls.t
 line 32.
#  got: 'Error:  is not a aptitude-robot config directory'
# expected: ''
# Looks like you failed 3 tests of 7.
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/010_simple-calls.t
  
Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/7 subtests 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/011_simple-calls-from-cli.t
 ... ok
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/014_pass-extra-options-cli.t
 .. ok
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/aptitude-robot
 line 99.
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/aptitude-robot
 line 103.

#   Failed test 'multiple file case'
#   at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/020_runparts.t
 line 34.
# Structures begin differing at:
#  $got-[0] = Does not exist
# $expected-[0] = 
'/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/testdata/multiple-files/pkglist.d/10_foo'
# Looks like you failed 1 test of 4.
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/020_runparts.t
  
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/4 subtests 
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/aptitude-robot
 line 99.
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/aptitude-robot
 line 103.

#   Failed test 'lines for single file case'
#   at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/021_file-slurp.t
 line 25.
# Structures begin differing at:
#  $got-[0] = Does not exist
# $expected-[0] = '+ foo'
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/aptitude-robot
 line 99.
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/aptitude-robot
 line 103.

#   Failed test 'lines for multiple file case'
#   at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/021_file-slurp.t
 line 34.
# Structures begin differing at:
#  $got-[0] = Does not exist
# $expected-[0] = '+ foo'
# Looks like you failed 2 tests of 4.
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/t/021_file-slurp.t
 .. 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/4 subtests 
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/aptitude-robot
 line 99.
Use of uninitialized value in concatenation (.) or string at 
/build/dom-aptitude-robot_1.2.14-1-i386-p0IDb0/aptitude-robot-1.2.14/aptitude-robot
 line 103.

#   Failed test 'multiple file case'
#