Bug#728362: awffull: /etc/cron.daily/awffull needs update

2015-04-30 Thread Ludovic Rousseau 

Le 31/10/2013 14:47, Boris Pek a écrit :

Hi Barry,


Package: awffull
Version: 3.10.2-4
Severity: important
Tags: patch

I get the following error message:

/etc/cron.daily/awffull:
Use of Really Quiet (-Q) has been deprecated.
Initially processed default config file: /etc/awffull/awffull.conf
awffull 3.10.2 (Linux 3.11-1-amd64) English
Error: Can't open log file 0
ERROR: Running awffull, exit status: 1

obviously /etc/cron.daily/awffull is not updated to the current command line
parameters

...


As I see in debian/changelog you have already fixed this problem (see #496968).
Could you look at new bug report?


I just upgraded to Jessie. I get the exact same bug.

$ dpkg -l awffull
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name   Version  Architecture Description
+++-==---=
ii  awffull3.10.2-4 i386 web server log analysis program


$ sudo /etc/cron.daily/awffull
Use of Really Quiet (-Q) has been deprecated.
Initially processed default config file: /etc/awffull/awffull.conf
awffull 3.10.2 (Linux 2.6.32-042stab106.4) French
Error: Can't open log file 0
ERROR: Running awffull, exit status: 1


I think we have two problems in the /etc/cron.daily/awffull script:

1. it uses -Q that has been removed from the arguments list

2. is uses -v 0 to set the log level to 0. But that confuses awffull and 0 is 
taken as a file name. -v does not take any argument.


You can easily reproduce the output with:

$ awffull -v 0 foobar -Q
Use of Really Quiet (-Q) has been deprecated.
Initially processed default config file: /etc/awffull/awffull.conf
awffull 3.10.2 (Linux 2.6.32-042stab106.4) French
Error: Can't open log file 0

I guess the correct command line should be:
$ awffull foobar
Error: Can't open log file foobar

Proposed patch (-v 0 and -Q removed):
--- debian/awffull.cron.daily   2013-10-18 19:35:33.0 +0200
+++ /etc/cron.daily/awffull 2015-04-30 14:43:35.940490933 +0200
@@ -30,7 +30,7 @@
   [ -w ${OUTDIR} ] || { echo ERROR: OutputDir not writable: ${OUTDIR}; 
continue; };
 
   # Run Really quietly, exit with status code if !0

-  ${AWFFULL} -v 0 ${i} -Q || { echo ERROR: Running awffull, exit status: $?; 
continue; };
+  ${AWFFULL} ${i} || { echo ERROR: Running awffull, exit status: $?; 
continue; };
   RET=$?;
 
   # Non rotated log file

@@ -43,7 +43,7 @@
 # readable ?
 [ -r ${NLOGFILE} ] || { echo WARNING: Non-rotated LogFile is not readable: 
${NLOGFILE}; continue; };
 
-${AWFFULL} -v 0 ${i} -Q ${NLOGFILE};

+${AWFFULL} ${i} ${NLOGFILE};
 RET=$?;
   fi;
 done;


--
Dr. Ludovic Rousseau


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#728362: awffull: /etc/cron.daily/awffull needs update

2015-04-30 Thread Ludovic Rousseau 

Le 31/10/2013 14:47, Boris Pek a écrit :

Hi Barry,


Package: awffull
Version: 3.10.2-4
Severity: important
Tags: patch

I get the following error message:

/etc/cron.daily/awffull:
Use of Really Quiet (-Q) has been deprecated.
Initially processed default config file: /etc/awffull/awffull.conf
awffull 3.10.2 (Linux 3.11-1-amd64) English
Error: Can't open log file 0
ERROR: Running awffull, exit status: 1

obviously /etc/cron.daily/awffull is not updated to the current command line
parameters

...


As I see in debian/changelog you have already fixed this problem (see #496968).
Could you look at new bug report?


Another update for /etc/cron.daily/awffull is to fix how the configuration file 
is used using:
  -c, --config=FILE  Use configuration file 'FILE'

You should not use ${AWFFULL} ${i} because ${i} will be used as the log file 
not as the configuration file.
So you will get the error:
Cannot recognise log format. Manually configure LogType in the config file.
ERROR: Running awffull, exit status: 1


Use ${AWFFULL} --config=${i} instead.


A complete patch could be:
--- debian/awffull.cron.daily   2013-10-18 19:35:33.0 +0200
+++ /etc/cron.daily/awffull 2015-04-30 15:17:23.514272321 +0200
@@ -30,7 +30,7 @@
   [ -w ${OUTDIR} ] || { echo ERROR: OutputDir not writable: ${OUTDIR}; 
continue; };
 
   # Run Really quietly, exit with status code if !0

-  ${AWFFULL} -v 0 ${i} -Q || { echo ERROR: Running awffull, exit status: $?; 
continue; };
+  ${AWFFULL} --config=${i} || { echo ERROR: Running awffull, exit status: 
$?; continue; };
   RET=$?;
 
   # Non rotated log file

@@ -43,7 +43,7 @@
 # readable ?
 [ -r ${NLOGFILE} ] || { echo WARNING: Non-rotated LogFile is not readable: 
${NLOGFILE}; continue; };
 
-${AWFFULL} -v 0 ${i} -Q ${NLOGFILE};

+${AWFFULL} --config=${i} ${NLOGFILE};
 RET=$?;
   fi;
 done;

--
Dr. Ludovic Rousseau


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#728362: awffull: /etc/cron.daily/awffull needs update

2013-10-31 Thread Tobias Schlemmer 
Package: awffull
Version: 3.10.2-4
Severity: important
Tags: patch

I get the following error message:

/etc/cron.daily/awffull:
Use of Really Quiet (-Q) has been deprecated.
Initially processed default config file: /etc/awffull/awffull.conf
awffull 3.10.2 (Linux 3.11-1-amd64) English
Error: Can't open log file 0
ERROR: Running awffull, exit status: 1

obviously /etc/cron.daily/awffull is not updated to the current command line
parameters



-- System Information:
Debian Release: jessie/sid
  APT prefers testing-proposed-updates
  APT policy: (500, 'testing-proposed-updates'), (500, 'oldstable-updates'), 
(500, 'unstable'), (500, 'testing'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-1-amd64 (SMP w/6 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages awffull depends on:
ii  debconf [debconf-2.0]  1.5.51
ii  libc6  2.17-93
ii  libgd3 2.1.0-3
ii  libgeoip1  1.5.1-2
ii  libpcre3   1:8.31-2
ii  zlib1g 1:1.2.8.dfsg-1

awffull recommends no packages.

Versions of packages awffull suggests:
ii  apache2-bin [httpd]  2.4.6-3
pn  dnshistory   none
ii  ttf-dejavu   2.33+svn2514-3

-- Configuration Files:
/etc/cron.daily/awffull changed:
AWFFULL=/usr/bin/awffull
AWFFULL_CONFDIR=/etc/awffull
[ -x ${AWFFULL} ] || exit 0;
[ -d ${AWFFULL_CONFDIR} ] || exit 0;
for i in ${AWFFULL_CONFDIR}/*.conf; do
  # run agains a rotated or normal logfile
  LOGFILE=`awk '$1 ~ /^LogFile$/ {print $2}' $i`;
  # empty ?
  [ -s ${LOGFILE} ] || { echo ERROR: LogFile not found: ${LOGFILE}; 
continue; };
  # readable ?
  [ -r ${LOGFILE} ] || { echo ERROR: LogFile is not readable: ${LOGFILE}; 
continue; };
  
  # there was a output ?
  OUTDIR=`awk '$1 ~ /^OutputDir$/ {print $2}' $i`;
  #  exists something ?
  [ ${OUTDIR} !=  ] || { echo ERROR: OutputDir not defined: ${OUTDIR}; 
continue; };
  # its a directory ?
  [ -d ${OUTDIR} ] || { echo ERROR: OutputDir is not a directory: ${OUTDIR}; 
continue; };
  # its writable ?
  [ -w ${OUTDIR} ] || { echo ERROR: OutputDir not writable: ${OUTDIR}; 
continue; };
  # Run Really quietly, exit with status code if !0
  ${AWFFULL} ${i} || { echo ERROR: Running awffull, exit status: $?; 
continue; };
  RET=$?;
  # Non rotated log file
  NLOGFILE=`awk '$1 ~ /^LogFile$/ {gsub(/\.[0-9]+(\.gz)?/,); print $2}' $i`;
  # check current log, if last log is a rotated logfile
  if [ ${LOGFILE} != ${NLOGFILE} ]; then
# empty ?
[ -s ${NLOGFILE} ] || { echo INFO: Non-rotated LogFile empty or missing: 
${NLOGFILE}; continue; };
# readable ?
[ -r ${NLOGFILE} ] || { echo WARNING: Non-rotated LogFile is not 
readable: ${NLOGFILE}; continue; };
${AWFFULL} -v 0 ${i} -Q ${NLOGFILE};
RET=$?;
  fi;
done;
exit $RET;


-- debconf information:
  awffull/logfile: /var/log/apache2/access.log.1
  awffull/directory: /var/www/awffull


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#728362: awffull: /etc/cron.daily/awffull needs update

2013-10-31 Thread Boris Pek 
Hi Barry,

 Package: awffull
 Version: 3.10.2-4
 Severity: important
 Tags: patch

 I get the following error message:

 /etc/cron.daily/awffull:
 Use of Really Quiet (-Q) has been deprecated.
 Initially processed default config file: /etc/awffull/awffull.conf
 awffull 3.10.2 (Linux 3.11-1-amd64) English
 Error: Can't open log file 0
 ERROR: Running awffull, exit status: 1

 obviously /etc/cron.daily/awffull is not updated to the current command line
 parameters

 ...

As I see in debian/changelog you have already fixed this problem (see #496968).
Could you look at new bug report?

Best regards,
Boris


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org