Bug#729500: ssh-agent-filter: [PATCH] Resolve FTBFS from linking order

[Daniel T Chen]

Package: ssh-agent-filter
Version: 0.3-1
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu trusty ubuntu-patch

Dear Maintainer,

In Ubuntu 14.04, the attached patch was applied to achieve the following:

  * Changed linking order to resolve FTBFS.


I've taken the liberty of realigning the linker variables to bring them
in line with convention. Also, I noticed in the master git branch that
you've moved to boost:iostreams; I made the least invasive change to
resolve the FTBFS. Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers precise-updates
  APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500, 
'precise'), (100, 'precise-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.8.0-33-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru ssh-agent-filter-0.3/debian/patches/0001-Fix-linking-order-FTBFS.patch ssh-agent-filter-0.3/debian/patches/0001-Fix-linking-order-FTBFS.patch
--- ssh-agent-filter-0.3/debian/patches/0001-Fix-linking-order-FTBFS.patch	1969-12-31 19:00:00.0 -0500
+++ ssh-agent-filter-0.3/debian/patches/0001-Fix-linking-order-FTBFS.patch	2013-11-13 10:46:52.0 -0500
@@ -0,0 +1,21 @@
+Index: ssh-agent-filter-0.3/Makefile
+===
+--- ssh-agent-filter-0.3.orig/Makefile	2013-10-25 19:18:11.0 -0400
 ssh-agent-filter-0.3/Makefile	2013-11-13 10:46:50.438054442 -0500
+@@ -19,7 +19,7 @@
+ CXXFLAGS ?= -g -O2 -Wall -Wold-style-cast
+ 
+ CXXFLAGS += -std=c++11
+-LDFLAGS += -lstdc++ -lboost_program_options -lboost_filesystem -lboost_system -lnettle
++LDADD += -lstdc++ -lboost_program_options -lboost_filesystem -lboost_system -lnettle
+ 
+ all: ssh-agent-filter.1 afssh.1 ssh-askpass-noinput.1
+ 
+@@ -30,6 +30,7 @@
+ 	help2man -n $ -o $@ -N ./$
+ 
+ ssh-agent-filter: ssh-agent-filter.o
++	$(CXX) $ -o $@ $(LDADD)
+ 
+ ssh-agent-filter.o: ssh-agent-filter.C rfc4251.h ssh-agent.h version.h
+ 
diff -Nru ssh-agent-filter-0.3/debian/patches/series ssh-agent-filter-0.3/debian/patches/series
--- ssh-agent-filter-0.3/debian/patches/series	1969-12-31 19:00:00.0 -0500
+++ ssh-agent-filter-0.3/debian/patches/series	2013-11-13 10:30:27.0 -0500
@@ -0,0 +1 @@
+0001-Fix-linking-order-FTBFS.patch

Bug#729500: ssh-agent-filter: [PATCH] Resolve FTBFS from linking order

[Timo Weingärtner]

Hi Daniel,

On Wed, 2013-11-13 10:58:24 you wrote:
 Package: ssh-agent-filter
 Version: 0.3-1
 Severity: wishlist
 Tags: patch
 User: ubuntu-de...@lists.ubuntu.com
 Usertags: origin-ubuntu trusty ubuntu-patch
 
 Dear Maintainer,
 
 In Ubuntu 14.04, the attached patch was applied to achieve the following:
 
   * Changed linking order to resolve FTBFS.
 
 
 I've taken the liberty of realigning the linker variables to bring them
 in line with convention. Also, I noticed in the master git branch that
 you've moved to boost:iostreams; I made the least invasive change to
 resolve the FTBFS. Thanks for considering the patch.

Your patch has two effects:
* use $(CXX) instead of $(CC) for linking
* discard $(LDFLAGS) from dpkg-buildflags

The latter produces a lintian warning.

I still don't understand what your problem is, but does it help to just add:

CC = $(CXX)

to Makefile?

It would have been nice to include the sbuild log of the FTBFS.


Greetings
Timo

signature.asc
Description: This is a digitally signed message part.

Bug#729500: ssh-agent-filter: [PATCH] Resolve FTBFS from linking order

[Dan Chen]

Hi Timo, indeed, that discard is an error on my part, sorry! I'll sbuild
with the proposed minimal CC change soon.

For one arch, the buildd log is at
https://launchpadlibrarian.net/155030371/buildlog_ubuntu-trusty-armhf.ssh-agent-filter_0.3-1_FAILEDTOBUILD.txt.gz
.

Bug#729500: ssh-agent-filter: [PATCH] Resolve FTBFS from linking order

[Timo Weingärtner]

On Wed, 2013-11-13 13:06:40 Dan Chen wrote:
 Hi Timo, I've attached three files (two sbuild logs and a fixed debdiff
 against the current sid source package). In summary, only changing CC =
 $(CXX) still FTBFS; the build log for timestamp 1253 demonstrates that
 failure.
 
 Adjusting the link order without touching CC (cf. attached debdiff)
 resolves the FTBFS; the build log for timestamp 1256 demonstrates.

I can reproduce when adding --as-needed to LDFLAGS, but I can't find anything 
in the sbuild log (not introduced by dpkg-buildflags) or ubuntu's binutils/gcc 
changelog.


Greetings
Timo

signature.asc
Description: This is a digitally signed message part.