Bug#729956: Forwarded upstream

[Diane Trout]

Hi

I pushed my work to alioth on the branch detrout-python3

I modified the statsmodels build recipe to at least partially use
pybuild, and the documentation build uses python 3 components instead
of python 2.

I skipped the 4 tests that failed for me, that had an upstream bug
report, when a new version comes out those skips need to be removed.

I tried rebasing on Yuri's latest commit but there was conflicts over
which version of ipython to use that I'm to tired to resolve right now.

It builds python 2 and python 3 statsmodels and statsmodels-lib as well
as the documentation. (including the example notebooks)

There was also some changes because there's were new temp files that
dh_auto_clean needed to fix.

I tried to commit changes in logical chunks for easier review.

There's still problems with dependencies in sid, so all my testing was
against my unclean testing laptop.

Someone should probably debdiff the package against a previous build to
see if anything important got lost.

If it looks good we can discuss if I need to rebase, or if you just
want to merge this work, but right now I need to go to sleep.

Diane

Bug#729956: Forwarded upstream

[Andreas Tille]

Hi Diane,

On Wed, Sep 06, 2017 at 09:35:58PM -0700, Diane Trout wrote:
> > > 
> > >  libpython2.7-stdlib : Breaks: python-pandas-lib (<= 0.20.3-1) but
> > > 0.20.3-1 is to be installed
> > 
> > I also get an error in the Python 2.7 test suite so I have no idea
> > where to continue with the Python3 stuff.
> 
> Was the test failures you were see 4 instances like whats shown below?
> ...

I'm not sure and I was doing it on a box yesterday evening which I can
not access right now.  At least I need to say that what you quotet in
your mail looked somehow different to what I remember from yesterday.

I have added python3-* Build-Depends now in the debian-python3 branch
but I can not build any mire due to the python-pandas versioned breaks
issue. :-(

Kind regards

 Andreas.

-- 
http://fam-tille.de

Bug#729956: Forwarded upstream

[Diane Trout]

On Thu, 2017-09-07 at 06:20 +0200, Andreas Tille wrote:
> Hi Diane,
> 
> On Wed, Sep 06, 2017 at 02:45:14PM -0700, Diane Trout wrote:
> > 
> > > but the build failed (for other reasons).  I'd willing to work on
> > > this
> > > but I definitely need help since I'm lacking the needed Python
> > > knowledge.
> > 
> > Hi,
> > 
> > I saw your debian-python3 branch for statsmodels.
> > 
> > The dependencies added in the package should probably be added as
> > build-dependencies. and not package dependencies.
> > 
> > I believe python-zmq should be a binary dependency. 
> 
> Thanks for the hints.
>  
> > I was trying to build it right now but I'm getting a dependency
> > error.
> > 
> >  libpython2.7-stdlib : Breaks: python-pandas-lib (<= 0.20.3-1) but
> > 0.20.3-1 is to be installed
> 
> I also get an error in the Python 2.7 test suite so I have no idea
> where to continue with the Python3 stuff.

Was the test failures you were see 4 instances like whats shown below?

I found a match upstream at:
https://github.com/statsmodels/statsmodels/issues/3401

I've gotten failures with 2.7 and 3.6.

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in
runTest
self.test(*self.arg)
  File
"/home/diane/src/debian/statsmodels/.pybuild/pythonX.Y_2.7/build/statsm
odels/tsa/statespace/tests/test_save.py", line 65, in test_varmax
res.save('test_save_varmax.p')
  File
"/home/diane/src/debian/statsmodels/.pybuild/pythonX.Y_2.7/build/statsm
odels/base/wrapper.py", line 72, in save
save_pickle(self, fname)
  File
"/home/diane/src/debian/statsmodels/.pybuild/pythonX.Y_2.7/build/statsm
odels/iolib/smpickle.py", line 15, in save_pickle
cPickle.dump(obj, fout, protocol=-1)
  File "stringsource", line 2, in
statsmodels.tsa.statespace._statespace.zStatespace.__reduce_cython__
TypeError:
self._design,self._initial_state,self._initial_state_cov,self._obs,self
._obs_cov,self._obs_intercept,self._selected_state_cov,self._selection,
self._state_cov,self._state_intercept,self._transition cannot be
converted to a Python object for pickling

Bug#729956: Forwarded upstream

[Andreas Tille]

Hi Diane,

On Wed, Sep 06, 2017 at 02:45:14PM -0700, Diane Trout wrote:
> 
> > but the build failed (for other reasons).  I'd willing to work on
> > this
> > but I definitely need help since I'm lacking the needed Python
> > knowledge.
> 
> Hi,
> 
> I saw your debian-python3 branch for statsmodels.
> 
> The dependencies added in the package should probably be added as
> build-dependencies. and not package dependencies.
> 
> I believe python-zmq should be a binary dependency. 

Thanks for the hints.
 
> I was trying to build it right now but I'm getting a dependency error.
> 
>  libpython2.7-stdlib : Breaks: python-pandas-lib (<= 0.20.3-1) but
> 0.20.3-1 is to be installed

I also get an error in the Python 2.7 test suite so I have no idea
where to continue with the Python3 stuff.

> Should I see if I can get a python3 build working? and who should I
> send any progress too?

Keep on commiting on the debian-python3 branch (or fix everything inside
the debian branch - I simply did not want to crash this ...)  Please
just consider me a poor uneducated guy who only intended to inspire the
more skilled ones to pick up an urgent topic. :-P

Kind regards

 Andreas.

-- 
http://fam-tille.de

Bug#729956: Forwarded upstream

[Matthias Klose]

On 06.09.2017 23:45, Diane Trout wrote:
> I was trying to build it right now but I'm getting a dependency error.
> 
>  libpython2.7-stdlib : Breaks: python-pandas-lib (<= 0.20.3-1) but
> 0.20.3-1 is to be installed

this is unrelated, and waiting for #874413.

Bug#729956: git-dpm (was Re: Bug#729956: Forwarded upstream)

[Scott Kitterman]

On September 6, 2017 5:16:13 PM EDT, Yuri D'Elia  wrote:
>On Wed, Sep 06 2017, Andreas Tille wrote:
>>> But just to confirm, I see that statsmodels is just using
>>> git-buildpackage?
>>
>> Yes.
>
>Ok, that's reassuring. I'll have a look at the packaging, since I'm
>already on alioth.
>
>But since DPMT is CC-ed (I normally follow via gmane), I take the
>occasion to say that I _really_ _REALLY_ wished the recommendation on
>git-dpm to be reconsidered, or at least relaxed.
>
>For a newcomer, git-dpm is overkill and underdocumented.
>>From an outsider, making a Debian package already looks daunting.
>git-dpm does not help.
>
>On the other hand, git-buildpackage is a relatively smooth progression
>from quilt, and it does provide some added convenience.

Conveniently, we already decided to switch:

https://wiki.debian.org/Python/GitPackagingPQ

Scott K

Bug#729956: Forwarded upstream

[Diane Trout]

> but the build failed (for other reasons).  I'd willing to work on
> this
> but I definitely need help since I'm lacking the needed Python
> knowledge.

Hi,

I saw your debian-python3 branch for statsmodels.

The dependencies added in the package should probably be added as
build-dependencies. and not package dependencies.

I believe python-zmq should be a binary dependency. 

I was trying to build it right now but I'm getting a dependency error.

 libpython2.7-stdlib : Breaks: python-pandas-lib (<= 0.20.3-1) but
0.20.3-1 is to be installed

Should I see if I can get a python3 build working? and who should I
send any progress too?

Diane

Bug#729956: git-dpm (was Re: Bug#729956: Forwarded upstream)

[Yuri D'Elia]

On Wed, Sep 06 2017, Andreas Tille wrote:
>> But just to confirm, I see that statsmodels is just using
>> git-buildpackage?
>
> Yes.

Ok, that's reassuring. I'll have a look at the packaging, since I'm
already on alioth.

But since DPMT is CC-ed (I normally follow via gmane), I take the
occasion to say that I _really_ _REALLY_ wished the recommendation on
git-dpm to be reconsidered, or at least relaxed.

For a newcomer, git-dpm is overkill and underdocumented.
>From an outsider, making a Debian package already looks daunting.
git-dpm does not help.

On the other hand, git-buildpackage is a relatively smooth progression
from quilt, and it does provide some added convenience.

Bug#729956: Forwarded upstream

[Andreas Tille]

Hi Yuri,

On Wed, Sep 06, 2017 at 10:35:57PM +0200, Yuri D'Elia wrote:
> I always built from source, not with the debian packaging.
> 
> >https://anonscm.debian.org/git/debian-science/packages/statsmodels.git
> >
> > but the build failed (for other reasons).  I'd willing to work on this
> > but I definitely need help since I'm lacking the needed Python
> > knowledge.
> 
> Hum, I always assumed the consensus on python packages was to manage
> them with git-dpm, which is something I cannot digest (and has stopped
> me from contributing more).
> 
> But just to confirm, I see that statsmodels is just using
> git-buildpackage?

Yes.
 
Kind regards

Andreas.

-- 
http://fam-tille.de

Bug#729956: Forwarded upstream

[Yuri D'Elia]

On Wed, Sep 06 2017, Andreas Tille wrote:
> Great.  What about sending a patch with your changes to the bug
> report?  I've added a branch debian-python3 to

I always built from source, not with the debian packaging.

>https://anonscm.debian.org/git/debian-science/packages/statsmodels.git
>
> but the build failed (for other reasons).  I'd willing to work on this
> but I definitely need help since I'm lacking the needed Python
> knowledge.

Hum, I always assumed the consensus on python packages was to manage
them with git-dpm, which is something I cannot digest (and has stopped
me from contributing more).

But just to confirm, I see that statsmodels is just using
git-buildpackage?

Bug#729956: Forwarded upstream

[Andreas Tille]

Hi,

On Wed, Sep 06, 2017 at 05:26:13PM +0200, Yuri D'Elia wrote:
> On Wed, Sep 06 2017, Andreas Tille wrote:
> > I opened an issue on Github
> >
> > https://github.com/statsmodels/statsmodels/issues/3909
> >
> > requesting Python3 support.
> 
> I concur with what was said in the issue.
> This is only an issue with debian's packaging.
> 
> I've been using a custom build of statsmodels on python3 since years
> as well without problems.

Great.  What about sending a patch with your changes to the bug
report?  I've added a branch debian-python3 to

   https://anonscm.debian.org/git/debian-science/packages/statsmodels.git

but the build failed (for other reasons).  I'd willing to work on this
but I definitely need help since I'm lacking the needed Python
knowledge.

Kind regards

  Andreas.

-- 
http://fam-tille.de

Bug#729956: Forwarded upstream

[Yuri D'Elia]

On Wed, Sep 06 2017, Andreas Tille wrote:
> I opened an issue on Github
>
> https://github.com/statsmodels/statsmodels/issues/3909
>
> requesting Python3 support.

I concur with what was said in the issue.
This is only an issue with debian's packaging.

I've been using a custom build of statsmodels on python3 since years
as well without problems.

Bug#729956: Forwarded upstream

[Andreas Tille]

control: forwarded upstream

Hi,

I opened an issue on Github

https://github.com/statsmodels/statsmodels/issues/3909

requesting Python3 support.

Kind regards

  Andreas.

-- 
http://fam-tille.de