Bug#734357: [pkg-golang-devel] Bug#734357:

2016-02-02 Thread Tianon Gravi 
On 15 December 2015 at 13:32, Michael Hudson-Doyle
 wrote:
> FWIW, this bug is fixed properly upstream in git tip and will be part of 1.6.

Nice! :D

The upstream fix applies cleanly against Go 1.5 -- do you think it's
important enough to include now, or just wait for Go 1.6 to be GA
(which will be soon anyways)?

♥,
- Tianon
  4096R / B42F 6819 007F 00F8 8E36  4FD4 036A 9C25 BF35 7DD4

Bug#734357: [pkg-golang-devel] Bug#734357:

2016-02-02 Thread Tianon Gravi 
On 2 February 2016 at 23:45, Michael Hudson-Doyle
 wrote:
> TBH, I'm a bit vague about what problems exactly this bug actually
> caused (even though I spent half a week fixing it!). So I guess that's
> a shrug from me -- if it's not causing active problems and 1.6 is, as
> you say, around the corner, I'd just as soon leave it out.

Cool, fair enough!  Let's plan to circle back for Go 1.6 then. :)

♥,
- Tianon
  4096R / B42F 6819 007F 00F8 8E36  4FD4 036A 9C25 BF35 7DD4

Bug#734357: [pkg-golang-devel] Bug#734357:

2016-02-02 Thread Michael Hudson-Doyle 
Well,

On 3 February 2016 at 20:41, Tianon Gravi  wrote:
> On 15 December 2015 at 13:32, Michael Hudson-Doyle
>  wrote:
>> FWIW, this bug is fixed properly upstream in git tip and will be part of 1.6.
>
> Nice! :D
>
> The upstream fix applies cleanly against Go 1.5 -- do you think it's
> important enough to include now, or just wait for Go 1.6 to be GA
> (which will be soon anyways)?

TBH, I'm a bit vague about what problems exactly this bug actually
caused (even though I spent half a week fixing it!). So I guess that's
a shrug from me -- if it's not causing active problems and 1.6 is, as
you say, around the corner, I'd just as soon leave it out.

Cheers,
mwh

Bug#734357:

2015-12-15 Thread Michael Hudson-Doyle 
FWIW, this bug is fixed properly upstream in git tip and will be part of 1.6.

Bug#734357:

2015-12-06 Thread Michael Hudson-Doyle 
A proper fix for this went upstream and will be in 1.6 fwiw

Bug#734357: golang: Use correct ELF header for armhf binaries

2014-01-10 Thread James Page 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Michael

On 06/01/14 21:52, Michael Stapelberg wrote:
 In Ubuntu, the attached patch was applied to achieve the
 following:
 
 * 016-armhf-elf-header.patch: Use correct ELF header for armhf
 binaries.
 
 This resolved linking issues that we saw on armhf in Ubuntu; I
 *think* that this is OK to hold in Debian as well despite that
 fact that you don't see the same linking issue due to dpkg
 differences.
 
 Thanks for considering the patch.
 In the patch, I don’t see a Forwarded: header. Has this been
 forwarded to upstream? In 
 https://code.google.com/p/go/source/browse/src/cmd/ld/elf.c, at the
 time of writing, I don’t see the changes.
 
 I’m comfortable applying this once it gets applied upstream, but I
 am a bit hesitant until then, mostly because I’m not very familiar
 with ARM intricacies (even though I use Go on a couple of ARM
 boxen).

I've raised a bug and attached the patch in the upstream issue tracker:

http://code.google.com/p/go/issues/detail?id=7094

I would have raised the code review myself, but struggling to get my
google login working from the command line with mercurial.

Cheers

James

- -- 
James Page
Ubuntu and Debian Developer
james.p...@ubuntu.com
jamesp...@debian.org
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJSz8sbAAoJEL/srsug59jD1J0QAJeynapABuOcNyeGy8YH2Un9
OvC00WkUQdHNW7zMWb3mdpSgZJC01aHNfRtNtLRrmukrdZqpg9MSG3/IAHU97BJI
Hb9HRo59oHuEHar3HEMJ9wBDOYDrZcPwO135Nz66FnWnH4elLv85Amw2AR7XX8nW
xVTMRvlNek0MfjJirVPJ/0HKdEpUA/jxHBZhyPFD6VP28PemiUz4hImjijCyzm9h
n/7OIkQatXuLsuJRIDbtATZjVZbhrdWU9quGl/D5IHWqHuYc0O70i80B79QUneAu
SqEYVSLSgC0/gOzwJQ/PwQB1m7EI35eLqVR0QMvznr1b6egu4bHSXJF3DE6T3Exf
70AlHlC3Vft5kt1gqUucuhqqVzT0YidRiqMtoWV22iN2TBp0leUxL6JJCfyMJbcs
gnq26Y5qhgq+OO2giY3yeRXsfEqhTNy48KbT1hhxS/SBQ2yGQ8P00r6q4jbFV37X
kbadvJZRYYxNx97Qi2IyogJU8ANZqEw/bA80ngKWq4XFEPmOPpgGuUI9gISIQRsz
wI4m1C3fC2idBSD9vSI1JTgI630OiZqEdjFo/vJROmhJO5yACaMw0UhZNQXx/pAL
WQxerrygHtDJCT4hqPpWH77jeiThiqrx5cViSBbXfJ050ekwlLW4ozXPH3Xk8k7R
fuY0933i7fCQsZgOn291
=F6NT
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#734357: golang: Use correct ELF header for armhf binaries

2014-01-06 Thread James Page 
Package: golang
Version: 2:1.2-2
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu trusty ubuntu-patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * 016-armhf-elf-header.patch: Use correct ELF header for armhf binaries.

This resolved linking issues that we saw on armhf in Ubuntu; I *think* that 
this is
OK to hold in Debian as well despite that fact that you don't see the same 
linking
issue due to dpkg differences.

Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers trusty-updates
  APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500, 
'trusty'), (100, 'trusty-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12.0-7-generic (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru golang-1.2/debian/changelog golang-1.2/debian/changelog
diff -Nru golang-1.2/debian/patches/016-armhf-elf-header.patch golang-1.2/debian/patches/016-armhf-elf-header.patch
--- golang-1.2/debian/patches/016-armhf-elf-header.patch	1970-01-01 01:00:00.0 +0100
+++ golang-1.2/debian/patches/016-armhf-elf-header.patch	2013-07-15 09:52:57.0 +0100
@@ -0,0 +1,21 @@
+Description: Use correct ELF header for armhf binaries.
+Author: Adam Conrad adcon...@ubuntu.com
+Last-Update: 2013-07-08
+
+Index: golang-1.1/src/cmd/ld/elf.c
+===
+--- golang-1.1.orig/src/cmd/ld/elf.c	2013-07-08 08:25:34.246800925 -0600
 golang-1.1/src/cmd/ld/elf.c	2013-07-08 08:25:56.254801274 -0600
+@@ -57,7 +57,11 @@
+ 	case '5':
+ 		// we only use EABI on linux/arm
+ 		if(HEADTYPE == Hlinux)
+-			hdr.flags = 0x502; // has entry point, Version5 EABI
++#ifdef __ARM_PCS_VFP
++			hdr.flags = 0x5000402; // has entry point, Version5 EABI, hard-float ABI
++#else
++			hdr.flags = 0x5000202; // has entry point, Version5 EABI, soft-float ABI
++#endif
+ 		// fallthrough
+ 	default:
+ 		hdr.phoff = ELF32HDRSIZE;	/* Must be be ELF32HDRSIZE: first PHdr must follow ELF header */
diff -Nru golang-1.2/debian/patches/series golang-1.2/debian/patches/series
--- golang-1.2/debian/patches/series	2013-12-31 17:24:50.0 +
+++ golang-1.2/debian/patches/series	2014-01-06 09:35:45.0 +
@@ -1 +1,2 @@
 add-src-pkg-debug-elf-testdata-hello.patch
+016-armhf-elf-header.patch

Bug#734357: golang: Use correct ELF header for armhf binaries

2014-01-06 Thread Michael Stapelberg 
Hi James,

Thanks for submitting this patch to Debian, I appreciate that.

James Page james.p...@ubuntu.com writes:
 In Ubuntu, the attached patch was applied to achieve the following:

   * 016-armhf-elf-header.patch: Use correct ELF header for armhf binaries.

 This resolved linking issues that we saw on armhf in Ubuntu; I *think* that 
 this is
 OK to hold in Debian as well despite that fact that you don't see the same 
 linking
 issue due to dpkg differences.

 Thanks for considering the patch.
In the patch, I don’t see a Forwarded: header. Has this been forwarded
to upstream? In
https://code.google.com/p/go/source/browse/src/cmd/ld/elf.c, at the time
of writing, I don’t see the changes.

I’m comfortable applying this once it gets applied upstream, but I am a
bit hesitant until then, mostly because I’m not very familiar with ARM
intricacies (even though I use Go on a couple of ARM boxen).

-- 
Best regards,
Michael


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org