Bug#734878: xrdp: install fails if xrdp user already exists

2014-01-13 Thread Chris J Arges 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 01/11/2014 12:58 PM, Vincent Bernat wrote:
 ❦ 10 janvier 2014 16:38 CET, Chris J Arges
 chris.j.ar...@canonical.com :
 
 If xrdp already exists as a user the package fails to install
 with the following error message:
 
 Setting up xrdp (0.6.0-1) ... adduser: The user `xrdp' already
 exists. Exiting. dpkg: error processing xrdp (--configure): 
 subprocess installed post-installation script returned error exit
 status 1
 
 This patch checks if the user already exists and doesn't
 re-create the user.
 
 I'm not sure if this is the best approach, as an existing user
 might not have the correct setup to use this package.
 
 adduser is already checking if the user already exists. You get an
 error because the user exists and is not what is expected, notably,
 it is not a system user. I don't think we can accept an existing
 normal user: if it is affected to a real user, this user will have
 privileged access to the xrdp daemon.
 

This makes sense. Please close this as you see fit.
Thanks,
- --chris j arges
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJS1CpmAAoJEPNFAiJniEz2bO8H+gPd4lZa1KVYOBBhoVRxhq9G
/yzkC0X8S0HEfYy1zE94nRxMprpjDdenXmtcad4owd4bq8MR0vC5Lfvb62kPutPh
ER23z62gtXvQk+C7kf1YHEWvUwPVr80zTKeODUauu7n4dk/LOpyLlnlf9Psa19tn
p/eWpYa9W0xvJ6zr0K4Tj+/aj9lvRiZlKw4a/hUwTS4b+jKkrCWrBvJ1LMQLtrNA
zcEOHvlX961Th9o60ghtGsjF0ZLW16hd71VQLHaOkVrDgbApPU8yjVmrU7pJfUOp
eBNYmdK1/2mU7wBqIVR/+c7iSmwRsHYz48OEFDOCfviRTwEGaj78J8mKqyVCCLY=
=v6VN
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#734878: xrdp: install fails if xrdp user already exists

2014-01-11 Thread Vincent Bernat 
 ❦ 10 janvier 2014 16:38 CET, Chris J Arges chris.j.ar...@canonical.com :

 If xrdp already exists as a user the package fails to install with the
 following error message:

 Setting up xrdp (0.6.0-1) ...
 adduser: The user `xrdp' already exists. Exiting.
 dpkg: error processing xrdp (--configure):
  subprocess installed post-installation script returned error exit status 1

 This patch checks if the user already exists and doesn't re-create the user.

 I'm not sure if this is the best approach, as an existing user might not
 have the correct setup to use this package.

adduser is already checking if the user already exists. You get an error
because the user exists and is not what is expected, notably, it is not
a system user. I don't think we can accept an existing normal user: if
it is affected to a real user, this user will have privileged access to
the xrdp daemon.
-- 
printk(KERN_ERR msp3400: chip reset failed, penguin on i2c bus?\n);
2.2.16 /usr/src/linux/drivers/char/msp3400.c


signature.asc
Description: PGP signature

Bug#734878: xrdp: install fails if xrdp user already exists

2014-01-10 Thread Chris J Arges 
Package: xrdp
Version: 0.6.0-1
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu trusty ubuntu-patch

Dear Maintainer,
If xrdp already exists as a user the package fails to install with the
following error message:

Setting up xrdp (0.6.0-1) ...
adduser: The user `xrdp' already exists. Exiting.
dpkg: error processing xrdp (--configure):
 subprocess installed post-installation script returned error exit status 1

This patch checks if the user already exists and doesn't re-create the user.

I'm not sure if this is the best approach, as an existing user might not
have the correct setup to use this package.

Thanks for considering the patch.


-- System Information:
Debian Release: wheezy/sid
  APT prefers precise-updates
  APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500,
'precise')
Architecture: amd64 (x86_64)

Kernel: Linux 3.8.0-35-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru xrdp-0.6.0/debian/changelog xrdp-0.6.0/debian/changelog
diff -Nru xrdp-0.6.0/debian/postinst xrdp-0.6.0/debian/postinst
--- xrdp-0.6.0/debian/postinst	2012-09-29 08:04:03.0 -0500
+++ xrdp-0.6.0/debian/postinst	2014-01-10 09:34:35.0 -0600
@@ -10,8 +10,8 @@
 ADDUSER=/usr/sbin/adduser
 
 [ -d /var/run/xrdp ] || mkdir -p /var/run/xrdp
-$ADDUSER --system --disabled-password --disabled-login --home /var/run/xrdp \
- --no-create-home --quiet --group $XRDP
+id -u $XRDP /dev/null || $ADDUSER --system --disabled-password \
+--disabled-login --home /var/run/xrdp --no-create-home --quiet --group $XRDP
 
 $CHOWN -R $XRDP:$XRDP /etc/xrdp