Bug#735940: Info received (fixed)

[Zooko Wilcox-OHearn]

Package: tahoe-lafs
Version: 1.10.0-1
Control: tag -1 + fixed-upstream


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940: Info received (fixed)

[intrigeri]

Hi Zooko,

Zooko Wilcox-OHearn wrote (30 Apr 2014 16:54:52 GMT) :
> Package: tahoe-lafs
> Version: 1.10.0-1
> Tags: fixed-upstream

This syntax would work when creating a bug report, but not when
modifying an existing one. Instead, you'll want to either email the
bug address with the "Control: tag -1 + fixed-upstream" pseudo-header,
or the control@bugs.d.o address.

Resources:

  https://www.debian.org/Bugs/server-control
  
https://wiki.debian.org/HowtoUseBTS#Tweaking_bug_reports:_control.40bugs.debian.org

Alternatively, the bts(1) command-line tool, available in the
devscripts package, does it just right for you :)

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940: Info received (fixed)

[Zooko Wilcox-OHearn]

Package: tahoe-lafs
Version: 1.10.0-1
Tags: fixed-upstream


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940: fixed

[Zooko Wilcox-OHearn]

Tags: fixed-upstream


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940: fixed

[intrigeri]

Zooko Wilcox-OHearn wrote (30 Apr 2014 02:39:47 GMT) :
> We, the upstream Tahoe-LAFS maintainers, believe we have fixed this
> issue in Tahoe-LAFS.

Great news! You might want to indicate this tagging this Debian bug
"fixed-upstream". Cheers :)


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940: fixed

[Zooko Wilcox-OHearn]

We, the upstream Tahoe-LAFS maintainers, believe we have fixed this
issue in Tahoe-LAFS. We've closed the ticket in the Tahoe-LAFS issue
tracker:

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2208

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940: Minified JavaScript has been removed upstream

[Daira Hopwood]

The original complaint is now fixed upstream:
https://tahoe-lafs.org/trac/tahoe-lafs/changeset/b6c0297deea77cce2aa22458f0645635cb1aa50d/trunk
or on github:
https://github.com/tahoe-lafs/tahoe-lafs/commit/b6c0297deea77cce2aa22458f0645635cb1aa50d


We had intended to use the same versions of d3 and jquery that were available
as Debian packages, but were stymied by two problems:

1. There appears to be a non-backward-compatible change in the 3.x releases of 
d3
   that breaks zoom and pan functionality.
2. We cannot reproduce the d3.js file in the libjs-d3 3.4.6-1 package from the
   upstream sources (filed as 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745688 ).


I hope this change is sufficient despite not using the libjs-d3 or libjs-jquery 
packages.
Please feel free to cherry-pick the above changeset to make a new version of 
the Debian
tahoe-lafs 1.10 package; it should backport cleanly. (Alternatively, it will be 
in the
upcoming Tahoe-LAFS v1.11 release.)

-- 
Daira Hopwood ⚥



signature.asc
Description: OpenPGP digital signature

Bug#735940: Sourceless file

[Ramakrishnan Muthukrishnan]

affects 735940 libjs-d3
thanks

Dear libjs-d3 maintainer,

Would you please take a look at the tahoe-lafs bug #735940 report
thread?
-- 
  Ramakrishnan


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940:

[Zooko Wilcox-OHearn]

I asked on the #debian-devel IRC channel, and mrvn there suggested
that we update the d3 source package and upload the new version to
mentors.debian.org. Also Clint on that channel said that we should
file a bug on libjs-d3.

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940:

[Daira Hopwood]

We've run into a snag: the file d3-2.4.6.time.min.js (or any more recent 
version of that
file) does not appear to be packaged in the libjs-d3 package. Loading only 
d3.min.js is
not sufficient, since it does not include the d3.time "module". We cannot find 
any other
Debian package that includes it.

In addition, version 3.3.13-1 of libjs-d3 contains a d3.min.js file that is not
binary-identical to the d3.min.js from the upstream d3 project (downloadable 
from
). We are loath to proceed
with using the Debian version without knowing what the differences from 
upstream are.
(They could just be differences in minification, but that isn't clear.)

-- 
Daira Hopwood ⚥



signature.asc
Description: OpenPGP digital signature

Bug#735940: proposed fix

[Zooko Wilcox-OHearn]

Dear Olivier, et al.:

Please see Daira Hopwood's proposal:

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2208#comment:3

Steps 1, 2, and 3 should be done by Tahoe-LAFS upstream and steps 4,
5, and 6 should be done by Debian. Please go ahead and do your three
steps in parallel with us while we do our three steps!

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940:

[Zooko Wilcox-OHearn]

On Tue, Mar 25, 2014 at 2:26 PM, Olivier Schwander
 wrote:
> Hum, I just gave a quick look at the debian package and I do not understand 
> how these files are produced for the binary package.
>
> Do you know where these 3 files come from ? Some magic inside setup.py or 
> something like that ?

Yes, all files in src/allmydata/web/static ¹ get included into the
package built by "setup.py", because it is marked in setup.py as being
"package_data" ².

Does that answer your question?

¹ https://tahoe-lafs.org/trac/tahoe-lafs/browser/trunk/src/allmydata/web/static

² 
https://tahoe-lafs.org/trac/tahoe-lafs/browser/trunk/setup.py?annotate=blame&rev=37c8b733a57dbbc4f9db0b3c8427f4e07994c3fa#L454

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940:

[Olivier Schwander]

Le 25 Mar 2014 14:41, Zooko Wilcox-OHearn a écrit:
> Yes, all files in src/allmydata/web/static ¹ get included into the
> package built by "setup.py", because it is marked in setup.py as being
> "package_data" ².
>
> Does that answer your question?

Oh, ok, I made a mess with my find invocation and missed the js files
inside src/allmydata/web/static.

So, a first solution would be to remove the .min.js upstream, add
original .js and to do the minification at build time.

Since the two js libraries are shipped in Debian the best would be to
remove these js files completely (at least in the debian version of the
sources) and to use the files provided by the debian packages.

Creating a symlink between /usr/share/javascript/d3/d3.min.js (and
others) and the static directory of tahoe-lafs (which seems to be
/usr/lib/python2.7/dist-packages/allmydata/web/static/ right now) would
do the job. Another solution (as found in the libjs-rickshaw package)
would be to replace all the references to a local foobar.min.js file in
html files by the absolute path of the debian-provided js file with a
quick and dirty sed -i in the debian rules (I have no idea of why is
file is publicly accessible through a web server). I don't know how the
webserver part of tahoe works, but it may also be possible to the
directory /usr/share/javascript/ to the search path.

By the way, it's just some ideas, I do not have any experience with js
in debian packages and I do not have any time to work precisely on it
these days.

Best,

Olivier


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940:

[Zooko Wilcox-OHearn]

I would like for Tahoe-LAFS v1.10 to be included in Debian, but I
don't understand how to make it use the Debian packages of jquery and
d3. That doesn't sound like something that could be done by changing
the upstream source of Tahoe-LAFS. How can I help?

Regards,

Zooko


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940:

[Olivier Schwander]

Le 25 Mar 2014 14:10, Zooko Wilcox-OHearn a écrit:
> I would like for Tahoe-LAFS v1.10 to be included in Debian, but I
> don't understand how to make it use the Debian packages of jquery and
> d3. That doesn't sound like something that could be done by changing
> the upstream source of Tahoe-LAFS. How can I help?

Hum, I just gave a quick look at the debian package and I do not
understand how these files are produced for the binary package.

Do you know where these 3 files come from ? Some magic inside setup.py
or something like that ?


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940:

[Olivier Schwander]

Le 25 Mar 2014 13:07, Zooko Wilcox-OHearn a écrit:
> Would it satisfy the Debian policy if those Javascript files were
> stored in source form instead of minified form?

The Debian policy is to avoid shipping external libraries inside a
source package. Since libjs-jquery (1.7.2+dfsg-1) and libjs-d3
(3.3.13-1) are available in sid, the best is to use the minified js
files provided by these two packages. Before doing that, we should check
tahoe-lafs is really working with these version, since they are
different from the ones provided with tahoe-lafs.

Best,

Olivier


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940:

[Zooko Wilcox-OHearn]

Would it satisfy the Debian policy if those Javascript files were
stored in source form instead of minified form?

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940: Sourceless file

[Zooko Wilcox-OHearn]

I'm a maintainer of Tahoe-LAFS. I just opened a ticket to track this
issue in our issue tracker:

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2208

Regards,

Zooko Wilcox-O'Hearn

Founder, CEO, and Customer Support Rep
https://LeastAuthority.com
Freedom matters.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#735940: Sourceless file

[bastien ROUCARIES]

Package: src:tahoe-lafs 
Version:1.10.0-1
Severity: serious
User: debian...@lists.debian.org
Usertags: source-contains-prebuilt-javascript-object
X-Debbugs-CC: ftpmas...@debian.org

It seems that this file are not sourced:

src/allmydata/web/static/d3-2.4.6.min.js
src/allmydata/web/static/d3-2.4.6.time.min.js
src/allmydata/web/static/jquery-1.6.1.min.js

Bastien


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org