Bug#738104: gramps: Event-types non-editable after upgrade

2014-02-08 Thread IOhannes m zmoelnig
Package: gramps
Version: 4.0.3+dfsg-1
Followup-For: Bug #738104

indeed your patch fixes the problem.
thanks for the quick response

fgmrds
IOhannes (waiting for 4.0.3+dfsg-2 to appear :-))

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages gramps depends on:
ii  gir1.2-gtk-3.0   3.8.6-1
ii  librsvg2-2   2.40.0-1
ii  python   2.7.5-5
ii  python-gi3.10.2-2
ii  python-gi-cairo  3.10.2-2
pn  python:any   none
ii  xdg-utils1.1.0~rc1+git20111210-7

Versions of packages gramps recommends:
ii  graphviz2.26.3-16.1
ii  libosmgpsmap-1.0-0-dev  1.0.1-2
ii  python-pyicu1.5-2+b2

Versions of packages gramps suggests:
ii  fonts-freefont-ttf20120503-2
ii  gir1.2-gexiv2-0.4 0.7.0-1
pn  gir1.2-gtk-gtkspell3-3.0  none
ii  python-pil2.3.0-1
pn  rcs   none

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#738104: gramps: Event-types non-editable after upgrade

2014-02-08 Thread Ross Gammon
tag 738104 - unreproducible moreinfo + patch confirmed
owner 738104 !
thanks

On 02/08/2014 09:51 AM, IOhannes m zmoelnig wrote:
 Package: gramps
 Version: 4.0.3+dfsg-1
 Followup-For: Bug #738104
 
 indeed your patch fixes the problem.
 thanks for the quick response
 
 fgmrds
 IOhannes (waiting for 4.0.3+dfsg-2 to appear :-))
 
snip

Okay, I will incorporate the patch. Thanks for the quick test!

Ross


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#738104: gramps: Event-types non-editable after upgrade

2014-02-07 Thread IOhannes m zmoelnig
Package: gramps
Version: 4.0.3+dfsg-1
Severity: normal

Dear Maintainer,

after an upgrade from 3.4.6-1 to 4.0.3+dfsg-1, i cannot edit *any* event
in one of my databases.
whenever i try to do so (double-clicking on an event in the Events menu, or
double-clicking on an event associated with a person) i get the following
backtrace:

 31867: ERROR: grampsapp.py: line 114: Unhandled exception
 Traceback (most recent call last):
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/displaytabs/buttontab.py,
  line 202, in double_click
 self.edit_button_clicked(obj)
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/displaytabs/eventembedlist.py,
  line 271, in edit_button_clicked
 event, ref[1], self.object_edited)
   File /usr/lib/python2.7/dist-packages/gramps/gui/editors/editeventref.py, 
 line 59, in __init__
 update)
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/editreference.py, line 
 108, in __init__
 self._setup_fields()
   File /usr/lib/python2.7/dist-packages/gramps/gui/editors/editeventref.py, 
 line 159, in _setup_fields
 custom_values=self.get_custom_events())
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/widgets/monitoredwidgets.py, 
 line 470, in __init__
 menu=get_val().get_menu())
   File /usr/lib/python2.7/dist-packages/gramps/gui/autocomp.py, line 148, 
 in __init__
 self.store = self.create_menu()
   File /usr/lib/python2.7/dist-packages/gramps/gui/autocomp.py, line 191, 
 in create_menu
 key, value = self.get_key_and_value(event_type)
 TypeError: 'NoneType' object is not iterable

the database worked fine with the 3.x packages.

note that this only happens with one database. everything seems to work fine
with another db i have lying around. (of course, the broken database is the
important one).

mfgdsar
IOhannes


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages gramps depends on:
ii  gir1.2-gtk-3.0   3.8.6-1
ii  librsvg2-2   2.40.0-1
ii  python   2.7.5-5
ii  python-gi3.10.2-2
ii  python-gi-cairo  3.10.2-2
pn  python:any   none
ii  xdg-utils1.1.0~rc1+git20111210-7

Versions of packages gramps recommends:
ii  graphviz2.26.3-16.1
ii  libosmgpsmap-1.0-0-dev  1.0.1-2
ii  python-pyicu1.5-2+b2

Versions of packages gramps suggests:
ii  fonts-freefont-ttf20120503-2
ii  gir1.2-gexiv2-0.4 0.7.0-1
pn  gir1.2-gtk-gtkspell3-3.0  none
ii  python-pil2.3.0-1
pn  rcs   none

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#738104: gramps: Event-types non-editable after upgrade

2014-02-07 Thread Ross Gammon
tag 738104 + unreproducible moreinfo
thanks

Hi IOhannes,
I can't reproduce this on my machine. Can you do a gramps -v so we can
compare what libraries Gramps is importing on your machine and mine?
In the meantime I will check in the upstream bug tracker if anyone else
has this problem.
Regards,
Ross

On 02/07/2014 07:36 PM, IOhannes m zmoelnig wrote:
 Package: gramps
 Version: 4.0.3+dfsg-1
 Severity: normal
 
 Dear Maintainer,
 
 after an upgrade from 3.4.6-1 to 4.0.3+dfsg-1, i cannot edit *any* event
 in one of my databases.
 whenever i try to do so (double-clicking on an event in the Events menu, or
 double-clicking on an event associated with a person) i get the following
 backtrace:
 
 31867: ERROR: grampsapp.py: line 114: Unhandled exception
 Traceback (most recent call last):
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/displaytabs/buttontab.py,
  line 202, in double_click
 self.edit_button_clicked(obj)
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/displaytabs/eventembedlist.py,
  line 271, in edit_button_clicked
 event, ref[1], self.object_edited)
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/editeventref.py, line 
 59, in __init__
 update)
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/editreference.py, line 
 108, in __init__
 self._setup_fields()
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/editeventref.py, line 
 159, in _setup_fields
 custom_values=self.get_custom_events())
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/widgets/monitoredwidgets.py, 
 line 470, in __init__
 menu=get_val().get_menu())
   File /usr/lib/python2.7/dist-packages/gramps/gui/autocomp.py, line 148, 
 in __init__
 self.store = self.create_menu()
   File /usr/lib/python2.7/dist-packages/gramps/gui/autocomp.py, line 191, 
 in create_menu
 key, value = self.get_key_and_value(event_type)
 TypeError: 'NoneType' object is not iterable
 
 the database worked fine with the 3.x packages.
 
 note that this only happens with one database. everything seems to work fine
 with another db i have lying around. (of course, the broken database is the
 important one).
 
 mfgdsar
 IOhannes
 
 
 -- System Information:
 Debian Release: jessie/sid
   APT prefers unstable
   APT policy: (500, 'unstable'), (500, 'testing')
 Architecture: amd64 (x86_64)
 Foreign Architectures: i386
 
 Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
 Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
 Shell: /bin/sh linked to /bin/dash
 
 Versions of packages gramps depends on:
 ii  gir1.2-gtk-3.0   3.8.6-1
 ii  librsvg2-2   2.40.0-1
 ii  python   2.7.5-5
 ii  python-gi3.10.2-2
 ii  python-gi-cairo  3.10.2-2
 pn  python:any   none
 ii  xdg-utils1.1.0~rc1+git20111210-7
 
 Versions of packages gramps recommends:
 ii  graphviz2.26.3-16.1
 ii  libosmgpsmap-1.0-0-dev  1.0.1-2
 ii  python-pyicu1.5-2+b2
 
 Versions of packages gramps suggests:
 ii  fonts-freefont-ttf20120503-2
 ii  gir1.2-gexiv2-0.4 0.7.0-1
 pn  gir1.2-gtk-gtkspell3-3.0  none
 ii  python-pil2.3.0-1
 pn  rcs   none
 
 -- no debconf information
 


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#738104: gramps: Event-types non-editable after upgrade

2014-02-07 Thread Ross Gammon
Actually IOhannes,

This looks like bug:
https://gramps-project.org/bugs/view.php?id=7429
on the upstream tracker.

Could you apply the changes in the attached patch to your autocomp.py
file and let me know if it fixes it?

Regards,

Ross

On 02/07/2014 09:47 PM, Ross Gammon wrote:
 tag 738104 + unreproducible moreinfo
 thanks
 
 Hi IOhannes,
 I can't reproduce this on my machine. Can you do a gramps -v so we can
 compare what libraries Gramps is importing on your machine and mine?
 In the meantime I will check in the upstream bug tracker if anyone else
 has this problem.
 Regards,
 Ross
 
 On 02/07/2014 07:36 PM, IOhannes m zmoelnig wrote:
 Package: gramps
 Version: 4.0.3+dfsg-1
 Severity: normal

 Dear Maintainer,

 after an upgrade from 3.4.6-1 to 4.0.3+dfsg-1, i cannot edit *any* event
 in one of my databases.
 whenever i try to do so (double-clicking on an event in the Events menu, or
 double-clicking on an event associated with a person) i get the following
 backtrace:

 31867: ERROR: grampsapp.py: line 114: Unhandled exception
 Traceback (most recent call last):
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/displaytabs/buttontab.py,
  line 202, in double_click
 self.edit_button_clicked(obj)
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/displaytabs/eventembedlist.py,
  line 271, in edit_button_clicked
 event, ref[1], self.object_edited)
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/editeventref.py, line 
 59, in __init__
 update)
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/editreference.py, 
 line 108, in __init__
 self._setup_fields()
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/editors/editeventref.py, line 
 159, in _setup_fields
 custom_values=self.get_custom_events())
   File 
 /usr/lib/python2.7/dist-packages/gramps/gui/widgets/monitoredwidgets.py, 
 line 470, in __init__
 menu=get_val().get_menu())
   File /usr/lib/python2.7/dist-packages/gramps/gui/autocomp.py, line 148, 
 in __init__
 self.store = self.create_menu()
   File /usr/lib/python2.7/dist-packages/gramps/gui/autocomp.py, line 191, 
 in create_menu
 key, value = self.get_key_and_value(event_type)
 TypeError: 'NoneType' object is not iterable

 the database worked fine with the 3.x packages.

 note that this only happens with one database. everything seems to work fine
 with another db i have lying around. (of course, the broken database is the
 important one).

 mfgdsar
 IOhannes


 -- System Information:
 Debian Release: jessie/sid
   APT prefers unstable
   APT policy: (500, 'unstable'), (500, 'testing')
 Architecture: amd64 (x86_64)
 Foreign Architectures: i386

 Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
 Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
 Shell: /bin/sh linked to /bin/dash

 Versions of packages gramps depends on:
 ii  gir1.2-gtk-3.0   3.8.6-1
 ii  librsvg2-2   2.40.0-1
 ii  python   2.7.5-5
 ii  python-gi3.10.2-2
 ii  python-gi-cairo  3.10.2-2
 pn  python:any   none
 ii  xdg-utils1.1.0~rc1+git20111210-7

 Versions of packages gramps recommends:
 ii  graphviz2.26.3-16.1
 ii  libosmgpsmap-1.0-0-dev  1.0.1-2
 ii  python-pyicu1.5-2+b2

 Versions of packages gramps suggests:
 ii  fonts-freefont-ttf20120503-2
 ii  gir1.2-gexiv2-0.4 0.7.0-1
 pn  gir1.2-gtk-gtkspell3-3.0  none
 ii  python-pil2.3.0-1
 pn  rcs   none

 -- no debconf information

 
 

From 4c51f7d033b42bf1f4faa8a6875a9794fed99547 Mon Sep 17 00:00:00 2001
From: Nick Hall nick__h...@hotmail.com
Date: Sun, 2 Feb 2014 15:42:45 +
Subject: [PATCH] 7429: Fix bug when an empty string is used as custom type

---
 gramps/gui/autocomp.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gramps/gui/autocomp.py b/gramps/gui/autocomp.py
index ef748e3..bcfdc1e 100644
--- a/gramps/gui/autocomp.py
+++ b/gramps/gui/autocomp.py
@@ -276,8 +276,7 @@ class StandardCustomSelector(object):
 instance.
 
 if isinstance(event_type, STRTYPE):
-if event_type:
-return (self.custom_key, event_type)
+return (self.custom_key, event_type)
 elif isinstance(event_type, tuple):
 if event_type[1]:
 return (event_type[0], event_type[1])
-- 
1.8.3.2