Bug#748476: RFS: eggdrop/1.6.21-2
Hello, On 19 May 2014 05:03, Vincent Cheng vch...@debian.org wrote: - Why does debian/control now have Build-Conflicts: autoconf2.13, automake1.4? Probably because configure.in is for a newer autoconf, but doesn't have AC_PREREQ(), so the autoconf wrapper incorrectly detects it as autoconf2.13-compatible because of the name (.in). In my packages I just replace an autoconf call by a call to autoconf2.50. P.S. I haven't actually checked the package, this is just a guess based on the symptoms :) -- Cheers, Andrew -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#748476: RFS: eggdrop/1.6.21-2
On Sun, 18 May 2014 20:03:41 -0700 Vincent Cheng vch...@debian.org wrote: Well, since I've read /usr/share/doc/autotools-dev/README.Debian.gz and tried to use dh-autoreconf properly. You can find the updated package at the same place : http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc - Why does debian/control now have Build-Conflicts: autoconf2.13, automake1.4? - debian/source/options should be unnecessary (dh-autoreconf takes care of removing/restoring autotools cruft before/after build) For these two points I only applied autotools-dev/README (after learning its existence at https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-autotools ): The autoconf2.13 package diverts autoconf, autoheader and autoreconf from the autoconf package to autoconf2.50, autoheader2.50 and autoreconf2.50. You must make sure you are not depending on the existence of the diverted scripts. The automake packages provide alternatives for the automake command, with increased priority for newer versions. There is one exception: the automake1.4 package provides a higher priority alternative for the automake command than the newer automake packages. and Reducing the annoyance factor with diffs: By adding a suitable extend-diff-ignore option to debian/source/options, one can instruct dpkg-source to ignore config.sub, config.guess, and any other autogenerated files (such as Makefile when autoconf is used, Makefile and Makefile.in when automake is used, etc). For example, you could use: extend-diff-ignore=(^|/)(config\.sub|config\.guess|Makefile)$ I'm not able to say if these tips should be followed in this particular case. Would you like me do any more changes? Regards -- Cédric -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#748476: RFS: eggdrop/1.6.21-2
On Mon, May 19, 2014 at 5:32 AM, Andrew Shadura bugzi...@tut.by wrote: Hello, On 19 May 2014 05:03, Vincent Cheng vch...@debian.org wrote: - Why does debian/control now have Build-Conflicts: autoconf2.13, automake1.4? Probably because configure.in is for a newer autoconf, but doesn't have AC_PREREQ(), so the autoconf wrapper incorrectly detects it as autoconf2.13-compatible because of the name (.in). In my packages I just replace an autoconf call by a call to autoconf2.50. P.S. I haven't actually checked the package, this is just a guess based on the symptoms :) That's not the case with this package (i.e. AC_PREREQ(2.60) in configure.ac), but thanks anyhow! Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#748476: RFS: eggdrop/1.6.21-2
On Sat, 17 May 2014 16:02:29 -0700 Vincent Cheng vch...@debian.org wrote: * debian/patches/03fix_freebsd_build: - use $CC in SHLIB_LD (instead of hardcoded ld) Why are you patching automatically generated files (configure, in this case)? I'm certainly not an autotools expert, but can't you patch aclocal.m4 instead and then run autoreconf (or rather, use dh-autoreconf) afterwards? Hi Vincent, Thanks for your feedback. You're right, and indeed my first local patch was against aclocal.m4. But it did introduce automake + autoconf as build dependencies (we were using upstream configure before), and was getting more complicated than a one-line fix to build on kfreebsd. I agree that it is not a good excuse. Well, since I've read /usr/share/doc/autotools-dev/README.Debian.gz and tried to use dh-autoreconf properly. You can find the updated package at the same place : http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc I successfully built it on amd64 with pbuilder and on a fresh kfreebsd-amd64 install. Regards -- Cédric -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#748476: RFS: eggdrop/1.6.21-2
On Sun, May 18, 2014 at 10:52 AM, Cédric Barboiron c...@winkie.fr wrote: On Sat, 17 May 2014 16:02:29 -0700 Vincent Cheng vch...@debian.org wrote: * debian/patches/03fix_freebsd_build: - use $CC in SHLIB_LD (instead of hardcoded ld) Why are you patching automatically generated files (configure, in this case)? I'm certainly not an autotools expert, but can't you patch aclocal.m4 instead and then run autoreconf (or rather, use dh-autoreconf) afterwards? Hi Vincent, Thanks for your feedback. You're right, and indeed my first local patch was against aclocal.m4. But it did introduce automake + autoconf as build dependencies (we were using upstream configure before), and was getting more complicated than a one-line fix to build on kfreebsd. I agree that it is not a good excuse. I would argue that introducing more build dependencies (especially common ones like autoconf/automake) is a lesser evil than patching auto-generated files. :) Well, since I've read /usr/share/doc/autotools-dev/README.Debian.gz and tried to use dh-autoreconf properly. You can find the updated package at the same place : http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc - Why does debian/control now have Build-Conflicts: autoconf2.13, automake1.4? - debian/source/options should be unnecessary (dh-autoreconf takes care of removing/restoring autotools cruft before/after build) Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#748476: RFS: eggdrop/1.6.21-2
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package eggdrop * Package name: eggdrop Version : 1.6.21-2 Upstream Author : EggHeads Development Team egghe...@eggheads.org * URL : http://www.eggheads.org/ * License : GPL-2+ Section : net It builds those binary packages: eggdrop- Advanced IRC Robot eggdrop-data - Architecture independent files for eggdrop To access further information about this package, please visit the following URL: http://mentors.debian.net/package/eggdrop Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc More information about hello can be obtained from http://www.example.com. Changes since the last upload: * debian/patches/03fix_freebsd_build: - use $CC in SHLIB_LD (instead of hardcoded ld) Regards, Cédric Barboiron -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#748476: RFS: eggdrop/1.6.21-2
Control: tag -1 + moreinfo Hi Cédric, On Sat, May 17, 2014 at 8:42 AM, Cédric Barboiron c...@winkie.fr wrote: Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package eggdrop * Package name: eggdrop Version : 1.6.21-2 Upstream Author : EggHeads Development Team egghe...@eggheads.org * URL : http://www.eggheads.org/ * License : GPL-2+ Section : net It builds those binary packages: eggdrop- Advanced IRC Robot eggdrop-data - Architecture independent files for eggdrop To access further information about this package, please visit the following URL: http://mentors.debian.net/package/eggdrop Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc More information about hello can be obtained from http://www.example.com. Changes since the last upload: * debian/patches/03fix_freebsd_build: - use $CC in SHLIB_LD (instead of hardcoded ld) Why are you patching automatically generated files (configure, in this case)? I'm certainly not an autotools expert, but can't you patch aclocal.m4 instead and then run autoreconf (or rather, use dh-autoreconf) afterwards? Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
