Bug#749582: #749582: qgo installs a generated file
On 2014-09-14 22:29, Yann Dirson wrote: * if the official MIME-type to be used is application/x-go-sgf, wouldn't it be better to use it in qgo.desktop ? Yes, it would be. (not sure if it has any impact, since there is a text/x-sgf alias) There's no such alias for the XDG mime type application/x-go-sgf. * there is an src/sgf.desktop file, that gets installed to /usr/share/mimelnk/text/, which seems to describe yet another MIME type (text/go-sgf). Not sure who uses that file anyway: we have no dpkg trigger on this, a fedora18-era (not so old) book says that KDE uses this to build the main menu, and some info from 2004 mentionned that at that time a special package installed files there for openoffice integration with KDE. Given the few files remaining there, I'd be tempted to think it's not of any use whatsover nowadays. As I wrote earlier in this bug: | Ah, side note while I looked at qgo' sources: src/sgf.desktop, which | gets installed to /usr/share/mimelnk, is a KDE 3 only mime type, so | there is not much use for it. I see it has been removed upstream, anyway. -- Pino Toscano -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#749582: #749582: qgo installs a generated file
On Sun, Sep 14, 2014 at 01:34:17PM +0200, Pino Toscano wrote: This has been forwarded [1] and accepted upstream. That's cool, thanks work working this out :) Maybe we'd want to go further in MIME-related cleanups ? * submitted a patch for multi-file handling in qgo.desktop * if the official MIME-type to be used is application/x-go-sgf, wouldn't it be better to use it in qgo.desktop ? (not sure if it has any impact, since there is a text/x-sgf alias) * there is an src/sgf.desktop file, that gets installed to /usr/share/mimelnk/text/, which seems to describe yet another MIME type (text/go-sgf). Not sure who uses that file anyway: we have no dpkg trigger on this, a fedora18-era (not so old) book says that KDE uses this to build the main menu, and some info from 2004 mentionned that at that time a special package installed files there for openoffice integration with KDE. Given the few files remaining there, I'd be tempted to think it's not of any use whatsover nowadays. Best regards, -- Yann -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#749582: #749582: qgo installs a generated file
retitle 749582 qgo: installs a generated XML mime type
tag 749582 + patch
thanks
Hi,
the real issue is in qgo itself.
What happens is that qgo is installing a generated XML mime type [1]
directly to /usr/share/mime/text, without its XML mime type
definition in /usr/share/mime/packages, so update-mime-database will
just remove /usr/share/mime/text/x-sgf.xml (and the rest of the
content of that directory) at the next run, without creating a new
XML mime type.
Furthermore, the generated mime type definition is installed with the
wrong file name even, since a text/go-sgf mime type should be in
/usr/share/mime/text/go-sgf.xml.
On the other hand, shared-mime-info is already providing a mime type
for *.sgf files, called application/x-go-sgf, and already shipped for
many years already (the latest change to that was in 2007, so since
shared-mime-info 0.20+).
Thus, the fix is to just not install that generated XML file anymore,
since as it is now is
a) useless (it has no definition, so gets removed by
update-mime-database)
b) harmful (it conflicts with an existing mimetype shipped by
shared-mime-info)
Patch attached for it (ideally upstream could also drop src/x-sgf.xml
altogether).
Ah, side note while I looked at qgo' sources: src/sgf.desktop, which
gets installed to /usr/share/mimelnk, is a KDE 3 only mime type, so
there is not much use for it.
[1] you can see the self-explaining
!--Created automatically by update-mime-database. DO NOT EDIT!--
comment in x-sgf.xml
Thanks,
--
PinoAuthor: Pino Toscano p...@debian.org
Description: stop installing generated XML mime type
x-sgf.xml is a generated XML mime type without a proper definition, so
installing it in one of the directories of generated XML mime types causes
its deletion at the next update-mime-database run.
.
Furthermore, shared-mime-info is providing application/x-go-sgf for *.sgf
files since many years, so there is no need for a mime type for it.
Last-Update: 2014-09-14
Bug-Debian: https://bugs.debian.org/749582
--- a/src/src.pro
+++ b/src/src.pro
@@ -180,9 +180,7 @@ linux-* {
INSTALLS += desktopfile
filetype.path = /usr/share/mimelnk/text
filetype.files = sgf.desktop
-mimetype.path = /usr/share/mime/text
-mimetype.files = x-sgf.xml
-INSTALLS += filetype mimetype
+INSTALLS += filetype
}
isEmpty(QMAKE_LRELEASE) {
Bug#749582: #749582: qgo installs a generated file
tag 749582 + fixed-upstream thanks Hi, On 2014-09-14 10:36, Pino Toscano wrote: Thus, the fix is to just not install that generated XML file anymore, since as it is now is a) useless (it has no definition, so gets removed by update-mime-database) b) harmful (it conflicts with an existing mimetype shipped by shared-mime-info) Patch attached for it (ideally upstream could also drop src/x-sgf.xml altogether). This has been forwarded [1] and accepted upstream. Also, if you pull a newer upstream snapshot, it would fix the installation on non-Linux architectures. [1] https://github.com/pzorin/qgo/pull/30 Thanks, -- Pino Toscano -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
