Bug#754364: python-pycountry: Python 3 support for pycountry
Michael Banck mba...@debian.org writes: So I'd like to ask you to upload a +ds1 version to mentors.debian.net where the .orig.tar.gz does not include those directories, possibly by using the get-orig-source you updated (I haven't looked at that yet). Oh, that's right. Could you please review the new one I uploaded? http://mentors.debian.net/package/pycountry Thanks. -- m. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
Hi,
thanks a lot for the quick response and the changes!
On Tue, Aug 26, 2014 at 03:04:10AM +0200, Michele Orru` wrote:
4. The package in unstable got repackaged (+ds1 upstream version number)
to remove a duplicated copy of isocodes, according to README.source. The
new package does not have that, either the upstream version number shold
be amended to reflect that, or README.source should get
removed/adjusted
Not sure what you mean here.
In [0] I see that src/pycountry/{databases,locales} are still
there, so the target get-orig-source in debian/rules might be still
needed. I've updated it to deal with new package versions. Hope that's
fine.
Well, your .orig.tar.gz on mentors includes them, whereas the current
one in unstable does not (it got repackaged on way or the other, and the
+ds1 added to reflect that).
So I'd like to ask you to upload a +ds1 version to mentors.debian.net
where the .orig.tar.gz does not include those directories, possibly by
using the get-orig-source you updated (I haven't looked at that yet).
Michael
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
Hi Michael,
I tried to address the issues you mentioned - the new package is in mentors.
http://mentors.debian.net/package/pycountry
1. The debian revision version number must reflect the NMU, i.e.
should be -0.1, not -1
Fixed, my apologies for this silly error.
2. The distribution must be unstable, not unreleased
Fixed, my apologies for this silly error.
3. The package fails to build for me, it apparently required
python3-setuptools (which would be consistent with the other python
package Build-Depends):
Fixed, there was also `unzip`, which I missed. Thanks!
4. The package in unstable got repackaged (+ds1 upstream version number)
to remove a duplicated copy of isocodes, according to README.source. The
new package does not have that, either the upstream version number shold
be amended to reflect that, or README.source should get
removed/adjusted
Not sure what you mean here.
In [0] I see that src/pycountry/{databases,locales} are still
there, so the target get-orig-source in debian/rules might be still
needed. I've updated it to deal with new package versions. Hope that's
fine.
5. 02-support_language_common-name.patch got removed, that should be
mentioned in the changelog
Fixed, my apologies for this silly error.
6. There's a typo in the changelog: Add .zip urls to wach,
s/wach/watch
Fixed, my apologies for this silly error.
[0] https://pypi.python.org/packages/source/p/pycountry/pycountry-1.8.zip
Thank you for reviewing,
--
m.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
Hi, David Paleino wrote (19 Aug 2014 12:58:38 GMT) : I haven't been able to do *ANY* Debian-related work because I'm in my summer house, with very limited connectivity. Thus, it would be nice if you could handle the package upload for me. :) OK, cool. Michael Banck (cc'd) will probably handle the sponsoring. Cheers, -- intrigeri -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
Hi,
On Sun, Aug 24, 2014 at 11:31:46AM -0700, intrigeri wrote:
David Paleino wrote (19 Aug 2014 12:58:38 GMT) :
I haven't been able to do *ANY* Debian-related work because I'm in my
summer house, with very limited connectivity. Thus, it would be nice
if you could handle the package upload for me. :)
OK, cool. Michael Banck (cc'd) will probably handle the sponsoring.
I looked at the package on mentors.
The following must be changed:
1. The debian revision version number must reflect the NMU, i.e.
should be -0.1, not -1
2. The distribution must be unstable, not unreleased
3. The package fails to build for me, it apparently required
python3-setuptools (which would be consistent with the other python
package Build-Depends):
|I: pybuild base:170: python3.4 setup.py clean
|Traceback (most recent call last):
| File setup.py, line 6, in module
|from setuptools import setup, find_packages
|ImportError: No module named 'setuptools'
|E: pybuild pybuild:256: clean: plugin distutils failed with: exit
|code=1: python3.4 setup.py clean
|dh_auto_clean: pybuild --clean -i python{version} -p 3.4 --dir .
|returned exit code 13
|make: *** [clean] Error 13
|debian/rules:17: recipe for target 'clean' failed
|dpkg-buildpackage: error: fakeroot debian/rules clean gave error exit
|status 2
4. The package in unstable got repackaged (+ds1 upstream version number)
to remove a duplicated copy of isocodes, according to README.source. The
new package does not have that, either the upstream version number shold
be amended to reflect that, or README.source should get
removed/adjusted
The following should really be changed:
5. 02-support_language_common-name.patch got removed, that should be
mentioned in the changelog
6. There's a typo in the changelog: Add .zip urls to wach,
s/wach/watch
Cheers,
Michael
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
Hi, 2014-08-17 1:13 GMT+02:00 intrigeri intrig...@debian.org: Hi David, hi mopidy-dirble maintainers, [..] Sorry for the *LATE* reply. I haven't been able to do *ANY* Debian-related work because I'm in my summer house, with very limited connectivity. Thus, it would be nice if you could handle the package upload for me. :) Thanks, and sorry David -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
Hi David, hi mopidy-dirble maintainers, intrigeri wrote (29 Jul 2014 20:00:42 GMT) : Trying to be of some help, I have updated the package, and it now resides in [4]. Will you please be so kind to review it and tell me your opinion? Ping? In case you don't have time to handle this specific package update, I can probably find someone with experience at Python packaging to review Michele's patch, and then I'll be happy to upload. Here's another gentle ping. Michele's patch was posted more than a month ago, and my offer for help is still valid :) My reasons for trying to speed this up a bit is that we at Tails need pycountry to support Python 3 in Jessie: our custom GDM greeter uses it and we'd rather not wait for Jessie+1 to migrate our code to Python 3. Any reason (but time, of course) not to update this package to the latest upstream version? I see that it only has one single reverse dependency (mopidy-dirble) in the archive, so it looks like an update would not be too risky. Still, the earlier it's done before the freeze, the greater chances we have to fix issues if there are any. Dear mopidy-dirble maintainers, any idea if your package works with recent upstream pycountry releases? Cheers, -- intrigeri -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
On Sun, Aug 17, 2014 at 1:13 AM, intrigeri intrig...@debian.org wrote: Dear mopidy-dirble maintainers, any idea if your package works with recent upstream pycountry releases? I just tested with pycountry 1.8, and everything works as expected. -- Stein Magnus Jodal -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
Stein Magnus Jodal wrote (16 Aug 2014 23:31:59 GMT) : On Sun, Aug 17, 2014 at 1:13 AM, intrigeri intrig...@debian.org wrote: Dear mopidy-dirble maintainers, any idea if your package works with recent upstream pycountry releases? I just tested with pycountry 1.8, and everything works as expected. Thanks a lot! -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
Hi David, Trying to be of some help, I have updated the package, and it now resides in [4]. Will you please be so kind to review it and tell me your opinion? Ping? In case you don't have time to handle this specific package update, I can probably find someone with experience at Python packaging to review Michele's patch, and then I'll be happy to upload. Cheers, -- intrigeri -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#754364: python-pycountry: Python 3 support for pycountry
Package: python-pycountry Version: 0.14.1+ds1-3 Severity: wishlist Tags: patch Dear Maintainer, At the time of this writing, the latest version of pycountry available in debian is 0.14, while upstream counts at 1.8[0]. Updating to 1.8 would be great not only because the package is right now obsolete, but above all for the presence of unittests[1] and python 3 support[2]. The latter in particular, is going to be used by Tails sooner or later[3]. Trying to be of some help, I have updated the package, and it now resides in [4]. Will you please be so kind to review it and tell me your opinion? [0] https://pypi.python.org/pypi/pycountry [1] https://bitbucket.org/gocept/pycountry/src/0.18/src/pycountry/tests/ [2] https://bitbucket.org/gocept/pycountry/src/tip/HISTORY.txt?at=default#cl-24 [3] https://tails.boum.org/blueprint/python3/ [4] http://mentors.debian.net/package/pycountry -- System Information: Debian Release: jessie/SID APT prefers testing APT policy: (1024, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 3.14-1-amd64 (SMP w/4 CPU cores) Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages python-pycountry depends on: ii iso-codes3.54-1 ii python 2.7.6-2 ii python-lxml 3.3.5-1+b1 python-pycountry recommends no packages. python-pycountry suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
